[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323602207 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -137,6 +139,13 @@ Status

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323602143 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -42,7 +44,13 @@ struct ColumnWriterOptions {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323602117 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -42,7 +44,13 @@ struct ColumnWriterOptions {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323601322 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -152,7 +153,12 @@ class

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323600981 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r321569645 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323588812 ## File path: be/src/olap/bloom_filter.hpp ## @@ -71,6 +70,16 @@ class BitSet { return true; }

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r323582503 ## File path: be/src/olap/types.h ## @@ -74,6 +74,7 @@ class TypeInfo { inline void set_to_min(void* buf)

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r321569645 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the