[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

On 12/4/2014 9:35 PM, Michael Qiu wrote: > app/test-pmd/csumonly.c: In function ?get_psd_sum?: > build/include/rte_ip.h:161: error: dereferencing pointer ?u16? > does break strict-aliasing rules > build/include/rte_ip.h:157: note: initialized from here > ... > > The root cause is

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

On 12/5/2014 5:26 PM, Thomas Monjalon wrote: > 2014-12-05 05:34, Qiu, Michael: >> Any comments about this version? a new workaround solution :) > Yes, one comment: I think it's ugly :) > These aliasing errors are not reliable so I think we can disable it (like > Linux does). > But in case you

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

On 12/5/2014 11:25 PM, Neil Horman wrote: > On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: >> On Fri, Dec 05, 2014 at 09:22:05AM -0500, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 04:31:47PM +0800, Chao Zhu wrote: On 2014/12/4 17:12, Michael Qiu wrote: >

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

On 12/8/2014 11:00 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: >> On 12/5/2014 11:25 PM, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: On Fri, Dec 05, 2014 at 09:22:05AM -0500, Neil Horman wrote: > On

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

On 12/8/2014 11:39 AM, Qiu, Michael wrote: > On 12/8/2014 11:00 AM, Neil Horman wrote: >> On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: >>> On 12/5/2014 11:25 PM, Neil Horman wrote: On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: > On Fri, Dec 05, 2014 at

[dpdk-dev] [RFC PATCH 01/17] virtio: Rearrange resource initialization

For clarity make the setup of PCI resources for Linux into a function rather than block of code #ifdef'd in middle of dev_init. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 76 --- 1 file changed,

[dpdk-dev] [RFC PATCH 05/17] ether: Add soft vlan encap/decap functions

It is helpful to allow device drivers that don't support hardware VLAN stripping to emulate this in software. This allows application to be device independent. Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any packet to be tagged that has a reference count > 1.

[dpdk-dev] [RFC PATCH 04/17] virtio: Add support for Link State interrupt

Virtio has link state interrupt which can be used. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++ lib/librte_pmd_virtio/virtio_pci.c| 22 ++ lib/librte_pmd_virtio/virtio_pci.h|

[dpdk-dev] [RFC PATCH 09/17] virtio: Fix how states are handled during initialization

Change order of initialiazation to match Linux kernel. Don't blow away control queue by doing reset when stopped. Calling dev_stop then dev_start would not work. Dev_stop was calling virtio reset and that would clear all queues and clear all feature negotiation. Resolved by only doing reset on

[dpdk-dev] [RFC PATCH 12/17] virtio: Move allocation before initialization

If allocation fails, don't want to leave virtio device stuck in middle of initialization sequence. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[dpdk-dev] [RFC PATCH 11/17] virtio: Check for packet headroom at compile time

Better to check at compile time than fail at runtime. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c

[dpdk-dev] [RFC PATCH 13/17] virtio: Add support for vlan filtering

Virtio supports vlan filtering. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c

[dpdk-dev] [RFC PATCH 15/17] virtio: Add ability to set MAC address

Need to have do special things to set default mac address. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.h | 5 + lib/librte_pmd_virtio/virtio_ethdev.c | 24 2 files changed, 29 insertions(+) diff --git

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

This is RFC patch for single virtio implementation. Why we need single virtio? As we know currently there are at least 3 virtio PMD driver implementations: A) lib/librte_pmd_virtio(refer as virtio A); B) virtio_net_pmd by 6wind(refer as virtio B); C) virtio by

[dpdk-dev] [RFC PATCH 14/17] virtio: Add suport for multiple mac addresses

Virtio support multiple MAC addresses. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++- lib/librte_pmd_virtio/virtio_ethdev.h | 3 +- lib/librte_pmd_virtio/virtqueue.h | 34 - 3

[dpdk-dev] [RFC PATCH 17/17] virtio: Use port IO to get PCI resource.

Make virtio not require UIO for some security reasons, this is to match 6Wind's virtio-net-pmd. Signed-off-by: Changchun Ouyang --- lib/librte_eal/common/include/rte_pci.h | 2 + lib/librte_eal/linuxapp/eal/eal_pci.c | 3 +- lib/librte_pmd_virtio/virtio_ethdev.c | 75

[dpdk-dev] [RFC PATCH 16/17] virtio: Free mbuf's with threshold

This makes virtio driver work like ixgbe. Transmit buffers are held until a transmit threshold is reached. The previous behavior was to hold mbuf's until the ring entry was reused which caused more memory usage than needed. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

On 12/5/2014 6:00 PM, Burakov, Anatoly wrote: > Hi Michael, > > Few nitpicks :-) (wording of the log message I guess is up to Thomas, I won't > comment on that) > >> lib/librte_eal/common/eal_private.h| 36 >> ++ >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of cause got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not be initialized EAL:

[dpdk-dev] [PATCH 12/15] eal/tile: add mPIPE buffer stack mempool provider

TileGX: Modified mempool to allow for variable metadata. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- app/test-pmd/mempool_anon.c | 2 +- app/test/Makefile | 6 +- app/test/test_mempool_tile.c | 217 lib/Makefile

[dpdk-dev] [PATCH 04/15] eal/tile: add spinlock operations for TileGx

TileGx uses generic spinlock operations. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_spinlock.h| 47 ++ 1 file changed, 47 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_spinlock.h

[dpdk-dev] error: value computed is not used

Hi all, My platform is: uname -a Linux suse-11-sp3 3.0.77-0.11-xen #1 SMP Tue Mar 11 16:48:56 CST 2014 x86_64 x86_64 x86_64 GNU/Linux gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/4.5/lto-wrapper Target: x86_64-suse-linux Configured with:

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

This patch adds architecture specific memory barrier operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_atomic.h | 62 ++ 1 file changed, 62 insertions(+) create mode 100644

[dpdk-dev] [PATCH 03/15] eal/tile: add byte order operations for TileGx

This patch adds architecture specific byte swap and endianness operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_byteorder.h | 70 ++ 1 file changed, 70 insertions(+) create mode 100644

[dpdk-dev] [PATCH 05/15] eal/tile: add prefetch operations for TileGx

Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_prefetch.h| 62 ++ 1 file changed, 62 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_prefetch.h diff --git

[dpdk-dev] [PATCH 08/15] eal/tile: add cycle operations for TileGx

This patch adds CPU TSC read operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_cycles.h | 64 ++ 1 file changed, 64 insertions(+) create mode 100644

[dpdk-dev] [PATCH 09/15] eal: split vector operations to architecture specific

This patch splits vector operations from DPDK and push them to architecture specific arch directories, so that other processor architecture can implement its own vector functions to support DPDK. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- lib/librte_eal/common/Makefile

[dpdk-dev] [PATCH 10/15] eal/tile: add vector operations for TileGx

Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_common_vect.h | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_common_vect.h diff --git

[dpdk-dev] [PATCH 00/15] Patches for DPDK to support tile architecture

This patch set adds default configuration, compiling related rte.vars.mk files for tile, and architecture-specific operations for EAL. TileGx processor, as a SOC, contains a on-chip networking engine named mPIPE( multicore Programmable Intelligent Packet Engine). This patch set also adds poll mode

[dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization

The TileGx mPIPE hardware provides Ethernet connectivity, packet classification, and packet load balancing services. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_mpipe.h | 67 ++ lib/librte_eal/linuxapp/eal/Makefile

[dpdk-dev] [PATCH 13/15] pmd/tile: add mPIPE poll mode driver for TileGx

Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- lib/Makefile |1 + lib/librte_pmd_mpipe/Makefile| 24 + lib/librte_pmd_mpipe/pmd_mpipe.c | 1343 ++ mk/rte.app.mk|4 + 4 files changed, 1372

[dpdk-dev] [PATCH 15/15] eal: allow empty set of compile time cpuflags

On architectures that do not rely on RTE_COMPILE_TIME_CPUFLAGS, the compile_time_flags[] array can end up being zero sized. This results in a compiler complaint in the subsequent loop. Pulling out the array size computation silences this complaint. Signed-off-by: Zhigang Lu Signed-off-by:

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

Some formatting issues during posting. I was talking about parenthesis in count calculation (sizeof(internals->slaves[0]) * internals->slave_count - i - 1));

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

> When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support could not be

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

On 12/8/2014 5:54 PM, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL:

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of cause got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not be initialized EAL:

[dpdk-dev] [PATCH v3] mbuf: fix of enabling all newly added RX error flags

Hi Helin, > -Original Message- > From: Zhang, Helin > Sent: Saturday, December 06, 2014 1:34 AM > To: dev at dpdk.org > Cc: Cao, Waterman; Cao, Min; olivier.matz at 6wind.com; Ananyev, Konstantin; > Zhang, Helin > Subject: [PATCH v3] mbuf: fix of enabling all newly added RX error flags >

[dpdk-dev] [PATCH v3] mbuf: fix of enabling all newly added RX error flags

Hi Helin, 2014-12-06 09:33, Helin Zhang: > Before redefining mbuf structure, there was lack of free bits in 'ol_flags' > (32 bits in total) for new RX or TX flags. So it tried to reuse existant > bits as most as possible, or even assigning 0 to some of bit flags. After > new mbuf structure

[dpdk-dev] [PATCH v2 2/2] mbuf: assign valid bit values for some RX and TX flags

> -Original Message- > From: Zhang, Helin > Sent: Saturday, December 06, 2014 1:08 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Cao, Waterman; Cao, Min; Wu, Jingjing; Liu, Jijiang; olivier.matz at > 6wind.com > Subject: RE: [PATCH v2 2/2] mbuf: assign valid bit values for some RX

[dpdk-dev] error: value computed is not used

> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsskey': > lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not used > > I dig out that, it was ome issue of the macros rte_memcpy() > #define rte_memcpy(dst, src, n) \ > ((__builtin_constant_p(n)) ?

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: > Add defconfig and rte.vars.mk files for Tile architecture. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > config/defconfig_tile-tilegx-linuxapp-gcc | 78 > +++ >

[dpdk-dev] [PATCH] doc: add license header to link bonding diagrams

Signed-off-by: Declan Doherty --- doc/guides/prog_guide/img/bond-mode-0.svg | 34 + doc/guides/prog_guide/img/bond-mode-1.svg | 34 + doc/guides/prog_guide/img/bond-mode-2.svg | 34 +

[dpdk-dev] [PATCH] doc: typos corrected in distributor application

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, December 5, 2014 4:08 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: typos corrected in distributor application > > corrected couple of typos in distributor

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

> When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support could not be

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

On Mon, Dec 08, 2014 at 11:09:13AM +, Bruce Richardson wrote: > On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: > > Add defconfig and rte.vars.mk files for Tile architecture. > > > > Signed-off-by: Zhigang Lu > > Signed-off-by: Cyril Chemparathy > > --- > >

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

On Mon, Dec 08, 2014 at 04:59:25PM +0800, Zhigang Lu wrote: > This patch adds architecture specific memory barrier operations for > TileGx. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > .../common/include/arch/tile/rte_atomic.h | 62 > ++

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

On 2014/12/8 19:38, Neil Horman wrote: > On Mon, Dec 08, 2014 at 03:37:19AM +, Qiu, Michael wrote: >> On 12/8/2014 11:00 AM, Neil Horman wrote: >>> On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: On 12/5/2014 11:25 PM, Neil Horman wrote: > On Fri, Dec 05, 2014 at

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: > Include rte_memory.h for lib files that use __rte_cache_aligned > attribute. > > Signed-off-by: Jia Yu > Why? I presume there was a build break or something. Please repost with a changelog that details what this patch is for. Neil >

[dpdk-dev] error: value computed is not used

> -Original Message- > From: Qiu, Michael > Sent: Monday, December 08, 2014 4:24 PM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: error: value computed is not used > > On 2014/12/8 19:00, Wodkowski, PawelX wrote: > >> lib/librte_pmd_enic/enic_main.c: In function

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

On 2014/12/8 20:19, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL:

[dpdk-dev] [PATCH] doc: add bsd license to svg file

Signed-off-by: Bernard Iremonger --- .../sample_app_ug/img/exception_path_example.svg | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/doc/guides/sample_app_ug/img/exception_path_example.svg b/doc/guides/sample_app_ug/img/exception_path_example.svg

[dpdk-dev] DDPK use of MAP_FIXED in mmap

Hello, In DPDK when we use mmap why are we passing the MAP_FIXED flag when Linux man page itself says that the option is discouraged? Any specific reason for passing the MAP_FIXED flag? http://linux.die.net/man/2/mmap MAP_FIXED Don't interpret addr as a hint: place the mapping at exactly

[dpdk-dev] (no subject)

>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.130426937 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:56 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger

[dpdk-dev] (no subject)

>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.232055974 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:58 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger

[dpdk-dev] (no subject)

>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.333788346 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:46:00 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

On 12/8/2014 6:28 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 04:59:25PM +0800, Zhigang Lu wrote: >> This patch adds architecture specific memory barrier operations for >> TileGx. >> >> Signed-off-by: Zhigang Lu >> Signed-off-by: Cyril Chemparathy >> --- [...] >> +__sync_synchronize();

[dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization

Hi Neil, On 12/8/2014 12:03 PM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 04:59:34PM +0800, Zhigang Lu wrote: >> The TileGx mPIPE hardware provides Ethernet connectivity, >> packet classification, and packet load balancing services. >> >> Signed-off-by: Zhigang Lu >> Signed-off-by: Cyril