[dpdk-dev] [PATCH v5 0/6] Interrupt mode PMD

2015-02-24 Thread Zhou Danny
v5 changes - Rebase the patchset onto the HEAD - Isolate ethdev from EAL for new-added wait-for-rx interrupt function - Export wait-for-rx interrupt function for shared libraries - Split-off a new patch file for changed struct rte_intr_handle that other patches depend on, to avoid breaking git

[dpdk-dev] [PATCH v5 1/6] ethdev: add rx interrupt enable/disable functions

2015-02-24 Thread Zhou Danny
v5 changes - Rebase the patchset onto the HEAD v4 changes - Export interrupt enable/disable functions for shared libraries - Put new functions at the end of eth_dev_ops to avoid breaking ABI v3 changes - Add return value for interrupt enable/disable functions Add two dev_ops functions to enable

[dpdk-dev] [PATCH v5 2/6] eal: add rx queue interrupt FDs to intr handle struct

2015-02-24 Thread Zhou Danny
v5 changes: - Create this new patch file for changed struct rte_intr_handle that other patches depend on, to avoid breaking git bisect. Signed-off-by: Danny Zhou Tested-by: Yong Liu --- lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v5 3/6] ixgbe: enable rx queue interrupts for both PF and VF

2015-02-24 Thread Zhou Danny
v5 changes - Rebase the patchset onto the HEAD v3 changes - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below things for ixgbe PF and VF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to

[dpdk-dev] [PATCH v5 4/6] igb: enable rx queue interrupts for PF

2015-02-24 Thread Zhou Danny
v5 changes - Rebase the patchset onto the HEAD v3 changes - Remove unnecessary variables in e1000_mac_info - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below for igb PF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-24 Thread Zhou Danny
v5 changes - Rebase the patchset onto the HEAD - Isolate ethdev from EAL for new-added wait-for-rx interrupt function - Export wait-for-rx interrupt function for shared libraries v4 changes: - Adjust position of new-added structure fields v3 changes: - Fix review comments v2 changes: - Fix

[dpdk-dev] [PATCH v5 6/6] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch

2015-02-24 Thread Zhou Danny
v5 changes - Change invoked function name and parameter to accomodate EAL change v3 changes - Add spinlock to ensure thread safe when accessing interrupt mask register v2 changes - Remove unused function which is for debug purpose Demonstrate how to handle per rx queue interrupt in a

[dpdk-dev] [PULL REQUEST] i40e: Performance workaround for XL710, enable

2015-02-24 Thread Thomas Monjalon
> Helin Zhang (1): > i40e: workaround for XL710 performance > > Jingjing Wu (2): > i40e: fix the bug when configuring vsi > i40e: enable internal switch of pf Pulled, thanks

[dpdk-dev] [PATCH v6 0/3] DPDK ethdev callback support

2015-02-24 Thread Thomas Monjalon
2015-02-23 18:30, John McNamara: > This patchset is for a small optional addition to the ethdev library, > to add support for callbacks at the RX and TX stages. This allows > packet processing to be done on packets before they get returned > to applications using rte_eth_rx_burst call. > > See

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-24 Thread Thomas Monjalon
2015-02-05 07:43, Neil Horman: > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > + > > +/** > > + * Hierarchical scheduler subport statistics reset > > + * > > + * @param port > > + * Handle to port scheduler instance > > + * @param subport_id > > + * Subport ID > > + *

[dpdk-dev] [PATCH v3 00/11] qemu vhost-user support

2015-02-24 Thread Thomas Monjalon
2015-02-23 17:36, Przemyslaw Czesnowicz: > v3 changes: > * move things around to make all patches compile > > > Xie, Huawei (11): > lib/librte_vhost: enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is > dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver > in guest

[dpdk-dev] [PATCH] RTE_PIPELINE_ACTION_PORT_META fix for non-default entries

2015-02-24 Thread Thomas Monjalon
2015-02-21 11:31, Ildar Mustafin: > Signed-off-by: Ildar Mustafin An explanation is generally preferred. Applied, thanks

[dpdk-dev] [PATCH] lpm: fix overflow issue

2015-02-24 Thread Thomas Monjalon
2015-02-22 20:29, Bruce Richardson: > On Fri, Feb 20, 2015 at 04:16:46PM +0300, Igor Ryzhov wrote: > > LPM table overflow may occur if table is full and added rule has the > > biggest depth that already have some rules. > > > > Signed-off-by: Igor Ryzhov > Acked-by: Bruce Richardson Applied,

[dpdk-dev] [PATCH] kni: optimizing the rte_kni_rx_burst

2015-02-24 Thread Thomas Monjalon
> > > 2014-07-23 12:15, Hemant Agrawal: > > > > The current implementation of rte_kni_rx_burst polls the fifo for > > > > buffers. > > > > Irrespective of success or failure, it allocates the mbuf and try to > > > > put them into the alloc_q > > > > if the buffers are not added to alloc_q, it

[dpdk-dev] [PATCH 2/2] Headers: more C++11 compilation fixes

2015-02-24 Thread Thomas Monjalon
2015-02-20 15:23, Stefan Puiu: > Fixed two more places where non-C++11 string concatenation is > used. Spotted by John McNamara. > > Signed-off-by: Stefan Puiu Both patches merged and applied, thanks.

[dpdk-dev] [PATCH v5 1/3] librte_headroom: New library for checking core/system/app load

2015-02-24 Thread Thomas Monjalon
2015-02-19 13:18, Pawel Wodkowski: > This library provide API to measure time spend in particular parts of > code and to calculate optimal polling time. > > To calculate a those statistics application code need to be divided into > parts (called jobs) that do something. It is up to application to

[dpdk-dev] [PATCH 0/3] Misc fixes

2015-02-24 Thread Thomas Monjalon
2015-02-20 12:10, Sergio Gonzalez Monroy: > This series fixes a few small issues in different files: > - doxygen syntax of a couple of comments in struct mbuf > - add missing reorder library directory to doxygen config > - rte_reorder_create was not being checked for possible errors, so >

[dpdk-dev] [PATCH] fm10k: fix clang unused function error

2015-02-24 Thread Thomas Monjalon
> >This commit fixes the following error which was reported when > >compiling with clang by moving the function inside an > >RTE_LIBRTE_FM10K_DEBUG_RX ifdef block. > > > >error: unused function 'dump_rxd' > > > >Signed-off-by: Jeff Shaw > > Acked-by: keith.wiles at intel.com Applied, thanks

[dpdk-dev] [PATCH] fm10k: fix clang warning flags

2015-02-24 Thread Thomas Monjalon
> >This commit fixes the following error which was reported when > >compiling with clang by removing the option. > > > >error: unknown warning option '-Wno-unused-but-set-variable' > > > >Signed-off-by: Jeff Shaw > > Acked-by: keith.wiles at intel.com Applied, thanks

[dpdk-dev] [PATCH 1/2] enic: replace use of printf with log

2015-02-24 Thread Thomas Monjalon
> > > Device driver should log via DPDK log, not to printf which is > > > sends to /dev/null in a daemon application. > > > > > > Signed-off-by: Stephen Hemminger > > > > Series > > Acked-by: Neil Horman > > Use of rte_log would be better for init messages, but since the driver > makes no

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Thomas Monjalon
> Separately comparing major and minor versions becomes seriously clumsy > when with major version changes, convert the entire version string into > a numeric value (ie 4.6.0 becomes 460 and 5.0.0 becomes 500) and use > that for comparisons, eliminate unnecessary negations while at it. > This

[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent

2015-02-24 Thread Yerden Zhumabekov
23.02.2015 23:36, Thomas Monjalon ?: > 2015-02-19 15:21, Bruce Richardson: >> Confirmed, this worked for me too. >> Looking at the patches, they look good. However, one thing I think we are >> missing >> is a unit test to verify that all our CRC implementations give the same >> result. >>

[dpdk-dev] [PATCH 0/3] doc: ACL - add description for new features.

2015-02-24 Thread Thomas Monjalon
> > Konstantin Ananyev (3): > > doc: Add restrictions for ACL rule fields > > doc: ACL - add description for different classification methods > > doc: ACL - add description for max_size build parameter > > Series Acked-by: Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent

2015-02-24 Thread Thomas Monjalon
2015-02-24 09:00, Yerden Zhumabekov: > > 23.02.2015 23:36, Thomas Monjalon ?: > > 2015-02-19 15:21, Bruce Richardson: > >> Confirmed, this worked for me too. > >> Looking at the patches, they look good. However, one thing I think we are > >> missing > >> is a unit test to verify that all our

[dpdk-dev] rte_memcpy optimization patch to dpdk ver 1.7

2015-02-24 Thread Vithal S Mohare
Hi Neil, While most of the newer CPUs supports ssse3, found a I7 not supporting it. So, DPDK can't run these CPUs? Is this restriction acceptable? -sh-3.2$ cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 26 model name :

[dpdk-dev] [PATCH v13 01/13] eal: Enable port Hotplug framework in Linux

2015-02-24 Thread Tetsuya Mukawa
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++

[dpdk-dev] [PATCH v13 03/13] eal_pci: pci memory map work with driver type

2015-02-24 Thread Tetsuya Mukawa
From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30

[dpdk-dev] [PATCH v13 04/13] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-24 Thread Tetsuya Mukawa
To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to

[dpdk-dev] [PATCH v13 05/13] eal/pci: Consolidate pci address comparison APIs

2015-02-24 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr

[dpdk-dev] [PATCH v13 06/13] ethdev: Add rte_eth_dev_release_port to release specified port

2015-02-24 Thread Tetsuya Mukawa
This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of

[dpdk-dev] [PATCH v13 07/13] eal, ethdev: Add a function and function pointers to close ether device

2015-02-24 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v10: - Add size

[dpdk-dev] [PATCH v13 09/13] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-24 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be

[dpdk-dev] [PATCH v13 10/13] eal/pci: Add probe and close functions of pci driver

2015-02-24 Thread Tetsuya Mukawa
- Add pci_close_all_drivers() The function tries to find a driver for the specified device, and then close the driver. - Add rte_eal_pci_probe_one() and rte_eal_pci_close_one() The functions are used for probe and close a device. First the function tries to find a device that has the

[dpdk-dev] [PATCH v13 11/13] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

2015-02-24 Thread Tetsuya Mukawa
This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v12: - Add missing symbol in version map. (Thanks to

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-24 Thread Tetsuya Mukawa
These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When

[dpdk-dev] [PATCH v13 13/13] doc: Add port hotplug framework section to programmers guide

2015-02-24 Thread Tetsuya Mukawa
This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Pawel Wodkowski
On 2015-02-23 17:04, Thomas Monjalon wrote: >>> Do you mean that you plan to add some features to this library? >>> > >Is it going to stay at providing some stats or could you make some >>> > >actions >>> > >like time-sharing helpers? >> >What do you mean here saying time-sharing? > I mean

[dpdk-dev] [PATCH 0/3] Misc fixes

2015-02-24 Thread Olivier MATZ
On 02/20/2015 01:10 PM, Sergio Gonzalez Monroy wrote: > This series fixes a few small issues in different files: > - doxygen syntax of a couple of comments in struct mbuf > - add missing reorder library directory to doxygen config > - rte_reorder_create was not being checked for possible

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

2015-02-24 Thread Olivier MATZ
Hi Helin, On 02/20/2015 03:26 PM, Zhang, Helin wrote: >> On 02/17/2015 07:59 AM, Helin Zhang wrote: >>> As there are only 6 bit flags in ol_flags for indicating packet types, >>> which is not enough to describe all the possible packet types hardware >>> can recognize. For example, i40e hardware

[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent

2015-02-24 Thread Bruce Richardson
On Tue, Feb 24, 2015 at 04:10:34AM +0100, Thomas Monjalon wrote: > 2015-02-24 09:00, Yerden Zhumabekov: > > > > 23.02.2015 23:36, Thomas Monjalon ?: > > > 2015-02-19 15:21, Bruce Richardson: > > >> Confirmed, this worked for me too. > > >> Looking at the patches, they look good. However, one

[dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places

2015-02-24 Thread Panu Matilainen
On 02/23/2015 06:00 PM, Stephen Hemminger wrote: > On Mon, 23 Feb 2015 15:10:00 +0100 > Pawel Wodkowski wrote: > >> Declaration of fgets() is >> char *fgets(char *str, int size, FILE *stream); >> >> Klocwork complain about passing "sizeof()" as size parameter since >> implicit casting size_t to

[dpdk-dev] [PATCH] eal: mmap uio resources using resourceX files

2015-02-24 Thread Tetsuya Mukawa
On 2015/02/24 0:00, Bruce Richardson wrote: > On Mon, Feb 23, 2015 at 02:57:24PM +, Bruce Richardson wrote: >> Instead of distinguishing the BAR mappings via offset within a single >> file, originally /dev/uioX, switch to mapping each individual bar via >> the appropriately numbered resourceX

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread David Marchand
Hello Panu, Looks like there is an issue with gcc 4.7 on my debian. $ make config T=x86_64-native-linuxapp-gcc && make -j8 ../mk/toolchain/gcc/rte.toolchain-compat.mk:46: You are using GCC < 4.x. This is neither supported, nor tested. ../mk/toolchain/gcc/rte.toolchain-compat.mk:46: You are using

[dpdk-dev] [PATCH] devargs: restore empty devargs as ""

2015-02-24 Thread David Marchand
Following commit c07691ae1089, an implicit change has been done in the devargs api. This triggers problem in virtual pmds that did not check for parameters validity as it was implicitely valid. Fix this by restoring the empty argument as "" and add a note in the api. Restore associated tests.

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Jastrzebski, MichalX K
> > > I also feel that the name of this library is a bit too vague. Some people > > > were asking first what means "headroom". It's actually for CPU headroom > > > monitoring. > > > What about "cpuheadroom", "cpuheadroomstat", "jobstat"? > > > > I think we can change the name to "cpuheadroom" as

[dpdk-dev] rte_memcpy optimization patch to dpdk ver 1.7

2015-02-24 Thread Bruce Richardson
On Tue, Feb 24, 2015 at 04:25:40AM +, Vithal S Mohare wrote: > Hi Neil, > > > While most of the newer CPUs supports ssse3, found a I7 not supporting it. > So, DPDK can't run these CPUs? Is this restriction acceptable? > > -sh-3.2$ cat /proc/cpuinfo > processor : 0 > vendor_id

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Panu Matilainen
On 02/24/2015 11:25 AM, David Marchand wrote: > Hello Panu, > > Looks like there is an issue with gcc 4.7 on my debian. > > $ make config T=x86_64-native-linuxapp-gcc && make -j8 > ../mk/toolchain/gcc/rte.toolchain-compat.mk:46 > : You are using GCC < 4.x. This

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Thomas Monjalon
2015-02-24 09:49, Jastrzebski, MichalX K: > > > > I also feel that the name of this library is a bit too vague. Some > > > > people > > > > were asking first what means "headroom". It's actually for CPU headroom > > > > monitoring. > > > > What about "cpuheadroom", "cpuheadroomstat", "jobstat"? >

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen wrote: > On 02/24/2015 11:25 AM, David Marchand wrote: > >> Hello Panu, >> >> Looks like there is an issue with gcc 4.7 on my debian. >> >> $ make config T=x86_64-native-linuxapp-gcc && make -j8 >> ../mk/toolchain/gcc/rte.toolchain-compat.mk:46

[dpdk-dev] [PATCH] devargs: restore empty devargs as ""

2015-02-24 Thread Tetsuya Mukawa
On 2015/02/24 18:41, David Marchand wrote: > Following commit c07691ae1089, an implicit change has been done in the devargs > api. > This triggers problem in virtual pmds that did not check for parameters > validity > as it was implicitely valid. > > Fix this by restoring the empty argument as ""

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 11:09 AM, David Marchand wrote: > On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen > wrote: > >> $ gcc -dumpversion >>> 4.7 >>> >> >> Meh. This seems to be a Debian specific modification to gcc, discussed >> here and there including but not limited to: >>

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand > Sent: Tuesday, February 24, 2015 10:21 AM > To: Panu Matilainen > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] mk: Rework gcc version detection to > permit versions newer than 4.x >

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

2015-02-24 Thread Olivier MATZ
Hi Pawel, On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Declaration for function pointer should be > typedef ret_type (*type_name)(args...) > not > typedef ret_type (type_name)(args...) > > although compiler treat both of them the same, the static analysis tool > like klocwork complain about

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

2015-02-24 Thread David Marchand
Hello Danny, On Mon, Feb 23, 2015 at 5:55 PM, Zhou Danny wrote: [snip] +/** > + * @param intr_handle > + * pointer to the interrupt handle. > + * @param queue_id > + * the queue id > + * @return > + * - On success, return 0 > + * - On failure, returns -1. > + */ > +int

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 11:36 AM, Mcnamara, John wrote: > > > >> $ gcc -dumpversion > > >>> 4.7 > > >>> > > Hum, how about something like always appending .0.0 to the gcc - > > dumpversion then cut at 3 characters ? > > Hi, > > Or something like this in Sed or Perl within the $(shell) expansion:

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread Panu Matilainen
Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some versions of Debian and Ubuntu where gcc has been modified to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'. Drop the micro-version from gcc version comparisons to work around this, it wasn't being used

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Bruce Richardson
On Tue, Feb 24, 2015 at 11:44:21AM +0100, David Marchand wrote: > On Tue, Feb 24, 2015 at 11:36 AM, Mcnamara, John > wrote: > > > > > > >> $ gcc -dumpversion > > > >>> 4.7 > > > >>> > > > Hum, how about something like always appending .0.0 to the gcc - > > > dumpversion then cut at 3 characters

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Panu Matilainen
On 02/24/2015 12:44 PM, David Marchand wrote: > On Tue, Feb 24, 2015 at 11:36 AM, Mcnamara, John > mailto:john.mcnamara at intel.com>> wrote: > > > > >> $ gcc -dumpversion > > >>> 4.7 > > >>> > > Hum, how about something like always appending .0.0 to the gcc - > > dumpversion

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

2015-02-24 Thread Bruce Richardson
On Mon, Feb 23, 2015 at 05:02:33PM +, Bruce Richardson wrote: > This patch does some cleanup of the uio mapping code to > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > by others. > b) eliminate redundant code and reduce scans of /sys > > > Bruce Richardson (2): >

[dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-24 Thread Mcnamara, John
> From: David Marchand [mailto:david.marchand at 6wind.com] > Sent: Tuesday, February 24, 2015 10:44 AM > To: Mcnamara, John > Cc: Panu Matilainen; dev at dpdk.org; Olivier Matz > Subject: Re: [dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit > versions newer than 4.x > >> Or

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread David Marchand
Panu, ack (and works with my debian gcc). -- David Marchand On Tue, Feb 24, 2015 at 11:46 AM, Panu Matilainen wrote: > Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation > on some versions of Debian and Ubuntu where gcc has been modified > to only emit MAJOR.MINOR part of the

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 11:00 AM > To: Jastrzebski, MichalX K > Cc: Wodkowski, PawelX; dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v5 0/3] new headroom stats library and example

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 11:00 AM > To: Jastrzebski, MichalX K > Cc: Wodkowski, PawelX; dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v5 0/3] new headroom stats library and example

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

2015-02-24 Thread Olivier MATZ
Hi Daniel, On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote: > Function match_inst is used to take buffor using sizeof() which is size_t > type. > This modification also involved changing '%u' to '%zu' in printf function. > > Signed-off-by: Daniel Mrzyglod > --- >

[dpdk-dev] [PATCH 4/5] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

2015-02-24 Thread Olivier MATZ
Hi Pawel, On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Fix warning reported by klocwork about size_t to int cast when passing > parameters to parse_set_list(). > > This patch fix code formating errors that give checkpatch.pl errors > after generating patch. > > Signed-off-by: Pawel Wodkowski

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Olivier MATZ
On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Free kvlist on function exit to avoid memory leak. > > Signed-off-by: Pawel Wodkowski Acked-by: Olivier Matz

[dpdk-dev] [PATCH v3 0/2] help option

2015-02-24 Thread Thomas Monjalon
> > This is a small reorganization of options. > > The main goal is to provide a nice --help option. > > > > changes in v3: > > - reword arguments in usage > > changes in v2: > > - sort also the options enum > > > > Thomas Monjalon (2): > > eal: sort and align options lists > > eal: add help

[dpdk-dev] Not getting statistics for all queues.

2015-02-24 Thread Alexandra Sava
Hi guys, I'm trying to get statistics per queue (on rx side), therefore I'm using rte_eth_dev_set_rx_queue_stats_mapping function in order to map a particular queue to a stat index (Note: I have 4 rx queues with the following mapping: queue 0 -> stat_idx 0; queue 1 -> stat_idx 1 , etc). The

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Pawel Wodkowski
On 2015-02-24 12:05, Olivier MATZ wrote: > On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >> Free kvlist on function exit to avoid memory leak. >> >> Signed-off-by: Pawel Wodkowski > > Acked-by: Olivier Matz > Please have in mind that this patch depend on patch 2/5 -- Pawel

[dpdk-dev] [PATCH] maintainers: claim VFIO and IVSHMEM

2015-02-24 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7750881..2eb7761 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -117,6 +117,7 @@ F: lib/librte_eal/linuxapp/igb_uio/ F: lib/librte_eal/linuxapp/eal/*uio* Linux

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread Panu Matilainen
On 02/24/2015 01:14 PM, Olivier MATZ wrote: > Hi Panu, David, > > On 02/24/2015 11:59 AM, David Marchand wrote: >>> >Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation >>> >on some versions of Debian and Ubuntu where gcc has been modified >>> >to only emit MAJOR.MINOR part of the

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

2015-02-24 Thread David Marchand
Hello Bruce, On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Mon, Feb 23, 2015 at 05:02:33PM +, Bruce Richardson wrote: > > This patch does some cleanup of the uio mapping code to > > a) fix issue with mmap of PCI bars reported by Tetsuya and

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Olivier MATZ
On 02/24/2015 12:15 PM, Pawel Wodkowski wrote: > On 2015-02-24 12:05, Olivier MATZ wrote: >> On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >>> Free kvlist on function exit to avoid memory leak. >>> >>> Signed-off-by: Pawel Wodkowski >> >> Acked-by: Olivier Matz >> > > Please have in mind that

[dpdk-dev] [PATCH 2/5] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

2015-02-24 Thread Olivier MATZ
On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > It is desired that all type of *_free() functions mimic behaviour of > libc free() function. This function does nothing if given parameter is > NULL. This patch add this behaviour for rte_kvargs_free(). > > Signed-off-by: Pawel Wodkowski Acked-by:

[dpdk-dev] rte_memcpy optimization patch to dpdk ver 1.7

2015-02-24 Thread Neil Horman
On Tue, Feb 24, 2015 at 04:25:40AM +, Vithal S Mohare wrote: > Hi Neil, > > > While most of the newer CPUs supports ssse3, found a I7 not supporting it. > So, DPDK can't run these CPUs? Is this restriction acceptable? > It has to run on all systems greater than -march=core2, as that

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

2015-02-24 Thread Bruce Richardson
On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > Hello Bruce, > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Mon, Feb 23, 2015 at 05:02:33PM +, Bruce Richardson wrote: > > > This patch does some cleanup of the uio

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread Thomas Monjalon
2015-02-24 11:59, David Marchand: > Panu, > > ack (and works with my debian gcc). > > > Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation > > on some versions of Debian and Ubuntu where gcc has been modified > > to only emit MAJOR.MINOR part of the version from 'gcc

[dpdk-dev] [PATCH] maintainers: claim VFIO and IVSHMEM

2015-02-24 Thread Thomas Monjalon
> Signed-off-by: Anatoly Burakov Acked-by: Thomas Monjalon Applied, thanks Anatoly.

[dpdk-dev] [PATCH] ring: fix minor memory leak of kvlist in dev init

2015-02-24 Thread Mcnamara, John
> -Original Message- > From: Mcnamara, John > Sent: Monday, February 23, 2015 1:17 PM > To: dev at dpdk.org > Cc: Mcnamara, John > Subject: [PATCH] ring: fix minor memory leak of kvlist in dev init > > Fix for Klocwork identified issue. Superseded by:

[dpdk-dev] [PATCH v3 2/2] eal: populate uio_maps from pci mem_resources array

2015-02-24 Thread Bruce Richardson
Rather than scanning the resource file in sysfs a second time, we can pull the information on physical addresses of BARs from the pci resource information already present in the dev structure. Signed-off-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 163

[dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files

2015-02-24 Thread Bruce Richardson
Instead of distinguishing the BAR mappings via offset within a single file, originally /dev/uioX, switch to mapping each individual bar via the appropriately numbered resourceX file. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_pci.h| 2 +-

[dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 12:32 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > > bruce.richardson at intel.com> wrote: > > > > > On Mon,

[dpdk-dev] [PATCH] app/test: add crc32 algorithms equivalence check

2015-02-24 Thread Yerden Zhumabekov
New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 53 ++

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

2015-02-24 Thread Olivier MATZ
Hi Pawel, On 02/24/2015 12:12 PM, Wodkowski, PawelX wrote: > > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, February 24, 2015 11:39 AM >> To: Wodkowski, PawelX; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/5] rte_timer: fix

[dpdk-dev] [PATCH v3 2/2] eal: populate uio_maps from pci mem_resources array

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > Rather than scanning the resource file in sysfs a second time, we > can pull the information on physical addresses of BARs from the > pci resource information already present in the dev structure. > >

[dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files

2015-02-24 Thread David Marchand
On Tue, Feb 24, 2015 at 1:20 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > Instead of distinguishing the BAR mappings via offset within a single > file, originally /dev/uioX, switch to mapping each individual bar via > the appropriately numbered resourceX file. > > Signed-off-by:

[dpdk-dev] rte_kni_rx_burst issues

2015-02-24 Thread Olivier Deme
All, I know that an issue was already raised with regards to the efficiency of rte_kni_rx_burst but I think that there is more to it than previously discussed. As previously pointed out rte_kni_rx_burst invokes kni_allocate_mbufs every single time. In turn, it looks like kni_allocate_mbufs

[dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5

2015-02-24 Thread Panu Matilainen
gcc 5 supports a new logical-not-parentheses warning which ixgbe_common.c triggers, causing build failure with -Werror. Since this source must not be modified, silence the warning instead. Signed-off-by: Panu Matilainen --- lib/librte_pmd_ixgbe/Makefile | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-24 Thread Maxime Leroy
Hi Tetsuya, On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote: > These functions are used for attaching or detaching a port. [...] > +static int > +rte_eal_vdev_init(const char *name, const char *args) > +{ > + struct rte_driver *driver; > + > + if (name == NULL) > +

[dpdk-dev] [PATCH v4 1/3] eal: mmap uio resources using resourceX files

2015-02-24 Thread Bruce Richardson
Instead of distinguishing the BAR mappings via offset within a single file, originally /dev/uioX, switch to mapping each individual bar via the appropriately numbered resourceX file. Signed-off-by: Bruce Richardson Acked-by: David Marchand --- lib/librte_eal/common/include/rte_pci.h| 2 +-

[dpdk-dev] [PATCH v4 0/3] fix and improve uio_pci_generic support

2015-02-24 Thread Bruce Richardson
V4 changes: Split second patch into two for more readable history V3 changes: Rebase to take account of commit 90a1633b "eal/linux: allow to map BARs with MSI-X tables" This patch does some cleanup of the uio mapping code to a) fix issue with mmap of PCI bars reported by Tetsuya and

[dpdk-dev] [PATCH v4 2/3] eal: populate uio_maps from pci mem_resources array

2015-02-24 Thread Bruce Richardson
Rather than scanning the resource file in sysfs a second time, we can pull the information on physical addresses of BARs from the pci resource information already present in the dev structure. Signed-off-by: Bruce Richardson Acked-by: David Marchand ---

[dpdk-dev] [PATCH v4 3/3] eal: remove unnecessary check for primary instance

2015-02-24 Thread Bruce Richardson
In pci_uio_map_resource we check that we are in a primary process before calling pci_uio_set_bus_master. However, there is already an earlier check which means that we are always in a primary instance at this point in the code, so the check can be removed. Signed-off-by: Bruce Richardson

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Tuesday, February 24, 2015 10:47 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - > dumpversion' output > > Commit

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

2015-02-24 Thread Zhang, Helin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, February 24, 2015 5:09 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified > packet > types > > Hi Helin, > > On 02/20/2015

[dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types

2015-02-24 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, February 23, 2015 6:59 AM > To: Zhang, Helin > Cc: dev at dpdk.org; Wu, Jingjing; Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload > types > > > >

[dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5

2015-02-24 Thread Ananyev, Konstantin
> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Tuesday, February 24, 2015 1:14 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin > Subject: [PATCH v2] ixgbe: fix build with gcc 5 > > gcc 5 supports a new logical-not-parentheses warning which >

[dpdk-dev] [PULL REQUEST] i40e: Performance workaround for XL710, enable

2015-02-24 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 7:04 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PULL REQUEST] i40e: Performance workaround for > XL710, enable > > > Helin Zhang (1): > >

[dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output

2015-02-24 Thread Panu Matilainen
On 02/24/2015 03:34 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Tuesday, February 24, 2015 10:47 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - >>

[dpdk-dev] [PATCH v13 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-24 Thread Tetsuya Mukawa
2015-02-24 22:25 GMT+09:00 Maxime Leroy : > Hi Tetsuya, > > On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. > [...] >> +static int >> +rte_eal_vdev_init(const char *name, const char *args) >> +{ >> + struct rte_driver

  1   2   >