[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

> -Original Message- > From: John W. Linville [mailto:linville at tuxdriver.com] > Sent: Saturday, February 21, 2015 2:39 AM > To: Thomas Monjalon > Cc: Liang, Cunming; dev at dpdk.org; John Linville > Subject: Re: [dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by > klocwork

[dpdk-dev] [PATCH v8 00/19] support multi-pthread per core

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 25, 2015 2:53 AM > To: Liang, Cunming > Cc: Ananyev, Konstantin; dev at dpdk.org; olivier.matz at 6wind.com; > nhorman at tuxdriver.com > Subject: Re: [PATCH v8 00/19] support

[dpdk-dev] [PATCH v1] doc: prog guide update for eal multi-pthread

I'm afraid not yet, so appreciate for any revision suggestion. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 25, 2015 3:11 AM > To: Liang, Cunming > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] doc: prog guide

[dpdk-dev] Manage DPDK port capability via KNI

Hi, I am wondering how could we manage a DPDK port offload capabilities, e.g. if we want to disable TSO capability on a DPDK port, is it feasible that we use ethtool to configure a KNI then the config will be sync to a DPDK port? Thanks, Tim

[dpdk-dev] Cannot compile l2fwd-jobstats example

Hi, I cannot compile l2fwd-jobstats using master branch. Here is log $ T=x86_64-native-linuxapp-gcc make examples == Build examples for x86_64-native-linuxapp-gcc == bond == cmdline == distributor == exception_path == helloworld == ip_pipeline == ip_reassembly == ipv4_multicast

[dpdk-dev] Missing symbol error

Hi, I've got following error when I enable CONFIG_RTE_BUILD_SHARED_LIB. dpdk/x86_64-native-linuxapp-gcc/lib/libethdev.so: undefined reference to `per_lcore__socket_id' collect2: error: ld returned 1 exit status make[5]: *** [dump_cfg] Error 1 make[4]: *** [dump_cfg] Error 2 make[4]: *** Waiting

[dpdk-dev] [PATCH] virtio: Changed variable types to prevent possible data loss in virtio_ethdev.c, virtio_ethdev.h and virtio_rxtx.c

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Saturday, February 21, 2015 12:13 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] virtio: Changed variable types to prevent > possible data loss in virtio_ethdev.c,

[dpdk-dev] Missing symbol error

Hi, You're right, it's missing in the version map. Will send path to fix it. Thanks. > -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Wednesday, February 25, 2015 10:49 AM > To: dev at dpdk.org > Cc: Liang, Cunming > Subject: Missing symbol error > >

[dpdk-dev] [PATCH] app/test: add crc32 algorithms equivalence check

24.02.2015 20:57, Bruce Richardson ?: > +#define CRC32_ITERATIONS (1U << 16) > This test takes almost no time at all, so maybe we want to do a few more > iterations e.g. 2^18 - 2^20. Noted, I'll put (1U << 20). >> +printf("# CRC32 implementations equivalence test\n"); >> +for (i = 0;

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Thursday, February 19, 2015 11:55 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV > > Enable DCB in SRIOV mode for ixgbe driver. > > To

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y. The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map. Thanks for the notification from Tetsuya Mukawa . Cunming Liang (2): eal/linux: fix symbol missing in

[dpdk-dev] [PATCH v1 1/2] eal/linux: fix symbol missing in version map

As per_lcore__socket_id and rte_sys_gettid are missing in version map, it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled. Signed-off-by: Cunming Liang --- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v1 2/2] eal/bsd: fix symbol missing in version map

As per_lcore__socket_id and rte_sys_gettid are missing in version map, it causes compiling error when CONFIG_RTE_BUILD_SHARED_LIB is enabled. Signed-off-by: Cunming Liang --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH v14 01/13] eal: Enable port Hotplug framework in Linux

The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++

[dpdk-dev] [PATCH v14 02/13] eal_pci: Add flag to hold kernel driver type

From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle

[dpdk-dev] [PATCH v14 03/13] eal_pci: pci memory map work with driver type

From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30

[dpdk-dev] [PATCH v14 04/13] eal/pci, ethdev: Remove assumption that port will not be detached

To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to

[dpdk-dev] [PATCH v14 05/13] eal/pci: Consolidate pci address comparison APIs

This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr

[dpdk-dev] [PATCH v14 06/13] ethdev: Add rte_eth_dev_release_port to release specified port

This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of

[dpdk-dev] [PATCH v14 07/13] eal, ethdev: Add a function and function pointers to close ether device

The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v10: - Add size

[dpdk-dev] [PATCH v14 08/13] ethdev: Add functions that will be used by port hotplug functions

The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or

[dpdk-dev] [PATCH v14 09/13] eal/linux/pci: Add functions for unmapping igb_uio resources

The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be

[dpdk-dev] [PATCH v14 11/13] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v12: - Add missing symbol in version map. (Thanks to

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When

[dpdk-dev] [PATCH v14 13/13] doc: Add port hotplug framework section to programmers guide

This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v14] librte_pmd_pcap: Add port hotplug support

This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v14] testpmd: Add port hotplug support

The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) -

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 63 ++

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

On 2015/02/25 12:39, Cunming Liang wrote: > These two patches are the fixing for the compling error when > CONFIG_RTE_BUILD_SHARED_LIB=y. > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in > the version map. > Thanks for the notification from Tetsuya Mukawa . > >

[dpdk-dev] ixgbe vector mode not working.

Hi Stephen, I tried on the latest mater branch with testpmd. 2 rxq and 2 txq as below, vector pmd on both rx and tx. I can't reproduced it. I checked your log, on tx side, it looks the tx vector haven't enabled. (it shows vpmd on rx, spmd on tx). Would you help to share the below params in your

[dpdk-dev] Manage DPDK port capability via KNI

You can do it but it will not sync with DPDK. In current KNI implementation, the devices' I/O address spaces are mapped to both userspace DPDK and kenrelspace KNI, so one can control the NIC device independently(using ethtool for KNI and ethdev APIs for DPDK) without synchronization. In theory,

[dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places

On 02/24/2015 09:01 PM, Stephen Hemminger wrote: > On Tue, 24 Feb 2015 11:20:33 +0200 > Panu Matilainen wrote: > >> The tool is technically correct, even if loss of precision might be >> unlikely to occur in this context > > Overflow is not there in the code. > That is why I said "shooting

[dpdk-dev] [PATCH v3 00/11] qemu vhost-user support

PC: Thanks a lot for the effort. During one of the rebase process, i moved eventfd copy into eventfd_copy.c but forget to update virtio-net.c, so it isn't compilable until later commit. Sorry for the trouble. Will check if each commit could be compiled in future. On 2/24/2015 1:36 AM, Przemyslaw

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Thursday, February 19, 2015 11:55 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() > logic to driver > > Function

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

Thanks for comments and please see my answers inline. From: David Marchand [mailto:david.march...@6wind.com] Sent: Tuesday, February 24, 2015 6:42 PM To: Zhou, Danny Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO Hello Danny,

[dpdk-dev] Cannot compile l2fwd-jobstats example

On 2015-02-25 03:26, Tetsuya Mukawa wrote: > Hi, > > I cannot compile l2fwd-jobstats using master branch. > Here is log > > $ T=x86_64-native-linuxapp-gcc make examples > == Build examples for x86_64-native-linuxapp-gcc > == bond > == cmdline > == distributor > == exception_path >

[dpdk-dev] Vhost-user early adopter feedback

On 2/18/2015 3:59 PM, Beno?t Canet wrote: > Hello Xie, > > As promized I integrated your vhost-user patchset from january in my vswitch. > > I just tried it, it works pretty well. > > I just had a minor bug with rte_vhost_driver_register taking ownership of the > string patch pointer too late. I

[dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool

On 2015-02-25 04:24, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool

[dpdk-dev] [PATCH] eal: add missing symbol export for rte_sys_gettid()

Signed-off-by: Panu Matilainen --- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index c207cee..117246a 100644 ---

[dpdk-dev] [PATCH] eal: add missing symbol export for rte_sys_gettid()

On 02/25/2015 09:50 AM, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > b/lib/librte_eal/linuxapp/eal/rte_eal_version.map

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cunming Liang > Sent: Wednesday, February 25, 2015 3:40 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map > > These two patches are the fixing for the compling

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 00:57, Liang, Cunming: > From: John W. Linville [mailto:linville at tuxdriver.com] > > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > > > 2015-02-12 17:08, Cunming Liang: > > > > --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c > > > > +++

[dpdk-dev] ixgbe vector mode not working.

Hi Stephen, Thanks for the info, with rxd=4000, I can reproduce it. On that time, it runs out of mbuf. I'll follow up this issue. > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Wednesday, February 25, 2015 3:37 PM > To: Liang, Cunming > Cc:

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

Hi Robert, On 02/25/2015 05:09 AM, Robert Sanford wrote: > Changes in v2: > - split into multiple patches > - minor coding-style changes > > Robert Sanford (3): >timer: fix return value of rte_timer_reset(), > insert rte_pause() into rte_timer_reset_sync() wait-loop >app/test: fix

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

> > These two patches are the fixing for the compling error when > > CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing > > in the version map. > > Thanks for the notification from Tetsuya Mukawa . Please use Reported-by: in such case.

[dpdk-dev] ixgbe vector mode not working.

2015-02-24 23:36, Stephen Hemminger: > On Wed, 25 Feb 2015 04:55:09 + > "Liang, Cunming" wrote: > > > Hi Stephen, > > > > I tried on the latest mater branch with testpmd. > > 2 rxq and 2 txq as below, vector pmd on both rx and tx. I can't reproduced > > it. > > I checked your log, on tx

[dpdk-dev] Cannot compile l2fwd-jobstats example

2015-02-25 08:38, Pawel Wodkowski: > On 2015-02-25 03:26, Tetsuya Mukawa wrote: > > Hi, > > > > I cannot compile l2fwd-jobstats using master branch. > > Here is log > > > > $ T=x86_64-native-linuxapp-gcc make examples > > == Build examples for x86_64-native-linuxapp-gcc > > == bond

[dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?

Hi, I have a question about the "scattered Rx" feature: why enabling it disabled "bulk allocation" feature? There is some unclear comment in the ixgbe_recv_scattered_pkts(): /* * Descriptor done. * * Allocate a new mbuf to

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

> > Changes in v2: > > - split into multiple patches > > - minor coding-style changes > > > > Robert Sanford (3): > >timer: fix return value of rte_timer_reset(), > > insert rte_pause() into rte_timer_reset_sync() wait-loop > >app/test: fix timer stress test to succeed on multiple

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 25, 2015 4:46 PM > To: Liang, Cunming > Cc: John W. Linville; dev at dpdk.org; John Linville > Subject: Re: [dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by >

[dpdk-dev] dpdk - poll mode - context switches

Hello, I am not sure to understand the mechanism behind dpdk concerning the context switches. I have two user space applications that need access to the NIC according to incoming port rules (port 80 and port 443). How to be sure that DPDK spreads the load to the right application ? Will 2

[dpdk-dev] Manage DPDK port capability via KNI

Thanks Danny, That means DPDK ports have to have dedicated control path other than KNI. I originally got confused by the statement at http://dpdk.org/doc/guides/prog_guide/kernel_nic_interface.html: "...Allows management of DPDK ports using standard Linux net tools such as ethtool, ifconfig

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

2015-02-25 09:52, Liang, Cunming: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-02-25 00:57, Liang, Cunming: > > > From: John W. Linville [mailto:linville at tuxdriver.com] > > > > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote: > > > > > 2015-02-12 17:08,

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

On 2015-02-25 07:14, Ouyang, Changchun wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() >>

[dpdk-dev] [PATCH v5 5/6] eal: add per rx queue interrupt handling based on VFIO

Hello Danny, On Wed, Feb 25, 2015 at 7:58 AM, Zhou, Danny wrote: > > +int > +rte_intr_wait_rx_pkt(struct rte_intr_handle *intr_handle, uint8_t > queue_id) > +{ > + struct epoll_event ev; > + unsigned numfds = 0; > + > + if (!intr_handle || intr_handle->fd < 0 ||

[dpdk-dev] [PATCH v2 0/4] DPDK memcpy optimization

> > This patch set optimizes memcpy for DPDK for both SSE and AVX platforms. > > It also extends memcpy test coverage with unaligned cases and more test > > points. > > > > Optimization techniques are summarized below: > > > > 1. Utilize full cache bandwidth > > > > 2. Enforce aligned stores >

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

Hi Thomas, Yes, I'm interested in becoming a maintainer of rte_timer. What are the responsibilities? One question about lib rte_timer that's been troubling me for a while: How are skip lists better than BSD-style timer wheels? -- Regards, Robert On Wed, Feb 25, 2015 at 4:46 AM, Thomas

[dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?

On Wed, Feb 25, 2015 at 11:40:36AM +0200, Vlad Zolotarov wrote: > Hi, I have a question about the "scattered Rx" feature: why enabling it > disabled "bulk allocation" feature? The "bulk-allocation" feature is one where a more optimized RX code path is used. For the sake of performance, when doing

[dpdk-dev] dpdk - poll mode - context switches

On Wed, Feb 25, 2015 at 10:54:51AM +0100, Jog Lie wrote: > Hello, > > I am not sure to understand the mechanism behind dpdk concerning the context > switches. > I have two user space applications that need access to the NIC according to > incoming port rules (port 80 and port 443). > > How to

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

2015-02-25 06:02, Robert Sanford: > Hi Thomas, > > Yes, I'm interested in becoming a maintainer of rte_timer. What are the > responsibilities? It means we know someone who can answer our questions about rte_timer. Having you email in the MAINTAINERS file helps to CC you. And we expect from the

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

On Wed, Feb 25, 2015 at 06:02:24AM -0500, Robert Sanford wrote: > Hi Thomas, > > Yes, I'm interested in becoming a maintainer of rte_timer. What are the > responsibilities? > > > One question about lib rte_timer that's been troubling me for a while: How > are skip lists better than BSD-style

[dpdk-dev] dpdk - poll mode - context switches

Hi Bruce, Ok. understood. Thanks ! --? Jog

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

On 2015-02-25 04:36, Ouyang, Changchun wrote: >> @@ -652,7 +655,9 @@ ixgbe_get_vf_queues(struct rte_eth_dev *dev, >> >uint32_t vf, uint32_t *msgbuf) { >> >struct ixgbe_vf_info *vfinfo = >> >*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data- >>> > >dev_private); >> >- uint32_t default_q =

[dpdk-dev] Vhost-user early adopter feedback

The Wednesday 25 Feb 2015 ? 07:46:56 (+), Xie, Huawei wrote : > On 2/18/2015 3:59 PM, Beno?t Canet wrote: > > Hello Xie, > > > > As promized I integrated your vhost-user patchset from january in my > > vswitch. > > > > I just tried it, it works pretty well. > > > > I just had a minor bug with

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

On Wed, Feb 25, 2015 at 10:08:32AM +0600, Yerden Zhumabekov wrote: > New function test_crc32_hash_alg_equiv() checks whether software, > 4-byte operand and 8-byte operand versions of CRC32 hash function > implementations return the same result value. > > Signed-off-by: Yerden Zhumabekov Two

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

From: Hemant Agrawal if any buffer is read from the tx_q, MAX_BURST buffers will be allocated and attempted to be added to to the alloc_q. This seems terribly inefficient and it also looks like the alloc_q will quickly fill to its maximum capacity. If the system buffers

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

Thank you Hemant, I think there might be one issue left with the patch though. The alloc_q must initially be filled with mbufs before getting mbuf back on the tx_q. So the patch should allow rte_kni_rx_burst to check if alloc_q is empty. If so, it should invoke kni_allocate_mbufs(kni, 0) (to

[dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, February 24, 2015 4:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use > > Since DPDK now has support for the in-tree

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, February 24, 2015 4:28 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: update programmers guide for > uio_pci_generic > > Since DPDK now has support for the

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

Hi OIivier Comments inline. Regards, Hemant > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Deme > Sent: 25/Feb/2015 5:44 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst > > Thank you Hemant,

[dpdk-dev] [PATCH 1/2] doc: Update GSG for uio_pci_generic use

On Wed, Feb 25, 2015 at 12:14:15PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, February 24, 2015 4:28 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] doc: Update

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

On Wed, Feb 25, 2015 at 12:19:10PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, February 24, 2015 4:28 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] doc: update

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

I guess it would be unusual but possible for the kernel to enqueue faster to tx_q than the application dequeues. But that would also be possible with a real NIC, so I think it is acceptable for the kernel to have to drop egress packets in that case. On 25/02/15 12:24, Hemant at freescale.com

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote: > These two patches are the fixing for the compling error when > CONFIG_RTE_BUILD_SHARED_LIB=y. > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in > the version map. > Thanks for the notification from

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 20:21 GMT+09:00 Thomas Monjalon : > 2015-02-25 13:04, Tetsuya Mukawa: >> --- a/lib/librte_eal/common/eal_common_dev.c >> +++ b/lib/librte_eal/common/eal_common_dev.c >> @@ -32,10 +32,13 @@ >> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> */ >> >>

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

New function test_crc32_hash_alg_equiv() checks whether software, 4-byte operand and 8-byte operand versions of CRC32 hash function implementations return the same result value. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c | 60 ++

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

On 25/02/15 13:24, Hemant at freescale.com wrote: > Hi OIivier >Comments inline. > Regards, > Hemant > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Deme >> Sent: 25/Feb/2015 5:44 PM >> To: dev at dpdk.org >> Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v2] app/test: add crc32 algorithms equivalence check

All notes taken into account. v3 posted. 25.02.2015 17:34, Bruce Richardson ?: > On Wed, Feb 25, 2015 at 10:08:32AM +0600, Yerden Zhumabekov wrote: >> New function test_crc32_hash_alg_equiv() checks whether software, >> 4-byte operand and 8-byte operand versions of CRC32 hash function >>

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

Static analysis report some issues against current DPDK version. Most of them need only cosmetic code changes (changing type of variable). One issue related with ring pmd fix real memory leak problem. PATCH v2 changes: - remove patch 5/5 as it was NACKed - reword commit log acording to mailing

[dpdk-dev] [PATCH v2 1/4] rte_timer: change declaration of rte_timer_cb_t

This patch remove inconsistency between declaration of type rte_timer_cb_t, field f in struct rte_timer and function __rte_timer_reset(). Although compiler treat both of them the same, the static analysis tool like complain about that. Signed-off-by: Pawel Wodkowski ---

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

Hi Marc, I think one of the observations is that currently the alloc_q grows very quickly to the maximum fifo size (1024). The patch suggests fixing the alloc_q to a fix size and maybe make that size configurable in rte_kni_alloc or rte_kni_init. It should then be up to the application to

[dpdk-dev] [PATCH v2 2/4] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

By convenction free() functions should ignore NULL parameter. This patch add this behaviour for rte_kvargs_free(). Signed-off-by: Pawel Wodkowski --- lib/librte_kvargs/rte_kvargs.c | 4 lib/librte_kvargs/rte_kvargs.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 3/4] pmd ring: fix possible memory leak during devinit

Free kvlist on function exit to avoid memory leak. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ring/rte_eth_ring.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte_eth_ring.c index a5dc71e..f049bb3

[dpdk-dev] [PATCH v2 4/4] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

Fix warning reported during static analysis about size_t to int cast when passing parameters to parse_set_list(). This patch fix code formating errors that give checkpatch.pl errors after generating patch. Signed-off-by: Pawel Wodkowski --- lib/librte_cmdline/cmdline_parse_portlist.c | 4 ++--

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, February 25, 2015 12:28 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update programmers guide for > uio_pci_generic > > On Wed, Feb 25, 2015 at 12:19:10PM +, Iremonger,

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

On Wed, Feb 25, 2015 at 06:34:06PM +0600, Yerden Zhumabekov wrote: > New function test_crc32_hash_alg_equiv() checks whether software, > 4-byte operand and 8-byte operand versions of CRC32 hash function > implementations return the same result value. > > Signed-off-by: Yerden Zhumabekov

[dpdk-dev] [PATCH 2/2] doc: update programmers guide for uio_pci_generic

On Wed, Feb 25, 2015 at 01:12:43PM +, Iremonger, Bernard wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Wednesday, February 25, 2015 12:28 PM > > To: Iremonger, Bernard > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update programmers

[dpdk-dev] [PATCH] kni:optimization of rte_kni_rx_burst

On Wed, Feb 25, 2015 at 6:38 AM, Marc Sune wrote: > > On 25/02/15 13:24, Hemant at freescale.com wrote: > >> Hi OIivier >> Comments inline. >> Regards, >> Hemant >> >> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Deme >>> Sent:

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

On Wed, Feb 25, 2015 at 6:16 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Wed, Feb 25, 2015 at 06:02:24AM -0500, Robert Sanford wrote: > > > > > One question about lib rte_timer that's been troubling me for a while: > How > > are skip lists better than BSD-style timer wheels?

[dpdk-dev] Looking forward to DPDK 2.1

Hi all, The progress on DPDK 2.0 has been really positive and thanks to everyone for contributing and helping to grow our community. We now look onwards to DPDK 2.1 planning which is due to release at the end of July, and we'd like to inform the community of the features that we hope to submit

[dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

2015-02-25 07:30, Neil Horman: > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote: > > These two patches are the fixing for the compling error when > > CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing > > in the version

[dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD

This PMD adds support for Mellanox ConnectX-3-based adapters through the verbs framework. It relies on external libraries (libibverbs and user space driver libmlx4) and kernel support to do so. While these libraries and kernel modules are available on OpenFabrics Alliance's website [1] and

[dpdk-dev] [PATCH v3 1/3] scripts: check features to generate configuration header

This script looks for types, macros and functions in header files using compilation options found in the environment (CC, CFLAGS, CPPFLAGS) to define feature macros in a generated header. Useful in combination with external headers that do not provide such macros. Signed-off-by: Adrien Mazarguil

[dpdk-dev] [PATCH v3 2/3] mlx4: new poll mode driver

This PMD manages all variants of Mellanox ConnectX-3 (EN 40, EN 10, Pro EN 40) as well as their virtual functions in SR-IOV context through IB Verbs (libibverbs) and the dedicated user-space driver (libmlx4). It is disabled by default due to dependencies on these libraries and only supports Linux

[dpdk-dev] [PATCH v3 3/3] doc: add librte_pmd_mlx4 documentation

This documentation covers implementation details, features and limitations, configuration, prerequisites and provides a usage example. Signed-off-by: Adrien Mazarguil --- MAINTAINERS | 1 + doc/guides/prog_guide/index.rst | 1 +

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-25 21:32, Tetsuya Mukawa: > 2015-02-25 20:21 GMT+09:00 Thomas Monjalon : > > 2015-02-25 13:04, Tetsuya Mukawa: > >> --- a/lib/librte_eal/common/eal_common_dev.c > >> +++ b/lib/librte_eal/common/eal_common_dev.c > >> @@ -32,10 +32,13 @@ > >> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE

[dpdk-dev] Looking forward to DPDK 2.1

Hi Siobhan, Thanks for contributing to the roadmap, the page http://dpdk.org/dev/roadmap will be updated soon. 2015-02-25 13:39, Butler, Siobhan A: > Hi all, > > The progress on DPDK 2.0 has been really positive and thanks to everyone for > contributing and helping to grow our community. We

[dpdk-dev] [PATCH v14 12/13] eal/pci: Add rte_eal_dev_attach/detach() functions

On 2015/02/25 23:00, Thomas Monjalon wrote: > 2015-02-25 21:32, Tetsuya Mukawa: >> 2015-02-25 20:21 GMT+09:00 Thomas Monjalon : >>> 2015-02-25 13:04, Tetsuya Mukawa: --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -32,10 +32,13 @@

[dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD

> This PMD adds support for Mellanox ConnectX-3-based adapters through the > verbs framework. It relies on external libraries (libibverbs and user space > driver libmlx4) and kernel support to do so. > > While these libraries and kernel modules are available on OpenFabrics > Alliance's website

[dpdk-dev] [PATCH v3] app/test: add crc32 algorithms equivalence check

> > New function test_crc32_hash_alg_equiv() checks whether software, > > 4-byte operand and 8-byte operand versions of CRC32 hash function > > implementations return the same result value. > > > > Signed-off-by: Yerden Zhumabekov > > Acked-by: Bruce Richardson Applied, thanks

  1   2   >