[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-03-31 Thread Thomas Monjalon
Hi Ravi, 2015-01-06 12:24, Ravi Kerur: > Fix v3 PATCH review comments from Thomas. > eal_common.c is further split into eal_common_system.c and > eal_common_runtime.c files with appropriate functions. > eal_externs.h file is removed and _get_ and _set_ APIs are > used to access variables. >

[dpdk-dev] [PATCH] maintainers: claim pcap pmd library

2015-03-31 Thread Thomas Monjalon
> > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -247,6 +247,7 @@ F: lib/librte_pmd_vmxnet3/ > > > F: doc/guides/prog_guide/poll_mode_drv_paravirtual_vmxnets_nic.rst > > > > > > PCAP PMD > > > +M: Nicol?s Pernas Maradei > > > F: lib/librte_pmd_pcap/ > > > F:

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-31 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, March 30, 2015 8:56 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when > application uses private mbuf data > >

[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-03-31 Thread Thomas Monjalon
2015-03-30 16:15, Ravi Kerur: > On Mon, Mar 30, 2015 at 2:29 PM, Thomas Monjalon 6wind.com> wrote: > > Sorry for not integrating this big refactoring in release 2.0. > > It wasn't easy to merge it during development of some EAL features. > > And it's now too risky to rework it before the release.

[dpdk-dev] [PATCH v2 0/3] split programmers guide a bit

2015-03-31 Thread Thomas Monjalon
2015-03-19 17:48, Thomas Monjalon: > Too many things are included in the programmers guide. > I think it should cover only API and knowledge needed to make an application. > That's why I suggest to move Xen and NICs doc outside. > Then it will be easier to add doc for a new environment or a new

[dpdk-dev] [PATCH] doc: prog guide cleanup for eal multi-pthread

2015-03-31 Thread Thomas Monjalon
2015-03-04 08:51, Cunming Liang: > Reported-by: Butler, Siobhan A > Signed-off-by: Cunming Liang > --- > Fixes: 1733be6d3147(doc: new eal multi-pthread feature) Note: "Fixes" tag should be part of the commit message, above other tags. Applied, thanks

[dpdk-dev] [PATCH] doc: added missing new EAL options in testpmd UG

2015-03-31 Thread Thomas Monjalon
> > Added information on testpmd user guide > > for -l, --lcores and --master-lcore options > > > > Signed-off-by: Pablo de Lara > > Acked-by Siobhan Butler There is a small error: doc/guides/testpmd_app_ug/run_app.rst:58: WARNING: Definition list ends without a blank line; unexpected

[dpdk-dev] [PATCH v2] doc: add l2fwd-jobstats user guide

2015-03-31 Thread Thomas Monjalon
2015-03-27 15:33, De Lara Guarch, Pablo: > > Signed-off-by: Pawel Wodkowski > > --- > > > > Changes v2 > > 1. Fix trailing spaces and typos. > > 2. Add maintaners claim > > PDF will not build due to the extension of the images. Can you change them > from ".svg" to ".*"? Applied with

[dpdk-dev] [PATCH] doc: replace DPDK.xyz.mk by rte.xyz.mk

2015-03-31 Thread Thomas Monjalon
> There are some references to DPDK.xyz.mk files that do not exist in the > dpdk tree. This was probably the result of an automatic replacement, so > restore the proper file names which are rte.xyz.mk. > > Signed-off-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH 0/2] doc: update offload API

2015-03-31 Thread Thomas Monjalon
> Document the offload API and the testpmd commands related > to the checksum forward engine. > > Olivier Matz (2): > doc: update testpmd guide about csum forward engine > doc: add a description of the offload API Applied, thanks

[dpdk-dev] [PATCH] doc: add note on needing igb_uio module for VF devs

2015-03-31 Thread Thomas Monjalon
2015-03-25 15:02, Butler, Siobhan A: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Iremonger, Bernard > > Sent: Wednesday, March 25, 2015 10:43 AM > > To: Richardson, Bruce; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: add note on needing

[dpdk-dev] [PATCH] doc: Update doc for ixgbe VF RSS

2015-03-31 Thread Thomas Monjalon
> Since the following commit has already been merged into dpdk.org mainline, > commit: 42d2f78abcb77ecb769be4149df550308169ef0f > > So update the prog guide for it. > > Signed-off-by: Changchun Ouyang Applied, thanks

[dpdk-dev] [PATCH] doc: add warning for fm10k early driver

2015-03-31 Thread Thomas Monjalon
2015-03-22 11:32, Siobhan Butler: > This patch adds a note to the release notes new features, > as a warning regarding the early status of the FM10K driver for pre-release > access > > Signed-off-by: Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH] doc: New option for vhost sample

2015-03-31 Thread Thomas Monjalon
> > Since codes for this new option(--vlan-strip) are already merged into > > mainline, > > see: commit: e3d61d1609cb9b3ea851c7776bfbb60dcfe8844a. > > > > So the doc need update for that. > > > > Signed-off-by: Changchun Ouyang > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH] vhost library doc update

2015-03-31 Thread Thomas Monjalon
> > add vhost user documentation > > > > Signed-off-by: Huawei Xie > > Acked-by Siobhan Butler doc/guides/prog_guide/vhost_lib.rst:114: ERROR: Unexpected indentation. Applied with above fix, thanks

[dpdk-dev] [PATCH] vhost example doc update

2015-03-31 Thread Thomas Monjalon
> add vhost user documentation > fix some minor issues > > Signed-off-by: Huawei Xie Applied, thanks

[dpdk-dev] [PATCH v4] doc: Update doc for vhost sample

2015-03-31 Thread Thomas Monjalon
> > From: Ouyang Changchun > > > > Added some documentation on common issues for the vhost sample app > > and how to resolve them. > > > > Signed-off-by: Changchun Ouyang > > Signed-off-by: John McNamara > > Acked-by Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH] doc: update of testpmd user guide

2015-03-31 Thread Thomas Monjalon
> > It updated the user guide of testpmd, for the newly supported commands > > of getting/setting hash functions, and the command of showing port > > information. > > > > Signed-off-by: Helin Zhang > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH] doc: added to faq section of release notes

2015-03-31 Thread Thomas Monjalon
> Added some of the questions posted to the mailing list to the FAQ section of > release notes. > > Signed-off-by: Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH v2] doc: update release notes description for new sample apps

2015-03-31 Thread Thomas Monjalon
> Updated release notes release description notes: > - added new sample applications to list: Link Bonding,Skeleton, Callbacks, > Jobstats > - updated copyright date to 2015 > - updated release number form 1.7.0 to 2.0 > > Signed-off-by: Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH] doc: updated tested OS list in release notes

2015-03-31 Thread Thomas Monjalon
> Updated Operating Systems tested during 2.0 in release notes > > Signed-off-by: Siobhan Butler Applied, thanks

[dpdk-dev] [dpdk-announce] release candidate 2.0.0-rc3

2015-03-31 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v2.0.0-rc3 It is the last week to send your fixes before the release. Please check how you might help to review the last patches: http://dpdk.org/dev/patchwork Changelog (main changes since

[dpdk-dev] Inputs needed - testing l2fwd

2015-03-31 Thread Shankari Vaidyalingam
On Wed, Mar 25, 2015 at 11:55 AM, Shankari Vaidyalingam < shankari.v2k6 at gmail.com> wrote: > > +dpdk-dev > >> Thanks for the response. >> >> I'm using Intel 82545 EM as the network adapter type and not using >> virtio-net >> I also checked whether 82545 NIC is supported by DPDK and found that

[dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork

2015-03-31 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu > Sent: Thursday, February 12, 2015 7:22 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork > > Klocwork reports array 'src_offset' may use index 16. >

[dpdk-dev] [PATCH v3] ixgbe: fix data access on big endian cpu

2015-03-31 Thread xuelin....@freescale.com
From: Xuelin Shi enforce rules of the cpu and ixgbe exchange data. 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) 3. checking pci status with converted constant. Signed-off-by: Xuelin Shi ---

[dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork

2015-03-31 Thread Cao, Min
Tested-by: Min Cao Patch name: [dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork Test Flag: Tested-by Tester name:min.cao at intel.com Result summary: total 2 cases, 2passed, 0 failed Test Case 1: Name:

[dpdk-dev] VFIO in setup.sh

2015-03-31 Thread Burakov, Anatoly
> > 3. Why depend on location of vfio module in kernel tree? > >modprobe does the right thing and finds it. > > > > VFIO_PATH="kernel/drivers/vfio/pci/vfio-pci.ko" > > > > echo "Loading VFIO module" > > /sbin/lsmod | grep -s vfio_pci > /dev/null > > if [ $? -ne 0 ] ; then > >

[dpdk-dev] VFIO in setup.sh

2015-03-31 Thread Andre Richter
I think the whole process of VFIO binding maybe needs at least a second thought regarding corner cases and security. 1) in the setup process, there currently is no mechanism that checks if the Device to be used has other devices in the same iommu group that need to be bound to VFIO too. Otherwise

[dpdk-dev] VFIO in setup.sh

2015-03-31 Thread Burakov, Anatoly
> I think the whole process of VFIO binding maybe needs at least a second > thought regarding corner cases and security. > > 1) in the setup process, there currently is no mechanism that checks if the > Device to be used has other devices in the > same iommu group that need to be bound to VFIO

[dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support

2015-03-31 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 30, 2015 4:57 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support > > > > On 03/30/15 18:37, Vlad Zolotarov wrote: > > > >

[dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork

2015-03-31 Thread Thomas Monjalon
Hi Helin, > > Klocwork reports array 'src_offset' may use index 16. > > In function i40e_srcoff_to_flx_pit, index j + 1 can reach > > I40E_FDIR_MAX_FLEX_LEN. > > This patch fixes this issue to avoid array bound. > > > > Signed-off-by: Jingjing Wu > Acked-by: Helin Zhang Please confirm it's a

[dpdk-dev] [PATCH v2 0/3] split programmers guide a bit

2015-03-31 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, March 31, 2015 12:38 AM > To: Butler, Siobhan A > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/3] split programmers guide a bit > > 2015-03-19 17:48, Thomas

[dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support

2015-03-31 Thread Vlad Zolotarov
On 03/31/15 13:25, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Monday, March 30, 2015 4:57 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support >> >>

[dpdk-dev] [PATCH v9 0/3]: Add LRO support to ixgbe PMD

2015-03-31 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 30, 2015 8:21 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v9 0/3]: Add LRO support to ixgbe PMD > > This series adds the missing flow for enabling the LRO in the

[dpdk-dev] [PATCH v2 0/3] split programmers guide a bit

2015-03-31 Thread Thomas Monjalon
2015-03-31 11:34, Mcnamara, John: > Any objection to an additional patch to move the figure captions below > the figures in the docs? No objection. We should use figure:: keyword instead of image:: to add a caption. > The caption above the figure was the format used in the initial docs, > and it

[dpdk-dev] [PATCH] mbuf: add comment explaining confusing code

2015-03-31 Thread Zoltan Kiss
Hi, On 30/03/15 18:39, Don Provan wrote: > if (likely (rte_mbuf_refcnt_read(m) == 1) || > likely (rte_mbuf_refcnt_update(m, -1) == 0)) > > In all the debate about atomics, I don't think anyone got around to pointing > out that in the unlikely case that

[dpdk-dev] VFIO in setup.sh

2015-03-31 Thread Andre Richter
2015-03-31 11:35 GMT+02:00 Burakov, Anatoly : > > > I think the whole process of VFIO binding maybe needs at least a second > > thought regarding corner cases and security. > > > > 1) in the setup process, there currently is no mechanism that checks if the > > Device to be used has other devices

[dpdk-dev] VFIO in setup.sh

2015-03-31 Thread Burakov, Anatoly
> iommu groups already exist before vfio-pci is loaded. > The whole setup process as described in the VFIO documentation, where a > PCIe device shares an iommu group with other devices, can therefore be > automated. Some time ago I wrote a ruby script that does exactly that >

[dpdk-dev] issues with packets bigger than 1500 bytes

2015-03-31 Thread Newman Poborsky
Hi again, I tried setting MTU to larger value and I get really weird behaviour - statistics now show that there are no more errors, but after just a few minutes I get a segfault while calling rte_pktmbuf_free(): #0 0x004202fc in rte_atomic16_add_return (v=0xff94, inc=-1)

[dpdk-dev] Question about images in the docs

2015-03-31 Thread Mcnamara, John
Hi Bernard, If you get a break during your training could you drop up to me or I can drop down to you. I have a quick question about how the images are template in the docs. John > -Original Message- > From: Mcnamara, John > Sent: Tuesday, March 31, 2015 12:34 PM > To: Thomas

[dpdk-dev] Build failure in v2.0.0-rc3 with !CC_AVX2_SUPPORT

2015-03-31 Thread Seth Forshee
I'm getting errors when building DPDK in an Ubuntu 15.04 VM with T=x86_64-native-linuxapp-gcc. I've got a small VM set up without avx2 in the cpu flags: $ cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 6 model name :

[dpdk-dev] Build failure in v2.0.0-rc3 with !CC_AVX2_SUPPORT

2015-03-31 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Seth Forshee > Sent: Tuesday, March 31, 2015 3:41 PM > To: dev at dpdk.org > Subject: [dpdk-dev] Build failure in v2.0.0-rc3 with !CC_AVX2_SUPPORT > > I'm getting errors when building DPDK in an Ubuntu 15.04

[dpdk-dev] Queries on dpdk buffer allocation and kni

2015-03-31 Thread Rajasekhar Pulluru
Dear Group members, I have been trying to understand the dpdk code and have got two queries. 1. descriptor rings and packet buffer allocation Looking at the linux native e1000 kernel driver, Memory for NIC's tx and rx descriptor rings are allocated using dma_alloc_coherent. Memory for rx packet

[dpdk-dev] Build failure in v2.0.0-rc3 with !CC_AVX2_SUPPORT

2015-03-31 Thread Seth Forshee
On Tue, Mar 31, 2015 at 02:59:36PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Seth Forshee > > Sent: Tuesday, March 31, 2015 3:41 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] Build failure in v2.0.0-rc3

[dpdk-dev] [PATCH] mbuf: clean old refcnt option

2015-03-31 Thread Thomas Monjalon
CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by commit 4769bc5a27cc. Some traces remain because of delayed patches. It can also be removed from doxygen config. It is now poisoned in rte_mbuf.h to warn any misuse. Fixes: d0dff9ba445e

[dpdk-dev] dev@DPDK Hackathon Proposal

2015-03-31 Thread Butler, Siobhan A
Hi all, As a community we have virtually come together from all over the globe, developing now our third successful open source DPDK version with DPDK r2.0 about to release. It is astounding to comprehend the commitment and enthusiasm you have all shared to bring DPDK to this point. With

[dpdk-dev] [PATCH v4 0/7] Move EAL common function

2015-03-31 Thread Ravi Kerur
I will work on it and send out patches by next week. If you need it earlier please let me know. Thanks, Ravi On Mon, Mar 30, 2015 at 4:24 PM, Thomas Monjalon wrote: > 2015-03-30 16:15, Ravi Kerur: > > On Mon, Mar 30, 2015 at 2:29 PM, Thomas Monjalon < > thomas.monjalon at 6wind.com> wrote: > >

[dpdk-dev] [PATCH v2 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-31 Thread Olivier MATZ
Hi Konstantin, On 03/31/2015 01:17 AM, Ananyev, Konstantin wrote: With this solution, there are 2 options: - no mempool modification, so each application/driver has to add priv_size bytes to the object to get the mbuf pointer. This does not look feasible. - change the

[dpdk-dev] [PATCH v3 0/5] mbuf: enhancements of mbuf clones

2015-03-31 Thread Olivier Matz
This series fixes the support of indirect mbufs when the application reserves a private area in mbufs. This is done adding a new field in each mbuf storing the size of this private area. Another option would have been to store that in the mbuf pool private info, but as we have enough room in mbuf,

[dpdk-dev] [PATCH v3 1/5] mbuf: fix clone support when application uses private mbuf data

2015-03-31 Thread Olivier Matz
From: Olivier Matz Add a new private_size field in mbuf structure that should be initialized at mbuf pool creation. This field contains the size of the application private data in mbufs. Introduce new static inline functions rte_mbuf_from_indirect() and

[dpdk-dev] [PATCH v3 2/5] mbuf: allow to clone an indirect mbuf

2015-03-31 Thread Olivier Matz
From: Olivier Matz Remove one limitation of rte_pktmbuf_attach(): "mbuf we're attaching to must be direct". Now, when we attach to an indirect mbuf: - copy the all relevant fields (addr, len, offload, ...) as before - get the pointer to the mbuf that embeds the data

[dpdk-dev] [PATCH v3 3/5] test/mbuf: rename mc variable in m

2015-03-31 Thread Olivier Matz
From: Olivier Matz It's better to name the mbuf 'm' instead of 'mc' as it's not a clone. Signed-off-by: Olivier Matz --- app/test/test_mbuf.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/app/test/test_mbuf.c

[dpdk-dev] [PATCH v3 4/5] test/mbuf: enhance mbuf refcnt test

2015-03-31 Thread Olivier Matz
From: Olivier Matz Check that the data in the cloned mbuf is the same than in the reference mbuf. Check that the reference counter is incremented for each segment. Signed-off-by: Olivier Matz --- app/test/test_mbuf.c | 37 + 1 file

[dpdk-dev] [PATCH v3 5/5] test/mbuf: verify that cloning a clone works properly

2015-03-31 Thread Olivier Matz
From: Olivier Matz Signed-off-by: Olivier Matz --- app/test/test_mbuf.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 9d8ee4e..e59aedc 100644 --- a/app/test/test_mbuf.c +++

[dpdk-dev] [PATCH] mbuf: clean old refcnt option

2015-03-31 Thread Olivier MATZ
Hi Thomas, On 03/31/2015 07:58 PM, Thomas Monjalon wrote: > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into CONFIG_RTE_MBUF_REFCNT > by commit 62814bc2e923 and removed by commit 4769bc5a27cc. > Some traces remain because of delayed patches. > > It can also be removed from doxygen config. > It is