[dpdk-dev] [PATCH v5] examples/l2fwd-cat: PQoS CAT and CDP, example of libpqos usage

2016-03-22 Thread Thomas Monjalon
2016-03-14 13:46, Wojciech Andralojc: > This patch implements PQoS as a sample application. > PQoS allows management of the CPUs last level cache, > which can be useful for DPDK to ensure quality of service. > The sample app links against the existing 01.org PQoS library >

[dpdk-dev] [PATCH] examples/performance-thread: fix build without SSE4.1

2016-03-22 Thread Thomas Monjalon
clang reports these errors: error: too many arguments to function call, expected 2, have 3 examples/performance-thread/l3fwd-thread/main.c:1220:1: note: 'l3fwd_simple_forward' declared here examples/l3fwd/main.c:550:1: error: unused function 'send_packetsx4' The function is used

[dpdk-dev] [PATCH v3 05/10] qede: Add core driver

2016-03-22 Thread Rasesh Mody
> From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, March 21, 2016 10:33 AM > > On Fri, 18 Mar 2016 17:53:20 -0700 > Rasesh Mody wrote: > > > +static struct eth_dev_ops qede_eth_dev_ops = { > > + .dev_configure = qede_dev_configure, > > + .dev_infos_get =

[dpdk-dev] [PATCH v13 2/2] vhost: Add VHOST PMD

2016-03-22 Thread Tetsuya Mukawa
On 2016/03/22 0:40, Loftus, Ciara wrote: >> + >> +static void >> +eth_dev_info(struct rte_eth_dev *dev, >> + struct rte_eth_dev_info *dev_info) >> +{ >> +dev_info->driver_name = drivername; >> +dev_info->max_mac_addrs = 1; >> +dev_info->max_rx_pktlen = (uint32_t)-1; >> +

[dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD

2016-03-22 Thread Marvin Liu
Build log: /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named 's6_addr32' in 'struct in6_addr' rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd swap big endian parameter to host endian. Move the swap

[dpdk-dev] Reg: promiscuous mode on VF

2016-03-22 Thread bharath paulraj
Thanks a lot Michael. Finally i am able to see some light. I will try the same in our setup and will post you the results. Thanks, Bharath On Tue, Mar 22, 2016 at 12:09 PM, Qiu, Michael wrote: > Yes, we could let ovs using 82599 VF to do rx/tx. I don't know what's > your l2 bridge, but since

[dpdk-dev] [dpdk-dev, 1/3] rte_interrupts: add rte_eal_intr_exit to shut down IRQ thread

2016-03-22 Thread Matthew Hall
On Mon, Mar 21, 2016 at 03:58:44PM +0800, Liang, Cunming wrote: > the default termination handler I am not so experienced with this "default termination handler". Can someone clarify what it is so I could comment better about it? > If EINTR is caused by some non-term purpose signals, are you

[dpdk-dev] [PATCH] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). Fixes: 4758404a3084 ("mk: fix eal shared library

[dpdk-dev] [PATCH] ixgbe: add TX queue number check

2016-03-22 Thread Wenzhuo Lu
Ixgbe supports at most 128 TX queues. But in none VT nor DCB mode the queues 64 ~ 127 should not be used. Ixgbe doesn't do any check about that. If a queue larger than 64 is used, the TX packets will be dropped silently. It's hard to debug. This check is added to forbid using queue number larger

[dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues

2016-03-22 Thread Tetsuya Mukawa
Currently, the maximum value of rx/tx queueus are kept by EAL. But, the value are used like below different meanings in vhost PMD. - The maximum value of current enabled queues. - The maximum value of current supported queues. This wrong double meaning will cause an issue like below steps. *

[dpdk-dev] [PATCH] ixgbe: add TX queue number check

2016-03-22 Thread Qiu, Michael
On 3/22/2016 4:10 PM, Wenzhuo Lu wrote: > Ixgbe supports at most 128 TX queues. But in none VT nor DCB mode > the queues 64 ~ 127 should not be used. Ixgbe doesn't do any check > about that. If a queue larger than 64 is used, the TX packets will > be dropped silently. It's hard to debug. > This

[dpdk-dev] [PATCH] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Thomas Monjalon
2016-03-22 09:09, Daniel Mrzyglod: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). [...] > ---

[dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD

2016-03-22 Thread Qiu, Michael
On 3/22/2016 2:51 PM, Marvin Liu wrote: > Build log: > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named > 's6_addr32' in 'struct in6_addr' > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd >

[dpdk-dev] [PATCH] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Mrzyglod, DanielX T
>-Original Message- >From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >Sent: Tuesday, March 22, 2016 9:55 AM >To: Mrzyglod, DanielX T >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH] mk: fix eal shared library dependencies -lrt > >2016-03-22 09:09, Daniel Mrzyglod: >> For

[dpdk-dev] [PATCH] testpmd: fix build on FreeBSD

2016-03-22 Thread Sergio Gonzalez Monroy
On 22/03/2016 03:30, Liu, Yong wrote: > Hi Pablo & Sergio, > >> -Original Message- >> From: De Lara Guarch, Pablo >> Sent: Monday, March 21, 2016 5:40 PM >> To: Gonzalez Monroy, Sergio; Liu, Yong; dev at dpdk.org >> Subject: RE: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD >> >> >> >>>

[dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested

2016-03-22 Thread Olivier Matz
Hi Keith, On 03/21/2016 06:38 PM, Wiles, Keith wrote: >> On Mar 21, 2016, at 11:10 AM, Olivier Matz wrote: >> >> When using RSS, the number of rxqs has to be a power of two. >> This is a problem because there is no API is dpdk that makes >> the application aware of that. >> >> A good compromise

[dpdk-dev] [PATCH v3 0/3] xen: netfront poll mode driver

2016-03-22 Thread Jan Blunck
v3 changes: - removed fake PCI interface - removed struct virt_eth_driver - check for UIO name and version - added basic documentation Jan Blunck (3): xen: Add UIO kernel driver xen: Add netfront poll mode driver xen: Add documentation config/common_base| 6 +

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Jan Blunck
New UIO helper kernel driver for Xen netfront UIO poll mode driver. Signed-off-by: Stephen Hemminger Signed-off-by: Jan Blunck --- lib/librte_eal/linuxapp/Makefile | 1 + lib/librte_eal/linuxapp/xen_uio/Makefile | 56 ++ lib/librte_eal/linuxapp/xen_uio/compat.h | 47 ++

[dpdk-dev] [PATCH v3 2/3] xen: Add netfront poll mode driver

2016-03-22 Thread Jan Blunck
This implements a poll mode driver that has the same functionality as the Xen netfront driver in the Linux kernel. Signed-off-by: Stephen Hemminger Signed-off-by: Jan Blunck --- config/common_base | 6 + drivers/net/Makefile | 1 + drivers/net/xen/Makefile

[dpdk-dev] [PATCH v3 3/3] xen: Add documentation

2016-03-22 Thread Jan Blunck
Add basic documentation for Xen Netfront PMD compilation and testpmd invocation. Signed-off-by: Jan Blunck --- doc/guides/nics/overview.rst | 28 ++-- doc/guides/nics/xen.rst | 101 +++ 2 files changed, 115 insertions(+), 14 deletions(-)

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). Fixes: 4758404a3084 ("mk: fix eal shared library

[dpdk-dev] [PATCH v3 2/3] xen: Add netfront poll mode driver

2016-03-22 Thread David Marchand
Hello, On Tue, Mar 22, 2016 at 10:55 AM, Jan Blunck wrote: > +static struct eth_dev_ops xen_eth_dev_ops = { > + /*dev*/ > + .dev_configure= xen_dev_configure, > + .dev_close= xen_dev_close, > + .dev_start= xen_dev_start, > + .dev_stop

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-22 Thread Thomas Monjalon
2016-03-17 17:40, Thomas Monjalon: > CC Maryam and Olivier who had discussions about imissed and other stats: > http://dpdk.org/ml/archives/dev/2015-August/022905.html > http://dpdk.org/ml/archives/dev/2015-September/023351.html >

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-22 Thread Bruce Richardson
On Mon, Mar 21, 2016 at 05:47:44PM +, Xie, Huawei wrote: > On 3/18/2016 10:17 PM, Bruce Richardson wrote: > > On Fri, Mar 18, 2016 at 01:47:29PM +0100, Mauricio V?squez wrote: > >> Hi, > >> > >> > >> On Fri, Mar 18, 2016 at 11:35 AM, Thomas Monjalon >> 6wind.com > >>> wrote: > >>> 2016-03-18

[dpdk-dev] DPDK and HW offloads

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 05:50:28AM +, Qiu, Michael wrote: > On 3/21/2016 11:27 PM, Kyle Larose wrote: > > On Mon, Mar 21, 2016 at 10:52 AM, Bruce Richardson > > wrote: > >> On Sun, Mar 20, 2016 at 08:18:57PM +0100, Thomas Monjalon wrote: > >>> 2016-03-20 14:17, Zhang, Helin: > From:

[dpdk-dev] [PATCH v2 0/9] pci cleanup and blacklist rework

2016-03-22 Thread David Marchand
Hello Jan, On Wed, Mar 16, 2016 at 5:07 PM, Jan Viktorin wrote: > On Fri, 29 Jan 2016 15:49:04 +0100 > David Marchand wrote: > >> Before 2.2.0 release, while preparing for more changes in eal (and fixing >> a problem reported by Roger M. [1]), I came up with this (part of) patchset >> that

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Bruce Richardson
On Mon, Mar 21, 2016 at 04:34:50PM -0700, Clarylin L wrote: > I am trying multi-segment mbuf, but it seems not working. > > On my target host, the mbuf size is set to 2048 and I am trying to send > large packet to it (say 2500 bytes without fragmentation) from another > host. I enabled both

[dpdk-dev] [PATCH v13 2/2] vhost: Add VHOST PMD

2016-03-22 Thread Loftus, Ciara
> > On 2016/03/22 10:55, Tetsuya Mukawa wrote: > > On 2016/03/22 0:40, Loftus, Ciara wrote: > >>> + > >>> +static void > >>> +eth_dev_info(struct rte_eth_dev *dev, > >>> + struct rte_eth_dev_info *dev_info) > >>> +{ > >>> + dev_info->driver_name = drivername; > >>> + dev_info->max_mac_addrs

[dpdk-dev] [PATCH] mlx4: check if port is configured for Ethernet

2016-03-22 Thread Adrien Mazarguil
Notify user otherwise. A similar check has already been added to mlx5 in commit "mlx5: check port is configured as ethernet device". Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c

[dpdk-dev] [PATCH v3 2/3] xen: Add netfront poll mode driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 11:07 AM, David Marchand wrote: > Hello, > > On Tue, Mar 22, 2016 at 10:55 AM, Jan Blunck wrote: >> +static struct eth_dev_ops xen_eth_dev_ops = { >> + /*dev*/ >> + .dev_configure= xen_dev_configure, >> + .dev_close= xen_dev_close, >>

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 10:55, Jan Blunck: > New UIO helper kernel driver for Xen netfront UIO poll mode driver. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Jan Blunck Is it contributed upstream? Is there something common with igb_uio?

[dpdk-dev] [PATCH v3 05/10] qede: Add core driver

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > drivers/net/qede/Makefile | 90 +++ > drivers/net/qede/qede_eth_if.h| 176 + >

[dpdk-dev] [PATCH v3 05/10] qede: Add core driver

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 10:55:54AM +, Bruce Richardson wrote: > On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote: > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > Signed-off-by: Sony Chacko > > --- > > drivers/net/qede/Makefile | 90 +++ > >

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon wrote: > 2016-03-22 10:55, Jan Blunck: >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. >> >> Signed-off-by: Stephen Hemminger >> Signed-off-by: Jan Blunck > > Is it contributed upstream? No. Haven't planed that yet. > Is

[dpdk-dev] [PATCH v3 06/10] qede: Add L2 support

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:53:21PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- Again, a commit message describing in a bit more detail what is included in this patchset - clarifying what is meant by l2 support - would

[dpdk-dev] [PATCH v3 08/10] qede: Add attention support

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:53:23PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- Commit message describing the patch, please. /Bruce

[dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD

2016-03-22 Thread Richardson, Bruce
I've had a quick scan over this patchset, and as you've probably seen I've made some public comments on it. General comments on the whole patchset are: * Please run checkpatch on the patchset and clear up as many issues as you can. There are a number of typos called out which especially must be

[dpdk-dev] [PATCH v3 10/10] qede: Enable PMD build

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:53:25PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > config/common_base| 14 ++ > drivers/net/Makefile |1 + > mk/rte.app.mk |2 ++ > scripts/test-build.sh

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 12:04, Jan Blunck: > On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon > wrote: > > 2016-03-22 10:55, Jan Blunck: > >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. > >> > >> Signed-off-by: Stephen Hemminger > >> Signed-off-by: Jan Blunck > > > > Is it

[dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 11:21:25AM +, Richardson, Bruce wrote: > I've had a quick scan over this patchset, and as you've probably seen I've > made some public comments on it. General comments on the whole patchset are: > * Please run checkpatch on the patchset and clear up as many issues as

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Thomas Monjalon
Sergio, your help is required here. Thanks 2016-03-17 10:35, gowrishankar: > Could this patch be reviewed please. > > Thanks, > Gowrishankar > > On Monday 07 March 2016 07:43 PM, Gowrishankar wrote: > > From: Gowri Shankar > > > > For a secondary process address space to map hugepages from

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-22 Thread Thomas Monjalon
Hi, Pablo, Sergio, please could you help with this issue? 2016-03-13 22:16, Dhana Eadala: > We found a problem in dpdk-2.2 using under multi-process environment. > Here is the brief description how we are using the dpdk: > > We have two processes proc1, proc2 using dpdk. These proc1 and proc2

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Sergio Gonzalez Monroy
On 22/03/2016 11:36, Thomas Monjalon wrote: > Sergio, your help is required here. I missed it with the /ppc tag. I'll get to it. Sergio > Thanks > > 2016-03-17 10:35, gowrishankar: >> Could this patch be reviewed please. >> >> Thanks, >> Gowrishankar >> >> On Monday 07 March 2016 07:43 PM,

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Panu Matilainen
On 03/22/2016 11:58 AM, Daniel Mrzyglod wrote: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > >

[dpdk-dev] DPDK and HW offloads

2016-03-22 Thread Jay Rolette
On Tue, Mar 22, 2016 at 5:19 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Mar 22, 2016 at 05:50:28AM +, Qiu, Michael wrote: > > > > Why not to implement one simple API with variable arguments, just like > > syscall ioctl() does. And drivers implement it's specific

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). v3: change LDFLAGS to LDLIBS v2: Add missed example v1:

[dpdk-dev] [PATCH v3] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). v3: change LDFLAGS to LDLIBS v2: Add missed example v1:

[dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function

2016-03-22 Thread Zhe Tao
Issue: when using the following CLI in testpmd to enable ipv6 TSO feature = set verbose 1 csum set ip hw 0 csum set udp hw 0 csum set tcp hw 0 csum set sctp hw 0 csum set outer-ip hw 0 csum parse_tunnel on 0 tso set 800 0 set fwd csum start = We will not get we want, the

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Pablo de Lara
Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, l2fwd-crypto may use them, extending the list of algorithms parsed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/main.c

[dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help

2016-03-22 Thread Pablo de Lara
Previous cdev parameter was changed to cdev_type, to select a crypto device type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...). Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1

[dpdk-dev] Regarding DPDK installation

2016-03-22 Thread Thomas Monjalon
2016-03-22 13:13, Vivek Gupta: > I am trying to install DPDK 2.2 on Ubuntu 14. Do you just want to compile DPDK or really install it? Where do you want to install DPDK? > After configuring all necessary variables in common_linuxapp > file, I run following two commands > > make config

[dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function

2016-03-22 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhe Tao > Sent: Tuesday, March 22, 2016 1:14 PM > To: dev at dpdk.org > Cc: Tao, Zhe > Subject: [dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function > > Issue: > when using the following CLI in

[dpdk-dev] [PATCH 00/10] cxgbe: Add flow director support

2016-03-22 Thread Bruce Richardson
On Wed, Feb 03, 2016 at 02:02:21PM +0530, Rahul Lakkireddy wrote: > This series of patches extend the flow director filter and add support > for Chelsio T5 hardware filtering capabilities. > > Chelsio T5 supports carrying out filtering in hardware which supports 3 > actions to carry out on a

[dpdk-dev] Regarding DPDK installation

2016-03-22 Thread Vivek Gupta
Hi >Do you just want to compile DPDK or really install it?Where do you want to >install DPDK? I want to install DPDK into {$HOME}/dpdk downloaded tar ball. > The install directory is not specified in this command. After your suggestion i used as make config T=x86_64-ivshmem-linuxapp-gcc

[dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested

2016-03-22 Thread Wiles, Keith
Hi Olivier, >Hi Keith, > >On 03/21/2016 06:38 PM, Wiles, Keith wrote: >>> On Mar 21, 2016, at 11:10 AM, Olivier Matz >>> wrote: >>> >>> When using RSS, the number of rxqs has to be a power of two. >>> This is a problem because there is no API is dpdk that makes >>> the application aware of

[dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at the tail of rx hwring

2016-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Monday, March 21, 2016 2:27 AM > To: Richardson, Bruce > Cc: Lu, Wenzhuo; Zhang, Helin; Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at

[dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes

2016-03-22 Thread Bruce Richardson
On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c| 207 > +- > drivers/net/bnx2x/bnx2x.h|4 +- > drivers/net/bnx2x/bnx2x_ethdev.c |

[dpdk-dev] [PATCH] ixgbe: fix vector RX can't always set packet_type properly

2016-03-22 Thread Konstantin Ananyev
Fixes: 39625417585 ("mbuf: redefine packet type") Current vector RX can't always set packet_type properly. To be more specific: a) it never sets RTE_PTYPE_L2_ETHER b) it doesn't handle tunnel ipv4/ipv6 case correctly. c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not. While a) is pretty

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-22 Thread Xie, Huawei
On 3/22/2016 6:13 PM, Richardson, Bruce wrote: > On Mon, Mar 21, 2016 at 05:47:44PM +, Xie, Huawei wrote: >> On 3/18/2016 10:17 PM, Bruce Richardson wrote: >>> On Fri, Mar 18, 2016 at 01:47:29PM +0100, Mauricio V?squez wrote: Hi, On Fri, Mar 18, 2016 at 11:35 AM, Thomas

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 12:27 PM, Thomas Monjalon wrote: > 2016-03-22 12:04, Jan Blunck: >> On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon >> wrote: >> > 2016-03-22 10:55, Jan Blunck: >> >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. >> >> >> >> Signed-off-by: Stephen

[dpdk-dev] [PATCH] testpmd: fix enumerated type mixed with another type

2016-03-22 Thread Tomasz Kulasek
This patch fixes error #188: enumerated type mixed with another type, when uint32_t is casted on enum type in icc. Fixes: 05f1b9c82ec2 ("app/testpmd: add commands for L2 tunnel config") Signed-off-by: Tomasz Kulasek --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help

2016-03-22 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, March 22, 2016 1:21 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help > >

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, March 22, 2016 1:17 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms > > Since SNOW3G

[dpdk-dev] [PATCH v6 0/2] i40evf: pf reset event report

2016-03-22 Thread Bruce Richardson
On Tue, Mar 15, 2016 at 09:59:38AM +0800, Jingjing Wu wrote: > v6 changes: > - rebase on latest dpdk-next-net/rel_16_04 branch (commit 94d8f4bf963a) > - fix complie issue > > v5 changes: > - doc rewording and format fixing. > > v4 changes: > - rebase on latest dpdk-next-net/rel_16_04 branch

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-22 Thread Tahhan, Maryam
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, March 17, 2016 4:41 PM > To: Igor Ryzhov > Cc: dev at dpdk.org; Tahhan, Maryam ; > olivier.matz at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in > erroneous packets counter > > CC

[dpdk-dev] [PATCH] i40e: fix using memory after free issue

2016-03-22 Thread Bruce Richardson
On Mon, Mar 14, 2016 at 09:02:04AM +, Jiangu Zhao wrote: > The old code still uses entry in the next loop of LIST_FOREACH after free() > in i40e_res_pool_destroy(). > Change to a safe way to free entry, which is similar with LIST_FOREACH_SAFE > in FreeBSD. > > Signed-off-by: Jiangu Zhao

[dpdk-dev] [PATCH] doc: notify Rx errors not counting missed packets anymore

2016-03-22 Thread Thomas Monjalon
Fixes: 86057c9992f5 ("ethdev: remove missed packets from error counter") Suggested-by: Maryam Tahhan Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/release_16_04.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_16_04.rst

[dpdk-dev] [PATCH v4 0/5] lpm allocation fixes

2016-03-22 Thread Thomas Monjalon
2016-03-21 15:06, Christian Ehrhardt: > Poking a bit on autotest revealed a few shortcomings in the lpm allocation > path. > Thanks to the feedback to the first revision of the patches here v2. > Also Oliver Matz spotted similar issues and made me aware - thanks! > Integrating them revealed even

[dpdk-dev] [PATCH v3 0/5] Implement missing features in mlx5

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 04:38:53PM +0100, Adrien Mazarguil wrote: > This patchset adds to mlx5 a few features available in mlx4 (TX from > secondary processes) or provided by Verbs (support for HW packet padding, > TX VLAN insertion). > > Release notes and documentation are updated accordingly. >

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Sergio Gonzalez Monroy
First of all, forgive my ignorance regarding ppc64 and if the questions are naive but after having a look to the already existing code for ppc64 and this patch now, why are we doing this reverse mapping at all? I guess the question revolves around the comment in eal_memory.c: 1316

[dpdk-dev] [PATCH] enic: add missing \n to a few print statements

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:48:13PM -0700, John Daley wrote: > From: Nelson Escobar > > Signed-off-by: Nelson Escobar > Acked-by: John Daley Applied to dpdk-next-net/rel_16_04 /Bruce

[dpdk-dev] [PATCH] enic: prevent segfaults when allocating too many TX or RX queues

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:49:58PM -0700, John Daley wrote: > From: Nelson Escobar > > Add checks to make sure we don't try to allocate more tx or rx queues > than we support. > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley Better to use the word fix in the title to indicate this

[dpdk-dev] [PATCH] enic: prevent segfaults when allocating too many TX or RX queues

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 04:46:30PM +, Bruce Richardson wrote: > On Thu, Mar 17, 2016 at 03:49:58PM -0700, John Daley wrote: > > From: Nelson Escobar > > > > Add checks to make sure we don't try to allocate more tx or rx queues > > than we support. > > > > Signed-off-by: Nelson Escobar > >

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-22 Thread Thomas Monjalon
> > Issuing a zero objects dequeue with a single consumer has no effect. > > Doing so with multiple consumers, can get more than one thread to succeed > > the compare-and-set operation and observe starvation or even deadlock in > > the while loop that checks for preceding dequeues. The

[dpdk-dev] [PATCH 0/3] enic PMD receive path fixes

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:57:04PM -0700, John Daley wrote: > These patches fix up some bugs in the enic receive path. > > John Daley (3): > enic: mbuf->ol_flags could be set incorrectly > enic: handle error packets properly > enic: small cleanup- remove a packet_error conditional > >

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-22 Thread Michael Frasca
If the provided configuration does not call for RSS, then RSS is explicitly disabled. Without this change, the device continues to operate under the previous RSS configuration. Fixes: 57033cdf8fdc ("fm10k: add PF RSS") Signed-off-by: Michael Frasca --- drivers/net/fm10k/fm10k_ethdev.c | 4 +++-

[dpdk-dev] [PATCH] doc: notify Rx errors not counting missed packets anymore

2016-03-22 Thread Thomas Monjalon
2016-03-22 16:57, Thomas Monjalon: > Fixes: 86057c9992f5 ("ethdev: remove missed packets from error counter") > > Suggested-by: Maryam Tahhan > Signed-off-by: Thomas Monjalon [...] > +* The ethdev statistics counter imissed is considered exclusive with ierrors. > + Every drivers are now

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 04:35:32PM +, Sergio Gonzalez Monroy wrote: > First of all, forgive my ignorance regarding ppc64 and if the questions are > naive but after having a > look to the already existing code for ppc64 and this patch now, why are we > doing this reverse mapping at all? > > I

[dpdk-dev] [PATCH] testpmd: fix enumerated type mixed with another type

2016-03-22 Thread Thomas Monjalon
2016-03-22 15:52, Tomasz Kulasek: > This patch fixes error #188: enumerated type mixed with another type, > when uint32_t is casted on enum type in icc. > > Fixes: 05f1b9c82ec2 ("app/testpmd: add commands for L2 tunnel config") > > Signed-off-by: Tomasz Kulasek Applied, thanks

[dpdk-dev] DPDK and HW offloads

2016-03-22 Thread Stephen Hemminger
On Tue, 22 Mar 2016 07:19:01 -0500 Jay Rolette wrote: > On Tue, Mar 22, 2016 at 5:19 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Tue, Mar 22, 2016 at 05:50:28AM +, Qiu, Michael wrote: > > > > > > Why not to implement one simple API with variable arguments, just

[dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues

2016-03-22 Thread Loftus, Ciara
> > Currently, the maximum value of rx/tx queueus are kept by EAL. But, > the value are used like below different meanings in vhost PMD. > - The maximum value of current enabled queues. > - The maximum value of current supported queues. > > This wrong double meaning will cause an issue like

[dpdk-dev] [PATCH] ixgbe: fix reta query and update on x550

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 03:19:35AM +, Lu, Wenzhuo wrote: > Hi, > > > > -Original Message- > > From: Wang, Xiao W > > Sent: Friday, March 18, 2016 10:28 AM > > To: Zhang, Helin > > Cc: dev at dpdk.org; Lu, Wenzhuo; Wang, Xiao W > > Subject: [PATCH] ixgbe: fix reta query and update on

[dpdk-dev] [PATCH 1/2] mlx5: fix overwritten RSS configuration

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:27:47PM +0100, Adrien Mazarguil wrote: > On Fri, Mar 18, 2016 at 01:54:42PM +0100, Nelio Laranjeiro wrote: > > RSS configuration provided by the application should not be used as storage > > by the PMD. > > > > Fixes: 2f97422e7759 ("mlx5: support RSS hash update and

[dpdk-dev] [PATCH v3] enic: update enic PMD maintainer and pointer to the guide.

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 11:27:07AM -0700, John Daley wrote: > Change maintainers for ENIC PMD and fix pointer to enic > documentation in MAINTAINERS. > > Signed-off-by: John Daley > --- Applied to dpdk-next-net/rel_16_04 /Bruce

[dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote: > From: Nelson Escobar > > On initialization, the rq descriptor count was set to the limit > of the vic. When the requested number of rx descriptors was > less than this count, enic_alloc_rq() was incorrectly setting > the count to the

[dpdk-dev] [dpdk-users] how to Read(Write) from(to) via lcores in dpdk regardless of NIC

2016-03-22 Thread Mahdi Moradmand Badie
Dear Andriy, I did my task with the help of rte_ring, but now I wanna replace rte_ring with real share cache(L3), May I ask you if there is any possibility in DPDK in order to do it. Thanks in advance, On 9 March 2016 at 05:26, Andriy Berestovskyy wrote: > Mahdi, > 1. Sure, the rte_ring is

[dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 05:32:41PM +, Bruce Richardson wrote: > On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote: > > From: Nelson Escobar > > > > On initialization, the rq descriptor count was set to the limit > > of the vic. When the requested number of rx descriptors was > >

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, March 22, 2016 1:17 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH] l2fwd-crypto: add SNOW3G algorithms > > Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, >

[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Markos Chandras
This is similar to what's being used in the Linux kernel. Querying the GCC macros directly gives more accurate results compared to -dumpversion which could vary across distributions. Signed-off-by: Markos Chandras --- In openSUSE Tumbleweed (and in any other SUSE distribution which uses (or will

[dpdk-dev] [PATCH] examples/ip_pipeline: fix configuration parser

2016-03-22 Thread Thomas Monjalon
2016-03-14 12:22, Fan Zhang: > Fixes: 377cd98e ("example/ip_pipeline: add link identification") > > Signed-off-by: Fan Zhang > Acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH] examples/performance-thread: fix build without SSE4.1

2016-03-22 Thread Thomas Monjalon
> clang reports these errors: > > error: too many arguments to function call, expected 2, have 3 > examples/performance-thread/l3fwd-thread/main.c:1220:1: note: > 'l3fwd_simple_forward' declared here > > examples/l3fwd/main.c:550:1: error: unused function 'send_packetsx4' > > The

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-22 Thread Stephen Hemminger
On Tue, 22 Mar 2016 15:23:22 + "Tahhan, Maryam" wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Thursday, March 17, 2016 4:41 PM > > To: Igor Ryzhov > > Cc: dev at dpdk.org; Tahhan, Maryam ; > > olivier.matz at 6wind.com > > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] examples/l3fwd: remove old SSE4 comments

2016-03-22 Thread Thomas Monjalon
The flag ENABLE_MULTI_BUFFER_OPTIMIZE has been removed so the related comments are now useless. Fixes: 26b5b020 ("examples/l3fwd: modularize") Signed-off-by: Thomas Monjalon --- examples/l3fwd/l3fwd_em.c | 9 - examples/l3fwd/l3fwd_lpm.c | 8 2 files changed, 17

[dpdk-dev] [PATCH] mk: restrict CPU flags list

2016-03-22 Thread Thomas Monjalon
2016-03-21 21:27, Thomas Monjalon: > When compiling each file, the CPU flags are given as RTE_MACHINE_CPUFLAG_* > and in the list RTE_COMPILE_TIME_CPUFLAGS. > > RTE_MACHINE_CPUFLAG_* are used to check the CPU features when compiling. > > The list RTE_COMPILE_TIME_CPUFLAGS is used only to check

[dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies

2016-03-22 Thread Thomas Monjalon
2016-03-21 11:48, Ferruh Yigit: > On 3/21/2016 11:33 AM, Panu Matilainen wrote: > > Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by > > librte_meter is typically inlined so the missing dependency does not > > actually cause failures, and librte_pmd_nfp is not built by

[dpdk-dev] [PATCH v3] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Thomas Monjalon
2016-03-22 13:51, Daniel Mrzyglod: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > > v3: change

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-22 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, March 22, 2016 11:42 AM > To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Cc: dev at dpdk.org; Dhana Eadala; Richardson, Bruce; Qiu, Michael > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

2016-03-22 Thread Thomas Monjalon
2016-03-17 19:08, Thomas Monjalon: > There are still too few tests and reviews, especially for > autonegotiation with Intel devices (patch #6). > I would not be surprised to see some bugs in this rework. Any feedback about autoneg in e1000/ixgbe/i40e? Has it been tested before its integration in

[dpdk-dev] Question on examples/multi_process app

2016-03-22 Thread Harish Patil
Hi, I have a question regarding symmetric_mp and mp_server applications under examples/multi_process. In those apps, rte_eth_promiscuous_enable() is called before rte_eth_dev_start(). Is this the correct way to initialize the port/device? As per the description in

[dpdk-dev] [PATCH 1/8] lpm: Fix pointer aliasing issues

2016-03-22 Thread Thomas Monjalon
2016-02-25 21:30, Bruce Richardson: > On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote: > > /** > > + * Convert from tbl_entry types to integer types > > + */ > > +static inline uint16_t > > +rte_lpm_tbl24_entry_to_uint16(const struct rte_lpm_tbl24_entry *entry) > > +{ > > + union {

  1   2   >