[dpdk-dev] [RFC] kernel paramters like DPDK CLI options

On Wed, Jun 01, 2016 at 04:03:07PM +0200, Thomas Monjalon wrote: > 2016-06-01 21:19, Yuanhan Liu: > > On Wed, Jun 01, 2016 at 02:39:28PM +0200, Thomas Monjalon wrote: > > > I was thinking to implement the library options parsing in DPDK. > > > But if the application implements its own options

[dpdk-dev] [PATCH v5 7/8] virtio-user: add a new vdev named virtio-user

Hi Yuanhan, On 6/1/2016 4:26 PM, Yuanhan Liu wrote: > On Mon, May 30, 2016 at 10:55:38AM +, Jianfeng Tan wrote: >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> index 41d8ad1..5e4f60b 100644 >> ---

[dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs

Tested-by: Yongjie Gu - Check patch: success - Apply patch: success - compilation: success OS: fedora20 GCC: gcc_x86-64, 4.8.3 ICC: 16.0.2 Commit: 587d684d70f9d7f74e77a886c58103b40409caea i686-native-linuxapp-icc: compile pass

[dpdk-dev] [PATCH 0/2] NSH packet type support in i40e

On Tue, May 03, 2016 at 01:51:10PM +0800, Jingjing Wu wrote: > NSH packet can be recognized by Intel X710/XL710 series. This > patch set enables it. > > Jingjing Wu (2): > mbuf: new NSH packet type > i40e: NSH packet type support > > app/test-pmd/rxonly.c | 3 +++ >

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

The patches will work on below patch series. - [PATCH v5 0/8] virtio support for container It seems his implementation will be changed a bit. So, this patch series are also going to be changed to follow his implementation. [Changes] v5 changes: - Rebase on latest dpdk-next-virtio. - Follow

[dpdk-dev] [PATCH v5 1/6] virtio, qtest: Add QTest utility basic functions

The patch adds basic functions for accessing to QEMU quest that runs in QTest mode. The functions will be used by virtio container extension that can access to the above guest. Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp| 2 + drivers/net/virtio/Makefile

[dpdk-dev] [PATCH v5 2/6] virtio, qtest: Add pci device initialization function to qtest utils

The patch adds general pci device initialization functionality to qtest utils. It initializes pci devices using qtest messaging. Signed-off-by: Tetsuya Mukawa --- drivers/net/virtio/virtio_qtest/qtest_utils.c | 349 +- drivers/net/virtio/virtio_qtest/qtest_utils.h | 114

[dpdk-dev] [PATCH v5 3/6] virtio, qtest: Add functionality to share memory between QTest guest

The patch adds functionality to share memory between QTest guest and DPDK application using ivshmem device. The shared memory will be all EAL memory on hugepages. This memory will be accessed by QEMU vcpu and DPDK application using same address. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v5 4/6] virtio, qtest: Add misc functions to handle pci information

The patch adds below functions. - qtest_read_pci_cfg - qtest_get_bar_addr - qtest_get_bar_size These are used for handling pci device information. It will be called by later patches. Signed-off-by: Tetsuya Mukawa --- drivers/net/virtio/virtio_qtest/qtest_utils.c | 77

[dpdk-dev] [PATCH v5 5/6] virtio: Add QTest support to vtpci abstraction

The patch adds QTest support to vtpci abstraction. With this patch, only modern virtio device will be supported. This implementation will be used by later QTest extension patch of virtio-net PMD. Signed-off-by: Tetsuya Mukawa --- drivers/net/virtio/Makefile| 1 +

[dpdk-dev] [PATCH v5 6/6] virtio: Add QTest support for virtio-net PMD

The patch adds a new virtio-net PMD configuration that allows the PMD to work on host as if the PMD is in VM. Here is new configuration for virtio-net PMD. - CONFIG_RTE_VIRTIO_QTEST To use this mode, EAL needs map all hugepages as one file. Also the file should be mapped between (1 << 31) and (1

[dpdk-dev] [PATCH v1 0/2] Supplement patches for virtio-qtest to support LSC interrupt

This is patches to support LSC interrupt handling for virtio-qtest. This patches should be on below patches. - [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container To support LSC interrupts, vtpci abstraction was expanded to handle interrupt from pci devices. Actually, this PMD is

[dpdk-dev] [PATCH v1 1/2] virtio: Handle interrupt things under vtpci abstraction

So far, interrupts from PCI devices are handled in virtio_ethdev directly. The patch changes it, and try to handle it under vtpci abstraction. The patch is needed because virtio-qtest needs to handle interrupts from virtual pci devices. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v1 2/2] virtio, qtest: Add functionality to handle interrupt

The patch adds functionality to handle interrupt from pci device of QEMU guest. To handle the interrupts, the patch adds to initialize piix3 pci device. Signed-off-by: Tetsuya Mukawa --- drivers/net/virtio/virtio_ethdev.c | 7 +- drivers/net/virtio/virtio_qtest/qtest.h

[dpdk-dev] [PATCH v2 1/2] ixgbe: VF supports mailbox interruption for PF link up/down

> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, June 01, 2016 9:53 AM > To: dev at dpdk.org > Cc: Wu, Jingjing; Lu, Wenzhuo > Subject: [PATCH v2 1/2] ixgbe: VF supports mailbox interruption for PF link > up/down > > In this scenario, kernel PF + DPDK VF, when PF finds the

[dpdk-dev] [PATCH] i40e: fix flexible payload selection

On Thu, May 12, 2016 at 04:11:40PM +0800, Jingjing Wu wrote: > When setting up flexible payload selection rules, it is allowed > that setting value to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF). > However, MK_FLX_PIT macro is always adding an offset value 50 >

[dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue

On 6/1/2016 3:13 PM, Yuanhan Liu wrote: > On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote: >> We keep a common vq structure, containing only vq related fields, >> and then split others into RX, TX and control queue respectively. >> >> Signed-off-by: Huawei Xie >> --- >> v2: >> - don't

[dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue

On Thu, Jun 02, 2016 at 06:38:49AM +, Xie, Huawei wrote: > On 6/1/2016 3:13 PM, Yuanhan Liu wrote: > > On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote: > >> We keep a common vq structure, containing only vq related fields, > >> and then split others into RX, TX and control queue

[dpdk-dev] [PATCH] e1000: configure VLAN TPID

Hi Beilei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, April 21, 2016 4:56 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Xing, Beilei > Subject: [dpdk-dev] [PATCH] e1000: configure VLAN TPID > > This patch enables

[dpdk-dev] [PATCH] ivshmem: add all memzones of mempool to metada

Hi Ferruh, Thank you for fixing this issue. On 06/01/2016 03:18 PM, Ferruh Yigit wrote: > [PATCH] ivshmem: add all memzones of mempool to metada Minor comment: it seems the title is truncated > +static int > +add_mempool_to_metadata(const struct rte_mempool *mp, > + struct

[dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods

Hi Jianbo, On 06/01/2016 05:29 AM, Jianbo Liu wrote: >> enum rte_mbuf_prefetch_type { >> > PREFETCH0, >> > PREFETCH1, >> > ... >> > }; >> > >> > static inline void >> > rte_mbuf_prefetch_part1(enum rte_mbuf_prefetch_type type, >> > struct rte_mbuf *m) >> > { >> >

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

On Thu, Jun 02, 2016 at 12:29:39PM +0900, Tetsuya Mukawa wrote: > The patches will work on below patch series. > - [PATCH v5 0/8] virtio support for container > > It seems his implementation will be changed a bit. > So, this patch series are also going to be changed to follow his >

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

Hi Jerin, On 06/01/2016 09:00 AM, Jerin Jacob wrote: > On Tue, May 31, 2016 at 11:05:30PM +0200, Olivier MATZ wrote: >> Today, the objects pointers are reversed only in the get(). It means >> that this code: >> >> rte_mempool_get_bulk(mp, table, 4); >> for (i = 0; i < 4; i++) >>

[dpdk-dev] about rx checksum flags

Hi Olivier, Thank you for working on this.. A comment on the proposal is given below, Regards _Sugesh > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Wednesday, June 1, 2016 10:07 AM > To: Stephen Hemminger ; Olivier MATZ >

[dpdk-dev] [RFC] Yet another option for DPDK options

On Wed, Jun 01, 2016 at 03:00:11PM +, Wiles, Keith wrote: > I have been looking at a number of different options here and the direction I > was thinking was using a file for the options and configurations with the > data in a clean format. It should be helpful and handy for productive

[dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue

We keep a common vq structure, containing only vq related fields, and then split others into RX, TX and control queue respectively. Signed-off-by: Huawei Xie --- v2: - don't split virtio_dev_rx/tx_queue_setup v3: - fix some 80 char warnings - fix other newer version checkpatch warnings - remove

[dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue

On 6/2/2016 4:07 PM, Xie, Huawei wrote: > We keep a common vq structure, containing only vq related fields, > and then split others into RX, TX and control queue respectively. > > Signed-off-by: Huawei Xie sorry, this is v4.

[dpdk-dev] [PATCH v2] qat: fix phys address of content descriptor

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, June 1, 2016 11:52 AM > To: dev at dpdk.org > Cc: Trahe, Fiona ; Griffin, John > ; Jain, Deepak K ; > olivier.matz at 6wind.com; thomas.monjalon at 6wind.com; Kusztal, ArkadiuszX > > Subject: [PATCH v2] qat: fix phys

[dpdk-dev] [PATCH] virtio: use volatile to get used->idx in the loop

On 6/1/2016 2:03 PM, Yuanhan Liu wrote: > On Wed, Jun 01, 2016 at 05:40:08AM +, Xie, Huawei wrote: >> On 5/30/2016 4:20 PM, Yuanhan Liu wrote: >>> On Wed, May 25, 2016 at 12:16:41AM +0800, Huawei Xie wrote: There is no external function call or any barrier in the loop, the used->idx

[dpdk-dev] [PATCH] virtio: use volatile to get used->idx in the loop

On 6/2/2016 4:52 PM, Yuanhan Liu wrote: > On Thu, Jun 02, 2016 at 08:39:36AM +, Xie, Huawei wrote: >> On 6/1/2016 2:03 PM, Yuanhan Liu wrote: >>> On Wed, Jun 01, 2016 at 05:40:08AM +, Xie, Huawei wrote: On 5/30/2016 4:20 PM, Yuanhan Liu wrote: > On Wed, May 25, 2016 at 12:16:41AM

[dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods

On 1 June 2016 at 14:00, Jerin Jacob wrote: > On Wed, Jun 01, 2016 at 11:29:47AM +0800, Jianbo Liu wrote: >> On 1 June 2016 at 03:28, Olivier MATZ wrote: >> > Hi Jianbo, >> > >> > On 05/31/2016 05:06 AM, Jianbo Liu wrote: >> >> Change the inline function to macro with parameters >> >> >> >>

[dpdk-dev] [PATCH v6 1/5] mempool: support external handler

On 6/1/2016 6:54 PM, Jan Viktorin wrote: > Hello David, > > the rename s/handler/ops/ has a lot of residues. Sorry for that :). I tried to > mark most of them. Otherwise, I couldn't see many more serious issues for now. Ah, I had assumed that we were just talking about the

[dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods

On 2 June 2016 at 15:10, Olivier MATZ wrote: > Hi Jianbo, > > On 06/01/2016 05:29 AM, Jianbo Liu wrote: >>> enum rte_mbuf_prefetch_type { >>> > PREFETCH0, >>> > PREFETCH1, >>> > ... >>> > }; >>> > >>> > static inline void >>> > rte_mbuf_prefetch_part1(enum rte_mbuf_prefetch_type

[dpdk-dev] [PATCH] scripts: check commits with checkpatch

The new option -n allows to give a number of commits to check from the git HEAD. If neither -n nor patch files are given, the commits after origin/master are checked. Signed-off-by: Thomas Monjalon --- scripts/checkpatches.sh | 45 - 1 file changed,

[dpdk-dev] [RFC] Yet another option for DPDK options

On 1 June 2016 at 20:51, Thomas Monjalon wrote: > Hi Keith, > > I'll try to bring more context to this discussion below. > > 2016-06-01 15:00, Wiles, Keith: > > Started from the link below, but did not want to highjack the thread. > > http://dpdk.org/ml/archives/dev/2016-June/040021.html > > > >

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

Hi Yuanhan, On 2016/06/02 16:31, Yuanhan Liu wrote: > But still, I'd ask do we really need 2 virtio for container solutions? I appreciate your comments. Let me have time to discuss it with our team. Thanks, Tetsuya

[dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods

On Thu, Jun 02, 2016 at 05:04:13PM +0800, Jianbo Liu wrote: > On 1 June 2016 at 14:00, Jerin Jacob > wrote: > > On Wed, Jun 01, 2016 at 11:29:47AM +0800, Jianbo Liu wrote: > >> On 1 June 2016 at 03:28, Olivier MATZ wrote: > >> > Hi Jianbo, > >> > > >> > On 05/31/2016 05:06 AM, Jianbo Liu wrote:

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

On Thu, Jun 02, 2016 at 09:36:34AM +0200, Olivier MATZ wrote: > Hi Jerin, > > On 06/01/2016 09:00 AM, Jerin Jacob wrote: > > On Tue, May 31, 2016 at 11:05:30PM +0200, Olivier MATZ wrote: > >> Today, the objects pointers are reversed only in the get(). It means > >> that this code: > >> > >>

[dpdk-dev] [PATCH v6 0/7] virtio support for container

v6: - Move driver related code into from driver/net/virtio/virtio-user/ to driver/net/virtio/ directory, inside virtio_user_ethdev.c. - Rename vdev to virtio_user in comments and code. - Merge code, which lies in virtio_user_pci.c, into virtio_user_ethdev.c. - Add some comments at

[dpdk-dev] [PATCH v6 1/7] virtio: hide phys addr check inside pci ops

This patch is to move phys addr check from virtio_dev_queue_setup to pci ops. To makt that happen, make sure virtio_ops.setup_queue return the result if we pass through the check. Signed-off-by: Jianfeng Tan Signed-off-by: Huawei Xie Acked-by: Yuanhan Liu ---

[dpdk-dev] [PATCH v6 2/7] virtio: clean up virtio_dev_queue_setup

Abstract vring hdr desc init as an inline method. Signed-off-by: Huawei Xie Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 42 ++ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v6 3/7] virtio: enable use virtual address to fill desc

This patch is related to how to calculate relative address for vhost backend. The principle is that: based on one or multiple shared memory regions, vhost maintains a reference system with the frontend start address, backend start address, and length for each segment, so that each frontend

[dpdk-dev] [PATCH v6 4/7] virtio-user: add vhost adapter layer

This patch is to provide vhost adapter layer implementations. Instead of relying on a hypervisor to translate between device emulation and vhost backend, here we directly talk with vhost backend through the vhost file. Depending on the type of vhost file, - vhost-user is used if the given path

[dpdk-dev] [PATCH v6 6/7] virtio-user: add new virtual pci driver for virtio

This patch implements another new instance of struct virtio_pci_ops to drive the virtio-user virtual device. Instead of rd/wr ioport or PCI configuration space, this virtual pci driver will rd/wr the virtual device struct virtio_user_hw, and when necessary, invokes APIs provided by device

[dpdk-dev] [PATCH v6 7/7] virtio-user: add a new vdev named virtio-user

Add a new virtual device named vhost-user, which can be used just like eth_ring, eth_null, etc. To reuse the code of original virtio, we do some adjustment in virtio_ethdev.c, such as remove key _static_ of eth_virtio_dev_init() so that it can be reused in virtual device; and we add some check to

[dpdk-dev] [PATCH] librte_sched: fix compile error on unused parameter red

This commit fixes the following compile error messages when CONFIG_RTE_SCHED_RED=n and CONFIG_RTE_SCHED_COLLECT_STATS=y; rte_sched.c: In function ?rte_sched_port_update_subport_stats_on_drop?: rte_sched.c:1090:41: error: unused parameter ?red? [-Werror=unused-parameter] struct

[dpdk-dev] [RFC] Yet another option for DPDK options

On Wed, Jun 01, 2016 at 03:00:11PM +, Wiles, Keith wrote: > Started from the link below, but did not want to highjack the thread. > http://dpdk.org/ml/archives/dev/2016-June/040021.html > > I was thinking about this problem from a user perspective and command line > options are very

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

Hi, Rich. Thank you for testing and analysing. On 01.06.2016 01:06, Rich Lane wrote: > On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets > wrote: > > In current implementation guest application can reinitialize vrings > by executing start after stop. In

[dpdk-dev] [PATCH v6 1/5] mempool: support external handler

On 6/1/2016 6:54 PM, Jan Viktorin wrote: > > mp->populated_size--; > @@ -383,13 +349,16 @@ rte_mempool_populate_phys(struct rte_mempool *mp, char > *vaddr, > unsigned i = 0; > size_t off; > struct rte_mempool_memhdr *memhdr; > - int ret; > > /*

[dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet capturing

> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, May 31, 2016 6:21 PM > To: Pattan, Reshma ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet > capturing > > > > > -Original Message- > > From: Pattan, Reshma > >

[dpdk-dev] [PATCH] scripts: check commits with checkpatch

On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote: > The new option -n allows to give a number of commits to check > from the git HEAD. > If neither -n nor patch files are given, the commits after > origin/master are checked. > Yep, I love it, exactly what I wanted to replace my

[dpdk-dev] [PATCH] scripts: check commits with checkpatch

2016-06-02 13:33, Bruce Richardson: > Testing this out here, I find that git format-patch includes the diff stats > in the output, which then can trigger long-line warnings for the commit > message. > > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description > (prefer a

[dpdk-dev] [RFC] Yet another option for DPDK options

2016-06-02 06:41, Neil Horman: > I'm not sure why you're focusing no selecting a config file format at all. > Why > not just focus on removing the argument parsing from the core rte_eal_init > code, > instead passing in a configuration struct that is stored and queried per > application. Leave

[dpdk-dev] [PATCH v7 1/5] mempool: support external mempool operations

Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_handler() right after

[dpdk-dev] [PATCH v7 2/5] mempool: remove rte_ring from rte_mempool struct

Now that we're moving to an external mempoool handler, which uses a void *pool_data as a pointer to the pool data, remove the unneeded ring pointer from the mempool struct. Signed-off-by: David Hunt --- app/test/test_mempool_perf.c | 1 - lib/librte_mempool/rte_mempool.h | 1 - 2 files

[dpdk-dev] [PATCH v7 3/5] mempool: add default external mempool ops

The first patch in this series added the framework for an external mempool manager. This patch in the series adds a set of default ops (functioni callbacks) based on rte_ring. Signed-off-by: Olivier Matz Signed-off-by: David Hunt --- lib/librte_mempool/Makefile | 1 +

[dpdk-dev] [PATCH v7 4/5] app/test: test external mempool manager

Use a minimal custom mempool external ops and check that it also passes basic mempool autotests. Signed-off-by: Olivier Matz Signed-off-by: David Hunt --- app/test/test_mempool.c | 114 1 file changed, 114 insertions(+) diff --git

[dpdk-dev] [PATCH v7 5/5] mbuf: allow apps to change default mempool ops

By default, the mempool ops used for mbuf allocations is a multi producer and multi consumer ring. We could imagine a target (maybe some network processors?) that provides an hardware-assisted pool mechanism. In this case, the default configuration for this architecture would contain a different

[dpdk-dev] [PATCH] scripts: check commits with checkpatch

On Thu, Jun 02, 2016 at 03:15:54PM +0200, Thomas Monjalon wrote: > 2016-06-02 13:33, Bruce Richardson: > > Testing this out here, I find that git format-patch includes the diff stats > > in the output, which then can trigger long-line warnings for the commit > > message. > > > >

[dpdk-dev] [PATCH v7 0/5] mempool: add external mempool manager

Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 19/5/2016, including Olivier's 35-part patch series on mempool re-org [1] [1] http://dpdk.org/ml/archives/dev/2016-May/039229.html v7 changes: * Changed rte_mempool_handler_table

[dpdk-dev] [PATCH v6 1/5] mempool: support external handler

On Thu, 2 Jun 2016 12:23:41 +0100 "Hunt, David" wrote: > On 6/1/2016 6:54 PM, Jan Viktorin wrote: > > > > mp->populated_size--; > > @@ -383,13 +349,16 @@ rte_mempool_populate_phys(struct rte_mempool *mp, > > char *vaddr, > > unsigned i = 0; > > size_t off; > > struct

[dpdk-dev] [PATCH v7 0/5] mempool: add external mempool manager

Since the cover letter seems to have gone missing, sending it again: Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 19/5/2016, including Olivier's 35-part patch series on mempool re-org [1] [1]

[dpdk-dev] [RFC] Yet another option for DPDK options

On 6/2/16, 8:19 AM, "Thomas Monjalon" wrote: >2016-06-02 06:41, Neil Horman: >> I'm not sure why you're focusing no selecting a config file format at all. >> Why The reason is I am on now looking at formats is because I have been thinking about this issue for some time and already

[dpdk-dev] [PATCH v2 0/3] Keep-alive enhancements

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Wednesday, May 18, 2016 10:30 AM > To: dev at dpdk.org; Mcnamara, John > Subject: [dpdk-dev] [PATCH v2 0/3] Keep-alive enhancements > > This patchset adds enhancements to the keepalive core monitoring > and reporting

[dpdk-dev] [PATCH] crypto: fix null pointer dereferencing

Hi Deepak, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Deepak Kumar Jain > Sent: Monday, May 23, 2016 4:47 PM > To: Doherty, Declan > Cc: Jain, Deepak K; dev at dpdk.org > Subject: [dpdk-dev] [PATCH] crypto: fix null pointer dereferencing > > From:

[dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet capturing

> -Original Message- > From: Pattan, Reshma > Sent: Thursday, June 02, 2016 1:32 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 6/9] app/pdump: add pdump tool for packet > capturing > > > > > -Original Message- > > From: Ananyev, Konstantin

[dpdk-dev] [PATCH] app/testpmd: log mbuf pool creation

> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, May 30, 2016 1:04 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: log mbuf pool creation > > Enhance the logs related to mbuf pool creation. Display an info

[dpdk-dev] [PATCH 0/5] cxgbe: add features to CXGBE PMD

On Fri, May 06, 2016 at 01:13:14PM +0530, Rahul Lakkireddy wrote: > This patch series add some features to CXGBE PMD. > > Patch 1 fixes a bug where reading/writing PCI config space in BSD fails > with EPERM due to missing write permission when opening /dev/pci/. > > Patch 2 adds support to

[dpdk-dev] [PATCH] ixgbe: fix unused value

An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. In reassemble_packets: A value assigned to a variable is never used. Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx")

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

On Thu, Jun 2, 2016 at 3:46 AM, Ilya Maximets wrote: > Hi, Rich. > Thank you for testing and analysing. > > On 01.06.2016 01:06, Rich Lane wrote: > > On Fri, May 20, 2016 at 5:50 AM, Ilya Maximets > wrote: > > > > In current implementation guest application

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 01:53:32PM +, Wiles, Keith wrote: > > On 6/2/16, 8:19 AM, "Thomas Monjalon" wrote: > > >2016-06-02 06:41, Neil Horman: > >> I'm not sure why you're focusing no selecting a config file format at all. > >> Why > > The reason is I am on now looking at formats is

[dpdk-dev] [RFC] Yet another option for DPDK options

On 6/2/16, 12:11 PM, "Neil Horman" wrote: >On Thu, Jun 02, 2016 at 01:53:32PM +, Wiles, Keith wrote: >> >> On 6/2/16, 8:19 AM, "Thomas Monjalon" wrote: >> >> >2016-06-02 06:41, Neil Horman: >> >> I'm not sure why you're focusing no selecting a config file format at >> >> all. Why >> >>

[dpdk-dev] [RFC] Yet another option for DPDK options

On 6/2/16, 12:11 PM, "Neil Horman" wrote: > >1) The definition of a config structure that can be passed to rte_eal_init, >defining the configuration for that running process Having a configuration structure means we have to have an ABI change to that structure anytime we add or remove an

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 07:41:10PM +, Wiles, Keith wrote: > > On 6/2/16, 12:11 PM, "Neil Horman" wrote: > > > > >1) The definition of a config structure that can be passed to rte_eal_init, > >defining the configuration for that running process > > Having a configuration structure means we

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 07:41:10PM +, Wiles, Keith wrote: > Would this work better in the long run, does a fixed structure still make > sense? This right here is why I suggested libjson-c as an example. It has a nice API like this already:

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote: > struct key_vals { > char *key; > union { > ulong longval; > void *ptrval; > } value; > }; > > struct config { > size_t count; > struct key_vals kvp[0]; > }; This sort of code

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 01:53:55PM -0700, Matthew Hall wrote: > On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote: > > struct key_vals { > > char *key; > > union { > > ulong longval; > > void *ptrval; > > } value; > > }; > > > > struct config { > >

[dpdk-dev] [PATCH v3 00/13] enic counter fixes and Tx optimization

The first 3 patches are related to drop counters. The remaining patches make up refactoring, cleanup bug fixes and optimization of the Tx path. Changes since v2 are: - Piotr Azarewicz's ol_flags patch http://www.dpdk.org/dev/patchwork/patch/12642 - fix Tx IP and UDP/TCP checksum offload John

[dpdk-dev] [PATCH v3 01/13] enic: fix Rx drop counters

rx_no_bufs is a hardware counter of packets dropped on the interface due to no host buffers and should be used to update r_stats->imissed counter instead of rx_nombuf. Include rx_drop in ierrors. rx_drop is incremented if packets arrive when the receive queue is disabled. Add a structure and

[dpdk-dev] [PATCH v3 02/13] enic: drop bad packets and remove unused Rx error flag

Following the discussions from: http://dpdk.org/ml/archives/dev/2015-July/021721.html http://dpdk.org/ml/archives/dev/2016-April/038143.html Remove the unused flag from enic driver. Also, the enic driver is modified to drop bad packets. Signed-off-by: Olivier Matz Signed-off-by: John Daley ---

[dpdk-dev] [PATCH v3 03/13] enic: count truncated packets

Truncated packets occur on enic if an mbuf is not big enough to receive it or there aren't enough mbufs if rx scatter is in use. They show up as error packets but unlike other error packets (like packets bad FCS) there are no nic drop counts incremented for them. Truncated packets are calculated

[dpdk-dev] [PATCH v3 04/13] enic: put Tx and Rx functions into same file

Signed-off-by: John Daley --- drivers/net/enic/Makefile | 2 +- drivers/net/enic/enic.h| 3 + drivers/net/enic/enic_ethdev.c | 65 -- drivers/net/enic/enic_main.c | 82 +-- drivers/net/enic/enic_rx.c | 343 -

[dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors

The NIC can either DMA a separate completion message for each completed send or periodically just DMA an index of the last completed send. Switch to the second method which improves cache locality and performance. Signed-off-by: John Daley --- drivers/net/enic/base/vnic_wq.c | 1 +

[dpdk-dev] [PATCH v3 06/13] enic: streamline mbuf handling in Tx path

The list of mbufs held by the driver on Tx was allocated in chunks (a hold-over from the enic kernel mode driver). The structure used next pointers across chunks which led to cache misses. Allocate the array used to hold mbufs in flight on Tx with rte_zmalloc_socket(). Remove unnecessary fields

[dpdk-dev] [PATCH v3 08/13] enic: refactor Tx mbuf recycling

Mbufs were returned to the pool one at a time. Use rte_mempool_put_bulk instead. There were muiltiple function calls for each buffer returned. Refactor this code into just 2 functions. Signed-off-by: John Daley --- drivers/net/enic/base/vnic_wq.h | 27 -

[dpdk-dev] [PATCH v3 09/13] enic: optimize the Tx function

Reduce host CPU overhead of Tx packet processing: * Use local variables inside per packet loop instead of fields in structs. * Factor book keeping and conditionals out of the per packet loop where possible. * Post buffers to the nic at a maximum of every 64 packets Signed-off-by: Nelson Escobar

[dpdk-dev] [PATCH v3 10/13] enic: remove unused files and functions and variables

Remove some files, functions and variables left unused after Tx performance improvements. Signed-off-by: John Daley --- drivers/net/enic/base/enic_vnic_wq.h | 63 drivers/net/enic/base/vnic_cq.h | 44 -

[dpdk-dev] [PATCH v3 11/13] enic: add an enic assert macro

Add an ASSERT macro for the enic driver which is enabled when the log level is >= RTE_LOG_DEBUG. Assert that number of mbufs to return to the pool in the Tx function is never greater than the max allowed. Signed-off-by: John Daley --- drivers/net/enic/enic.h | 12

[dpdk-dev] [PATCH v3 12/13] enic: expand local Tx mbuf flags variable to 64-bits

The offload flags variable (ol_flags) in rte_mbuf structure is 64-bits, so local copy of it must be 64-bits too. Moreover bit comparison between 16-bits variable and 64-bits value make no sense. This breaks Tx vlan IP and L4 offloads. CID 13218 : Operands don't affect result

[dpdk-dev] [PATCH v3 13/13] enic: fix Tx IP and UDP/TCP checksum offload

Private/confilicting ol_flags where used to enable UDP/TCP Tx offloads. Use the common flags in PKT_TX_L4_MASK to support them. Also, do some minor code rearranging for slightly better performane. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- drivers/net/enic/enic.h

[dpdk-dev] [RFC] Yet another option for DPDK options

On Thu, Jun 02, 2016 at 06:34:58PM -0400, Neil Horman wrote: > > This sort of code is very 1970s / ioctl / messy binary. And doesn't buy any > > performance advantage because it's just for config. > > > What!? I can't even parse that sentence. I would not want to have to use the structure you