[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

Looking a bit more into librte_ivshmem, the documentation says we need a Qemu patch but the URL doesn't exist anymore: https://01.org/packet-processing/intel%C2%AE-ovdk -> 404 Oops, we couldn't find that page I've never understood why we should keep this wart and now I'm going to

[dpdk-dev] [PATCH v3] log: deprecate history dump

The log history uses rte_mempool. In order to remove the mempool dependency in EAL (and improve the build), this feature is deprecated. The ABI is kept but the behaviour is now voided because it seems this function was not used. The history can be read from syslog. Signed-off-by: Thomas Monjalon

[dpdk-dev] [PATCH v2] eal: remove useless includes of mempool and ring

The libraries rte_mempool and rte_ring are not used in EAL, except for the ivshmem part (CONFIG_RTE_LIBRTE_IVSHMEM). Signed-off-by: Thomas Monjalon --- This patch must be applied on top of "log: deprecate history dump". v2: clean up also EAL and ivshmem Makefiles ---

[dpdk-dev] [PATCH] port: add kni interface support

Hi Ethan, Great work! There are still several comments below that need to be addressed, but I am confident we can close on them quickly. Thank you! Please rebase the next version on top of the latest code on master branch. Please also update librte_port/rte_port_version.map file. >

[dpdk-dev] packet counting of vhost PMD

Hi Yuanhan, Can I get your opnion about packet counting of vhost PMD? So far, we may not be able to send all packets at once, the number of failed packets are counted, and when stats_get() is called, the number of the packet is filled like below. stats->imissed = tx_missed_total; I

[dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation

Signed-off-by: Simon Kagstrom --- I'm a total newbie to the rte_sched design and implementation, so I've added the RFC. We get crashes (at other places in the scheduler) without this code. lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi, On 06/09/2016 03:09 PM, Jan Viktorin wrote: >>> My suggestion is to have an additional flag, >>> 'MEMPOOL_F_PKT_ALLOC', which, if specified, would: >>> >>> ... #define MEMPOOL_F_SC_GET0x0008 #define >>> MEMPOOL_F_PKT_ALLOC 0x0010 ... >>> >>> in rte_mempool_create_empty: ... after

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

On Fri, 10 Jun 2016 09:29:44 +0200 Olivier Matz wrote: > Hi, > > On 06/09/2016 03:09 PM, Jan Viktorin wrote: > >>> My suggestion is to have an additional flag, > >>> 'MEMPOOL_F_PKT_ALLOC', which, if specified, would: > >>> > >>> ... #define MEMPOOL_F_SC_GET0x0008 #define > >>>

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

2016-05-27 17:48, Ferruh Yigit: > --whole-archive argument only required for pmd libraries, and currently > it covers more libraries. Reducing scope of the argument to pmd > libraries slightly reduce final application size. In my understanding, --whole-archive is required for static libraries

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

Hi Thomas, Just a few notes: > 3/ The automatic mapped allocation of DPDK objects in the guest. > It should not be done in EAL. > An ivshmem driver would be called by rte_eal_dev_init. > It would check where are the shared DPDK structures, as currently done with > the IVSHMEM_MAGIC (0x0BADC0DE),

[dpdk-dev] [PATCH v3 1/2] enic: fix seg fault when releasing queues

On Thu, Jun 09, 2016 at 11:56:08AM -0700, John Daley wrote: > If device configuration failed due to a lack of resources, such as > if more queues are requested than are available, the queue release > function is called with NULL pointers which were being dereferenced. > > Skip releasing queues if

[dpdk-dev] [PATCH v2 4/8] app/testpmd: reconfigure forwarding after changing portlist

Hi Pablo, > > Subject: [PATCH v2 4/8] app/testpmd: reconfigure forwarding after > > changing portlist > > > > Set nb_fwd_ports to zero on quit. > > Check portlist has been set before displaying forwarding configuration. > > > > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > >

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

2016-06-10 09:05, Burakov, Anatoly: > Hi Thomas, > > Just a few notes: > > > 3/ The automatic mapped allocation of DPDK objects in the guest. > > It should not be done in EAL. > > An ivshmem driver would be called by rte_eal_dev_init. > > It would check where are the shared DPDK structures, as

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi all, On 10/6/2016 8:29 AM, Olivier Matz wrote: > Hi, > > On 06/09/2016 03:09 PM, Jan Viktorin wrote: My suggestion is to have an additional flag, 'MEMPOOL_F_PKT_ALLOC', which, if specified, would: ... #define MEMPOOL_F_SC_GET0x0008 #define MEMPOOL_F_PKT_ALLOC

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

> > Hi Thomas, > > > > Just a few notes: > > > > > 3/ The automatic mapped allocation of DPDK objects in the guest. > > > It should not be done in EAL. > > > An ivshmem driver would be called by rte_eal_dev_init. > > > It would check where are the shared DPDK structures, as currently > > > done

[dpdk-dev] [PATCH v3] log: deprecate history dump

On Fri, Jun 10, 2016 at 12:10 AM, Thomas Monjalon wrote: > The log history uses rte_mempool. In order to remove the mempool > dependency in EAL (and improve the build), this feature is deprecated. > The ABI is kept but the behaviour is now voided because it seems this > function was not used. The

[dpdk-dev] [PATCH v3] e1000: fix build with clang

On Thu, May 26, 2016 at 08:36:39PM +0900, Hiroyuki Mikita wrote: > GCC_VERSION is empty in case of clang: > /bin/sh: line 0: test: -ge: unary operator expected > > It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/ > > Fixes: 366113dbfb69 ("e1000: suppress misleading

[dpdk-dev] [PATCH v2] eal: remove useless includes of mempool and ring

On Fri, Jun 10, 2016 at 12:19 AM, Thomas Monjalon wrote: > The libraries rte_mempool and rte_ring are not used in EAL, > except for the ivshmem part (CONFIG_RTE_LIBRTE_IVSHMEM). > > Signed-off-by: Thomas Monjalon Thanks Thomas. Acked-by: David Marchand -- David Marchand

[dpdk-dev] [PATCH v3] e1000: fix build with clang

On Fri, Jun 10, 2016 at 10:50:50AM +0100, Bruce Richardson wrote: > On Thu, May 26, 2016 at 08:36:39PM +0900, Hiroyuki Mikita wrote: > > GCC_VERSION is empty in case of clang: > > /bin/sh: line 0: test: -ge: unary operator expected > > > > It is the same issue as

[dpdk-dev] [PATCH v5 1/5] bnx2x: fixed stats get

On 6/8/2016 5:15 PM, Bruce Richardson wrote: > On Wed, May 11, 2016 at 05:06:21PM -0700, Rasesh Mody wrote: >> Fix stats_get() routine to display drop counters under imissed counter. >> >> Fixes: 540a211084a7 ("bnx2x: driver core") >> >> Signed-off-by: Rasesh Mody >> Signed-off-by: Harish Patil

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

2016-06-10 09:47, Burakov, Anatoly: > > > > The last step of the ivshmem cleanup will be to remove the memory > > > > hack RTE_EAL_SINGLE_FILE_SEGMENTS. Then CONFIG_RTE_LIBRTE_IVSHMEM > > > > could be removed. > > > > > > The reason for that hack is that we often need to map several hugepages, > >

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

2016-06-10 10:57, Ferruh Yigit: > On 6/10/2016 10:03 AM, Thomas Monjalon wrote: > > 2016-05-27 17:48, Ferruh Yigit: > >> --whole-archive argument only required for pmd libraries, and currently > >> it covers more libraries. Reducing scope of the argument to pmd > >> libraries slightly reduce final

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

On 6/10/2016 11:18 AM, Thomas Monjalon wrote: > 2016-06-10 10:57, Ferruh Yigit: >> On 6/10/2016 10:03 AM, Thomas Monjalon wrote: >>> 2016-05-27 17:48, Ferruh Yigit: --whole-archive argument only required for pmd libraries, and currently it covers more libraries. Reducing scope of the

[dpdk-dev] [PATCH v1] hash: add tsx support for cuckoo hash

> -Original Message- > From: Shen, Wei1 > Sent: Monday, May 09, 2016 5:52 PM > To: Stephen Hemminger > Cc: dev at dpdk.org; De Lara Guarch, Pablo; Maciocco, Christian; Gobriel, > Sameh > Subject: Re: [dpdk-dev] [PATCH v1] hash: add tsx support for cuckoo hash > > Hi Stephen, > >

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

On Fri, Jun 10, 2016 at 09:29:44AM +0200, Olivier Matz wrote: > Hi, > > On 06/09/2016 03:09 PM, Jan Viktorin wrote: > >>> My suggestion is to have an additional flag, > >>> 'MEMPOOL_F_PKT_ALLOC', which, if specified, would: > >>> > >>> ... #define MEMPOOL_F_SC_GET0x0008 #define > >>>

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi David, > -Original Message- > From: Hunt, David [mailto:david.hunt at intel.com] > Sent: Friday, June 10, 2016 3:05 PM > To: Olivier Matz ; Jan Viktorin > > Cc: Shreyansh Jain ; dev at dpdk.org; > jerin.jacob at caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] mempool:

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, June 10, 2016 1:00 PM > To: Jan Viktorin ; Hunt, David > > Cc: Shreyansh Jain ; dev at dpdk.org; > jerin.jacob at caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] mempool:

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

Hi Thomas, > 2016-06-10 09:47, Burakov, Anatoly: > > > > > The last step of the ivshmem cleanup will be to remove the > > > > > memory hack RTE_EAL_SINGLE_FILE_SEGMENTS. Then > > > > > CONFIG_RTE_LIBRTE_IVSHMEM could be removed. > > > > > > > > The reason for that hack is that we often need to

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

2016-06-10 12:06, Ferruh Yigit: > On 6/10/2016 11:18 AM, Thomas Monjalon wrote: > > 2016-06-10 10:57, Ferruh Yigit: > >> On 6/10/2016 10:03 AM, Thomas Monjalon wrote: > >>> 2016-05-27 17:48, Ferruh Yigit: > --whole-archive argument only required for pmd libraries, and currently > it

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

2016-06-10 12:08, Burakov, Anatoly: > Hi Thomas, > > > 2016-06-10 09:47, Burakov, Anatoly: > > > > > > The last step of the ivshmem cleanup will be to remove the > > > > > > memory hack RTE_EAL_SINGLE_FILE_SEGMENTS. Then > > > > > > CONFIG_RTE_LIBRTE_IVSHMEM could be removed. > > > > > > > > > >

[dpdk-dev] [PATCH v3] log: deprecate history dump

> > The log history uses rte_mempool. In order to remove the mempool > > dependency in EAL (and improve the build), this feature is deprecated. > > The ABI is kept but the behaviour is now voided because it seems this > > function was not used. The history can be read from syslog. > > > >

[dpdk-dev] [PATCH v2] eal: remove useless includes of mempool and ring

> > The libraries rte_mempool and rte_ring are not used in EAL, > > except for the ivshmem part (CONFIG_RTE_LIBRTE_IVSHMEM). > > > > Signed-off-by: Thomas Monjalon > > Thanks Thomas. > Acked-by: David Marchand Applied

[dpdk-dev] [PATCH v2 0/6] reduce overlinking in applications

This is a respin of the ideas of Christian and Ferruh to limit the static application size or dynamic links to shared libraries. It also brings some clean-up in rte.app.mk. Ferruh Yigit (2): mk: prevent overlinking in applications mk: reduce scope of whole-archive static linking Thomas

[dpdk-dev] [PATCH v2 1/6] mk: sort drivers in static application link list

Just a clean up to prepare next patches. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 45 + 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index b84b56d..07be17c 100644 --- a/mk/rte.app.mk +++

[dpdk-dev] [PATCH v2 2/6] mk: fix driver dependencies order for static application

On a linker command line, the dependencies must be declared after the libraries using them. It will avoid some issues when building an application with static libraries and --as-needed option. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 38 +++--- 1 file

[dpdk-dev] [PATCH v2 3/6] mk: remove library grouping during application linking

>From "man ld": Using this option has a significant performance cost. It is best to use it only when there are unavoidable circular references between two or more archives. Remove the option since it does not seem necessary. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 4 +--- 1

[dpdk-dev] [PATCH v2 4/6] mk: prevent overlinking in applications

From: Ferruh Yigit Replace --no-as-needed linker flag with --as-needed flag, which will only link libraries directly called by application. It can be achieved now that the libraries dependencies are handled properly. Signed-off-by: Ferruh Yigit Signed-off-by: Thomas

[dpdk-dev] [PATCH v2 5/6] mk: sort libraries in level order when linking

As stated in the comment: Order is important: from higher level to lower level This is an attempt to make the layering order better respected. It will help to restrict the --whole-archive scope for plugins. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 54

[dpdk-dev] [PATCH v2 6/6] mk: reduce scope of whole-archive static linking

From: Ferruh Yigit The --whole-archive argument is only required for plugins (drivers) and libraries used by these plugins. Currently it covers all libraries. Reducing the scope of this argument slightly reduce final application size when statically linked.

[dpdk-dev] [PATCH 2/2] mk: reduce scope of whole-archive to pmd libraries

On 6/10/2016 1:21 PM, Thomas Monjalon wrote: > 2016-06-10 12:06, Ferruh Yigit: >> On 6/10/2016 11:18 AM, Thomas Monjalon wrote: >>> 2016-06-10 10:57, Ferruh Yigit: On 6/10/2016 10:03 AM, Thomas Monjalon wrote: > 2016-05-27 17:48, Ferruh Yigit: >> --whole-archive argument only required

[dpdk-dev] [PATCH v2 0/6] bonding: locks

On Thu, May 26, 2016 at 05:38:41PM +0100, Bernard Iremonger wrote: > Add spinlock to bonding rx and tx queues. > Take spinlock in rx and tx burst functions. > Take all spinlocks in slave add and remove functions. > With spinlocks in place remove memcpy of slaves. > > Changes in v2: > Replace

[dpdk-dev] [PATCH v2 2/6] mk: fix driver dependencies order for static application

On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > On a linker command line, the dependencies must be declared after > the libraries using them. > It will avoid some issues when building an application with static > libraries and --as-needed option. > > Signed-off-by: Thomas Monjalon > --- Do we

[dpdk-dev] [PATCH v2 2/6] mk: fix driver dependencies order for static application

2016-06-10 15:49, Ferruh Yigit: > On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > > On a linker command line, the dependencies must be declared after > > the libraries using them. > > It will avoid some issues when building an application with static > > libraries and --as-needed option. > > > >

[dpdk-dev] [PATCH v2 3/6] mk: remove library grouping during application linking

On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > From "man ld": > Using this option has a significant performance cost. > It is best to use it only when there are unavoidable > circular references between two or more archives. > > Remove the option since it does not seem necessary. > >

[dpdk-dev] [PATCH v2 4/6] mk: prevent overlinking in applications

On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > From: Ferruh Yigit > > Replace --no-as-needed linker flag with --as-needed flag, which will > only link libraries directly called by application. > It can be achieved now that the libraries dependencies are handled > properly. > > Signed-off-by:

[dpdk-dev] [PATCH v2 6/6] mk: reduce scope of whole-archive static linking

On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > From: Ferruh Yigit > > The --whole-archive argument is only required for plugins (drivers) > and libraries used by these plugins. > Currently it covers all libraries. > Reducing the scope of this argument slightly reduce final application size >

[dpdk-dev] [PATCH 1/2] mlx: fix compilation with recent Glibc

Various BSD ioctl macros are not exposed anymore when _XOPEN_SOURCE is defined, and linux/if.h now conflicts with net/if.h. Suggested-by: Bruce Richardson Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 7 +++

[dpdk-dev] [PATCH 2/2] mlx: regenerate autoconf file automatically

Mellanox PMDs must be rebuilt if a Verbs update would cause the autoconf file to differ. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 13 +++-- drivers/net/mlx5/Makefile | 13 +++-- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git

[dpdk-dev] [PATCH v2 3/6] mk: remove library grouping during application linking

2016-06-10 15:54, Ferruh Yigit: > On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > > From "man ld": > > Using this option has a significant performance cost. > > It is best to use it only when there are unavoidable > > circular references between two or more archives. > > > > Remove the

[dpdk-dev] [PATCH v2 4/6] mk: prevent overlinking in applications

2016-06-10 15:56, Ferruh Yigit: > On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > > From: Ferruh Yigit > > > > Replace --no-as-needed linker flag with --as-needed flag, which will > > only link libraries directly called by application. > > It can be achieved now that the libraries dependencies

[dpdk-dev] [PATCH v9 0/3] mempool: add external mempool manager

Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 09/6/2016, including Olivier's 35-part patch series on mempool re-org [1] [1] http://dpdk.org/ml/archives/dev/2016-May/039229.html v9 changes: * added a check for NULL alloc in

[dpdk-dev] [PATCH v9 2/3] app/test: test external mempool manager

Use a minimal custom mempool external ops and check that it also passes basic mempool autotests. Signed-off-by: Olivier Matz Signed-off-by: David Hunt --- app/test/test_mempool.c | 115 1 file changed, 115 insertions(+) diff --git

[dpdk-dev] [PATCH v9 3/3] mbuf: make default mempool ops configurable at build

By default, the mempool ops used for mbuf allocations is a multi producer and multi consumer ring. We could imagine a target (maybe some network processors?) that provides an hardware-assisted pool mechanism. In this case, the default configuration for this architecture would contain a different

[dpdk-dev] [PATCH v9 1/3] mempool: support external mempool operations

Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_handler() right after

[dpdk-dev] [PATCH v2 6/6] mk: reduce scope of whole-archive static linking

2016-06-10 16:03, Ferruh Yigit: > On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > > From: Ferruh Yigit > > > > The --whole-archive argument is only required for plugins (drivers) > > and libraries used by these plugins. > > Currently it covers all libraries. > > Reducing the scope of this

[dpdk-dev] [PATCH] mk: Fix cruft getting installed by "make install" with tar >= 1.29

2016-05-23 08:53, Panu Matilainen: > --exclude became a positional option in tar 1.29, breaking the > test app filtering in "make install", causing .map files and all test > apps to get installed in bindir. Adjust the tar arguments accordingly, > this is compatible with older versions too since

[dpdk-dev] [PATCH v4] ip_pipeline: add script file for pipeline to core mappings

From: Guruprasad Mukundarao This script parses the application configuration file and detects all the pipelines specified therein, and then, it generates all the possible mappings of those pipelines on the specified CPU core-list. As a result, each of the possible

[dpdk-dev] [PATCH v2 4/8] app/testpmd: reconfigure forwarding after changing portlist

Hi Pablo, > > > Subject: [PATCH v2 4/8] app/testpmd: reconfigure forwarding after > > > changing portlist > > > > > > Set nb_fwd_ports to zero on quit. > > > Check portlist has been set before displaying forwarding configuration. > > > > > > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and

[dpdk-dev] about rx checksum flags

Regards _Sugesh > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, June 8, 2016 2:02 PM > To: Chandran, Sugesh ; Ananyev, Konstantin > ; Stephen Hemminger > > Cc: Yuanhan Liu ; dev at dpdk.org; Richardson, > Bruce ; Adrien Mazarguil > ; Tan,

[dpdk-dev] [PATCH v8 0/8] add packet capture framework

This patch set include below changes 1)Changes to librte_ether. 2)A new library librte_pdump added for packet capture framework. 3)A new app/pdump tool added for packet capturing. 4)Test pmd changes done to initialize packet capture framework. 5)Documentation update. 1)librte_pdump

[dpdk-dev] [PATCH v8 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks

Added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v8 2/8] librte_ether: add new api rte_eth_add_first_rx_callback

Added new public api rte_eth_add_first_rx_callback to add given callback as head of list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 28 +++

[dpdk-dev] [PATCH v8 7/8] app/test-pmd: add pdump initialization uninitialization

Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..9707cfc 100644 ---

[dpdk-dev] [PATCH v8 8/8] doc: update doc for packet capture framework

Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 +

[dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support

Added new library for packet capturing support. Added public api rte_pdump_init, applications should call this as part of their application setup to have packet capturing framework ready. Added public api rte_pdump_uninit to uninitialize the packet capturing framework. Added public apis

[dpdk-dev] [PATCH v8 3/8] librte_ether: add new fields to rte_eth_dev_info struct

New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v8 6/8] app/pdump: add pdump tool for packet capturing

New tool added for packet capturing on dpdk. This tool supports command line options. This tool runs as secondary process by default. Command line supports various parameters to capture the packets. User should pass on a)port and queue (or) b)pci address and queue (or) c)device name and queue to

[dpdk-dev] [PATCH v2 1/6] bonding: add spinlock to rx and tx queues

> Signed-off-by: Bernard Iremonger > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 > drivers/net/bonding/rte_eth_bond_private.h | 4 +++- > 2 files changed, 7 insertions(+), 1 deletion(-) > Acked-by: Konstantin Ananyev

[dpdk-dev] [PATCH 2/8] lib/librte_ether: defind RX/TX lock mode

On Wed, 8 Jun 2016 07:34:43 + "Lu, Wenzhuo" wrote: > > > > The fact that it requires lots more locking inside each device driver > > implies to me > > this is not correct way to architect this. > It's a good question. This patch set doesn't follow the regular assumption of > DPDK. > But

[dpdk-dev] [PATCH v2 2/6] bonding: grab queue spinlocks in slave add and remove

> > Signed-off-by: Bernard Iremonger > --- Acked-by: Konstantin Ananyev

[dpdk-dev] [PATCH v2 3/6] bonding: take queue spinlock in rx/tx burst functions

> > Signed-off-by: Bernard Iremonger > --- Acked-by: Konstantin Ananyev

[dpdk-dev] [PATCH v2 6/6] bonding: remove memcpy from burst functions

> > Signed-off-by: Bernard Iremonger > --- Acked-by: Konstantin Ananyev

[dpdk-dev] [PATCH v2 0/6] bonding: locks

Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Friday, June 10, 2016 3:46 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org; Doherty, Declan ; Ananyev, > Konstantin > Subject: Re: [dpdk-dev] [PATCH v2 0/6] bonding: locks > > On Thu, May 26, 2016 at 05:38:41PM +0100,

[dpdk-dev] [PATCH v3 0/6] reduce overlinking in applications

This patch set updates application linking, main motivation is to reduce overlinking in application, also removes library grouping by re-ordering libraries and for static compilation reduces whole library linking to PMD libs. There is a workaround because of librte_eal <-> librte_mempool cyclic

[dpdk-dev] [PATCH v3 1/6] mk: sort drivers in static application link list

From: Thomas Monjalon Just a clean up to prepare next patches. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 45 + 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index

[dpdk-dev] [PATCH v3 2/6] mk: fix driver dependencies order for static application

From: Thomas Monjalon On a linker command line, the dependencies must be declared after the libraries using them. It will avoid some issues when building an application with static libraries and --as-needed option. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk |

[dpdk-dev] [PATCH v3 4/6] mk: sort libraries when linking, move external libs to lower level

As stated in the comment: Order is important: from higher level to lower level This is an attempt to make the layering order better respected. Signed-off-by: Thomas Monjalon Signed-off-by: Ferruh Yigit --- mk/rte.app.mk | 30 +++--- 1 file changed, 15

[dpdk-dev] [PATCH v3 5/6] mk: remove library grouping during application linking

From: Thomas Monjalon >From "man ld": Using this option has a significant performance cost. It is best to use it only when there are unavoidable circular references between two or more archives. Remove the option since it does not seem necessary. Signed-off-by:

[dpdk-dev] [PATCH v3 3/6] mk: sort libraries when linking, move pmd libs to higher level

As stated in the comment: Order is important: from higher level to lower level This is an attempt to make the layering order better respected. Limit scope of --whole-archive to pmd libraries Signed-off-by: Thomas Monjalon Signed-off-by: Ferruh Yigit --- mk/rte.app.mk | 88

[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

Replace --no-as-needed linker flag with --as-needed flag, which will only link libraries directly called by application. It can be achieved now that the libraries dependencies are handled properly. Signed-off-by: Ferruh Yigit Signed-off-by: Thomas Monjalon --- mk/exec-env/linuxapp/rte.vars.mk

[dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support

Hi Reshma, Reshma Pattan writes: > Added new library for packet capturing support. > > Added public api rte_pdump_init, applications should call > this as part of their application setup to have packet > capturing framework ready. > > Added public api rte_pdump_uninit to uninitialize the packet

[dpdk-dev] [PATCH v3 1/6] mk: sort drivers in static application link list

On 6/10/16, 1:32 PM, "dev on behalf of Ferruh Yigit" wrote: >From: Thomas Monjalon > >Just a clean up to prepare next patches. One thing you have or will do with these patches is create a set of groups PMD, Core, LIB, ? and sort the items in each group. I was thinking it maybe more useful

[dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors

On Thu, Jun 02, 2016 at 05:22:51PM -0700, John Daley wrote: > The NIC can either DMA a separate completion message for each > completed send or periodically just DMA an index of the last > completed send. Switch to the second method which improves > cache locality and performance. > >

[dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support

Hi, > -Original Message- > From: Aaron Conole [mailto:aconole at redhat.com] > Sent: Friday, June 10, 2016 7:48 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for > packet capturing support > > Hi Reshma, > >

[dpdk-dev] [PATCH] bnx2x: Correctly determine MSIX vector count

From: "Charles (Chas) Williams" If MSIX is available, the vector count given by the table size is one less than the actual count. This count also limits the receive and transmit queue resources the VF can support. Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by:

[dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors

> -Original Message- > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Friday, June 10, 2016 2:18 PM > To: John Daley (johndale) > Cc: dev at dpdk.org; bruce.richarsdon at intel.com > Subject: Re: [dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages >

[dpdk-dev] [PATCH v8 0/8] add packet capture framework

On Fri, Jun 10, 2016 at 05:18:46PM +0100, Reshma Pattan wrote: > This patch set include below changes > > 1)Changes to librte_ether. > 2)A new library librte_pdump added for packet capture framework. > 3)A new app/pdump tool added for packet capturing. > 4)Test pmd changes done to initialize