[dpdk-dev] [PATCH v5 00/25] DPDK PMD for ThunderX NIC device

2016-06-15 Thread Jerin Jacob
This patch set provides the initial version of DPDK PMD for the built-in NIC device in Cavium ThunderX SoC family. Implemented features and ThunderX nicvf PMD documentation added in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst respectively in this patch set. These patches are

[dpdk-dev] [PATCH v5 01/25] net/thunderx/base: add HW constants for ThunderX inbuilt NIC

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_hw_defs.h | 551 ++ 1 file changed, 551

[dpdk-dev] [PATCH v5 02/25] net/thunderx/base: add register definition for ThunderX inbuilt NIC

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_hw_defs.h | 668 ++ 1 file changed, 668

[dpdk-dev] [PATCH v5 03/25] net/thunderx/base: implement DPDK based platform abstraction for base code

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_plat.h | 129 + 1 file changed, 129

[dpdk-dev] [PATCH v5 04/25] net/thunderx/base: add mbox API for ThunderX PF/VF driver communication

2016-06-15 Thread Jerin Jacob
DPDK nicvf driver doesn't have access to NIC's PF address space. Introduce a mailbox mechanism to communicate with PF driver through shared 128bit register interface. Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski ---

[dpdk-dev] [PATCH v5 05/25] net/thunderx/base: add hardware API for ThunderX nicvf inbuilt NIC

2016-06-15 Thread Jerin Jacob
add nicvf hardware specific APIs for initialization and configuration. Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_hw.c

[dpdk-dev] [PATCH v5 06/25] net/thunderx/base: add RSS and reta configuration HW APIs

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_hw.c | 129 +++

[dpdk-dev] [PATCH v5 07/25] net/thunderx/base: add statistics get HW APIs

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/base/nicvf_hw.c | 45

[dpdk-dev] [PATCH v5 08/25] net/thunderx: add pmd skeleton

2016-06-15 Thread Jerin Jacob
Introduce driver initialization and enable build infrastructure for nicvf pmd driver. By default, It is enabled only for defconfig_arm64-thunderx-* config as it is an inbuilt NIC device. Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by:

[dpdk-dev] [PATCH v5 09/25] net/thunderx: add link status and link update support

2016-06-15 Thread Jerin Jacob
Extended the nicvf_interrupt function to respond NIC_MBOX_MSG_BGX_LINK_CHANGE mbox message from PF and update struct rte_eth_link accordingly. Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek

[dpdk-dev] [PATCH v5 10/25] net/thunderx: add registers dump support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 27 +++ 1 file changed, 27 insertions(+) diff

[dpdk-dev] [PATCH v5 11/25] net/thunderx: add ethdev configure support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 78 + 1

[dpdk-dev] [PATCH v5 12/25] net/thunderx: add get device info support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 45 +

[dpdk-dev] [PATCH v5 13/25] net/thunderx: add Rx queue setup and release support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 136

[dpdk-dev] [PATCH v5 14/25] net/thunderx: add Tx queue setup and release support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 175 1 file changed, 175

[dpdk-dev] [PATCH v5 15/25] net/thunderx: add RSS and reta query and update support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 172 1

[dpdk-dev] [PATCH v5 16/25] net/thunderx: add MTU set and promiscuous enable support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 51 +

[dpdk-dev] [PATCH v5 17/25] net/thunderx: add stats support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.c | 66 + 1

[dpdk-dev] [PATCH v5 18/25] net/thunderx: add single and multi segment Tx functions

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/Makefile | 2 + drivers/net/thunderx/nicvf_ethdev.c | 5 +-

[dpdk-dev] [PATCH v5 19/25] net/thunderx: add single and multi segment Rx functions

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki Reviewed-by: Ferruh Yigit --- drivers/net/thunderx/nicvf_ethdev.h | 33 drivers/net/thunderx/nicvf_rxtx.c

[dpdk-dev] [PATCH v5 20/25] net/thunderx: implement supported ptype get and Rx queue count

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 41 +

[dpdk-dev] [PATCH v5 21/25] net/thunderx: add Rx queue start and stop support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 167

[dpdk-dev] [PATCH v5 22/25] net/thunderx: add Tx queue start and stop support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 59 + 1 file changed, 59

[dpdk-dev] [PATCH v5 23/25] net/thunderx: add device start, stop and close support

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj Signed-off-by: Kamil Rytarowski Signed-off-by: Zyta Szpak Signed-off-by: Slawomir Rosek Signed-off-by: Radoslaw Biernacki --- drivers/net/thunderx/nicvf_ethdev.c | 467 1 file changed, 467

[dpdk-dev] [PATCH v5 24/25] net/thunderx: updated driver documentation and release notes

2016-06-15 Thread Jerin Jacob
Updated doc/guides/nics/overview.rst, doc/guides/nics/thunderx.rst and release notes Changed "*" to "P" in overview.rst to capture the partially supported feature as "*" creating alignment issues with Sphinx table Signed-off-by: Jerin Jacob Signed-off-by: Slawomir Rosek Acked-by: John McNamara

[dpdk-dev] [PATCH v5 25/25] maintainers: claim responsibility for the ThunderX nicvf PMD

2016-06-15 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Signed-off-by: Maciej Czekaj --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e8558f..625423f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -336,6 +336,12 @@ M: Sony Chacko F: drivers/net/qede/ F:

[dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver

2016-06-15 Thread Xing, Beilei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 14, 2016 6:55 PM > To: Xing, Beilei ; Lu, Wenzhuo intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver > > On 6/14/2016 11:36 AM, Ferruh Yigit wrote: > > On 6/14/2016

[dpdk-dev] [PATCH v5 1/4] lib/librte_ether: support device reset

2016-06-15 Thread Wenzhuo Lu
Add an API to reset the device. It's for VF device in this scenario, kernel PF + DPDK VF. When the PF port down->up, APP should call this API to reset VF port. Most likely, APP should call it in its management thread and guarantee the thread safe. It means APP should stop the rx/tx and the device,

[dpdk-dev] [PATCH v5 0/4] support reset of VF link

2016-06-15 Thread Wenzhuo Lu
If the PF link is down and up, VF link will not work accordingly. This patch set addes the support of VF link reset. So, when VF receices the messges of physical link down/up. APP can reset the VF link and let it recover. PS: This patch set is splitted from a previous patch set, *automatic link

[dpdk-dev] [PATCH v5 2/4] ixgbe: implement device reset on VF

2016-06-15 Thread Wenzhuo Lu
Implement the device reset function. Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_16_07.rst | 9 + drivers/net/ixgbe/ixgbe_ethdev.c | 64 +- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 12

[dpdk-dev] [PATCH v5 3/4] igb: implement device reset on VF

2016-06-15 Thread Wenzhuo Lu
Implement the device reset function. Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_16_07.rst | 2 +- drivers/net/e1000/igb_ethdev.c | 59 ++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v5 4/4] i40e: implement device reset on VF

2016-06-15 Thread Wenzhuo Lu
Implement the device reset function. This reset function will detach device then attach device, reconfigure dev, re-setup the Rx/Tx queues. Signed-off-by: Zhe Tao --- doc/guides/rel_notes/release_16_07.rst | 4 ++ drivers/net/i40e/i40e_ethdev.h | 4 ++

[dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary()

2016-06-15 Thread Tetsuya Mukawa
If pci_map_resource() succeeds but mapped address is different from an address primary process mapped, this should be error. Then the address secondary process mapped should be freed. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci_uio.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH] eal: Fix wrong error checking of rte_eal_parse_devargs_str()

2016-06-15 Thread Tetsuya Mukawa
Currently, a return value of strdup() isn't checked correctly. The patch fixes it. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCH] eal: Fix wrong resource release of pci_uio_unmap()

2016-06-15 Thread Tetsuya Mukawa
The 'path' member of mapped_pci_resource structure is allocated by primary process, but currenctly it will be freed by both primary and secondary process. The patch fixes to be freed by only primary process. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci_uio.c | 4 +++-

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-15 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:00 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx > callback lists > > 2016-06-14 10:38, Reshma

[dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture framework

2016-06-15 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:41 PM > To: Pattan, Reshma > Cc: dev at dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture > framework > > When

[dpdk-dev] [PATCH v1 07/28] eal/soc: add rte_eal_soc_register/unregister logic

2016-06-15 Thread Shreyansh Jain
Hi Jan, One more comment which I missed in previous reply: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shreyansh Jain > Sent: Monday, June 13, 2016 7:50 PM > To: Jan Viktorin > Cc: David Marchand ; Thomas Monjalon > ; Bruce Richardson intel.com>; >

[dpdk-dev] [PATCH] doc: virtio pmd versions

2016-06-15 Thread Wang, Zhihong
> -Original Message- > From: Mcnamara, John > Sent: Thursday, June 9, 2016 8:56 PM > To: Richardson, Bruce ; Wang, Zhihong > ; dev at dpdk.org > Cc: Wang, Zhihong > Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versions > > > -Original Message- > > From: Richardson, Bruce > >

[dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start

2016-06-15 Thread Wang, Zhihong
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 14, 2016 11:13 PM > To: Wang, Zhihong ; dev at dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; thomas.monjalon at 6wind.com > Subject: RE: [PATCH v2 5/5] testpmd: show topology at forwarding start > > >

[dpdk-dev] [PATCH v12 0/3] mempool: add external mempool manager

2016-06-15 Thread David Hunt
Here's the latest version of the External Mempool Manager patchset. It's re-based on top of the latest head as of 14/6/2016, including Olivier's 35-part patch series on mempool re-org [1] [1] http://dpdk.org/ml/archives/dev/2016-May/039229.html v12 changes: * Fixed a comment (function pram h

[dpdk-dev] [PATCH v12 2/3] app/test: test external mempool manager

2016-06-15 Thread David Hunt
Use a minimal custom mempool external ops and check that it also passes basic mempool autotests. Signed-off-by: Olivier Matz Signed-off-by: David Hunt Acked-by: Shreyansh Jain Acked-by: Olivier Matz --- app/test/test_mempool.c | 122 +++- 1 file

[dpdk-dev] [PATCH v12 3/3] mbuf: make default mempool ops configurable at build

2016-06-15 Thread David Hunt
By default, the mempool ops used for mbuf allocations is a multi producer and multi consumer ring. We could imagine a target (maybe some network processors?) that provides an hardware-assisted pool mechanism. In this case, the default configuration for this architecture would contain a different

[dpdk-dev] [PATCH v12 1/3] mempool: support external mempool operations

2016-06-15 Thread David Hunt
Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_ops_byname() right after

[dpdk-dev] [PATCH v3 00/30]

2016-06-15 Thread Beilei Xing
Update base driver for ixgbe, mainly work on new features and bug fixes. v3 changes: Fix some commit log issues. Beilei Xing (30): ixgbe/base: add new VF requests for mailbox API ixgbe/base: add sgmii link for X550 ixgbe/base: fix problematic return value ixgbe/base: add MAC link setup

[dpdk-dev] [PATCH v3 01/30] ixgbe/base: add new VF requests for mailbox API

2016-06-15 Thread Beilei Xing
It adds two new VF requests of IXGBE_VF_GET_RETA and IXGBE_VF_GET_RSS_KEY for mailbox API. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_mbx.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h

[dpdk-dev] [PATCH v3 02/30] ixgbe/base: add sgmii link for X550

2016-06-15 Thread Beilei Xing
It adds sgmii link for X550. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 9 +++ drivers/net/ixgbe/base/ixgbe_x550.c | 127 +--- 2 files changed, 127 insertions(+), 9 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h

[dpdk-dev] [PATCH v3 03/30] ixgbe/base: fix problematic return value

2016-06-15 Thread Beilei Xing
An error code indicating that the PF rejects the MAC address change should be returned, in case that the PF has already assigned a MAC for the VF. Fixes: af75078fece3 ("first public release") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_vf.c | 4 +++- 1 file changed, 3

[dpdk-dev] [PATCH v3 05/30] ixgbe/base: fix checksum error of checking PHY token

2016-06-15 Thread Beilei Xing
This patch sets the Host Interface PHY token command checksum to the checksum default of 0xFF, therefore the checksum is not checked by the firmware. Otherwise the command fails with a checksum failed error. Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resource sharing on

[dpdk-dev] [PATCH v3 09/30] ixgbe/base: add link MAC setup for X550a SFP+

2016-06-15 Thread Beilei Xing
This patch updates ixgbe_setup_mac_link_sfp_x550a for X550 SFP+. ixgbe_set_lan_id_multi_port_pcie has been updated to set the MAC instance(0/1) which is needed when configuring the external PHY, since X550a has two instances of MGPK. The MAC instance is read from the EEPROM. Signed-off-by: Beilei

[dpdk-dev] [PATCH v3 08/30] ixgbe/base: add KR support for X550em_a devices

2016-06-15 Thread Beilei Xing
Implement KR support for X550em_a devices. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 51 + 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c

[dpdk-dev] [PATCH v3 06/30] ixgbe/base: refactor eee setup for X550

2016-06-15 Thread Beilei Xing
Break ixgbe_setup_eee_X550 down to better handle a change from if statements to switch statements needed to add X550em_a KR support. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 174 ++-- 1 file changed, 105 insertions(+), 69 deletions(-)

[dpdk-dev] [PATCH v3 10/30] ixgbe/base: clear stale pool mappings

2016-06-15 Thread Beilei Xing
This patch adds clearing the pool mappings when configuring default MAC addresses for the interface. Without this there will be the risk of leaking an address into pool 0 which really belongs to VF 0 when SR-IOV is enabled. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_82599.c |

[dpdk-dev] [PATCH v3 11/30] ixgbe/base: rename macro of TDL

2016-06-15 Thread Beilei Xing
This patch renames IXGBE_PVFTTDLEN to IXGBE_PVFTDLEN according to abbreviation of Transmit Descriptor Length in datasheet. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h

[dpdk-dev] [PATCH v3 04/30] ixgbe/base: add MAC link setup for X550a SFP

2016-06-15 Thread Beilei Xing
This patch adds ixgbe_setup_mac_link_sfp_x550a for X550a SFP. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 4 +++ drivers/net/ixgbe/base/ixgbe_x550.c | 64 - drivers/net/ixgbe/base/ixgbe_x550.h | 3 ++ 3 files changed, 70

[dpdk-dev] [PATCH v3 13/30] ixgbe/base: fix for code style

2016-06-15 Thread Beilei Xing
The ixgbe_vf.h file did not use __ and instead used which is not the standard used in every other file. Fixes: af75078fece3 ("first public release") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_vf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v3 14/30] ixgbe/base: fix firmware commands on X550em_a

2016-06-15 Thread Beilei Xing
This patch fixes firmware commands on X550em_a. For one thing, the checksum value was not being set. Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 19 ++- 1 file changed, 10 insertions(+), 9

[dpdk-dev] [PATCH v3 07/30] ixgbe/base: change access method

2016-06-15 Thread Beilei Xing
Use the method pointers instead of direct function calls so that the right thing will happen on X550EM_a. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 84 ++--- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git

[dpdk-dev] [PATCH v3 15/30] ixgbe/base: refactor NW management interface ops

2016-06-15 Thread Beilei Xing
This patch adds ixgbe_read_mng_if_sel_x550em to read NW_MNG_IF_SEL register and save fields such as PHY MDIO_ADD. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ drivers/net/ixgbe/base/ixgbe_x550.c | 48 +++-- 2 files changed, 32

[dpdk-dev] [PATCH v3 16/30] ixgbe/base: add new phy definitions

2016-06-15 Thread Beilei Xing
It adds new phy definitions. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_phy.c | 16 +- drivers/net/ixgbe/base/ixgbe_type.h | 14 +- drivers/net/ixgbe/base/ixgbe_x550.c | 303 ++-- drivers/net/ixgbe/base/ixgbe_x550.h | 43 + 4 files

[dpdk-dev] [PATCH v3 12/30] ixgbe/base: fix error path to release lock

2016-06-15 Thread Beilei Xing
When there is an error getting the PHY token, the error path fails to release the locks that it has taken. Release those locks in that failure case. Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resource sharing on X550em_a") Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v3 18/30] ixgbe/base: add function to reset swfw semaphore

2016-06-15 Thread Beilei Xing
For X540 and forward it is possible if a system reset occur at the right time to leave the SWFW semaphore high. This new function will attempt to grab and release the semaphore. If the grab times out it will still release the semaphore placing it in a known good state. The idea is to call this

[dpdk-dev] [PATCH v3 19/30] ixgbe/base: fix possible race issue

2016-06-15 Thread Beilei Xing
This patch fixes possible race issue between ports when issuing host interface command by acquiring/releasing the management host interface semaphore in ixgbe_host_interface_command. Fixes: 36f43e8679ae ("ixgbe/base: refactor manageability block communication") Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v3 17/30] ixgbe/base: change device IDs

2016-06-15 Thread Beilei Xing
There're two device IDs changed from 15C6/15C7 to 15E4/15E5 cause PHY info changes. Make the change and use 15C6/15C7 for the backplane SGMII. Clean up some discovery kludges from the previous shared ID, and also add 15C6/15C7 to ixgbe_set_mdio_speed just for paranoia to control MDIO speed even

[dpdk-dev] [PATCH v3 20/30] ixgbe/base: fix register access error

2016-06-15 Thread Beilei Xing
This patch corrects the FLA/GSCL/GSCN access offset value according to the datasheet. Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 42 - 1 file changed, 41 insertions(+), 1

[dpdk-dev] [PATCH v3 21/30] ixgbe/base: limit PHY token accessing to MDIO only

2016-06-15 Thread Beilei Xing
This patch limits getting and putting the PHY Token to PHY MDIO access only by adding ixgbe_read_phy_reg_x550a and ixgbe_write_phy_reg_x550a. The PHY Token is only needed to synchronize access to the MDIO shared between the two MAC instance. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v3 22/30] ixgbe/base: simplify add/remove VLANs

2016-06-15 Thread Beilei Xing
This patch simplifies the adding and removing VLANs from VFTA/VLVF/VLVFB registers. The logic to determine registers has been simplified to (vid / 32) and (1 - vid / 32). Many conditional paths and checks are no longer needed with this patch. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v3 23/30] ixgbe/base: add bypassing VLVF

2016-06-15 Thread Beilei Xing
This patch adds support for the VLVF to be bypassed when adding or removing a VFTA entry. The PF can utilize the default pool while preserving the VLVF for the VFs use. Meanwhile, update corresponding VF ops and drivers where corresponding ops is invoked. Signed-off-by: Beilei Xing ---

[dpdk-dev] [PATCH v3 24/30] ixgbe/base: unify coding style

2016-06-15 Thread Beilei Xing
This patch changes static keyword to STATIC definition, which can be redefined depending on the compiler used. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_x550.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[dpdk-dev] [PATCH v3 25/30] ixgbe/base: use u8 to replace u16 for a variable

2016-06-15 Thread Beilei Xing
Since PCIe standard defines maximum of 8 functions per device lan_id is a value 0..7. Because of that, lan_id don't need to be u16. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- drivers/net/ixgbe/base/ixgbe_type.h | 2 +- 2 files changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v3 26/30] ixgbe/base: fix endianness issues

2016-06-15 Thread Beilei Xing
This patch fixes endianness issues about host interface command. Fixes: ad66a85dce9a ("ixgbe/base: new FW values") Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_osdep.h | 1 + drivers/net/ixgbe/base/ixgbe_type.h | 17

[dpdk-dev] [PATCH v3 27/30] ixgbe/base: allow setting MAC anti spoofing per VF

2016-06-15 Thread Beilei Xing
Make ixgbe_set_mac_anti_spoofing() consistent with the other functions that deal with setting VLAN and Ethertype spoofing by changing the prototype to accept a VF parameter. Also change the logic for writing the PFVFSPOOF register to be similar to the MAC and Ethertype functions. Signed-off-by:

[dpdk-dev] [PATCH v3 28/30] ixgbe/base: add flow control autoneg for X550a

2016-06-15 Thread Beilei Xing
This patch adds X550a flow control auto negotiation support. ixgbe_setup_fc_x550a and ixgbe_fc_autoneg_X550a functions where added to setup and enable flow control. MAC ops function pointer fc_autoneg was added so that hardware specific fc autoneg functions can be called from

[dpdk-dev] [PATCH v3 29/30] ixgbe/base: define if enable crosstalk work around

2016-06-15 Thread Beilei Xing
A work around for a new crosstalk erratum that causes link flap in entry cages has been introduced. So this patch defines the bit in NVM that will tell software if this work around is needed. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/base/ixgbe_type.h | 1 + 1 file changed, 1

[dpdk-dev] [PATCH v3 30/30] ixgbe/base: update README

2016-06-15 Thread Beilei Xing
The ixgbe base driver was updated refer to version cid-10g-shared-code.2016.04.12 released by ND. The changes include: Added sgmii link for X550. Added mac link setup for X550a SFP and SFP+. Added KR support for X550em_a. Added new phy definitions for M88E1500. Added support for the VLVF to be

[dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver

2016-06-15 Thread Thomas Monjalon
2016-06-15 02:56, Xing, Beilei: > Can I ignore the two warnings? > > 1) Wrong headline format: > ixgbe/base: fix firmware commands on X550em_a > ixgbe/base: add KR support for X550em_a devices > Seems it's caused by '_' in name ' X550em_a '. You can ignore these warnings. > 2)

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-15 Thread Thomas Monjalon
2016-06-15 05:30, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-06-14 10:38, Reshma Pattan: > > > Added spinlocks around add/remove logic of Rx and Tx callbacks to > > > avoid corruption of callback lists in multithreaded context. > > > > > > Signed-off-by:

[dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture framework

2016-06-15 Thread Thomas Monjalon
2016-06-15 05:44, Pattan, Reshma: > > > ABI Changes > > > --- > > > @@ -146,6 +156,9 @@ ABI Changes > > > * The ``rte_port_source_params`` structure has new fields to support PCAP > > file. > > >It was already in release 16.04 with ``RTE_NEXT_ABI`` flag. > > > > > > +* The

[dpdk-dev] [PATCH v3] i40e: fix olflags for vector Rx

2016-06-15 Thread Wu, Jingjing
> -Original Message- > From: Tao, Zhe > Sent: Tuesday, June 14, 2016 1:24 PM > To: dev at dpdk.org > Cc: Tao, Zhe ; Wu, Jingjing > Subject: [PATCH v3] i40e: fix olflags for vector Rx > > Problem: > The flag for RSS and flow director is not set correctly in the > vector Rx function, so

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-15 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 15, 2016 9:19 AM > To: Pattan, Reshma > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx > callback

[dpdk-dev] [PATCH 1/1] vhost: fix null pointer dereference

2016-06-15 Thread Marcin Kerlin
Return value of function get_device() is not checking before dereference. Fix this problem by adding checking condition. Coverity issue: 119262 Fixes: 77d20126b4c2 ("vhost-user: handle message to enable vring") Signed-off-by: Marcin Kerlin --- lib/librte_vhost/vhost_user/virtio-net-user.c | 6

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-15 Thread Thomas Monjalon
2016-06-15 08:37, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-06-15 05:30, Pattan, Reshma: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > 2016-06-14 10:38, Reshma Pattan: > > > > > Added spinlocks around add/remove logic of

[dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory

2016-06-15 Thread Sergio Gonzalez Monroy
Hi Marcin, On 14/06/2016 16:33, Marcin Kerlin wrote: > Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files > were not freed back to the OS in case of failure. Patch uses the behavior > of Linux munmap: "It is not an error if the indicated range does not > contain any mapped

[dpdk-dev] [PATCH 1/1] vhost: fix null pointer dereference

2016-06-15 Thread Yuanhan Liu
On Wed, Jun 15, 2016 at 11:47:22AM +0200, Marcin Kerlin wrote: > Return value of function get_device() is not checking before > dereference. Fix this problem by adding checking condition. > > Coverity issue: 119262 > Fixes: 77d20126b4c2 ("vhost-user: handle message to enable vring") > >

[dpdk-dev] [PATCH v9 1/6] virtio: hide phys addr check inside PCI ops

2016-06-15 Thread Jianfeng Tan
This patch is to move phys addr check from virtio_dev_queue_setup to pci ops. To makt that happen, make sure virtio_ops.setup_queue return the result if we pass through the check. Signed-off-by: Jianfeng Tan Signed-off-by: Huawei Xie Acked-by: Yuanhan Liu ---

[dpdk-dev] [PATCH v9 4/6] virtio-user: add device emulation layer APIs

2016-06-15 Thread Jianfeng Tan
Two device emulation layer APIs are added for virtio driver to call: - virtio_user_start_device() - virtio_user_stop_device() - virtio_user_dev_init() - virtio_user_dev_uninit() These APIs will get called by virtio driver, and they call vhost adapter layer APIs to implement the

[dpdk-dev] [PATCH v9 5/6] virtio-user: add new virtual PCI driver for virtio

2016-06-15 Thread Jianfeng Tan
This patch implements another new instance of struct virtio_pci_ops to drive the virtio-user virtual device. Instead of rd/wr ioport or PCI configuration space, this virtual pci driver will rd/wr the virtual device struct virtio_user_hw, and when necessary, invokes APIs provided by device

[dpdk-dev] [PATCH v9 6/6] virtio-user: add a new vdev named virtio-user

2016-06-15 Thread Jianfeng Tan
Add a new virtual device named vhost-user, which can be used just like eth_ring, eth_null, etc. To reuse the code of original virtio, we do some adjustment in virtio_ethdev.c, such as remove key _static_ of eth_virtio_dev_init() so that it can be reused in virtual device; and we add some check to

[dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support

2016-06-15 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support > > 2016-06-14

[dpdk-dev] [PATCH v3 0/3] add multi queue support for virtio-user

2016-06-15 Thread Jianfeng Tan
v3: - Fix compiling issue on 32-bit system. - Fix a segment fault issue when sending VHOST_USER_SET_VRING_ENABLE. - Squash the patch (use virtual address in mq) into "virtio for container" patch series. v2: - Move the ctrl queue handler and multi queue logic into device emulation. -

[dpdk-dev] [PATCH v3 1/3] virtio-user: add mq in vhost user adapter

2016-06-15 Thread Jianfeng Tan
This patch mainly adds method in vhost user adapter to communicate enable/disable queues messages with vhost user backend, aka, VHOST_USER_SET_VRING_ENABLE. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_user/vhost.h | 5 + drivers/net/virtio/virtio_user/vhost_user.c | 22

[dpdk-dev] [PATCH v3 2/3] virtio-user: add ctrl-q and mq in device emulation

2016-06-15 Thread Jianfeng Tan
The main purpose of this patch is to enable multi-queue. But multi-queue requires ctrl-queue so that driver can send how many queues will be enabled through ctrl-queue messages. So we partially implement ctrl-queue to handle control command with class of VIRTIO_NET_CTRL_MQ and with cmd of

[dpdk-dev] [PATCH v3 0/3] virtio-user: handle ctrl-q in driver

2016-06-15 Thread Jianfeng Tan
In virtio-user driver, when notify ctrl-queue, invoke API of virtio-user device emulation to handle ctrl-q command. Besides, multi-queue requires ctrl-queue and ctrl-queue will be enabled automatically when multi-queue is specified. Signed-off-by: Jianfeng Tan ---

[dpdk-dev] [PATCH v4 7/8] rte: change xstats usage to new API

2016-06-15 Thread Thomas Monjalon
2016-06-13 16:52, Remy Horton: > The current extended ethernet statistics fetching involve doing several > string operations, which causes performance issues if there are lots of > statistics and/or network interfaces. This patch changes the test-pmd > and proc_info applications to use the new

[dpdk-dev] [PATCH v3 0/3] Keep-alive enhancements

2016-06-15 Thread Remy Horton
This patchset adds enhancements to the keepalive core monitoring and reporting sub-system. The first is support for idled (sleeping and frequency-stepped) CPU cores, and the second is support for applications to be notified of active as well as faulted cores. The latter is to allow core state to

[dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations

2016-06-15 Thread Remy Horton
Changes the keepalive state from an anonymous enum to a declared one which is externally visible, so that keepalive enum values can be used by applications. Signed-off-by: Remy Horton --- lib/librte_eal/common/include/rte_keepalive.h | 12 +- lib/librte_eal/common/rte_keepalive.c

[dpdk-dev] [PATCH v3 2/3] eal: add additional keepalive callbacks

2016-06-15 Thread Remy Horton
Adds and documents new callbacks that allow transitions to core states other than dead to be reported to applications. Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_16_07.rst | 6 +++ examples/Makefile | 2 +-

[dpdk-dev] [PATCH v3 3/3] examples/l2fwd-keepalive: add IPC liveness reporting

2016-06-15 Thread Remy Horton
Changes the l2fwd keepalive example to show how the new keepalive enhancements can be used to relay core state to an external process. Signed-off-by: Remy Horton --- examples/Makefile | 1 + examples/l2fwd-keepalive/Makefile | 4 +-

[dpdk-dev] [PATCH v4 1/8] rte: change xstats to use integer ids

2016-06-15 Thread Thomas Monjalon
2016-06-13 16:51, Remy Horton: > Signed-off-by: Remy Horton Please insert an explanation of why this change is needed. [...] > /** > + * Retrieve names of extended statistics of an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param

[dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations

2016-06-15 Thread Thomas Monjalon
2016-06-15 10:17, Remy Horton: > +enum rte_keepalive_state { > + RTE_UNUSED = 0, > + RTE_ALIVE = 1, > + RTE_MISSING = 4, > + RTE_DEAD = 2, > + RTE_GONE = 3, > + RTE_DOZING = 5, > + RTE_SLEEP = 6 > +}; I'm concerned about the namespace here. RTE_UNUSED and others have a

  1   2   3   >