[dpdk-dev] Interrupt management thread created after driver initialization

Hi David, The patch below is causing performance regression with BNX2X PMD. We are seeing 1518 packets not getting to line rate after applying the patch. We are using l2fwd application on the test system. The same issue is not observed while using testpmd application. We are trying to

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Monday, June 20, 2016 5:14 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Ananyev, Konstantin; Richardson, Bruce; Chen, Jing D; > Liang, > Cunming; Wu, Jingjing; Zhang, Helin;

[dpdk-dev] [PATCH v5 1/2] app/test: reworks the crypto AES unit test

Tested-by: Chen, Zhaoyan * Commit: 3901ed99c2f82d3e979bb1bea001d61898241829 * Patch Apply: Success * Compilation: Success * Kernel/OS: 3.11.10-301.fc20.x86_64 * GCC: 4.8.3 20140911 * Case 1 ./app/test -cf -n4 cryptodev_aesni_mb_autotest Checked the AES-128-CBC / HMAC-224/384 unit test is added.

[dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler

On Mon, Jun 20, 2016 at 05:56:40PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Monday, June 20, 2016 3:22 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon; dev at dpdk.org; Hunt, David;

[dpdk-dev] [PATCH] bnx2x: Correctly determine MSIX vector count

> >From: "Charles (Chas) Williams" > >If MSIX is available, the vector count given by the table size is one >less than the actual count. This count also limits the receive and >transmit queue resources the VF can support. > >Fixes: 540a211084a7 ("bnx2x: driver core") > >Signed-off-by: Chas

[dpdk-dev] [DPDK16.04: Error While compiling]

Hi, I am facing compilation error for DPDK 16.04 as below: In file included from /home/cran/dpdk-16.04/lib/librte_eal/common/eal_common_options.c:52:0: /home/cran/dpdk-16.04/x86_64-native-linuxapp-gcc/include/rte_memcpy.h:673:9: error: called from here _mm_storeu_si128((__m128i

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

Hi Jerin, Stephen, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 11:51 AM > To: Stephen Hemminger > Cc: Lu, Wenzhuo; dev at dpdk.org; Ananyev, Konstantin; Richardson, Bruce; > Chen, > Jing D; Liang, Cunming; Wu,

[dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation

Hi again! Any news about this patch? I'm off for parental leave starting next week (until january), so any comments (or simply dropping it!) would be good to have before that :-) // Simon On 2016-06-10 08:29, Simon Kagstrom wrote: > Signed-off-by: Simon Kagstrom > --- > I'm a total newbie to

[dpdk-dev] [PATCH v2 00/25] Refactor mlx5 to improve performance

Hi Ferruh, On Mon, Jun 20, 2016 at 06:01:49PM +0100, Ferruh Yigit wrote: > Hi Nelio, > > On 6/20/2016 5:10 PM, Nelio Laranjeiro wrote: > > Enhance mlx5 with a data path that bypasses Verbs. > > > > The first half of this patchset removes support for functionality completely > > rewritten in the

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

On 06/10/2016 12:26 AM, Thomas Monjalon wrote: > Looking a bit more into librte_ivshmem, the documentation says we need > a Qemu patch but the URL doesn't exist anymore: > https://01.org/packet-processing/intel%C2%AE-ovdk > -> 404 Oops, we couldn't find that page > > I've never

[dpdk-dev] [RFC] librte_vhost: Add unix domain socket fd registration

On Fri, Jun 17, 2016 at 11:32:36AM -0400, Aaron Conole wrote: > Prior to this commit, the only way to add a vhost-user socket to the > system is by relying on librte_vhost to open the unix domain socket and > add it to the unix socket list. This is problematic for applications > which would like

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

Enhance mlx5 with a data path that bypasses Verbs. The first half of this patchset removes support for functionality completely rewritten in the second half (scatter/gather, inline send), while the data path is refactored without Verbs. The PMD remains usable during the transition. This

[dpdk-dev] [PATCH v3 02/25] mlx5: split memory registration function

Except for the first time when memory registration occurs, the lkey is always cached. Since memory registration is slow and performs system calls, performance can be improved by moving that code to its own function outside of the data path so only the lookup code is left in the original inlined

[dpdk-dev] [PATCH v3 01/25] drivers: fix PCI class id support

Fixes: 701c8d80c820 ("pci: support class id probing") Signed-off-by: Nelio Laranjeiro --- drivers/crypto/qat/rte_qat_cryptodev.c | 5 + drivers/net/mlx4/mlx4.c| 18 ++ drivers/net/mlx5/mlx5.c| 24

[dpdk-dev] [PATCH v3 03/25] mlx5: remove Tx gather support

This is done in preparation of bypassing Verbs entirely for the data path as a performance improvement. TX gather cannot be maintained during the transition and will be reimplemented later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 2

[dpdk-dev] [PATCH v3 04/25] mlx5: remove Rx scatter support

This is done in preparation of bypassing Verbs entirely for the data path as a performance improvement. RX scatter cannot be maintained during the transition and will be reimplemented later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c |

[dpdk-dev] [PATCH v3 05/25] mlx5: remove configuration variable

There is no scatter/gather support anymore, CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N has no purpose and can be removed. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- config/common_base | 1 - doc/guides/nics/mlx5.rst | 7 --- drivers/net/mlx5/Makefile| 4

[dpdk-dev] [PATCH v3 06/25] mlx5: remove inline Tx support

Inline TX will be fully managed by the PMD after Verbs is bypassed in the data path. Remove the current code until then. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- config/common_base | 1 - doc/guides/nics/mlx5.rst | 10 -- drivers/net/mlx5/Makefile

[dpdk-dev] [PATCH v3 07/25] mlx5: split Tx queue structure

To keep the data path as efficient as possible, move fields only useful to the control path into new structure txq_ctrl. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c| 21 +++-- drivers/net/mlx5/mlx5_ethdev.c | 27 +++---

[dpdk-dev] [PATCH v3 08/25] mlx5: split Rx queue structure

To keep the data path as efficient as possible, move fields only useful to the control path into new structure rxq_ctrl. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 6 +- drivers/net/mlx5/mlx5_fdir.c | 8 +- drivers/net/mlx5/mlx5_rxq.c

[dpdk-dev] [PATCH v3 09/25] mlx5: update prerequisites for upcoming enhancements

The latest version of Mellanox OFED exposes hardware definitions necessary to implement data path operation bypassing Verbs. Update the minimum version requirement to MLNX_OFED >= 3.3 and clean up compatibility checks for previous releases. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien

[dpdk-dev] [PATCH v3 10/25] mlx5: add definitions for data path without Verbs

These structures and macros extend those exposed by libmlx5 (in mlx5_hw.h) to let the PMD manage work queue and completion queue elements directly. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_prm.h | 163

[dpdk-dev] [PATCH v3 11/25] mlx5: add support for configuration through kvargs

The intent is to replace the remaining compile-time options and environment variables with a common mean of runtime configuration. This commit only adds the kvargs handling code, subsequent commits will update the rest. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH v3 12/25] mlx5: add Tx/Rx burst function selection wrapper

These wrappers are meant to prevent code duplication later. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h| 2 ++ drivers/net/mlx5/mlx5_ethdev.c | 34 -- drivers/net/mlx5/mlx5_txq.c| 2 +- 3 files

[dpdk-dev] [PATCH v3 13/25] mlx5: refactor Rx data path

Bypass Verbs to improve RX performance. Signed-off-by: Nelio Laranjeiro Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil Signed-off-by: Vasily Philipov --- drivers/net/mlx5/mlx5_ethdev.c | 4 +- drivers/net/mlx5/mlx5_fdir.c | 2 +- drivers/net/mlx5/mlx5_rxq.c| 303

[dpdk-dev] [PATCH v3 14/25] mlx5: refactor Tx data path

Bypass Verbs to improve Tx performance. Signed-off-by: Nelio Laranjeiro Signed-off-by: Yaacov Hazan Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile | 5 - drivers/net/mlx5/mlx5_ethdev.c | 10 +- drivers/net/mlx5/mlx5_mr.c | 4 +- drivers/net/mlx5/mlx5_rxtx.c |

[dpdk-dev] [PATCH v3 15/25] mlx5: handle Rx CQE compression

Mini (compressed) CQEs are returned by the NIC when PCI back pressure is detected, in which case the first CQE64 contains common packet information followed by a number of CQE8 providing the rest, followed by a matching number of empty CQE64 entries to be used by software for decompression.

[dpdk-dev] [PATCH v3 16/25] mlx5: replace countdown with threshold for Tx completions

From: Adrien Mazarguil Replacing the variable countdown (which depends on the number of descriptors) with a fixed relative threshold known at compile time improves performance by reducing the TX queue structure footprint and the amount of code to manage completions

[dpdk-dev] [PATCH v3 17/25] mlx5: add support for inline send

From: Yaacov Hazan Implement send inline feature which copies packet data directly into WQEs for improved latency. The maximum packet size and the minimum number of Tx queues to qualify for inline send are user-configurable. This feature is effective when HW causes a

[dpdk-dev] [PATCH v3 19/25] mlx5: add debugging information about Tx queues capabilities

From: Adrien Mazarguil Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_txq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 4f17fb0..bae9f3d 100644 --- a/drivers/net/mlx5/mlx5_txq.c

[dpdk-dev] [PATCH v3 20/25] mlx5: check remaining space while processing Tx burst

From: Adrien Mazarguil The space necessary to store segmented packets cannot be known in advance and must be verified for each of them. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 136 ++- 1 file

[dpdk-dev] [PATCH v3 21/25] mlx5: resurrect Tx gather support

From: Adrien Mazarguil Compared to its previous incarnation, the software limit on the number of mbuf segments is no more (previously MLX5_PMD_SGE_WR_N, set to 4 by default) hence no need for linearization code and related buffers that permanently consumed a non

[dpdk-dev] [PATCH v3 22/25] mlx5: work around spurious compilation errors

From: Adrien Mazarguil Since commit "mlx5: resurrect Tx gather support", older GCC versions (such as 4.8.5) may complain about the following: mlx5_rxtx.c: In function `mlx5_tx_burst': mlx5_rxtx.c:705:25: error: `wqe' may be used uninitialized in this function

[dpdk-dev] [PATCH v3 23/25] mlx5: remove redundant Rx queue initialization code

From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 10 -- 1 file changed,

[dpdk-dev] [PATCH v3 24/25] mlx5: make Rx queue reinitialization safer

From: Adrien Mazarguil The primary purpose of rxq_rehash() function is to stop and restart reception on a queue after re-posting buffers. This may fail if the array that temporarily stores existing buffers for reuse cannot be allocated. Update rxq_rehash() to work on

[dpdk-dev] [PATCH v3 25/25] mlx5: resurrect Rx scatter support

From: Adrien Mazarguil This commit brings back Rx scatter and related support by the MTU update function. The maximum number of segments per packet is not a fixed value anymore (previously MLX5_PMD_SGE_WR_N, set to 4 by default) as it caused performance issues when

[dpdk-dev] enic in passhtrough mode tx drops

Just wanted to update that the traffic problem was being caused by a completely different reason. Not related to the vlan priority as I thought. It was because I was changing the mbuf data offset and I was missing this patch : http://www.dpdk.org/ml/archives/dev/2016-February/033887.html

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

On Tue, Jun 21, 2016 at 06:14:29AM +, Lu, Wenzhuo wrote: > Hi Jerin, Stephen, > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Tuesday, June 21, 2016 11:51 AM > > To: Stephen Hemminger > > Cc: Lu, Wenzhuo; dev at dpdk.org; Ananyev,

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

Hi, Here is an off-topic comment: would you please add following line to the sendemail section of your git config file? chainreplyto = false That would let me to break the long threads in my client much easier. Otherwise, it's hard for me to do it, leading that your thread occupies several

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

On Tue, Jun 21, 2016 at 03:43:08PM +0800, Yuanhan Liu wrote: > Hi, > > Here is an off-topic comment: would you please add following line to > the sendemail section of your git config file? > > chainreplyto = false > > That would let me to break the long threads in my client much easier. >

[dpdk-dev] [PATCH 2/3] pdump: fix missing dependency on libpthread

Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Panu Matilainen --- lib/librte_pdump/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pdump/Makefile b/lib/librte_pdump/Makefile index af81a28..a506c4d 100644 --- a/lib/librte_pdump/Makefile

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 3:37 PM > To: Lu, Wenzhuo > Cc: Stephen Hemminger; dev at dpdk.org; Ananyev, Konstantin; Richardson, > Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang,

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8

This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8 examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function 'app_pipeline_track_pktq_out_to_link': examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: 'reader' may be used uninitialized in this

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

This commit fixes build errors triggered due misleading indentation. Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning) Signed-off-by: Anupam Kapoor --- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 12

[dpdk-dev] random pkt generator PMD

I've developed some preliminary version of the driver. The code is derived from Null PMD, but required a lot of rework. It uses following devargs to generate packets: 1) edit=offset:size:[rnd|value] Edit a field within an mbuf packet data with given offset and size. Mark it as 'rnd' or

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

On Tue, Jun 21, 2016 at 04:05:44PM +0800, Yuanhan Liu wrote: > On Tue, Jun 21, 2016 at 10:00:34AM +0200, N?lio Laranjeiro wrote: > > On Tue, Jun 21, 2016 at 03:43:08PM +0800, Yuanhan Liu wrote: > > > Hi, > > > > > > Here is an off-topic comment: would you please add following line to > > > the

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

On Tue, Jun 21, 2016 at 08:24:36AM +, Lu, Wenzhuo wrote: > Hi Jerin, Hi Wenzhuo, > > > > > > On Mon, Jun 20, 2016 at 02:24:27PM +0800, Wenzhuo Lu wrote: > > > > > > > Add an API to reset the device. > > > > > > > It's for VF device in this scenario, kernel PF + DPDK VF. > > > > > > > When

[dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get

Morning, On 11/05/2016 01:58, Rasesh Mody wrote: [..] >>> We shall split this patch into an enhancement and a bug fix. >> >> Keep in mind that the xstats API is changing so that stats_get() no >> longer includes strings: >> >> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37079 >>

[dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation

Hi Simon, I am going to take a look at it this week and come back to you. Thanks, Cristian > -Original Message- > From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net] > Sent: Tuesday, June 21, 2016 7:41 AM > To: Dumitrescu, Cristian ; > stephen at networkplumber.org; dev at

[dpdk-dev] [PATCH v3] qat: fix for VFs not getting recognized

From: "Jain, Deepak K" Updated the code to use RTE_PCI_DEVICE. Fixes: 701c8d80c820 ("pci: support class id probing") Signed-off-by: Jain, Deepak K --- v3: kept PCI id in the driver file v2: updated code to use RTE_PCI_DEVICE drivers/crypto/qat/rte_qat_cryptodev.c |

[dpdk-dev] supported packet types

Hi Olivier, > > Hi Konstantin, > > On 06/16/2016 01:29 PM, Ananyev, Konstantin wrote: > I suggest instead to set the ptype > in an opportunistic fashion instead: > - if the driver/hw knows the ptype, set it > - else, set it to unknown > >>> > >>> That's what PMD does now...

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 9:56 AM > To: Lu, Wenzhuo > Cc: Stephen Hemminger; dev at dpdk.org; Ananyev, Konstantin; Richardson, > Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang, >

[dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler

> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 4:35 AM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org; Hunt, David; olivier.matz at 6wind.com; > viktorin at rehivetech.com; shreyansh.jain at nxp.com >

[dpdk-dev] [DPDK16.04: Error While compiling]

Hi, Its VM fedora21, gcc 4.9. Thanks, Amartya -Original Message- From: Anupam Kapoor [mailto:akap...@parallelwireless.com] Sent: Tuesday, June 21, 2016 2:54 PM To: Amartya Kumar Das (MFG & Tech) Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [DPDK16.04: Error While compiling] ** This

[dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler

Hi, On 06/21/2016 11:28 AM, Ananyev, Konstantin wrote: I was proposing only to move only the new handler(lib/librte_mempool/rte_mempool_stack.c). Not any library or any other common code. Just like DPDK crypto device, Even if it is software implementation its better

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

OK, I will do the v4. On 17.06.2016 12:20, Thomas Monjalon wrote: > 2016-06-13 16:51, Remy Horton: >> On 12/06/2016 15:51, Zyta Szpak wrote: >>> I would prefer having only one function rte_eth_dev_get_regs() >>> which returns length and width if data is NULL. >>> The first call is

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Tuesday, June 21, 2016 9:12 AM > To: dev at dpdk.org > Cc: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com > Subject: [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline

[dpdk-dev] [PATCH] bnx2x: Correctly determine MSIX vector count

On Tue, Jun 21, 2016 at 05:55:19AM +, Harish Patil wrote: > > > >From: "Charles (Chas) Williams" > > > >If MSIX is available, the vector count given by the table size is one > >less than the actual count. This count also limits the receive and > >transmit queue resources the VF can support.

[dpdk-dev] [PATCH v3 0/9] IPSec Enhancements

> > Sergio Gonzalez Monroy (9): > > examples/ipsec-secgw: fix esp padding check > > examples/ipsec-secgw: fix stack smashing error > > examples/ipsec-secgw: add build option and cleanup > > examples/ipsec-secgw: rework ipsec execution loop > > examples/ipsec-secgw: fix no sa found case >

[dpdk-dev] [PATCH v4 4/4] doc: kni port support in the packet framework

From: WeiJie Zhuang add some descriptions for the kni port in the packet framework Signed-off-by: WeiJie Zhuang --- doc/api/doxy-api-index.md| 1 + doc/guides/sample_app_ug/ip_pipeline.rst | 112 +++ 2 files changed, 84

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Tuesday, June 21, 2016 11:45 AM > To: Richardson, Bruce > Cc: Dumitrescu, Cristian ; dev at dpdk.org; > christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

On 06/21/2016 01:29 PM, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: >> In current i40e codebase, if single VLAN header is added in a packet, >> it's treated as inner VLAN. Generally, a single VLAN header is >> treated as the outer VLAN header. So change

[dpdk-dev] [PATCH v3 1/3] port: add kni interface support

Hi Cristian, New patch has been submitted. All comments are fixed except this one: "Here is one bug for you, you need to make sure you add the following line here: param->parsed = 1;" I think the new convention is to set this flag by the macro PARSE_CHECK_DUPLICATE_SECTION. BTW, although

[dpdk-dev] [PATCH] lib/table: fix wrong type of nht field

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, June 20, 2016 11:14 AM > To: Jastrzebski, MichalX K ; Kobylinski, > MichalX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/table: fix wrong type of nht field > >

[dpdk-dev] [PATCH] lib/table: fix wrong type of nht field

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Monday, June 20, 2016 11:10 AM > To: dev at dpdk.org > Cc: Kobylinski, MichalX > Subject: [dpdk-dev] [PATCH] lib/table: fix wrong type of nht field > > From: Michal Kobylinski >

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

On Tue, Jun 21, 2016 at 3:40 PM, Ferruh Yigit wrote: > Hi Anupam, > > Thank you for the patch. > > > On 6/21/2016 9:37 AM, Anupam Kapoor wrote: > > This commit fixes build errors triggered due misleading indentation. > > > > Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning) >

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

On Tue, Jun 21, 2016 at 02:06:38PM +0300, Panu Matilainen wrote: > On 06/21/2016 01:29 PM, Bruce Richardson wrote: > >On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > >>In current i40e codebase, if single VLAN header is added in a packet, > >>it's treated as inner VLAN. Generally, a

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > In current i40e codebase, if single VLAN header is added in a packet, > it's treated as inner VLAN. Generally, a single VLAN header is > treated as the outer VLAN header. So change corresponding register > for single VLAN. > At the

[dpdk-dev] [PATCH v3 1/3] port: add kni interface support

Hi Ethan, Thanks very much for sending the new version. You are absolutely right about the param->parsed issue, sorry, my fault. I think you need to use the --cover-letter flag for git format-patch command. You can practice by sending the patch set to your email address first before you send

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

On 06/21/2016 01:58 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Tuesday, June 21, 2016 11:45 AM >> To: Richardson, Bruce >> Cc: Dumitrescu, Cristian ; dev at dpdk.org; >> christian.ehrhardt at canonical.com;

[dpdk-dev] [PATCH] mem: skip memory locking on failure

On 06/14/2016 05:12 PM, Olivier MATZ wrote: > Hi Panu, > > On 06/14/2016 03:21 PM, Panu Matilainen wrote: >> On 06/13/2016 01:26 PM, Olivier Matz wrote: >>> Since recently [1], it is not possible to run the dpdk with user >>> (non-root) privileges and the --no-huge option. This is because the eal

[dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver

* Original patch series is from David Marchand [1], [2]. * Cover letter text has been modified to make it author agnostic David created the original patchset based on the discussions on list [3]. Being a large piece of work, this patchset introduces first level of changes for generalizing the

[dpdk-dev] [PATCH v4 01/17] pci: no need for dynamic tailq init

These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors. Signed-off-by: David Marchand Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v4 02/17] crypto: no need for a crypto pmd type

This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v4 03/17] drivers: align pci driver definitions

Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +-

[dpdk-dev] [PATCH v4 04/17] eal: remove duplicate function declaration

rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci devices") Signed-off-by: David Marchand Signed-off-by:

[dpdk-dev] [PATCH v4 05/17] eal: introduce init macros

Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). RTE_EAL_PCI_REGISTER is added as a helper for pci drivers. RTE_EAL_PCI_REGISTER assumes that object expanded contains a pci_drv member.

[dpdk-dev] [PATCH v4 06/17] crypto: export init/uninit common wrappers for pci drivers

Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c |

[dpdk-dev] [PATCH v4 07/17] ethdev: export init/uninit common wrappers for pci drivers

Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++---

[dpdk-dev] [PATCH v4 08/17] drivers: convert all pdev drivers as pci drivers

Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. virtio and mlx* drivers use the general purpose RTE_INIT macro, as they both need some special stuff to be done before registering a

[dpdk-dev] [PATCH v4 09/17] crypto: get rid of crypto driver register callback

Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v4 1/4] port: kni interface support

> -Original Message- > From: Ethan Zhuang [mailto:zhuangwj at gmail.com] > Sent: Tuesday, June 21, 2016 11:56 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; Yigit, > Ferruh ; WeiJie Zhuang > Subject: [PATCH v4 1/4] port: kni interface support > > From: WeiJie

[dpdk-dev] [PATCH v4 10/17] ethdev: get rid of eth driver register callback

Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12

[dpdk-dev] [PATCH v4 11/17] eal/linux: move back interrupt thread init before setting affinity

Now that virtio pci driver is initialized in a constructor, iopl() stuff happens early enough so that interrupt thread can be created right after plugin loading. This way, chelsio driver should be happy again [1]. [1] http://dpdk.org/ml/archives/dev/2015-November/028289.html Signed-off-by: David

[dpdk-dev] [PATCH v4 12/17] pci: add a helper for device name

eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 ---

[dpdk-dev] [PATCH v4 13/17] pci: add a helper to update a device

This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 +

[dpdk-dev] [PATCH v4 14/17] ethdev: do not scan all pci devices on attach

No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6

[dpdk-dev] [PATCH v4 15/17] eal: add hotplug operations for pci and vdev

hotplug which deals with resources should come from the layer that already handles them, i.e. eal. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v4 16/17] ethdev: convert to eal hotplug

Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can not get rid of ethdev hotplug yet since we still

[dpdk-dev] [PATCH v4 17/17] ethdev: get rid of device type

Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +-

[dpdk-dev] [PATCH v2 0/6] ena: update PMD to cooperate with latest ENA firmware

As requested, big patch splitted into logical pieces for easier review. Improved style and fixed icc compiler issues. Jan Medala (6): ena: update of ENA communication layer ena: add debug area and host information ena: disable readless communication regarding to HW revision ena: allocate

[dpdk-dev] [PATCH v2 1/6] ena: update of ENA communication layer

Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_com.c | 203 ++- drivers/net/ena/base/ena_com.h | 82 +++-- drivers/net/ena/base/ena_defs/ena_admin_defs.h | 107 +-

[dpdk-dev] [PATCH v2 2/6] ena: add debug area and host information

Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 193 ++- drivers/net/ena/ena_ethdev.h | 38 + 2 files changed, 230 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 3/6] ena: disable readless communication regarding to HW revision

Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 12 +++- drivers/net/ena/ena_ethdev.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH v2 4/6] ena: allocate coherent memory in node-aware way

Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_com.c | 51 ++-- drivers/net/ena/base/ena_plat_dpdk.h | 23 drivers/net/ena/ena_ethdev.c | 15 +++ 3

[dpdk-dev] [PATCH v2 5/6] ena: fix memory management issue

After allocating memzone it's required to zeroize memory in it. Freeing memzone with function dedicated for memoryzones. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_plat_dpdk.h | 6 -- 1 file changed, 4

[dpdk-dev] [PATCH v2 6/6] ena: fix for icc compiler

Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index d0927f7..928b37f 100644

[dpdk-dev] [PATCH] bnx2x: set random MAC address if one isn't assigned

If the PF hasn't assigned an address, assign one randomly. While here, convert to use DPDK's ether address utility routines. Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Chas Williams <3chas3 at gmail.com> --- drivers/net/bnx2x/bnx2x.h | 8

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 11:44, Ferruh Yigit: > Although this is really detail, for multi version patchsets, if there is > a preferred way between (A) or (B) I would like to learn too? In my opinion, A and B are fine. And I prefer B. > A) > > - [0/N] > - - [1/N] > - - [2/N] > - - [v2 0/N] > - - - [v2 1/N] >

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

On 6/21/2016 12:43 PM, Anupam Kapoor wrote: > This commit fixes build errors triggered due misleading indentation. > > Fixes: 38db3f7f50bde (e1000: update base driver) Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline") > Fixes: 3fc5ca2f63529 (kni: initial import) > > >

  1   2   >