[dpdk-dev] [PATCH v3] i40e: fix VLAN filter in promiscuous mode

2016-06-30 Thread Jingjing Wu
For VLAN filtering VLAN table should be enabled. But VLAN table is disabled by default until a rule added. In promiscuous mode no rule is added to enable the VLAN table. So this patch clears promiscuous VLAN flag on VSI, and adds a rule to enable VLAN table to fix VLAN filtering in promiscuous

[dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe

2016-06-30 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Friday, June 24, 2016 8:46 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe > > Hi Thomas, > > > >

[dpdk-dev] [PATCH] net/thunderx: add missing external library dependency

2016-06-30 Thread Jerin Jacob
On Wed, Jun 29, 2016 at 07:34:49PM +0100, Ferruh Yigit wrote: > To prevent compile error when compiling for shared library: > nicvf_hw.o: In function `nicvf_qsize_regbit': > nicvf_hw.c:(.text+0xe64): undefined reference to `log2' > nicvf_hw.o: In function `nicvf_rss_reta_update': >

[dpdk-dev] [PATCH] vhost: fix Tx error counting of vhost PMD

2016-06-30 Thread Yuanhan Liu
On Fri, Jun 24, 2016 at 10:17:20AM +0800, Yuanhan Liu wrote: > On Fri, Jun 24, 2016 at 11:04:20AM +0900, Tetsuya Mukawa wrote: > > According to 'rte_eth_stats' structure comments, 'imissed' > > should represent RX error counting, but currently 'imissed' is > > used to count TX error. > > The patch

[dpdk-dev] [PATCH v2] net/virtio-user: fix implicit int to enum conversion

2016-06-30 Thread Yuanhan Liu
On Sun, Jun 26, 2016 at 01:48:13PM +, Jianfeng Tan wrote: > Implicit int to enum conversion is not allowed when icc is used as > the compiler. It raises the compiling error like, > /.../dpdk/drivers/net/virtio/virtio_user/vhost_user.c(257): > error #188: enumerated type mixed with

[dpdk-dev] [PATCH v2] doc: update vhost guide

2016-06-30 Thread Yuanhan Liu
On Mon, Jun 27, 2016 at 09:26:12AM +, Mcnamara, John wrote: > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Monday, June 27, 2016 6:20 AM > > To: dev at dpdk.org > > Cc: Xie, Huawei ; Mcnamara, John > > ; Thomas Monjalon > 6wind.com>; > >

[dpdk-dev] [PATCH] vhost: fix missing flag reset on stop

2016-06-30 Thread Yuanhan Liu
On Wed, Jun 29, 2016 at 02:55:40PM +, Loftus, Ciara wrote: > > > > Commit 550c9d27d143 ("vhost: set/reset device flags internally") moves > > the VIRTIO_DEV_RUNNING set/reset to vhost lib. But I missed one reset > > on stop; here fixes it. > > > > Fixes: 550c9d27d143 ("vhost: set/reset

[dpdk-dev] [PATCH 3/4] virtio: move SSE based Rx implementation to separate file

2016-06-30 Thread Yuanhan Liu
On Wed, Jun 29, 2016 at 04:57:46PM +0530, Jerin Jacob wrote: > On Tue, Jun 28, 2016 at 02:17:41PM +0800, Jianbo Liu wrote: > > On 27 June 2016 at 19:54, Jerin Jacob > > wrote: > > > split out SSE instruction based virtio simple rx > > > implementation to a separate file > > > > > >

[dpdk-dev] [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR

2016-06-30 Thread Yuanhan Liu
On Wed, Jun 29, 2016 at 05:10:31PM +0530, Jerin Jacob wrote: > On Wed, Jun 29, 2016 at 01:25:35PM +0200, Thomas Monjalon wrote: > > 2016-06-29 16:48, Jerin Jacob: > > > On Mon, Jun 27, 2016 at 04:59:42PM +0200, Thomas Monjalon wrote: > > > > 2016-06-27 20:18, Jerin Jacob: > > > > > On Mon, Jun 27,

[dpdk-dev] [PATCH 0/4] i40e: fix coverity defects

2016-06-30 Thread Beilei Xing
Fix some open coverity defects. Beilei Xing (4): i40e: fix wrong operator i40e: fix dereference before null check i40e: fix out-of-bounds access examples/tep_term: fix out-of-bounds access drivers/net/i40e/i40e_ethdev.c | 35 --

[dpdk-dev] [PATCH 1/4] i40e: fix wrong operator

2016-06-30 Thread Beilei Xing
Previously, (pf->flags | I40E_FLAG_VMDQ) will be always true regardless of the value of its operand, because I40E_FLAG_VMDQ is 4ULL. But he original idea should judge if VMDQ is enabled. Fix this issue with (pf->flags & I40E_FLAG_VMDQ). Fixes: 4805ed59e957 ("i40e: enhance mac address operations")

[dpdk-dev] [PATCH 2/4] i40e: fix dereference before null check

2016-06-30 Thread Beilei Xing
Null-checking vsi suggests that it may be null, but it has be dereferenced before null-checking. So move if statement to the front of assignment statement. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Fixes: 647d1eaf758b ("i40evf: support AQ based RSS config") Signed-off-by: Beilei

[dpdk-dev] [PATCH 4/4] examples/tep_term: fix out-of-bounds access

2016-06-30 Thread Beilei Xing
Coverity reported lots of out-of-bounds in function vxlan_link, these issues should happen when index port_id evaluates to 2, cause size of arrays is 2 in structure. Fix this issue by modifying judgement condition, make sure port_id is less than 2. Fixes: 4abe471ed6fc ("examples/tep_term:

[dpdk-dev] [PATCH 3/4] i40e: fix out-of-bounds access

2016-06-30 Thread Beilei Xing
When calling i40e_flowtype_to_pctype in i40e_get_hash_filter_global_config and i40e_set_hash_filter_global_config, function i40e_flowtype_to_pctype will be possibly out-of-bounds accessed, because size of callee's array is 15. So judge flow type before calling i40e_flowtype_to_pctype. Meanwhile do

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Panu Matilainen
On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > v3: - adapted the new vhost ABI/API changes to tep_term example, to make > sure not break build at least. > - bumped the ABI version to 3 > > NOTE: I created a branch at dpdk.org [0] for more conveinient testing: > > [0]:

[dpdk-dev] [PATCH v4 0/2] mempool: add stack mempool handler

2016-06-30 Thread David Hunt
This patch set adds a lifo stack handler to the external mempool manager. This patch utilises the mempool handler feature which allows the addition of new mempool handlers to DPDK. Performance Notes: For the mempool_perf_autotest, there's ain average of 30% increase in performance for the local

[dpdk-dev] [PATCH v4 1/2] mempool: add stack (lifo) mempool handler

2016-06-30 Thread David Hunt
This is a mempool handler that is useful for pipelining apps, where the mempool cache doesn't really work - example, where we have one core doing rx (and alloc), and another core doing Tx (and return). In such a case, the mempool ring simply cycles through all the mbufs, resulting in a LLC miss on

[dpdk-dev] [PATCH v4 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread David Hunt
After introducing the stack handler in the previous commit, we now have very similar code to the custom handler in test_mempool.c, which creates a custom mempool based on simple mallocs. The stack handler is a cleaner example of adding a new mempool handler, so this commit replaces the custom

[dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe

2016-06-30 Thread Thomas Monjalon
2016-06-30 01:40, Lu, Wenzhuo: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Lu, Wenzhuo > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2016-06-23 01:04, Lu, Wenzhuo: > > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > > 2016-05-06 05:33,

[dpdk-dev] [PATCHv8 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information

2016-06-30 Thread Remy Horton
On 29/06/2016 17:18, Neil Horman wrote: > On Wed, Jun 29, 2016 at 04:12:21PM +0100, Remy Horton wrote: >> 'noon, [..] >> No licence..? >> > Its BSD, same as the others, I let the README cover that. We can include > it if we must, though we have lots of examples where we haven't bothered Ok. The

[dpdk-dev] [PATCHv8 0/6] Implement pmd hardware support exports

2016-06-30 Thread Remy Horton
On 17/06/2016 19:46, Neil Horman wrote: > Hey all- > So heres attempt number 2 at a method for exporting PMD hardware support > information. As we discussed previously, the consensus seems to be that pmd > information should be: [..] > Signed-off-by: Neil Horman > Acked-by: Panu

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Yuanhan Liu
On Thu, Jun 30, 2016 at 10:39:45AM +0300, Panu Matilainen wrote: > On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > >v3: - adapted the new vhost ABI/API changes to tep_term example, to make > > sure not break build at least. > >- bumped the ABI version to 3 > > > >NOTE: I created a branch at

[dpdk-dev] [PATCH v2] examples/l2fwd-crypto: fix out-of-bounds read

2016-06-30 Thread Slawomir Mrozowicz
Overrunning array crypto_statistics of 32 64-byte elements at element index 63 using index cdevid. Fixed by extend crypto_statistics array. Coverity ID 120145 Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Slawomir Mrozowicz --- v2: - correct commit

[dpdk-dev] weak functions in some drivers

2016-06-30 Thread Sergio Gonzalez Monroy
On 29/06/2016 14:26, Elo, Matias (Nokia - FI/Espoo) wrote: >>> What is not clear to me is motivation to use weak here instead of simply >>> using >CONFIG_RTE_I40E_INC_VECTOR >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and >>> avoid issues like this one >>> which are

[dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe

2016-06-30 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, June 30, 2016 3:42 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe > > 2016-06-30 01:40, Lu, Wenzhuo: > >

[dpdk-dev] weak functions in some drivers

2016-06-30 Thread Elo, Matias (Nokia - FI/Espoo)
> >>> What is not clear to me is motivation to use weak here instead of simply > using >CONFIG_RTE_I40E_INC_VECTOR > >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and > >>> avoid > issues like this one > >>> which are quite hard to troubleshoot. > >> Since this issue

[dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe

2016-06-30 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, June 30, 2016 4:23 PM > To: 'Thomas Monjalon' > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe > > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Panu Matilainen
On 06/30/2016 10:57 AM, Yuanhan Liu wrote: > On Thu, Jun 30, 2016 at 10:39:45AM +0300, Panu Matilainen wrote: >> On 06/07/2016 06:51 AM, Yuanhan Liu wrote: >>> v3: - adapted the new vhost ABI/API changes to tep_term example, to make >>> sure not break build at least. >>>- bumped the ABI

[dpdk-dev] [PATCH v1 1/1] examples/bond: fix unchecked return value

2016-06-30 Thread Declan Doherty
On 29/06/16 10:23, ptazarex at ecsmtp.igk.intel.com wrote: > The example is calling rte_eal_wait_lcore without checking return value. > Now it is fixed by checking the value and print proper message. > > Coverity issue: 37789 > Coverity issue: 37790 > Fixes: cc7e8ae84faa ("examples/bond: add

[dpdk-dev] [PATCH] net/thunderx: add missing external library dependency

2016-06-30 Thread Thomas Monjalon
2016-06-30 09:02, Jerin Jacob: > On Wed, Jun 29, 2016 at 07:34:49PM +0100, Ferruh Yigit wrote: > > To prevent compile error when compiling for shared library: > > nicvf_hw.o: In function `nicvf_qsize_regbit': > > nicvf_hw.c:(.text+0xe64): undefined reference to `log2' > > nicvf_hw.o: In function

[dpdk-dev] [PATCH v5 0/3] mempool: user-owned mempool caches

2016-06-30 Thread Thomas Monjalon
> Lazaros Koromilas (3): > mempool: deprecate specific get and put functions > mempool: use bit flags to set multi consumers and producers > mempool: allow for user-owned mempool caches Applied with release nots additions, thanks

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

2016-06-30 Thread Thomas Monjalon
2016-05-26 13:37, Jerin Jacob: > Signed-off-by: Jerin Jacob Please Jerin (or anyone else), could you rebase this patch? Thanks

[dpdk-dev] [PATCH v4 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread Thomas Monjalon
Hi David, There is a compilation error: app/test/test_mempool.c:598:6: error: too few arguments to function ?test_mempool_basic? Please send a v5, thanks.

[dpdk-dev] [PATCH v1 1/1] examples/bond: fix unchecked return value

2016-06-30 Thread Azarewicz, PiotrX T
> The example is calling rte_eal_wait_lcore without checking return value. > Now it is fixed by checking the value and print proper message. > > Coverity issue: 37789 > Coverity issue: 37790 > Fixes: cc7e8ae84faa ("examples/bond: add example application for link > bonding mode 6") > >

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
Since below commit, ACL library is outside the scope of --whole-archive and ACL autotest fails. RTE>>acl_autotest ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid Line 1584: SSE classify with zero categories failed!

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, June 30, 2016 10:05 AM > To: Yuanhan Liu > Cc: dev at dpdk.org; Xie, Huawei ; Thomas Monjalon > ; Rich Lane ; > Tetsuya > Mukawa > Subject: Re: [dpdk-dev] [PATCH v3 00/20]

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 12:10, Sergio Gonzalez Monroy: > Since below commit, ACL library is outside the scope of --whole-archive > and ACL autotest fails. > > RTE>>acl_autotest > ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed > ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid >

[dpdk-dev] [PATCH v2] mempool: replace c memcpy code semantics with optimized rte_memcpy

2016-06-30 Thread Jerin Jacob
On Thu, Jun 30, 2016 at 11:41:59AM +0200, Thomas Monjalon wrote: > 2016-05-26 13:37, Jerin Jacob: > > Signed-off-by: Jerin Jacob > > Please Jerin (or anyone else), could you rebase this patch? OK. I will send the rebased version > Thanks

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-30 Thread Thomas Monjalon
2016-06-30 11:15, Mcnamara, John: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > > On 06/30/2016 10:57 AM, Yuanhan Liu wrote: > > > On Thu, Jun 30, 2016 at 10:39:45AM +0300, Panu Matilainen wrote: > > >> On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > > >>> v3: - adapted

[dpdk-dev] [PATCH] scripts: test clean build when config have changed

2016-06-30 Thread Thomas Monjalon
If there is a change in the config directory the build test will refresh the tested build config to take into account new options. The git working directory and the last git commit are checked for a change in config/. Signed-off-by: Thomas Monjalon --- scripts/test-build.sh | 7 ++- 1 file

[dpdk-dev] [RFC] mk: filter duplicate configuration entries

2016-06-30 Thread Christian Ehrhardt
Hi, thanks a lot for your feedback. I looked at it once more and found some issues - the tac was correct, but at the wrong place. Also I could simplify the inner section at least a bit. I agree to the move to the .config target. I'll submit a v2 now to this thread. Here is the diff it generates

[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

2016-06-30 Thread Thomas Monjalon
2016-06-29 17:27, Bruce Richardson: > Fix this by introducing two new functions to replace the old ones, > * rte_mempool_avail_count to replace rte_mempool_count > * rte_mempool_in_use_count to replace rte_mempool_free_count This patch needs to be rebased please. > ---

[dpdk-dev] [PATCH v2] mk: filter duplicate configuration entries

2016-06-30 Thread Christian Ehrhardt
*updates in v2* - move to .config target - fix usage order of tac - simplify inner section by only using awk (instead of awk+loop+bash+sed) Due to the hierarchy and the demand to keep the base config showing all options, some config keys end up multiple times in the .config file. Due to the way

[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

2016-06-30 Thread Panu Matilainen
On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count > > This patch needs

[dpdk-dev] [PATCH v1] change log level for check when add port in blacklist

2016-06-30 Thread Thomas Monjalon
2016-06-07 01:47, Lu, Wenzhuo: > > maybe we should change log level, when add port in blacklist,for check it > > easy. > > and it not influence performance and function > > > > Signed-off-by: xu,huilong > Acked-by: Wenzhuo Lu > Considering the usability, prefer to show the log to users.

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
On 30/06/2016 12:38, Thomas Monjalon wrote: > 2016-06-30 12:10, Sergio Gonzalez Monroy: >> Since below commit, ACL library is outside the scope of --whole-archive >> and ACL autotest fails. >> >>RTE>>acl_autotest >>ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed >>

[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

2016-06-30 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 02:00:16PM +0200, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: > > Fix this by introducing two new functions to replace the old ones, > > * rte_mempool_avail_count to replace rte_mempool_count > > * rte_mempool_in_use_count to replace rte_mempool_free_count

[dpdk-dev] [PATCH v2] mempool: rename functions with confusing names

2016-06-30 Thread Bruce Richardson
On Thu, Jun 30, 2016 at 03:02:22PM +0300, Panu Matilainen wrote: > On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > >2016-06-29 17:27, Bruce Richardson: > >>Fix this by introducing two new functions to replace the old ones, > >>* rte_mempool_avail_count to replace rte_mempool_count > >>*

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy > Sent: Thursday, June 30, 2016 12:10 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] mk: fix acl library static linking > > Since below commit, ACL library is outside the scope

[dpdk-dev] [PATCH v3] mempool: replace c memcpy code semantics with optimized rte_memcpy

2016-06-30 Thread Jerin Jacob
Signed-off-by: Jerin Jacob Acked-by: Olivier Matz --- v1..v2 Corrected the the git commit message(s/mbuf/mempool/g) v2..v3 re-base to master --- --- lib/librte_mempool/rte_mempool.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.h

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 13:04, Sergio Gonzalez Monroy: > On 30/06/2016 12:38, Thomas Monjalon wrote: > > Does it need to be commented in rte.app.mk? > > The other libs are in whole-archive to support dlopen of drivers. > > But the problem here is not because of a driver use. > > There seem to be a bunch of

[dpdk-dev] [PATCH v3] mempool: rename functions with confusing names

2016-06-30 Thread Bruce Richardson
The mempool_count and mempool_free_count behaved contrary to what their names suggested. The free_count function actually returned the number of elements that were allocated from the pool, not the number unallocated as the name implied. Fix this by introducing two new functions to replace the old

[dpdk-dev] [PATCH v3] eal/linuxapp: fix resource leak

2016-06-30 Thread Sergio Gonzalez Monroy
On 22/06/2016 17:50, Daniel Mrzyglod wrote: > This patch fix all cases to do proper handle all munmap if pointer > of hugepage is not NULL which prohibits resource leak. I would reword the above commit to something like: Current code does not munmap 'hugepage' mapping (hugepage info file) on

[dpdk-dev] [PATCH v5] eal: fix allocating all free hugepages

2016-06-30 Thread Thomas Monjalon
> > EAL memory init allocates all free hugepages of the whole system, > > which seen from sysfs, even when applications do not ask so many. > > When there is a limitation on how many hugepages an application can > > use (such as cgroup.hugetlb), or hugetlbfs is specified with an > > option of size

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-06-30 Thread Thomas Monjalon
2016-05-19 10:25, Tan, Jianfeng: > On 5/18/2016 8:46 PM, David Marchand wrote: > > On Wed, Mar 9, 2016 at 2:05 PM, Panu Matilainen > > wrote: > >> On 03/08/2016 07:38 PM, Tan, Jianfeng wrote: > >>> On 3/8/2016 4:54 PM, Panu Matilainen wrote: > On 03/04/2016 12:05 PM, Jianfeng Tan wrote: >

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
On 30/06/2016 13:44, Thomas Monjalon wrote: > 2016-06-30 13:04, Sergio Gonzalez Monroy: >> On 30/06/2016 12:38, Thomas Monjalon wrote: >>> Does it need to be commented in rte.app.mk? >>> The other libs are in whole-archive to support dlopen of drivers. >>> But the problem here is not because of a

[dpdk-dev] [PATCH v3 0/6] ena: update PMD to cooperate with latest ENA firmware

2016-06-30 Thread Jan Medala
v2: As requested, big patch splitted into logical pieces for easier review. Improved style and fixed icc compiler issues. v3: Added commit messages to clarify patch purpose and minor changes Jan Medala (6): ena: update of ENA communication layer ena: add debug area and host information

[dpdk-dev] [PATCH v3 2/6] ena: add debug area and host information

2016-06-30 Thread Jan Medala
Increase maintenance and debug potentiality with dedicated areas of memory where additional information can be stored by the ENA device. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 190

[dpdk-dev] [PATCH v3 1/6] ena: update of ENA communication layer

2016-06-30 Thread Jan Medala
Synchronize ENA communication layer with latest ENA FW version. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_com.c | 203 ++- drivers/net/ena/base/ena_com.h | 82 +++--

[dpdk-dev] [PATCH v3 3/6] ena: disable readless communication regarding to HW revision

2016-06-30 Thread Jan Medala
Depending on HW revision readless communcation between host and device may be unavailable. In that case prevent PMD of seting up readless communication mechanism. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 12

[dpdk-dev] [PATCH v3 4/6] ena: allocate coherent memory in node-aware way

2016-06-30 Thread Jan Medala
On multi-node systems try to allocate memory possibly closest to requesting node. While allocating (coherent) memory, get information about calling node Id and basing on it reserve memzone. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala ---

[dpdk-dev] [PATCH v3 5/6] ena: fix memory management issue

2016-06-30 Thread Jan Medala
After allocating memzone it's required to zeroize memory in it. Freeing memzone with function dedicated for memoryzones. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_plat_dpdk.h | 6 -- 1 file changed, 4

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-06-30 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index f8dbde4..a8c2b9c 100644

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy > Sent: Thursday, June 30, 2016 3:02 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: fix acl library static linking > > On 30/06/2016

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 15:02, Sergio Gonzalez Monroy: > On 30/06/2016 13:44, Thomas Monjalon wrote: > > 2016-06-30 13:04, Sergio Gonzalez Monroy: > >> On 30/06/2016 12:38, Thomas Monjalon wrote: > >>> Does it need to be commented in rte.app.mk? > >>> The other libs are in whole-archive to support dlopen of

[dpdk-dev] [PATCH v1] doc: update notes for i40e firmware version.

2016-06-30 Thread Ian Stokes
Updated notes for i40e firmware version as it referenced an older FVL firmware verion 4.2.5 which is no longer validated. Instruct users to consult release notes for current validated firmware versions. Signed-off-by: Ian Stokes --- doc/guides/linux_gsg/enable_func.rst |3 +-- 1 files

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 15:24, Ananyev, Konstantin: > Hi Thomas, [...] > > So are you going to apply this patch? > Right now acl just can't be used properly in case of static library build. Got it. I have suggested a small rework in another mail. Then I'll apply it promptly.

[dpdk-dev] [PATCH 0/3] vhost coverity issue fixes

2016-06-30 Thread Mcnamara, John
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Tuesday, June 28, 2016 4:58 AM > To: dev at dpdk.org > Cc: Xie, Huawei ; Mcnamara, John > ; Yuanhan Liu > Subject: [PATCH 0/3] vhost coverity issue fixes > > This is a small series fixes 3 coverity

[dpdk-dev] [PATCH] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
On 30/06/2016 16:28, Thomas Monjalon wrote: > 2016-06-30 15:02, Sergio Gonzalez Monroy: >> On 30/06/2016 13:44, Thomas Monjalon wrote: >>> 2016-06-30 13:04, Sergio Gonzalez Monroy: On 30/06/2016 12:38, Thomas Monjalon wrote: > Does it need to be commented in rte.app.mk? > The other

[dpdk-dev] [PATCH v2] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
Since below commit, ACL library is outside the scope of --whole-archive and ACL autotest fails. RTE>>acl_autotest ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid Line 1584: SSE classify with zero categories failed!

[dpdk-dev] [PATCH v2] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 17:01, Sergio Gonzalez Monroy: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG)+= > -lrte_ip_frag > _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter > _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched >

[dpdk-dev] [PATCH v3] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
Since below commit, ACL library is outside the scope of --whole-archive and ACL autotest fails. RTE>>acl_autotest ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid Line 1584: SSE classify with zero categories failed!

[dpdk-dev] [PATCH v2] mk: fix acl library static linking

2016-06-30 Thread Sergio Gonzalez Monroy
On 30/06/2016 17:10, Thomas Monjalon wrote: > 2016-06-30 17:01, Sergio Gonzalez Monroy: >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG)+= >> -lrte_ip_frag >> _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter >>

[dpdk-dev] [PATCH v2] mk: fix acl library static linking

2016-06-30 Thread Thomas Monjalon
2016-06-30 17:14, Sergio Gonzalez Monroy: > On 30/06/2016 17:10, Thomas Monjalon wrote: > > 2016-06-30 17:01, Sergio Gonzalez Monroy: > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > >> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG)+= > >> -lrte_ip_frag > >>

[dpdk-dev] [PATCH] jobstats: Fix a typo in rte_jobstat.h.

2016-06-30 Thread Thomas Monjalon
2016-04-20 23:04, Rami Rosen: > jobstats: max_exec_time represents Maximum execute time and not > Minimum execute time. > > Signed-off-by: Rami Rosen Applied, thanks

[dpdk-dev] [PATCH v2] mem: revert page locking when not using hugepages

2016-06-30 Thread Thomas Monjalon
2016-06-27 17:58, Olivier Matz: > This reverts commit 593a084afc2b441895aeca78a2c4465e450d0ef5. > > Since recently [1], it is not possible to run the dpdk with > non-root privileges and the --no-huge option. This is because the eal > layer tries to lock the memory. Using locked memory is

[dpdk-dev] [PATCH] app/testpmd: limit number of forwarding cores

2016-06-30 Thread Thomas Monjalon
2016-06-28 10:41, N?lio Laranjeiro: > On Mon, Jun 27, 2016 at 11:35:19PM +0100, Pablo de Lara wrote: > > Number of forwarding cores must be equal or less than > > number of forwarding streams, otherwise two cores > > would try to use a same queue on a port, which is not allowed. > > > > Fixes:

[dpdk-dev] [PATCH v3] mempool: replace c memcpy code semantics with optimized rte_memcpy

2016-06-30 Thread Thomas Monjalon
2016-06-30 17:46, Jerin Jacob: > Signed-off-by: Jerin Jacob > Acked-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH v4 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread Hunt, David
On 30/6/2016 10:45 AM, Thomas Monjalon wrote: > Hi David, > > There is a compilation error: > > app/test/test_mempool.c:598:6: error: > too few arguments to function ?test_mempool_basic? > > Please send a v5, thanks. Thomas, after the second commit patch-set is applied, there should only be

[dpdk-dev] [PATCH v4 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread Thomas Monjalon
2016-06-30 18:36, Hunt, David: > On 30/6/2016 10:45 AM, Thomas Monjalon wrote: > > Hi David, > > > > There is a compilation error: > > > > app/test/test_mempool.c:598:6: error: > > too few arguments to function ?test_mempool_basic? > > > > Please send a v5, thanks. > > Thomas, after the second

[dpdk-dev] [PATCH v4 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread Hunt, David
On 30/6/2016 6:46 PM, Thomas Monjalon wrote: > 2016-06-30 18:36, Hunt, David: >> On 30/6/2016 10:45 AM, Thomas Monjalon wrote: >>> Hi David, >>> >>> There is a compilation error: >>> >>> app/test/test_mempool.c:598:6: error: >>> too few arguments to function ?test_mempool_basic? >>> >>> Please

[dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

2016-06-30 Thread Thomas Monjalon
> Hi Thomas, > > I got the duplicates with following command [1], does it make sense to > add this into one of the check scripts, -not sure which one? > > [1] > # for m in $(find . -name *_version.map); do for l in $(cat $m | sort | > uniq -d | grep -v global | grep -v local); do ll=$(echo $l |

[dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map

2016-06-30 Thread Thomas Monjalon
2016-06-27 14:02, Ferruh Yigit: > Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type") > Signed-off-by: Ferruh Yigit Series applied, thanks

[dpdk-dev] [PATCH v1] doc: autogenerate nic overview table from ini files

2016-06-30 Thread John McNamara
This patch converts the NIC feature table in the overview doc into a set of ini files and adds some functions into the Sphinx conf.py file to convert them back into an RST table. The reason for doing this is to make it easier for PMD maintainers to update the feature matrix that makes up the

[dpdk-dev] [PATCH v1] doc: autogenerate nic overview table from ini files

2016-06-30 Thread John McNamara
Convert the NIC feature table in the overview doc into a set of ini files and add functions into the Sphinx conf.py file to auto-generate them back into an RST table. The reason for doing this is to make it easier for PMD maintainers to update the feature matrix that makes up the table and to

[dpdk-dev] [PATCH v5 0/2] mempool: add stack mempool handler

2016-06-30 Thread David Hunt
This patch set adds a lifo stack handler to the external mempool manager. This patch utilises the mempool handler feature which allows the addition of new mempool handlers to DPDK. v5 changes: * Added the extra parameter requred for the test_mempool_basic() function, which has changed due

[dpdk-dev] [PATCH v5 1/2] mempool: add stack (lifo) mempool handler

2016-06-30 Thread David Hunt
This is a mempool handler that is useful for pipelining apps, where the mempool cache doesn't really work - example, where we have one core doing rx (and alloc), and another core doing Tx (and return). In such a case, the mempool ring simply cycles through all the mbufs, resulting in a LLC miss on

[dpdk-dev] [PATCH v5 2/2] test: migrate custom handler test to stack handler

2016-06-30 Thread David Hunt
After introducing the stack handler in the previous commit, we now have very similar code to the custom handler in test_mempool.c, which creates a custom mempool based on simple mallocs. The stack handler is a cleaner example of adding a new mempool handler, so this commit replaces the custom

[dpdk-dev] [PATCH v1] doc: autogenerate nic overview table from ini files

2016-06-30 Thread Thomas Monjalon
2016-06-30 19:03, John McNamara: > This patch converts the NIC feature table in the overview doc into a set of > ini files and adds some functions into the Sphinx conf.py file to convert them > back into an RST table. > > The reason for doing this is to make it easier for PMD maintainers to

[dpdk-dev] ix40e driver issue DPDK2.2 - maximum TX rate is 20MPPS

2016-06-30 Thread Hanoch Haim (hhaim)
Hi, We have a DPDK 2.2 application and on specific server types with ix40e driver we have an issue that we can't push more 20MPPS on Tx. (SW gets back pressure from software queue, in other words the NIC is not happy) Moving to 16.4 fix the issue. Wanted to identify this specific issue throw

[dpdk-dev] [PATCH] bnx2x: set random MAC address if one isn't assigned

2016-06-30 Thread Rasesh Mody
> From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Wednesday, June 29, 2016 3:56 AM > > On Tue, Jun 21, 2016 at 08:18:46AM -0400, Chas Williams wrote: > > If the PF hasn't assigned an address, assign one randomly. While > > here, convert to use DPDK's ether address utility

[dpdk-dev] [PATCH] bnx2x: Call bnx2x_init_rte() later

2016-06-30 Thread Rasesh Mody
> From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Wednesday, June 29, 2016 3:59 AM > > On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote: > > We need sc->igu_sb_cnt determined before calculating the number of > > queues we can support. > > > > Fixes: a787538ee754

[dpdk-dev] [PATCH v3] mempool: rename functions with confusing names

2016-06-30 Thread Thomas Monjalon
2016-06-30 13:49, Bruce Richardson: > The mempool_count and mempool_free_count behaved contrary to what their > names suggested. The free_count function actually returned the number of > elements that were allocated from the pool, not the number unallocated as > the name implied. > > Fix this by