[dpdk-dev] [PATCH v2 00/12] net/virtio: add offload support

2016-10-12 Thread Yuanhan Liu
On Tue, Oct 11, 2016 at 02:14:10PM +0200, Olivier MATZ wrote: > Hi Yuanhan, > > On 10/11/2016 01:35 PM, Yuanhan Liu wrote: > >Hi, > > > >Firstly, apologize for so late review. It's been forgotten :( > > > >BTW, please feel free to ping me in future if I made no response > >in one or two weeks! >

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-12 Thread Jerin Jacob
Thanks to Intel and NXP folks for the positive and constructive feedback I've received so far. Here is the updated RFC(v2). I've attempted to address as many comments as possible. This series adds rte_eventdev.h to the DPDK tree with adequate documentation in doxygen format. Updates are also

[dpdk-dev] [PATCH] net/i40e: add additional prefetch instructions for bulk rx

2016-10-12 Thread Ananyev, Konstantin
Hi Vladislav, > > > > > > > > > > On 7/14/2016 6:27 PM, Vladyslav Buslov wrote: > > > > > > Added prefetch of first packet payload cacheline in > > > > > > i40e_rx_scan_hw_ring Added prefetch of second mbuf cacheline in > > > > > > i40e_rx_alloc_bufs > > > > > > > > > > > > Signed-off-by:

[dpdk-dev] [PATCH] hash: fix unlimited cuckoo path

2016-10-12 Thread Pablo de Lara
When trying to insert a new entry, if its target bucket is full, the alternative location (bucket) of one of the entries is checked, to try to find an empty slot, with make_space_bucket. This function is called every time a new bucket is checked, recursively. To avoid having a very long insert

[dpdk-dev] [PATCH] hash: fix unlimited cuckoo path

2016-10-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, October 11, 2016 5:43 PM > To: dev at dpdk.org > Cc: Richardson, Bruce; De Lara Guarch, Pablo > Subject: [PATCH] hash: fix unlimited cuckoo path > > When trying to insert a new entry, if its target bucket is full, > the

[dpdk-dev] [PATCH v2] hash: fix unlimited cuckoo path

2016-10-12 Thread Pablo de Lara
When trying to insert a new entry, if its target bucket is full, the alternative location (bucket) of one of the entries is checked, to try to find an empty slot, with make_space_bucket. This function is called every time a new bucket is checked, recursively. To avoid having a very long insert

[dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G and 50G speeds

2016-10-12 Thread De Lara Guarch, Pablo
Hi, > From: Ajit Khaparde [mailto:ajit.khaparde at broadcom.com] > Sent: Monday, October 10, 2016 11:41 AM > To: Yigit, Ferruh > Cc: dev at dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G > and 50G speeds > > On Mon, Oct 10, 2016 at

[dpdk-dev] [PATCH] hash: fix incorrect bucket size usage

2016-10-12 Thread Pablo de Lara
Multiwriter insert function was using a fixed value for the bucket size, instead of using the RTE_HASH_BUCKET_ENTRIES macro, which value was changed recently (making it inconsistent in this case). Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Signed-off-by:

[dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Tuesday, October 11, 2016 9:35 AM > To: Thomas Monjalon > Cc: Yigit, Ferruh; dev at dpdk.org; Shah, Rahul R; Lu, Wenzhuo; > az5157 at att.com > Subject: Re: [dpdk-dev] [PATCH v7

[dpdk-dev] ZUC PMD as shared library

2016-10-12 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Saturday, October 08, 2016 10:19 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: ZUC PMD as shared library > > Hi Pablo, > > You are probably aware of the issue, but I

[dpdk-dev] [RFC v2] Generic flow director/filtering/classification API

2016-10-12 Thread Zhao1, Wei
Hi Adrien Mazarguil, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Tuesday, October 11, 2016 4:21 PM > To: Zhao1, Wei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC v2] Generic flow > director/filtering/classification > API > > Hi

[dpdk-dev] [PATCH 2/5] i40e: implement vector PMD for ARM architecture

2016-10-12 Thread Zhang, Qi Z
Hi Jianbo: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jianbo Liu > Sent: Wednesday, August 24, 2016 5:54 PM > To: Zhang, Helin ; Wu, Jingjing > ; jerin.jacob at caviumnetworks.com; dev at dpdk.org > Cc: Jianbo Liu > Subject: [dpdk-dev] [PATCH 2/5]

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Yuanhan Liu
On Thu, Sep 22, 2016 at 01:47:45PM +0800, Jianbo Liu wrote: > On 22 September 2016 at 10:29, Yuanhan Liu > wrote: > > On Wed, Sep 21, 2016 at 08:54:11PM +0800, Jianbo Liu wrote: > >> >> > My setup consists of one host running a guest. > >> >> > The guest generates as much 64bytes packets as

[dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver

2016-10-12 Thread Zhang, Qi Z
Hi Jianbo > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jianbo Liu > Sent: Wednesday, August 24, 2016 5:54 PM > To: Zhang, Helin ; Wu, Jingjing > ; jerin.jacob at caviumnetworks.com; dev at dpdk.org > Cc: Jianbo Liu > Subject: [dpdk-dev] [PATCH 1/5] i40e:

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-12 Thread Yuanhan Liu
On Tue, Oct 11, 2016 at 02:57:49PM +0800, Yuanhan Liu wrote: > > > > > > There was an example: the vhost enqueue optmization patchset from > > > > > > Zhihong [0] uses memset, and it introduces more than 15% drop (IIRC) Though it doesn't matter now, but I have verified it yesterday (with and

[dpdk-dev] [PATCH v3] test_cryptodev_perf: IV and digest should be stored at a DMAeble address

2016-10-12 Thread akhil.go...@nxp.com
From: Akhil Goyal For physical crypto devices, IV and digest are processed by the crypto device which need the contents to be written on some DMA able address. So in order to do that, IV and digest are accomodated in the packet. Signed-off-by: Akhil Goyal v2: patch

[dpdk-dev] [PATCH v2 0/3] fix flow director mask issues

2016-10-12 Thread Wenzhuo Lu
There're 2 issues about flow director mask. 1, MAC address mask is not supported in mac-vlan mode. 2, All the parameter are defined as big endian, but they're not treated approriately. This patch set is used to fix these 2 issues. v2: - Re-split the patches and reword commit log. No code

[dpdk-dev] [PATCH v2 1/3] ixgbe: fix wrong flow director mask

2016-10-12 Thread Wenzhuo Lu
In mac-vlan mode, MAC address mask is not supported by HW. The MAC address mask should not be set in mac-vlan mode. Instead, only set it in tunnel mode. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_fdir.c | 10

[dpdk-dev] [PATCH v2 3/3] app/testpmd: fix flow director endian issue

2016-10-12 Thread Wenzhuo Lu
The vlan mask and tunnel id mask of flow director are defined as big endian. So they should be converted. When the mask is printed, the parameters are not converted either. This patch converts the mask parameters. Some lines of the mask print are too long, split them to more lines. Fixes:

[dpdk-dev] [PATCH v2 2/3] app/testpmd: fix wrong flow director mask

2016-10-12 Thread Wenzhuo Lu
In mac-vlan mode, MAC address mask is not supported by HW. The MAC address mask should not be set in mac-vlan mode. Remove this parameter from the CLI. Remove MAC address from mask print too. Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands") Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-12 Thread Thomas Monjalon
2016-10-11 14:46, John Ousterhout: > All of your suggestions look reasonable and fairly straightforward; I'll > work on a new patch that includes them. > > Given that rte_eal_log_init is a no-op (and won't even be invoked), would > it be better to remove that function completely, and even delete

[dpdk-dev] ZUC PMD as shared library

2016-10-12 Thread Thomas Monjalon
2016-10-12 02:23, De Lara Guarch, Pablo: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > Hi Pablo, > > > > You are probably aware of the issue, but I would like to make it clear > > in case someone else run into the same trouble: > > > > It is impossible to

[dpdk-dev] Project Governance and Linux Foundation

2016-10-12 Thread Thomas Monjalon
Hi, This is a really interesting use case. Questions below, 2016-10-12 13:44, qin.chunhua at zte.com.cn: > ZTE is supportive of improving the DPDK project governance including > moving the project to the Linux Foundation. > DPDK has been used in lots of ZTE's equipments and solutions such as

[dpdk-dev] [PATCH v3 0/7] vhost: add dequeue zero copy support

2016-10-12 Thread Yuanhan Liu
On Sun, Oct 09, 2016 at 03:27:53PM +0800, Yuanhan Liu wrote: > This patch set enables vhost dequeue zero copy. The majority work goes > to patch 4: "vhost: add dequeue zero copy". Applied to dpdk-next-virtio. --yliu > > The basic idea of dequeue zero copy is, instead of copying data

[dpdk-dev] [PATCH v4] drivers/net:new PMD using tun/tap host interface

2016-10-12 Thread Michał Mirosław
2016-10-11 22:56 GMT+02:00 Wiles, Keith : >> On Oct 11, 2016, at 6:30 AM, Micha? Miros?aw wrote: >> >> 2016-10-04 16:45 GMT+02:00, Keith Wiles : >>> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces >>> on the local host. The PMD allows for DPDK and the host to >>> communicate using

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix verify with decrypt in chain

2016-10-12 Thread Piotr Azarewicz
This patch fix setting crypto operation data parameters in l2fwd-crypto application. >From now decryption in chain with auth verify work fine. How to reproduce the issue: 1. Run l2fwd_crypto with command: -c 0x3 -n 4 --vdev "crypto_aesni_mb" \ --vdev "crypto_aesni_mb" \ -- -p 0x3 --chain

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, October 12, 2016 10:53 AM > To: Wang, Zhihong ; Jianbo Liu linaro.org> > Cc: Maxime Coquelin ; dev at dpdk.org; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize

[dpdk-dev] [PATCH v3] mk: gcc -march support for intel processors code names

2016-10-12 Thread Thomas Monjalon
2016-10-10 22:33, Reshma Pattan: > The GCC 4.9 -march option supports the intel code names for processors, > for example -march=silvermont, -march=broadwell. > The RTE_MACHINE config flag can be used to pass code name to > the compiler as -march flag. > > Release notes is updated. > > Linux and

[dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call

2016-10-12 Thread Thomas Monjalon
2016-10-10 22:44, Remy Horton: > > On 10/10/2016 15:35, Reshma Pattan wrote: > [..] > > Fixes: e4ffa2d3 ("pdump: fix error handlings") > > Fixes: bdd8dcc6 ("pdump: fix default socket path") > > > > Reported-by: Jianfeng Tan > > Signed-off-by: Reshma Pattan > > --- > >

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

2016-10-12 Thread Yuanhan Liu
On Wed, Oct 05, 2016 at 03:27:47PM +0200, Maxime Coquelin wrote: > >/* Update offload features */ > >- if (virtio_rx_offload(rxm, hdr) < 0) { > >+ if ((features & VIRTIO_NET_F_GUEST_CSUM) && > s/VIRTIO_NET_F_GUEST_CSUM/(1u << VIRTIO_NET_F_GUEST_CSUM)/

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-12 Thread Ilya Maximets
On 07.10.2016 05:02, Eric Kinzie wrote: > On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote: >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. >> >> It is necessary to reconfigure all queues every time because configuration >> can be changed. >> >> For example, if we're

[dpdk-dev] [PATCH] dpdk-procinfo: free allocated xstats memory upon failure

2016-10-12 Thread Thomas Monjalon
2016-10-04 17:42, Reshma Pattan: > Some of the failures cases inside the nic_xstats_display() > function doesn't free the allocated memory for the xstats and > their names, memory is freed now. > > Fixes: e2aae1c1 ("ethdev: remove name from extended statistic fetch") > Fixes: 22561383 ("app:

[dpdk-dev] [PATCH] dpdk-procinfo: free allocated xstats memory upon failure

2016-10-12 Thread Remy Horton
On 04/10/2016 17:42, Reshma Pattan wrote: > Some of the failures cases inside the nic_xstats_display() > function doesn't free the allocated memory for the xstats and > their names, memory is freed now. > > Fixes: e2aae1c1 ("ethdev: remove name from extended statistic fetch") > Fixes: 22561383

[dpdk-dev] [PATCH v3] mk: gcc -march support for intel processors code names

2016-10-12 Thread Pattan, Reshma
Hi > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 12, 2016 1:34 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] mk: gcc -march support for intel processors > code names > > 2016-10-10

[dpdk-dev] [PATCH v3] mk: gcc -march support for intel processors code names

2016-10-12 Thread Thomas Monjalon
2016-10-12 13:38, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-10-10 22:33, Reshma Pattan: > > > The GCC 4.9 -march option supports the intel code names for > > > processors, for example -march=silvermont, -march=broadwell. > > > The RTE_MACHINE config

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-12 Thread Yuanhan Liu
On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: > @@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) > { > const struct rte_eth_rxmode *rxmode = >data->dev_conf.rxmode; > struct virtio_hw *hw = dev->data->dev_private; > + uint64_t req_features; >

[dpdk-dev] [PATCH v5] drivers/net:new PMD using tun/tap host interface

2016-10-12 Thread Ferruh Yigit
On 10/11/2016 10:51 PM, Keith Wiles wrote: > The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > on the local host. The PMD allows for DPDK and the host to > communicate using a raw device interface on the host and in > the DPDK application. The device created is a Tap device with >

[dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Pablo, > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new > > API's > > > > Hi Thomas, > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests > > > > > for new API's > > > > > > > > > > 2016-10-11 16:09, Ferruh Yigit: > > > > > > This

[dpdk-dev] [PATCH v2] hash: fix unlimited cuckoo path

2016-10-12 Thread Thomas Monjalon
2016-10-12 01:50, Pablo de Lara: > When trying to insert a new entry, if its target bucket is full, > the alternative location (bucket) of one of the entries is checked, > to try to find an empty slot, with make_space_bucket. > This function is called every time a new bucket is checked,

[dpdk-dev] [PATCH v8 0/2] add API's for VF management

2016-10-12 Thread Bernard Iremonger
This patchset contains new DPDK API's for use with the Virtual Function Daemon (VFD). The need to configure and manage VF's on a NIC has grown to the point where a DPDK based tool, VFD, has been developed to do this. This patch set adds API extensions to DPDK for VF configuration. Eight new

[dpdk-dev] [PATCH v8 1/2] net/ixgbe: add API's for VF management

2016-10-12 Thread Bernard Iremonger
Add API's to configure and manage VF's on an Intel 82559 NIC. add rte_pmd_ixgbe_set_vf_vlan_anti_spoof function. add rte_pmd_ixgbe_set_vf_mac_anti_spoof function. add rte_pmd_ixgbe_set_vf_stripq function. Signed-off-by: Alex Zelezniak add rte_pmd_ixgbe_set_vf_vlan_insert function. add

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Bernard Iremonger
add test for set vf vlan anti spoof add test for set vf mac anti spoof add test for set vf vlan stripq add test for set vf vlan insert add test for set tx loopback add test for set all queues drop enable bit add test for set vf split drop enable bit add test for set vf mac address add new API's to

[dpdk-dev] [PATCH] hash: fix incorrect bucket size usage

2016-10-12 Thread Thomas Monjalon
2016-10-12 02:26, Pablo de Lara: > Multiwriter insert function was using a fixed value for > the bucket size, instead of using the > RTE_HASH_BUCKET_ENTRIES macro, which value was changed > recently (making it inconsistent in this case). > > Fixes: be856325cba3 ("hash: add scalable multi-writer

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Thomas Monjalon
2016-10-12 16:03, Bernard Iremonger: > --- a/app/test-pmd/Makefile > +++ b/app/test-pmd/Makefile > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c > SRCS-y += icmpecho.c > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) >

[dpdk-dev] [PATCH v4] net/mlx5: return RSS hash result in mbuf

2016-10-12 Thread Bruce Richardson
On Wed, Sep 28, 2016 at 02:11:18PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Applied to dpdk-next-net/rel_16_11 /Bruce

[dpdk-dev] [PATCH v3] doc: add limitations for i40e PMD

2016-10-12 Thread Bruce Richardson
On Fri, Sep 30, 2016 at 03:09:53PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Wu, Jingjing > > Sent: Friday, September 30, 2016 7:46 AM > > To: dev at dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Mcnamara, John > > Subject: [PATCH v3] doc: add limitations

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-12 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 04:24:54PM +0300, Ilya Maximets wrote: > On 07.10.2016 05:02, Eric Kinzie wrote: > > On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote: > >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > >> > >> It is necessary to reconfigure all queues every time

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > API's > > 2016-10-12 16:03, Bernard Iremonger: > > --- a/app/test-pmd/Makefile > > +++ b/app/test-pmd/Makefile > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c > >

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-12 Thread Thomas Monjalon
Sorry guys, you lost me in the discussion. Is there some regression only on ARM? Does it need some work specifically on memcpy for ARM, or vhost for ARM? Who can work on ARM optimization? More comments below. 2016-10-12 12:22, Wang, Zhihong: > From: Yuanhan Liu [mailto:yuanhan.liu at

[dpdk-dev] [PATCH 1/2] net/bonding: validate speed after link up

2016-10-12 Thread Bruce Richardson
On Wed, Oct 05, 2016 at 12:53:00PM +, Iremonger, Bernard wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eric Kinzie > > Sent: Thursday, August 4, 2016 7:25 PM > > To: dev at dpdk.org > > Cc: Jan Blunck > > Subject: [dpdk-dev] [PATCH 1/2]

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Thomas Monjalon
2016-10-12 15:27, Iremonger, Bernard: > Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > > API's > > > > 2016-10-12 16:03, Bernard Iremonger: > > > --- a/app/test-pmd/Makefile > > > +++ b/app/test-pmd/Makefile > > > @@ -58,6 +58,17 @@ SRCS-y +=

[dpdk-dev] [PATCH v6 0/8] Misc enhancements in testpmd

2016-10-12 Thread Olivier Matz
This patchset introduces several enhancements or minor fixes in testpmd. It is targetted for v16.11, and applies on top of software ptype v2 patchset [1]. These patches are useful to validate the virtio offload patchset [2] (to be rebased). [1]

[dpdk-dev] [PATCH v6 1/8] mbuf: add function to dump ol flag list

2016-10-12 Thread Olivier Matz
The functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() can dump one flag, or set of flag that are part of the same mask (ex: PKT_TX_UDP_CKSUM, part of PKT_TX_L4_MASK). But they are not designed to dump the list of flags contained in mbuf->ol_flags. This commit introduce new

[dpdk-dev] [PATCH v6 3/8] app/testpmd: dump Rx flags in csum engine

2016-10-12 Thread Olivier Matz
Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/csumonly.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 2ecd6b8..42974d5 100644 --- a/app/test-pmd/csumonly.c +++

[dpdk-dev] [PATCH v6 4/8] app/testpmd: add option to enable lro

2016-10-12 Thread Olivier Matz
Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO feature on enabled ports, like it's done for '--enable-rx-cksum' for instance. Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/parameters.c | 4 doc/guides/testpmd_app_ug/run_app.rst

[dpdk-dev] [PATCH v6 5/8] app/testpmd: do not change ip addrs in csum engine

2016-10-12 Thread Olivier Matz
The csum forward engine was updated to change the IP addresses in the packet data in commit 51f694dd40f5 ("app/testpmd: rework checksum forward engine") This was done to ensure that the checksum is correctly reprocessed when using hardware checksum offload. But the functions

[dpdk-dev] [PATCH v6 8/8] app/testpmd: hide segsize when unrelevant in csum engine

2016-10-12 Thread Olivier Matz
When TSO is not asked, hide the segment size. Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index d51d85a..f9e65b6 100644 ---

[dpdk-dev] [PATCH v6 2/8] app/testpmd: use new function to dump offload flags

2016-10-12 Thread Olivier Matz
Use the functions introduced in the previous commit to dump the offload flags. Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/csumonly.c | 31 +++ app/test-pmd/rxonly.c | 15 ++- 2 files changed, 5 insertions(+), 41 deletions(-)

[dpdk-dev] [PATCH v6 6/8] app/testpmd: display Rx port in csum engine

2016-10-12 Thread Olivier Matz
This information is useful when debugging, especially with bidirectional traffic. Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/csumonly.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index

[dpdk-dev] [PATCH v6 7/8] app/testpmd: don't use tso if packet is too small

2016-10-12 Thread Olivier Matz
Asking for TSO (TCP Segmentation Offload) on packets that are already smaller than (headers + MSS) does not work, for instance on ixgbe. Fix the csumonly engine to only set the TSO flag when a segmentation offload is really required, i.e. when packet is large enough. Signed-off-by: Olivier Matz

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > API's > > 2016-10-12 15:27, Iremonger, Bernard: > > Hi Thomas, > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for > > > new API's > > > > > > 2016-10-12 16:03, Bernard

[dpdk-dev] [PATCH v4 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-12 Thread Bruce Richardson
On Thu, Oct 06, 2016 at 03:28:39PM +, Chen, Jing D wrote: > > > -Original Message- > > From: Shaw, Jeffrey B > > Sent: Wednesday, October 5, 2016 11:38 PM > > To: dev at dpdk.org > > Cc: Zhang, Helin ; Wu, Jingjing > > ; damarion at cisco.com; Zhang, Qi Z > > ; Chen, Jing D > >

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

2016-10-12 Thread Olivier MATZ
On 10/12/2016 03:02 PM, Yuanhan Liu wrote: > On Wed, Oct 05, 2016 at 03:27:47PM +0200, Maxime Coquelin wrote: >>> /* Update offload features */ >>> - if (virtio_rx_offload(rxm, hdr) < 0) { >>> + if ((features & VIRTIO_NET_F_GUEST_CSUM) && >>

[dpdk-dev] [PATCH v2 00/15] Add support for secondary queue set in nicvf thunderx driver

2016-10-12 Thread Bruce Richardson
On Fri, Sep 30, 2016 at 02:05:39PM +0200, Kamil Rytarowski wrote: > This series of patches adds support for secondary queue set in nicvf thunderx > driver > > There are two types of VFs: > - Primary VF > - Secondary VF > > Each port consist of a primary VF and n secondary VF(s). Each VF

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-12 Thread Olivier MATZ
Hello Yuanhan, On 10/12/2016 04:41 PM, Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: >> @@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) >> { >> const struct rte_eth_rxmode *rxmode = >data->dev_conf.rxmode; >> struct virtio_hw

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Thomas Monjalon
2016-10-12 15:48, Iremonger, Bernard: > Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > > API's > > > > 2016-10-12 15:27, Iremonger, Bernard: > > > Hi Thomas, > > > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests

[dpdk-dev] [PATCH] net/mlx: align drivers to latest naming convention

2016-10-12 Thread Bruce Richardson
On Fri, Oct 07, 2016 at 03:24:27PM +0200, Adrien Mazarguil wrote: > On Fri, Oct 07, 2016 at 03:04:13PM +0200, David Marchand wrote: > > Fixes: 2f45703c17ac ("drivers: make driver names consistent") > > > > Signed-off-by: David Marchand > Acked-by: Adrien Mazarguil > Applied to

[dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf

2016-10-12 Thread Bruce Richardson
On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley > > Sent: Thursday, September 29, 2016 9:55 PM > > To: Richardson, Bruce > > Cc: dev at dpdk.org; Nelson Escobar > > Subject:

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests > > > > > for new API's > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > --- a/app/test-pmd/Makefile > > > > > > +++ b/app/test-pmd/Makefile > > > > > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c

[dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters

2016-10-12 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 09:25:45AM +, John Daley (johndale) wrote: > > > > -Original Message- > > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > > Sent: Tuesday, October 11, 2016 2:22 AM > > To: John Daley (johndale) ; > > bruce.richardson at intel.com > > Cc: dev at

[dpdk-dev] [dpdk-stable] [PATCH v2 1/4] net/ena: improve safety of string handling in ena_config_host_info

2016-10-12 Thread Ferruh Yigit
On 9/29/2016 6:39 PM, John W. Linville wrote: > Use sizeof dest rather than sizeof src for limiting copy length, > and replace strncpy with snprintf to ensure NULL termination. > > Coverity issue: 127795 > Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device > info") > >

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Thomas Monjalon
2016-10-12 16:21, Iremonger, Bernard: > Hi Thomas, > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests > > > > > > for new API's > > > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > > --- a/app/test-pmd/Makefile > > > > > > > +++

[dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues

2016-10-12 Thread Bruce Richardson
On Wed, Oct 05, 2016 at 10:36:36PM -0700, Rasesh Mody wrote: > Fix the max number of PF rx/tx queues. Set the value based > on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128. > > Fixes: 540a211 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody > --- Series applied to

[dpdk-dev] [PATCH v6 0/8] Misc enhancements in testpmd

2016-10-12 Thread Thomas Monjalon
2016-10-12 17:39, Olivier Matz: > This patchset introduces several enhancements or minor fixes > in testpmd. It is targetted for v16.11, and applies on top of > software ptype v2 patchset [1]. > > These patches are useful to validate the virtio offload > patchset [2] (to be rebased). Applied,

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Thomas, > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add > > > > > > > tests for new API's > > > > > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > > > --- a/app/test-pmd/Makefile > > > > > > > > +++ b/app/test-pmd/Makefile > > > > > > > > @@ -58,6

[dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains

2016-10-12 Thread Kamil Rytarowski
W dniu 11.10.2016 o 18:52, David Marchand pisze: > On Tue, Oct 11, 2016 at 3:49 PM, Kamil Rytarowski > wrote: >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 382c959..01d5fb0 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++

[dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Iremonger, Bernard
Hi Thomas, > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add > > > > > > > > tests for new API's > > > > > > > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > > > > --- a/app/test-pmd/Makefile > > > > > > > > > +++ b/app/test-pmd/Makefile > > > > > > >

[dpdk-dev] [PATCH v9 0/2] add API's for VF management

2016-10-12 Thread Bernard Iremonger
This patchset contains new DPDK API's for use with the Virtual Function Daemon (VFD). The need to configure and manage VF's on a NIC has grown to the point where a DPDK based tool, VFD, has been developed to do this. This patch set adds API extensions to DPDK for VF configuration. Eight new

[dpdk-dev] [PATCH v9 1/2] net/ixgbe: add API's for VF management

2016-10-12 Thread Bernard Iremonger
Add API's to configure and manage VF's on an Intel 82559 NIC. add rte_pmd_ixgbe_set_vf_vlan_anti_spoof function. add rte_pmd_ixgbe_set_vf_mac_anti_spoof function. add rte_pmd_ixgbe_set_vf_stripq function. Signed-off-by: Alex Zelezniak add rte_pmd_ixgbe_set_vf_vlan_insert function. add

[dpdk-dev] [PATCH v9 2/2] app/test_pmd: add tests for new API's

2016-10-12 Thread Bernard Iremonger
add test for set vf vlan anti spoof add test for set vf mac anti spoof add test for set vf vlan stripq add test for set vf vlan insert add test for set tx loopback add test for set all queues drop enable bit add test for set vf split drop enable bit add test for set vf mac address add new API's to

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-12 Thread John Daley
Remove an RTE_ASSERT which will not compile if enabled and is not needed. Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters") Signed-off-by: John Daley --- Would have been nice if I caught this yesterday before you applied a1f7c7b3 :( drivers/net/enic/enic_clsf.c |

[dpdk-dev] [PATCH v5] drivers/net:new PMD using tun/tap host interface

2016-10-12 Thread Wiles, Keith
Regards, Keith > On Oct 12, 2016, at 9:56 AM, Yigit, Ferruh wrote: > > On 10/11/2016 10:51 PM, Keith Wiles wrote: >> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces >> on the local host. The PMD allows for DPDK and the host to >> communicate using a raw device interface on the

[dpdk-dev] [PATCH v3] test_cryptodev_perf: IV and digest should be stored at a DMAeble address

2016-10-12 Thread Trahe, Fiona
> -Original Message- > From: akhil.goyal at nxp.com [mailto:akhil.goyal at nxp.com] > Sent: Wednesday, October 12, 2016 12:16 PM > To: Kusztal, ArkadiuszX ; Doherty, Declan > > Cc: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K ; > dev at dpdk.org; Akhil Goyal > Subject: [PATCH v3]

[dpdk-dev] [PATCH v3] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-12 Thread John Ousterhout
Before this patch, application-specific loggers could not be installed before rte_eal_init completed (the initialization process called rte_openlog_stream, overwriting any previously installed logger). This made it impossible for an application to capture the initial log messages generated during

[dpdk-dev] [PATCH v4] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-12 Thread John Ousterhout
Before this patch, application-specific loggers could not be installed before rte_eal_init completed (the initialization process called rte_openlog_stream, overwriting any previously installed logger). This made it impossible for an application to capture the initial log messages generated during

[dpdk-dev] [PATCH v4] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-12 Thread Thomas Monjalon
2016-10-12 12:38, John Ousterhout: > @@ -127,6 +125,19 @@ rte_vlog(uint32_t level, uint32_t logtype, const char > *format, va_list ap) > { > int ret; > FILE *f = rte_logs.file; > + if (f == NULL) { > + f = default_log_stream; > + if (f == NULL) { > +

[dpdk-dev] [PATCH v5] drivers/net:new PMD using tun/tap host interface

2016-10-12 Thread Wiles, Keith
Regards, Keith > On Oct 12, 2016, at 1:19 PM, Wiles, Keith wrote: > > > Regards, > Keith > >> On Oct 12, 2016, at 9:56 AM, Yigit, Ferruh wrote: >> >>> + >>> +static void >>> +tap_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *tap_stats) >>> +{ >>> + unsigned i, imax; >> >>

[dpdk-dev] [PATCH] mempool: Add sanity check when secondary link in less mempools than primary

2016-10-12 Thread Jean Tourrilhes
mempool: Add sanity check when secondary link in less mempools than primary If the primary and secondary process were build using different build systems, the list of constructors included by the linker in each binary might be different. Mempools are registered via constructors, so the linker

[dpdk-dev] [PATCH 0/3] changes for enabling cuckoo hash into table library

2016-10-12 Thread Thomas Monjalon
> > From: Guruprasad Rao > > Acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH 1/2] net/enic: fix error in init of RQ when not using Rx scatter

2016-10-12 Thread John Daley
From: Nelson Escobar The Rx scatter patch was accidentally setting the index of the secondary receive queue in the primary receive queue's initialization when the secondary receive queue wasn't needed and was disabled. This caused some misleading hardware counters in some

[dpdk-dev] [PATCH 2/2] net/enic: revert "fix calculation of truncated packets"

2016-10-12 Thread John Daley
From: Nelson Escobar The reason this commit was needed was because of a misconfiguration of the receive queue when not using Rx scatter. This patch is unnecessary if the receive queue is configured correctly. Fixes: d142e1ac1089 ("net/enic: fix calculation of truncated

[dpdk-dev] [PATCH 2/2] examples/ip_pipeline: modify source port default parameter

2016-10-12 Thread Thomas Monjalon
> > The default value of ``file_name`` parameter of the source port structure is > > changed from ``NULL`` to ``./config/packets.pcap``. > > > > Signed-off-by: Jasvinder Singh > > Acked-by: Cristian Dumitrescu Series applied, thanks

[dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support

2016-10-12 Thread Thomas Monjalon
2016-09-04 15:38, Jasvinder Singh: > +#define RTE_PORT_FD_READER_STATS_PKTS_IN_ADD(port, val) \ > + do { port->stats.n_pkts_in += val } while (0) > +#define RTE_PORT_FD_READER_STATS_PKTS_DROP_ADD(port, val) \ > + do { port->stats.n_pkts_drop += val } while (0) > + It does not compile

[dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor port support

2016-10-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 12, 2016 9:33 PM > To: Singh, Jasvinder > Cc: dev at dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_port: enable file descriptor > port

[dpdk-dev] [PATCH 2/2] ip_pipeline: enable swap action in network layers configuration file

2016-10-12 Thread Thomas Monjalon
2016-08-26 22:21, Jasvinder Singh: > The network_layers configuration file (config/network_layers.cfg) > demonstrates the various network layer components such as TCP, UDP, > ICMP etc, which can be easily integrated into ip pipeline > infrastructure. > > The loopback function (implemented using

[dpdk-dev] [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly

2016-10-12 Thread Thomas Monjalon
> > From: Gowrishankar Muthukrishnan > > > > v2: minor correction in patch to avoid space between -d option and driver > > path > > Acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH v6] drivers/net:new PMD using tun/tap host interface

2016-10-12 Thread Keith Wiles
The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the local host. The PMD allows for DPDK and the host to communicate using a raw device interface on the host and in the DPDK application. The device created is a Tap device with a L2 packet header. v6 - fixed the checkpatch issues

[dpdk-dev] [PATCH] net/enic: fix crash on MTU update or rxq reconfigure

2016-10-12 Thread John Daley
The incorrect completion queue corresponding to an RQ would be freed if multiple Rx queues are in use and the MTU is changed, or an Rx queue is released. This could lead to a segmentation fault when the device is disabled or even in the Rx or Tx paths. The index of the completion queue

[dpdk-dev] [PATCH 1/2] net/enic: fix crash on MTU update or rxq reconfigure

2016-10-12 Thread John Daley
The incorrect completion queue corresponding to an RQ would be freed if multiple Rx queues are in use and the MTU is changed, or an Rx queue is released. This could lead to a segmentation fault when the device is disabled or even in the Rx or Tx paths. The index of the completion queue

[dpdk-dev] [PATCH 2/2] net/enic: trivial function name changes

2016-10-12 Thread John Daley
The function names for converting between RQ indexes known to the RTE code and intenal RQ indexes for primary Start of Packet (SOP) queues and spill-over (Data) queues was unclear and confusing. Clarify with more explicit function names. Signed-off-by: John Daley Reviewed-by: Nelson Escobar

  1   2   >