[dpdk-dev] [PATCH] examples/ip_fragmentation: add fragmentation size support

2017-04-20 Thread Ashish Jain
Adding support for determining fragmentation size for both ipv4 and ipv6 traffic dynamically through command line. It is helpful in testing to configure different fragmentation sizes and validate the packets. Signed-off-by: Ashish Jain Signed-off-by: Hemant Agrawal --- examples/ip_fragmentation

[dpdk-dev] [PATCH dpdk 1/5] vfio/ppc64/spapr: Use correct structures for add/remove windows

2017-04-20 Thread Alexey Kardashevskiy
This copies structures passed via VFIO_IOMMU_SPAPR_TCE_CREATE and VFIO_IOMMU_SPAPR_TCE_REMOVE ioctls. The existing ones cannot possible work. Signed-off-by: Alexey Kardashevskiy --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/

[dpdk-dev] [PATCH dpdk 0/5] ppc64/spapr: Attempt to use on POWER8

2017-04-20 Thread Alexey Kardashevskiy
Hi! This is my first attempt to use DPDK on POWER8 machine and yet unsuccessful as it turned out DPDK only supports IB-Mellanox (I only got ethernet-Mellanox, and requires OFED), rmmod on Intel 40Gb module produces PCI errors (unrelated to DPDK) and Broadcom bnx2x has few issues (below) and still

[dpdk-dev] [PATCH dpdk 3/5] RFC: bnx2x: Update firmware versions

2017-04-20 Thread Alexey Kardashevskiy
Recent kernels/distros have updated firmware images, use them. Signed-off-by: Alexey Kardashevskiy --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 1a7e1c8e1..17e8c6b4c 100644 --- a/d

[dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer

2017-04-20 Thread Alexey Kardashevskiy
The existing code initializes a PCI driver pointer but not the common one. As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c crashed as dev->device->driver==NULL. This adds missing initialization. Signed-off-by: Alexey Kardashevskiy --- lib/librte_eal/common/eal_common_pc

[dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-20 Thread Alexey Kardashevskiy
The existing code correctly checks if a container is set to a group and does not try attaching a group to a container for a second/third/... device from the same IOMMU group. However it still tries to set IOMMU type to a container for every device in a group which produces failure and closes conta

[dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for just created DMA window. It happens to start from zero because the default window is removed (leaving no windows) and new window starts from zero. However this is not guaranteed and the new window may start from another address,

Re: [dpdk-dev] [PATCH 1/2] eal/ppc: fix mmap for memory initialization

2017-04-20 Thread Thomas Monjalon
06/04/2017 12:06, Chao Zhu: > On IBM POWER platform, when mapping /dev/zero file to hugepage memory > space, mmap will not respect the requested address hint. This will cause > the memory initilization for the second process fails. This patch adds > the required mmap flags to make it work. Beside t

Re: [dpdk-dev] [PATCH 1/2] eal/ppc: fix mmap for memory initialization

2017-04-20 Thread Thomas Monjalon
13/04/2017 10:14, Sergio Gonzalez Monroy: > On 06/04/2017 11:06, Chao Zhu wrote: > > On IBM POWER platform, when mapping /dev/zero file to hugepage memory > > space, mmap will not respect the requested address hint. This will cause > > the memory initilization for the second process fails. This pat

[dpdk-dev] [PATCH] net/i40e: fix compilation error in ppc64le

2017-04-20 Thread Gowrishankar
From: Gowrishankar Muthukrishnan A typo introduced in i40e_rxtx_vec_altivec.c from commit 67f038076657 ("net/i40e: enable per-device packet type mapping"). This patch is to address compilation error in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/net/i40e/i40e_rxtx_vec_altive

Re: [dpdk-dev] [PATCH v9 10/13] doc: add NXP dpaa2 sec in cryptodev

2017-04-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Thursday, April 20, 2017 6:44 AM > To: dev@dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo; Mcnamara, John; > hemant.agra...@nxp.com > Subject: [PATCH v9 10/13] doc: add NXP dpaa2 sec in cryptodev >

[dpdk-dev] [PATCH] net/i40e: fix core dump during testpmd setup

2017-04-20 Thread Beilei Xing
Testpmd failed to start when CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC is disabled, the root cause is the length of sw_ring is incorrect with the above configuration. Fixes: 0be295312966 ("net/i40e: fix compile error") Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_rxtx.c | 4 1 fil

Re: [dpdk-dev] [PATCH] net/i40e: fix compilation error in ppc64le

2017-04-20 Thread Thomas Monjalon
20/04/2017 09:39, Gowrishankar: > From: Gowrishankar Muthukrishnan > > A typo introduced in i40e_rxtx_vec_altivec.c from commit 67f038076657 > ("net/i40e: enable per-device packet type mapping"). This patch is to > address compilation error in ppc64le. > > Signed-off-by: Gowrishankar Muthukrishn

[dpdk-dev] CLI parsing issue

2017-04-20 Thread Lu, Wenzhuo
Hi Olivier, I met a problem thar the parsing result of CLI is wrong. I checked this function, cmdline_parse. It will check the CLI instances one by one. Even if an instance is matched, the parsing will not stop for ambiguous check. Seems the following check may change the parsing result of the pr

[dpdk-dev] [PATCH] doc: update release notes for dpaa2 sec pmd

2017-04-20 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_17_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index 25e7144..c7fae86 100644 --- a/doc/guides/rel_notes/release_17_

[dpdk-dev] [PATCH v2] net/i40e: fix testpmd setup error when bulk is disabled

2017-04-20 Thread Beilei Xing
Testpmd failed to start when CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC is disabled, the root cause is the length of sw_ring and queue are incorrect with the above configuration. Fixes: 0be295312966 ("net/i40e: fix compile error") Signed-off-by: Beilei Xing --- v2 change: Correct the length of

Re: [dpdk-dev] CLI parsing issue

2017-04-20 Thread Olivier MATZ
Hi Wenzhuo, On Thu, 20 Apr 2017 08:36:38 +, "Lu, Wenzhuo" wrote: > Hi Olivier, > I met a problem thar the parsing result of CLI is wrong. > I checked this function, cmdline_parse. It will check the CLI instances one > by one. Even if an instance is matched, the parsing will not stop for > a

Re: [dpdk-dev] [PATCH v2] net/i40e: fix testpmd setup error when bulk is disabled

2017-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, April 20, 2017 4:52 PM > To: Wu, Jingjing ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH v2] net/i40e: fix testpmd setup error when bulk is disabled > > Testpmd failed to start when > CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALL

[dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors()

2017-04-20 Thread Nicolas Dichtel
pci_enable_msix() will be removed in kernel 4.12. The new API is available since linux 4.8, thus let's use it. Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18 Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244

Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset

2017-04-20 Thread Zhao1, Wei
Hi, Yuanhan > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Thursday, April 20, 2017 2:08 PM > To: Zhao1, Wei > Cc: Ananyev, Konstantin ; Mcnamara, John > ; dev@dpdk.org; Lu, Wenzhuo > ; Thomas Monjalon ; Liu, > Yu Y > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] doc: update release notes for dpaa2 sec pmd

2017-04-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Thursday, April 20, 2017 9:47 AM > To: dev@dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo; hemant.agra...@nxp.com; > Mcnamara, John; nhor...@tuxdriver.com; tho...@monjalon.net; Akhil > Goyal > Sub

Re: [dpdk-dev] [PATCH v9 00/13] Introducing NXP dpaa2_sec based cryptodev pmd

2017-04-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Thursday, April 20, 2017 6:44 AM > To: dev@dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo; Mcnamara, John; > hemant.agra...@nxp.com > Subject: [PATCH v9 00/13] Introducing NXP dpaa2_sec based cryp

[dpdk-dev] [pull-request] next-crypto 17.05 RC2

2017-04-20 Thread Pablo de Lara
The following changes since commit e4701c7a4eec9367819da0ea4ed8572310fe0832: net/i40e: fix build on ppc64le (2017-04-20 10:21:59 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 37ed2fa87d38f89e2ac8132dcb7e6d4a896e2cd7:

[dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-20 Thread Srini J
From: Srinivasan Jayarajan Adds support to use a different SFP/SFP+ without restarting the DPDK app. rte_eth_dev_stop()/rte_eth_dev_start() will need to be called on the port to detect the SFP/SFP+ change. Signed-off-by: Srinivasan Jayarajan --- drivers/net/ixgbe/ixgbe_ethdev.c | 1

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-20 Thread Akhil Goyal
Hi Pablo, On 4/4/2017 8:41 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] Sent: Monday, April 03, 2017 11:53 AM To: dev@dpdk.org Cc: Doherty, Declan; De Lara Guarch, Pablo; Akhil Goyal Subject: [PATCH] test/test: imp

Re: [dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors()

2017-04-20 Thread Ferruh Yigit
On 4/20/2017 10:01 AM, Nicolas Dichtel wrote: > pci_enable_msix() will be removed in kernel 4.12. The new API is available > since linux 4.8, thus let's use it. > > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18 > Link: > https://git.kernel.org

[dpdk-dev] "Cannot configure device: err=-16" resource busy error on running dpdk applications

2017-04-20 Thread Nidhia Varghese
Hi, I was trying to run l2fwd and ip_pipeline example programs. But I am getting the following error. ./build/app/l2fwd -c 0x3 --vdev=eth_af_packet0,iface=eno4 --vdev=eth_af_packet1,iface=eno3 -- -p 0x3 EAL: Detected 32 lcore(s) EAL: Probing VFIO support... PMD: Initializing pmd_af_packet for eth

Re: [dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors()

2017-04-20 Thread Nicolas Dichtel
Le 20/04/2017 à 13:59, Ferruh Yigit a écrit : > On 4/20/2017 10:01 AM, Nicolas Dichtel wrote: >> pci_enable_msix() will be removed in kernel 4.12. The new API is available >> since linux 4.8, thus let's use it. >> >> Link: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commi

[dpdk-dev] [PATCH v3] igb_uio: switch to pci_alloc_irq_vectors()

2017-04-20 Thread Nicolas Dichtel
pci_enable_msix() will be removed in kernel 4.12. The new API is available since linux 4.8, thus let's use it. Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18 Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 20/04/17 19:04, Jonas Pfefferle1 wrote: > Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: > >> From: Alexey Kardashevskiy >> To: dev@dpdk.org >> Cc: Alexey Kardashevskiy , j...@zurich.ibm.com, >> Gowrishankar Muthukrishnan >> Date: 20/04/2017 09:24 >> Subject: [PATCH dpdk 5/5] RFC: vfio/p

Re: [dpdk-dev] [PATCH 0/4] update ixgbe base driver to version 2017-03-29

2017-04-20 Thread Dai, Wei
Hi, Ferruh The first patch is to align a fix in firmware. The second is to fix the miss of support of 2.5G PHY which is also needed by some customers. The third is to fix LED support on MAC X550em/X557. We have just verified them with fixed firmware. So if it is accepted, some customers can get

Re: [dpdk-dev] [PATCH v3] igb_uio: switch to pci_alloc_irq_vectors()

2017-04-20 Thread Thomas Monjalon
20/04/2017 15:11, Nicolas Dichtel: > pci_enable_msix() will be removed in kernel 4.12. The new API is available > since linux 4.8, thus let's use it. > > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/? > id=aff171641d18 Link: > https://git.kernel.org/pub/scm/lin

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 20/04/17 23:25, Alexey Kardashevskiy wrote: > On 20/04/17 19:04, Jonas Pfefferle1 wrote: >> Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: >> >>> From: Alexey Kardashevskiy >>> To: dev@dpdk.org >>> Cc: Alexey Kardashevskiy , j...@zurich.ibm.com, >>> Gowrishankar Muthukrishnan >>> Date: 20

[dpdk-dev] [PATCH] app/testpmd: check port is stopped for QinQ setup

2017-04-20 Thread Bernard Iremonger
Check port is stopped before configuring it for QinQ, with the "vlan set qinq on " command. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f6bd75b78

[dpdk-dev] [PATCH 0/2] fixes for FreeBSD compilation

2017-04-20 Thread Bruce Richardson
Bruce Richardson (2): examples/performance-thread: fix FreeBSD compilation net/ark: fix FreeBSD compilation drivers/net/ark/Makefile| 2 ++ examples/performance-thread/l3fwd-thread/main.c | 4 examples/performance-thread/pthread_shim/main.c

[dpdk-dev] [PATCH 1/2] examples/performance-thread: fix FreeBSD compilation

2017-04-20 Thread Bruce Richardson
This set of sample apps did not compile on FreeBSD due to use of a number of Linux/glibc-specific APIs, or APIs which existed in different headers on FreeBSD. Specifically, the following APIs has problems: * sched_getcpu() is a glibc extension * pthread_yield() returns int on Linux, but void on

[dpdk-dev] [PATCH 2/2] net/ark: fix FreeBSD compilation

2017-04-20 Thread Bruce Richardson
On FreeBSD it's not necessary to use -ldl to link apps which use dlopen. This error only showed up with a shared library gcc build, not standard build using static libs. Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville") Signed-off-by: Bruce Richardson --- drivers/net/ark/Makef

Re: [dpdk-dev] [PATCH 2/2] net/ark: fix FreeBSD compilation

2017-04-20 Thread john miller
> On Apr 20, 2017, at 12:32 PM, Bruce Richardson > wrote: > > On FreeBSD it's not necessary to use -ldl to link apps which use > dlopen. This error only showed up with a shared library gcc build, > not standard build using static libs. > > Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rul

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] examples/performance-thread: fix FreeBSD compilation

2017-04-20 Thread Thomas Monjalon
20/04/2017 18:32, Bruce Richardson: > This set of sample apps did not compile on FreeBSD due to use of a number > of Linux/glibc-specific APIs, or APIs which existed in different headers > on FreeBSD. Specifically, the following APIs has problems: > * sched_getcpu() is a glibc extension > * pth

Re: [dpdk-dev] [pull-request] next-crypto 17.05 RC2

2017-04-20 Thread Thomas Monjalon
20/04/2017 11:43, Pablo de Lara: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

[dpdk-dev] DPAA2 crypto license

2017-04-20 Thread Thomas Monjalon
Hi, I'm not a lawyer but I think there may be an issue with the files in drivers/crypto/dpaa2_sec/hw/ The header of these files is: /* * Copyright 2008-2016 Freescale Semiconductor, Inc. * * SPDX-License-Identifier: BSD-3-Clause or GPL-2.0+ */ Could we make it more explicit than this SPDX ta

[dpdk-dev] DPDK log system is not working

2017-04-20 Thread Lu, Patrick
Hi, I've recently rebased my DPDK code from v16.07 to v17.05-rc1 and learned rte_set_log_type() API is deprecated now, so I switched to rte_log_set_level() API. My old code was as follow: #define C2CV3 RTE_LOGTYPE_USER1 #define D RTE_LOG_DEBUG #define I RTE_LOG_INFO #define N RTE_LOG_NOTICE rt

[dpdk-dev] [PATCH v4] doc: fix flow validate comments

2017-04-20 Thread John Daley
Change comments for rte_flow_validate() function to indicate that flow rule collision and resource validation is optional for PMDs and therefore the return codes may have different meanings. Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API") Signed-off-by: John Daley --- v2: another crac

[dpdk-dev] [RFC 17.08] Flow classification library

2017-04-20 Thread Ferruh Yigit
DPDK works with packets, but some network administration tools works based on flow information. This library is suggested to provide helper APIs to convert packet based information to the flow records. Library header file has more comments on how library works and provided APIs. Packets to flow c

[dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-04-20 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- config/common_base | 5 + doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + doc/guides/rel_notes/release_17_05.rst | 1 + lib/Makefile

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread gowrishankar muthukrishnan
On Thursday 20 April 2017 07:52 PM, Alexey Kardashevskiy wrote: On 20/04/17 23:25, Alexey Kardashevskiy wrote: On 20/04/17 19:04, Jonas Pfefferle1 wrote: Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: From: Alexey Kardashevskiy To: dev@dpdk.org Cc: Alexey Kardashevskiy , j...@zurich.ibm

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-20 Thread gowrishankar muthukrishnan
On Thursday 20 April 2017 12:54 PM, Alexey Kardashevskiy wrote: The existing code correctly checks if a container is set to a group and does not try attaching a group to a container for a second/third/... device from the same IOMMU group. However it still tries to set IOMMU type to a container f

Re: [dpdk-dev] DPDK log system is not working

2017-04-20 Thread Thomas Monjalon
20/04/2017 20:35, Lu, Patrick: > Hi, > > I've recently rebased my DPDK code from v16.07 to v17.05-rc1 and learned > rte_set_log_type() API is deprecated now, so I switched to > rte_log_set_level() API. It should be fixed with the recent patches. Please check the master branch or 17.05-rc2 when it

Re: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev library to allow grouping of stats

2017-04-20 Thread Thomas Monjalon
13/04/2017 16:59, Kuba Kozak: > Extended xstats API in ethdev library to allow grouping of stats logically > so they can be retrieved per logical grouping managed by the application. > Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_get > to use a new list of arguments: arra

Re: [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for port reset

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1509,6 +1512,9 @@ struct eth_dev_ops { > eth_l2_tunnel_offload_set_t l2_tunnel_offload_set; > /** Enable/disable l2 tunnel offload functions. */ > > + /** Reset device. *

Re: [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for port reset

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > Add support for port reset in rte layer.This reset > feature can be used not only in vf port reset in the following > code develop process later, but also pf port.But in this patch > set, we only limit the discussion scope to vf reset. > This patch add an API to restar

Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > + if (adapter->reset_store_data == NULL) { > + PMD_INIT_LOG(ERR, "Failed to allocate %ld bytes needed to" > + " to store data when reset vf", > + sizeof(struct i40e_vf_reset_store)); Compilation f

Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > + memset(dev->data->dev_private, 0, > +(uint64_t)&adapter->reset_flag - (uint64_t)adapter); It does not compile for 32-bit. Should it be replaced by offsetof()? Does it mean that new fields should be added before reset_flag? There is no comment about

Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: vf port reset

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > The patches mainly finish following functions: > 1) get pf reset vf comamand falg from interrupt server function. > 2) reset vf port from testpmd app using a command. > 3) sore and restore vf related parameters. [...] > zhao wei (3): > app/testpmd: add port reset com

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-20 Thread Thomas Monjalon
13/04/2017 10:21, Wei Dai: > some customers find adding mac addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > > Fixes: af75078fece3 ("first public release")

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 01:15, Jonas Pfefferle1 wrote: > Alexey Kardashevskiy wrote on 20/04/2017 16:22:01: > >> From: Alexey Kardashevskiy >> To: Jonas Pfefferle1 >> Cc: dev@dpdk.org, Gowrishankar Muthukrishnan >> , Adrian Schuepbach >> Date: 20/04/2017 16:22 >> Subject: Re: [PATCH dpdk 5/5] RFC: vfio/pp

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-20 Thread Thomas Monjalon
07/04/2017 17:27, Andriy Berestovskyy: > Hey Thomas, > > On 07.04.2017 16:47, Thomas Monjalon wrote: > >> What if we add to the max_rx_pkt_len description: "the effective maximum > >> RX frame size depends on PMD, please refer the PMD guide for the > >> details"? > > > > I think the problem is no

Re: [dpdk-dev] [PATCH v2 0/5] add device removal event

2017-04-20 Thread Thomas Monjalon
18/04/2017 14:17, Gaetan Rivet: > This new event represents the sudden removal of a device from its bus. > The underlying resources exposed by the bus are expected not to be available > anymore. The application should thus be able to react and possibly clean up > related resources that it reserved

Re: [dpdk-dev] [PATCH v2] lib/distributor: fix segfaults in flush

2017-04-20 Thread Thomas Monjalon
14/04/2017 10:59, David Hunt: > Occasionally, the distributor single-packet-at-a-time mode will > segfault because it inadvertently calls some burst mode code when > flushing packets. > > This patch ensures that only the v20 (single mode) codepath is used, and > returns without falling through to

Re: [dpdk-dev] [PATCH v1] lib/bitratestats: fix integer roundoff

2017-04-20 Thread Thomas Monjalon
19/04/2017 15:26, Remy Horton: > In the absence of traffic, it is possible for the bitrate moving average > to get stuck at a non-zero value, due to the calculated delta being less > than what an integer can represent. > > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > > Signed

Re: [dpdk-dev] [PATCH] app/testpmd: fix duplicated rte_metrics.h include

2017-04-20 Thread Thomas Monjalon
11/04/2017 10:33, Ferruh Yigit: > On 4/11/2017 9:22 AM, Pascal Mazon wrote: > > Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation") > > > > Signed-off-by: Pascal Mazon > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] app/testpmd: consolidate two duplicate ifdefs into one.

2017-04-20 Thread Thomas Monjalon
18/04/2017 00:56, Rami Rosen: > Cnsolidate the duplicate #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES > into one #ifdef. > > Signed-off-by: Rami Rosen Applied, thanks

Re: [dpdk-dev] [PATCH] app/testpmd: enable NUMA support by default

2017-04-20 Thread Thomas Monjalon
19/04/2017 18:19, Thomas Monjalon: > 24/03/2017 18:00, Bruce Richardson: > > There is little reason for NUMA support in testpmd to be off by default, > > so > > enable it, and add in a new commandline parameter to disable it, if that > > is > > wanted by users. > > > > Signed-off-by: Bruce Richard

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix possible memory leak

2017-04-20 Thread Thomas Monjalon
18/04/2017 16:21, Ferruh Yigit: > alloc_q and rx_q fifos holds physical address of the mbufs, and not able > to free those mbufs explicitly. > > But kernel thread reads from rx_q and puts used mbufs into free_q (with > their virtual addresses.) And kernel thread stopped when application > close th

Re: [dpdk-dev] [PATCH] table: fix hash_ext stats update

2017-04-20 Thread Thomas Monjalon
> > Fixed stats double update. > > > > Signed-off-by: Aleksey Katargin > > --- > > Thanks, Aleksey! BTW the " rte_table_hash_lru.c " suffers from the same > symptoms, so a patch to fix this one would also be highly appreciated :) > > Ack-ed by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH v2] pipeline_firewall: Fix for port range filtering

2017-04-20 Thread Thomas Monjalon
> > Firewall ACL definition need to use same input index for source and > > destination ports as these are 16 bits and would fit in one ACL > > field of 32 bits. This is required as per librte_acl API. Without this > > UDP/TCP source and destination ports filtering (and for that > > matter ICMP typ

Re: [dpdk-dev] [PATCH 1/5] examples/ip_pipeline: add support for more than 32 CPUs

2017-04-20 Thread Thomas Monjalon
31/03/2017 16:17, Dumitrescu, Cristian: > > -Original Message- > > From: Andriy Berestovskyy > > [mailto:andriy.berestovs...@caviumnetworks.com] > > Sent: Friday, March 31, 2017 2:37 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org > > Subject: [PATCH 1/5] examples/ip_pipeline: add sup

Re: [dpdk-dev] [PATCH 1/3] examples/ip_fragmentation: limit max frame size

2017-04-20 Thread Thomas Monjalon
10/04/2017 16:30, Andriy Berestovskyy: > Some PMDs do not support 9,5K jumbo frames, so the example fails. > Limit the frame size to the maximum supported by the underlying NIC. > > Signed-off-by: Andriy Berestovskyy Series squashed and applied, thanks

Re: [dpdk-dev] [PATCH] ethtool: disable promiscuous mode by default

2017-04-20 Thread Thomas Monjalon
18/04/2017 16:26, Remy Horton: > Probably ought to also add a new command so that promiscuous mode can be > enabled if needed. > > On 12/04/2017 20:58, Qi Zhang wrote: > > Disable promiscuous mode by default since VLAN filter > > does not work when promiscuous mode is enabled. > > > > Signed-off-

Re: [dpdk-dev] [PATCH v2] examples/performance-thread: add c++ ifdefs

2017-04-20 Thread Thomas Monjalon
16/04/2017 15:33, Keith Wiles: > Signed-off-by: Keith Wiles > --- > v2 - change ctx.h to be 664 permissions. > > examples/performance-thread/common/arch/x86/ctx.h | 8 > examples/performance-thread/common/lthread.h | 8 > examples/performance-thread/common/lthread_

Re: [dpdk-dev] [PATCH v2] example/performance-thread: lthread support C++

2017-04-20 Thread Thomas Monjalon
22/03/2017 03:26, Hiroki SHIROKURA: > Lthread is awesome but it doesn't support C++. > So I write patch to support lthread to support C++. > Added "extern C {}" to lthread-headers > > Signed-off-by: Hiroki SHIROKURA > Acked-by: Keith Wiles Applied, thanks

Re: [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line

2017-04-20 Thread Thomas Monjalon
10/04/2017 09:54, Mcnamara, John: > > -Original Message- > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > Sent: Friday, April 7, 2017 4:06 PM > > To: dev@dpdk.org; Mcnamara, John > > Cc: jfrei...@redhat.com; Maxime Coquelin > > Subject: [PATCH] doc: pvp: fix typo in host'

Re: [dpdk-dev] CLI parsing issue

2017-04-20 Thread Lu, Wenzhuo
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Thursday, April 20, 2017 4:55 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: CLI parsing issue > > Hi Wenzhuo, > > On Thu, 20 Apr 2017 08:36:38 +, "Lu, Wenzhuo" > wrote: > > Hi Oliv

Re: [dpdk-dev] [PATCH] app/testpmd: check port is stopped for QinQ setup

2017-04-20 Thread Xing, Beilei
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, April 20, 2017 11:14 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi > > Cc: Iremonger, Bernard > Subject: [PATCH] app/testpmd: check port is stopped for QinQ setup > > Check port is stopped before configuring

[dpdk-dev] [dpdk-announce] release candidate 17.05-rc2

2017-04-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.05-rc2 What's new in RC2? - progress on bus rework (PCI and VDEV) - ethdev xstats by ID - new Atomic Rules ark driver - new NXP dpaa2 drivers - a lot of fixes

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Jonas Pfefferle1
Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: > From: Alexey Kardashevskiy > To: dev@dpdk.org > Cc: Alexey Kardashevskiy , j...@zurich.ibm.com, > Gowrishankar Muthukrishnan > Date: 20/04/2017 09:24 > Subject: [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus > addresses for DMA map

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Jonas Pfefferle1
Alexey Kardashevskiy wrote on 20/04/2017 16:22:01: > From: Alexey Kardashevskiy > To: Jonas Pfefferle1 > Cc: dev@dpdk.org, Gowrishankar Muthukrishnan > , Adrian Schuepbach > Date: 20/04/2017 16:22 > Subject: Re: [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus > addresses for DMA map >

[dpdk-dev] [dpdk-announce] release candidate 17.05-rc2

2017-04-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.05-rc2 What's new in RC2? - progress on bus rework (PCI and VDEV) - ethdev xstats by ID - new Atomic Rules ark driver - new NXP dpaa2 drivers - a lot of fixes

Re: [dpdk-dev] [PATCH] net/ixgbe: align register setting when RSC is disabled

2017-04-20 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Dai, Wei > Sent: Thursday, April 20, 2017 11:06 AM > To: Zhang, Helin; Ananyev, Konstantin; Lu, Wenzhuo; Dai, Wei > Cc: dev@dpdk.org > Subject: [PATCH] net/ixgbe: align register setting when RSC is disabled > > When RSC is not used, the RSC_DIS of registe

[dpdk-dev] [PATCH] net/virtio-user: fix recognize physical devices

2017-04-20 Thread Jianfeng Tan
Segfault happens when using virtio-user after commit 7f0a669e7b04 ("ethdev: add allocation helper for virtual drivers"). It's due to we use ethdev->device to recognize physical devices, but after above commit, this field is also filled for virtual devices. Then we obtain the wrong pci_dev pointer

Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset

2017-04-20 Thread Yuanhan Liu
On Thu, Apr 20, 2017 at 09:17:24AM +, Zhao1, Wei wrote: > > > > Please explain exactly the responsibility of this function, and how > > > > it is different from calling stop/configure/start. > > > > > > In this reset feature, reset function can do the calling > > > stop/configure/start process,

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check

2017-04-20 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Thursday, April 20, 2017 11:28 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check > > Remove a useless item type check for

Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type

2017-04-20 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Thursday, April 20, 2017 11:28 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow > type > > The type check for flow_type s

[dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on POWER8

2017-04-20 Thread Alexey Kardashevskiy
Fixes: 67f038076657 ("net/i40e: enable per-device packet type mapping") Signed-off-by: Alexey Kardashevskiy --- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c b/drivers/net/i40e/i40e_rx

Re: [dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on POWER8

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 13:10, Alexey Kardashevskiy wrote: > Fixes: 67f038076657 ("net/i40e: enable per-device packet type mapping") > Signed-off-by: Alexey Kardashevskiy ah, never mind, fixed already. > --- > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 8 > 1 file changed, 4 insertions(+), 4 dele

Re: [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for port reset

2017-04-20 Thread Zhao1, Wei
Hi, Thomas > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, April 21, 2017 4:50 AM > To: Zhao1, Wei ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for port > reset > > 10/04/2017 05:02, W

Re: [dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on POWER8

2017-04-20 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Friday, April 21, 2017 11:10 AM > To: dev@dpdk.org > Cc: Alexey Kardashevskiy > Subject: [dpdk-dev] [PATCH dpdk] i40e/ppc64/altivec: Fix compile errors on > POWER8 > > Fixes: 67f03

Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Zhao1, Wei
Hi, Thomas > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, April 21, 2017 5:12 AM > To: Zhao1, Wei ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on > port > > 10/04/2017 05:02, Wei Z

Re: [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map

2017-04-20 Thread Alexey Kardashevskiy
On 21/04/17 05:16, gowrishankar muthukrishnan wrote: > On Thursday 20 April 2017 07:52 PM, Alexey Kardashevskiy wrote: >> On 20/04/17 23:25, Alexey Kardashevskiy wrote: >>> On 20/04/17 19:04, Jonas Pfefferle1 wrote: Alexey Kardashevskiy wrote on 20/04/2017 09:24:02: > From: Alexey Ka

Re: [dpdk-dev] [PATCH 0/4] update ixgbe base driver to version 2017-03-29

2017-04-20 Thread Peng, Yuan
Tested-by: Peng Yuan - Tested Branch: dpdk v17.02 - Tested Commit: b9ebab26d98f61bc407572623c4bee4390a8b432 - OS: 4.4.26-yocto-standard - IFWI: HAVLCRB1.X64.0014.D76.1703170116 - NIC: Intel Corporation Device [8086:15ce] (rev 10) driver: ixgbe-5.0.7 firmware-version: 0x86f8/ 0x8714 - De

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-04-20 Thread Lu, Wenzhuo
Hi Srini, > -Original Message- > From: Srini J [mailto:srinid...@gmail.com] > Sent: Thursday, April 20, 2017 6:48 PM > To: Lu, Wenzhuo; Ananyev, Konstantin > Cc: dev@dpdk.org; Srinivasan Jayarajan > Subject: [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ > > From: Srinivasan

Re: [dpdk-dev] DPAA2 crypto license

2017-04-20 Thread Akhil Goyal
Hi Thomas, On 4/20/2017 11:13 PM, Thomas Monjalon wrote: Hi, I'm not a lawyer but I think there may be an issue with the files in drivers/crypto/dpaa2_sec/hw/ The header of these files is: /* * Copyright 2008-2016 Freescale Semiconductor, Inc. * * SPDX-License-Identifier: BSD-3-Clause or GP

[dpdk-dev] Printing statistics on running passthrough pipeline in ip_pipeline application

2017-04-20 Thread Nidhia Varghese
Hi, I am running ip_pipeline application using ip_pipeline.cfg file. How can I see the statistics of the packets that is being sent and received from this pipeline? I tried running as shown below: pipeline> p 1 port in 0 enable pipeline> p 1 port in 1 enable pipeline> p 1 stats port in 1 Pipelin

Re: [dpdk-dev] Printing statistics on running passthrough pipeline in ip_pipeline application

2017-04-20 Thread Shyam Shrivastav
Enable flags in dpdk/config/common_base and recompile CONFIG_RTE_*_STATS_COLLECT=y {* for PIPELINE,PORT,TABLE ...} On Fri, Apr 21, 2017 at 11:58 AM, Nidhia Varghese < nidhiavarghes...@gmail.com> wrote: > Hi, > > I am running ip_pipeline application using ip_pipeline.cfg file. How can I > see

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-20 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Thursday, April 13, 2017 4:21 PM > To: thomas.monja...@6wind.com; harish.pa...@cavium.com; > rasesh.m...@cavium.com; stephen.h...@broadcom.com; > ajit.khapa...@broadcom.com; Lu, Wenzhuo; Zhang, Helin; Ananyev, > Konstantin; Wu, Jingjing