[dpdk-dev] [PATCH v2] net/bnxt: fix packet type

2018-02-08 Thread Olivier Matz
The hw flags are not read correctly: the defines RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be tested with if (value & X) but with if ((value & MASK) == X). This was resulting in a wrong packet type. For instance, an IPv4/ICMP packet was returning a value of 7 for the lay

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-08 Thread Hemant Agrawal
On 1/24/2018 6:57 PM, Lee Daly wrote: This updates the Intel and Cavium license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- .../performance-thread/common/ar

Re: [dpdk-dev] [PATCH v4] examples/ip_pipeline: update copyright and license

2018-02-08 Thread Hemant Agrawal
Olivier, Please review/ack this one. Regards, Hemant On 2/7/2018 10:13 PM, Lee Daly wrote: This updates the Intel and Oliver Matz licenses on a file in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing po

Re: [dpdk-dev] [PATCH] examples/l3fwd: update copyright and licenses

2018-02-08 Thread Hemant Agrawal
Adding Jianbo to ack it from Linaro side. Regards, Hemant On 1/23/2018 10:15 PM, Lee Daly wrote: This updates the Intel and Linaro Limited license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing po

Re: [dpdk-dev] [PATCH] examples/l3fwd: update copyright and licenses

2018-02-08 Thread Hemant Agrawal
Jianbo's id is bouncing. Can someone else from Linaro ack this patch? Note that this patch is only changing the Licensing format from full text to SPDX tag. No change in copyright or actual license. Regards, Hemant On 2/8/2018 2:05 PM, Hemant Agrawal wrote: Adding Jianbo to ack it from Linar

[dpdk-dev] [PATCH 0/2] add support for check descriptor status APIs

2018-02-08 Thread Wei Zhao
The patches set mainly finish following functions: Igb VF and fm10k nic add support check descriptor status APIs. wei zhao (2): net/e1000: add support for check descriptor status APIs net/fm10k: add support for check descriptor status APIs drivers/net/e1000/igb_ethdev.c | 3 ++ drivers/ne

[dpdk-dev] [PATCH 1/2] net/e1000: add support for check descriptor status APIs

2018-02-08 Thread Wei Zhao
Igb VF nic need to support check descriptor status APIs, they are rte_eth_rx_descriptor_status and rte_eth_tx_descriptor_status. So, this patch add ops with function pointer that enable feature. Signed-off-by: Wei Zhao --- drivers/net/e1000/igb_ethdev.c | 3 +++ 1 file changed, 3 insertions(+)

[dpdk-dev] [PATCH 2/2] net/fm10k: add support for check descriptor status APIs

2018-02-08 Thread Wei Zhao
Fm10k nic need to support check descriptor status APIs, they are rte_eth_rx_descriptor_status and rte_eth_tx_descriptor_status. So, this patch add ops with function pointer that enable feature. Signed-off-by: Wei Zhao --- drivers/net/fm10k/fm10k.h| 7 + drivers/net/fm10k/fm10k_ethde

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-08 Thread Hemant Agrawal
Hi Lee, Hasan Alayli's license seems to be BSD-2-Clause, which is typically compatible with BSD-3-Clause. It will be ideal to get ACK from Hasan Alayli to re-license it as BSD-3-clause and change it to SPDX tag. regards, Hemant On 1/23/2018 10:16 PM, Lee Daly wrote: This updates the Intel,

Re: [dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver

2018-02-08 Thread Maxime Coquelin
Hi Xiao, On 02/08/2018 03:23 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, February 6, 2018 10:24 PM To: Wang, Xiao W ; dev@dpdk.org Cc: Tan, Jianfeng ; Bie, Tiwei ; y...@fridaylinux.org; Liang, Cunming ;

[dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-02-08 Thread Yulong Pei
Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Yulong Pei --- doc/guides/rel_notes/release_18_02.rst | 75 ++ 1 file changed, 75 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_0

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add support for AES 256

2018-02-08 Thread Nicolau, Radu
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, February 8, 2018 6:13 AM > To: Akhil Goyal ; Doherty, Declan > ; Nicolau, Radu ; > Sergio Gonzalez Monroy > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject:

[dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities

2018-02-08 Thread Moti Haimovsky
This patch updates mlx4 Rx offload capabilities to also indicate that Rx CRC stripping is (always) supported. Since the device does not support disabeling CRC stripping the PMD silently ignores such requests. Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_rxq.c | 3 ++- 1 file changed,

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-08 Thread Burakov, Anatoly
On 06-Feb-18 5:55 PM, Ravi Kerur wrote: Hi Anatoly, I am actually confused with the state of vIOMMU + DPDK. Can you please help me clarify? I tested following DPDK versions (1) DPDK 17.11, exhibits the issue (IOMMU width as reported by RedHat and solution is to prevent using the patch) (2)

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

2018-02-08 Thread Ferruh Yigit
On 2/2/2018 3:29 AM, Wei Zhao wrote: > This patch add a user guidance document specific for igb nic. > By now, a doc like ixgbe.rst is also needed by igb nic. So this patch > add igb.rst to record important information about igb, like feature > supported and known issues. > > Signed-off-by: Wei Zh

[dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check

2018-02-08 Thread Ferruh Yigit
Some hardware doesn't support disabling CRC strip. In techboard it has been decided to enable CRC strip always. The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if PMD reports CRC strip capability. Not all PMDs updated to report CRC strip. For the PMDs not reporting CRC strip tes

Re: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check

2018-02-08 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, February 8, 2018 12:08 PM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon > ; Ananyev, Konstantin > ; mo...@mellanox.com; shah...@mellanox.com > Subject: [PATCH] app/testpmd: enable CRC str

[dpdk-dev] [PATCH v4 0/2] failsafe: fix calling device during RMV events

2018-02-08 Thread Matan Azrad
This series trys to mitigate failsafe race between control commands to the asynchronic plug-out\in processes. A full fix is required and will be sent later. v4(Matan): Rebase on top of 18.02-rc3. Extend the fix for other control commands. Fix hotplug alarm cancel. V3(Ophir): Rebase v2. Add rati

[dpdk-dev] [PATCH v4 2/2] net/failsafe: fix calling device during RMV events

2018-02-08 Thread Matan Azrad
From: Ophir Munk This commit prevents control path operations from failing after a sub device removal. Following are the failure steps: 1. The physical device is removed due to change in one of PF parameters (e.g. MTU) 2. The interrupt thread flags the device 3. Within 2 seconds Interrupt thread

[dpdk-dev] [PATCH v4 1/2] net/failsafe: fix hotplug alarm cancel

2018-02-08 Thread Matan Azrad
The hot-plug alarm mechanism of fail-safe PMD is responsible for handling removed devices during a plug-out event and to restore them back to activity following a plug-in event. Fail-safe sets a flag called "pending_alarm" to validate that only one alarm callback is pending at any time. While this

Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter

2018-02-08 Thread Nélio Laranjeiro
On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: > Nor upstream kernel nor MLNX_OFED support such filter. > > Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") > Cc: nelio.laranje...@6wind.com > > Signed-off-by: Shahaf Shuler > --- > doc/guides/rel_notes/r

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

2018-02-08 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, February 8, 2018 11:39 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for > igb > > On 2/2/2018 3:29 AM, Wei Zhao wrote: > > This patch add a user g

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix res cleanup when tap create fails

2018-02-08 Thread Ferruh Yigit
On 2/7/2018 4:00 PM, Pascal Mazon wrote: > On 05/02/2018 17:17, Moti Haimovsky wrote: >> This patch complements the partial cleanup done inside >> eth_dev_tap_create when the routine failed. >> Such a failure left a non-functional device attached to the system. >> >> Fixes: 050fe6e9ff97 ("drivers/

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 12:27 PM, Mcnamara, John wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, February 8, 2018 11:39 AM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Mcnamara, John >> Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for >> igb >> >> On 2/2/2018

[dpdk-dev] [PATCH] app/testpmd: fix FDIR issue

2018-02-08 Thread Beilei Xing
This patch fixes issue during dealing with flow director filter. Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test

Re: [dpdk-dev] [PATCH] app/testpmd: fix FDIR issue

2018-02-08 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, February 8, 2018 8:36 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix FDIR issue > > This patch fixes issue during dealing with flow > director filter. > > Fixes: 6c684f579df5 ("ap

Re: [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities

2018-02-08 Thread Adrien Mazarguil
On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote: > This patch updates mlx4 Rx offload capabilities to also indicate that > Rx CRC stripping is (always) supported. > Since the device does not support disabeling CRC stripping the PMD disabeling => disabling > silently ignores such re

[dpdk-dev] [PATCH v1] doc: add note on increased ring size to release notes

2018-02-08 Thread John McNamara
Added note on the increased ring size in testpmd and the sample applications to the release note. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_18_02.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/rel

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix Rx checksum flags

2018-02-08 Thread Ferruh Yigit
On 2/6/2018 11:27 PM, Ajit Khaparde wrote: > On Tue, Feb 6, 2018 at 5:39 AM, Olivier Matz wrote: > >> Fix the Rx offload flags when the IP or L4 checksum is seen as incorrect >> by the hardware. In this case, the proper value is PKT_RX_IP_CKSUM_BAD. >> >> PKT_RX_IP_CKSUM_NONE means that the check

Re: [dpdk-dev] [PATCH v1] doc: add note on increased ring size to release notes

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 12:47 PM, John McNamara wrote: > Added note on the increased ring size in testpmd and the sample > applications to the release note. > > Signed-off-by: John McNamara Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg

2018-02-08 Thread Beilei Xing
This patch fixes the coverity CHECKED_RETURN issue. Coverity issue: 261779 Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Reported-by: John McNamara Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

Re: [dpdk-dev] [PATCH 0/4] bnxt patchset

2018-02-08 Thread Ferruh Yigit
On 2/7/2018 1:16 AM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. > Please apply. > > Ajit Khaparde (4): > net/bnxt: update bnxt feature list > net/bnxt: fix link speed setting with autoneg off > net/bnxt: add 100G speed config capability > net/bnxt: fix an incorrect return in ma

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bnxt: fix packet type

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 8:24 AM, Olivier Matz wrote: > The hw flags are not read correctly: the defines > RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be > tested with if (value & X) but with if ((value & MASK) == X). > This was resulting in a wrong packet type. > > For instance, an IP

Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg

2018-02-08 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, February 8, 2018 9:18 PM > To: Wu, Jingjing ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] net/i40e: fix unchecked return in parse devarg > > This patch fixes the coverity CHECKED_RETURN issue. > > Coverity issue: 261779 > F

Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg

2018-02-08 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, February 8, 2018 9:18 PM > To: Wu, Jingjing; dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg > > This patch fixes the coverity

Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg

2018-02-08 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Thursday, February 8, 2018 9:39 PM > To: Xing, Beilei; dev@dpdk.org; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg > > > > > -Original Mes

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-08 Thread Daly, Lee
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Thursday, February 8, 2018 8:49 AM > To: Daly, Lee ; Mcnamara, John > ; De Lara Guarch, Pablo > ; Richardson, Bruce > ; Van Haaren, Harry > ; hala...@gmail.com > Cc: dev@dpdk.org > Subject: Re: [PATCH] exam

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

2018-02-08 Thread Ferruh Yigit
On 2/7/2018 7:12 AM, Zhang, Helin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John >> Sent: Monday, February 5, 2018 5:35 PM >> To: Zhao1, Wei; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for i

[dpdk-dev] [PATCH v2] examples/performance-thread: update copyrights and license

2018-02-08 Thread Lee Daly
This updates the Intel and Cavium license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. --- V2: Update commit message Signed-off-by: Lee Daly --- .../performance-thread/common/arch/x86/sta

Re: [dpdk-dev] [PATCH] net/mlx4: update Rx offload capabilities

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 12:43 PM, Adrien Mazarguil wrote: > On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote: >> This patch updates mlx4 Rx offload capabilities to also indicate that >> Rx CRC stripping is (always) supported. >> Since the device does not support disabeling CRC stripping the PMD >

Re: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 12:13 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, February 8, 2018 12:08 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon >> ; Ananyev, Konstantin >> ; mo...@mellanox.com; shah...

Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: >> Nor upstream kernel nor MLNX_OFED support such filter. >> >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") >> Cc: nelio.laranje...@6wind.com >> >> Signed-of

Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter

2018-02-08 Thread Thomas Monjalon
08/02/2018 15:35, Ferruh Yigit: > On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: > > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: > >> Nor upstream kernel nor MLNX_OFED support such filter. > >> > >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") > >> Cc

Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 2:38 PM, Thomas Monjalon wrote: > 08/02/2018 15:35, Ferruh Yigit: >> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: >>> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: Nor upstream kernel nor MLNX_OFED support such filter. Reverts commit 0fb2c9842b20 ("net/m

Re: [dpdk-dev] [PATCH] net/qede: fix tunnel init params

2018-02-08 Thread Ferruh Yigit
On 2/7/2018 9:51 PM, Rasesh Mody wrote: > From: Harish Patil > > Add the missing VF check to initialize tunnel params correctly. > > Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") > Cc: sta...@dpdk.org > > Signed-off-by: Harish Patil Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v1] doc: update tap with systems supported flows

2018-02-08 Thread Ophir Munk
Signed-off-by: Ophir Munk --- doc/guides/nics/tap.rst | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst index b69ee67..ea61be3 100644 --- a/doc/guides/nics/tap.rst +++ b/doc/guides/nics/tap.rst @@ -100,7 +1

Re: [dpdk-dev] [PATCH v2] examples/performance-thread: update copyrights and license

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 2:03 PM, Lee Daly wrote: > This updates the Intel and Cavium license on files in examples to be > the standard BSD-3-Clause license used for the rest of DPDK, bringing > the files in compliance with the DPDK licensing policy. > > --- > V2: Update commit message > > Signed-off-by: Lee

Re: [dpdk-dev] [PATCH v1] doc: update tap with systems supported flows

2018-02-08 Thread Pascal Mazon
Acked-by: Pascal Mazon On 08/02/2018 15:54, Ophir Munk wrote: > Signed-off-by: Ophir Munk > --- > doc/guides/nics/tap.rst | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst > index b69ee67..ea61be3 10

[dpdk-dev] Nehalem Intel Xeon X5506 architecture and PCIe NIC association to Numa node

2018-02-08 Thread Huertas García , Víctor
Hi all, After having tried many ways to make the PCIe NIC card appear associated to a numa node, I haven't been able to do it. That is, every time I try to look at which numa node belongs it always returns -1. $ cat /sys/bus/pci/devices/\:04\:00.1/numa_node -1 $ cat /sys/bus/pci/devices/0

[dpdk-dev] [PATCH v5 0/3] failsafe: fix calling device during RMV events

2018-02-08 Thread Matan Azrad
This series trys to mitigate failsafe race between control commands to the asynchronic plug-out\in processes. A full fix is required and will be sent later. v5(Matan): Change defines names to failsafe convention (UNSAFE). split a fix patch. v4(Matan): Rebase on top of 18.02-rc3. Extend the fix

[dpdk-dev] [PATCH v5 3/3] net/failsafe: fix calling device during RMV events

2018-02-08 Thread Matan Azrad
Following are the failure steps: 1. The physical device is removed due to change in one of PF parameters (e.g. MTU) 2. The interrupt thread flags the device 3. Within 2 seconds Interrupt thread initializes the actual device removal, then every 2 seconds it tries to re-sync (plug in) the device. The

[dpdk-dev] [PATCH v5 2/3] net/failsafe: fix removal scope

2018-02-08 Thread Matan Azrad
Fail-safe PMD uses per sub-device flag called "remove" to indicate the scope where the sub-device isn't synchronized with the fail-safe state. This flag is set when fail-safe gets RMV notification about the physical removal of the sub-device and should be unset when the sub-device completes all th

[dpdk-dev] [PATCH v5 1/3] net/failsafe: fix hotplug alarm cancel

2018-02-08 Thread Matan Azrad
The hot-plug alarm mechanism of fail-safe PMD is responsible for handling removed devices during a plug-out event and to restore them back to activity following a plug-in event. Fail-safe sets a flag called "pending_alarm" to validate that only one alarm callback is pending at any time. While this

[dpdk-dev] [PATCH v1] net/mlx: control netdevices through ioctl only

2018-02-08 Thread Adrien Mazarguil
Several control operations implemented by these PMDs affect netdevices through sysfs, itself subject to file system permission checks enforced by the kernel, which limits their use for most purposes to applications running with root privileges. Since performing the same operations through ioctl()

Re: [dpdk-dev] Nehalem Intel Xeon X5506 architecture and PCIe NIC association to Numa node

2018-02-08 Thread Bruce Richardson
On Thu, Feb 08, 2018 at 04:27:36PM +, Huertas García, Víctor wrote: > > Hi all, > > After having tried many ways to make the PCIe NIC card appear associated to a > numa node, I haven't been able to do it. > That is, every time I try to look at which numa node belongs it always > returns -1.

[dpdk-dev] [PATCH] vhost: fix offset while mmaping log base address

2018-02-08 Thread Tomasz Kulasek
QEMU always set offset to 0 but for sanity we should take the offset into account. Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") Cc: yuanhan@linux.intel.com Cc: sta...@dpdk.org Signed-off-by: Pawel Wodkowski Signed-off-by: Tomasz Kulasek --- lib/librte_vhost/vhost_user.

[dpdk-dev] [PATCH] vhost: fix check if cmsg is NULL

2018-02-08 Thread Tomasz Kulasek
Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") Cc: jianfeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Pawel Wodkowski Signed-off-by: Tomasz Kulasek --- lib/librte_vhost/socket.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_vhost/socket.c b/li

Re: [dpdk-dev] [PATCH v5 2/3] net/failsafe: fix removal scope

2018-02-08 Thread Gaëtan Rivet
Hi Matan, Thanks for dealing with this. On Thu, Feb 08, 2018 at 04:34:12PM +, Matan Azrad wrote: > Fail-safe PMD uses per sub-device flag called "remove" to indicate the > scope where the sub-device isn't synchronized with the fail-safe state. > > This flag is set when fail-safe gets RMV not

[dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask

2018-02-08 Thread Ajit Khaparde
Set the auto link speed only when force speed is not desired. Fixes: fe017534dfd4 ("net/bnxt: fix link speed setting with autoneg off") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c

Re: [dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 5:36 PM, Ajit Khaparde wrote: > Set the auto link speed only when force speed is not desired. > Fixes: fe017534dfd4 ("net/bnxt: fix link speed setting with autoneg off") > > Signed-off-by: Ajit Khaparde Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v1] doc: update tap with systems supported flows

2018-02-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pascal Mazon > Sent: Thursday, February 8, 2018 3:08 PM > To: Ophir Munk ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > Subject: Re: [dpdk-dev] [PATCH v1] doc: update tap with systems supported > flows Acke

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

2018-02-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ophir Munk > Sent: Thursday, February 8, 2018 6:56 AM > To: dev@dpdk.org; Adrien Mazarguil ; Moti > Haimovsky > Cc: Thomas Monjalon ; Olga Shern > ; Ophir Munk ; Matan Azrad > > Subject: [dpdk-dev] [PATCH v1] do

Re: [dpdk-dev] [PATCH v1] doc: update tap with systems supported flows

2018-02-08 Thread Ferruh Yigit
On 2/8/2018 3:07 PM, Pascal Mazon wrote: > On 08/02/2018 15:54, Ophir Munk wrote: >> Signed-off-by: Ophir Munk > > Acked-by: Pascal Mazon Acked-by: John McNamara Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v5 3/3] net/failsafe: fix calling device during RMV events

2018-02-08 Thread Gaëtan Rivet
On Thu, Feb 08, 2018 at 04:34:13PM +, Matan Azrad wrote: > Following are the failure steps: > 1. The physical device is removed due to change in one of PF parameters > (e.g. MTU) 2. The interrupt thread flags the device 3. Within 2 seconds > Interrupt thread initializes the actual device remova

Re: [dpdk-dev] [PATCH v1] doc: update dpdk proc info limitations

2018-02-08 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Wednesday, February 7, 2018 9:46 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Varghese, Vipin > ; Kovacevic, Marko > Subject: [PATCH v1] doc: update dpdk proc info limitations > > Updated the limitations for dpdk-procinfo to inform use

[dpdk-dev] [PATCH v3] doc: update the usage for shared library

2018-02-08 Thread Vipin Varghese
Add note information to intimate about use of option '-d' for shared library in DPDK application. Signed-off-by: Vipin Varghese --- V3 Changes: - updated from 'dpdk-testpmd' to 'testpmd' - John V2 Changes: - updated the space - John - updated testpmd to dpdk-testpmd - John --- doc/guides/ni

Re: [dpdk-dev] [dpdk-users] i40e VF Rx/Tx CRC Bytes Discrepancy

2018-02-08 Thread Matthew Coppola
Thank you for your prompt reply. BCC'd Users and added dev as I believe it is the more relevant channel. I apologize for using the wrong channel initially. I am happy to submit a patch if we would like to resolve the issue. I am confused why the hardware would have a different behavior for Rx/Tx

Re: [dpdk-dev] Nehalem Intel Xeon X5506 architecture and PCIe NIC association to Numa node

2018-02-08 Thread Victor Huertas
Bruce, My requirements are not that much (500 Mbps and 1 Gbps desirable). Thanks for your references links I will have a look at them. Regarding the NIC detection in the DPDK app by the DPDK EAL initialization after successfully having loaded the vfio-pci, it happens something strange. The n

Re: [dpdk-dev] [PATCH v5 2/3] net/failsafe: fix removal scope

2018-02-08 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Thursday, February 8, 2018 7:20 PM > Hi Matan, > > Thanks for dealing with this. > > On Thu, Feb 08, 2018 at 04:34:12PM +, Matan Azrad wrote: > > Fail-safe PMD uses per sub-device flag called "remove" to indicate the > > scope where the sub-device isn't synchron

Re: [dpdk-dev] [PATCH v5 3/3] net/failsafe: fix calling device during RMV events

2018-02-08 Thread Matan Azrad
Hi Gaetan > From: Gaëtan Rivet, Thursday, February 8, 2018 8:11 PM > On Thu, Feb 08, 2018 at 04:34:13PM +, Matan Azrad wrote: > > Following are the failure steps: > > 1. The physical device is removed due to change in one of PF > > parameters (e.g. MTU) 2. The interrupt thread flags the device

Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query

2018-02-08 Thread Thomas Monjalon
> > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > > (eal/ppc64: implement arch-specific TSC freq query). We intended to derive > > pkt/sec estimation with cpu clock frequency. As timebase register serves > the > > timer purpose, we need to stick with it for calculating pkt/sec, hen

Re: [dpdk-dev] [PATCH v2] buildtools: output build failure reason to stderr

2018-02-08 Thread Thomas Monjalon
07/02/2018 13:24, Neil Horman: > On Wed, Feb 07, 2018 at 08:24:00AM +, Andrew Rybchenko wrote: > > If build fails because of failed experimental check and stdout is > > redirected to /dev/null, it is absolutely unclear why build fails. > > > > Fixes: a4bcd61de82d ("buildtools: add script to ch

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix FDIR issue

2018-02-08 Thread Thomas Monjalon
> > This patch fixes issue during dealing with flow > > director filter. > > > > Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Beilei Xing > > Good catch, thanks! > > Acked-by: Jingjing Wu Applied, thanks

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add support for AES 256

2018-02-08 Thread Thomas Monjalon
> > Adding support for AES 256 algorithm in ipsec-secgw application > > > > Signed-off-by: Anoob Joseph > > --- > Acked-by: Radu Nicolau Applied, thanks

Re: [dpdk-dev] [PATCH v2] examples/performance-thread: update copyrights and license

2018-02-08 Thread Thomas Monjalon
08/02/2018 15:55, Ferruh Yigit: > On 2/8/2018 2:03 PM, Lee Daly wrote: > > This updates the Intel and Cavium license on files in examples to be > > the standard BSD-3-Clause license used for the rest of DPDK, bringing > > the files in compliance with the DPDK licensing policy. > > > > --- > > V2:

Re: [dpdk-dev] [PATCH] examples/l3fwd: update copyright and license

2018-02-08 Thread Thomas Monjalon
07/02/2018 17:15, Ferruh Yigit: > On 1/23/2018 4:45 PM, Lee Daly wrote: > > This updates the Intel and IBM license on files in examples to be the > > standard > > BSD-3-Clause license used for the rest of DPDK, > > bringing the files in compliance with the DPDK licensing policy. > > > > Signed-of

Re: [dpdk-dev] [PATCH v2] doc: update ip pipeline callback functions

2018-02-08 Thread Thomas Monjalon
08/02/2018 02:19, long...@viettel.com.vn: > From: longtb5 > > Update f_post_init for pipeline frontend. > Move f_track from pipeline backend to pipeline frontend. > > Signed-off-by: Bao-Long Tran > Acked-by: Marko Kovacevic Applied, thanks

Re: [dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

2018-02-08 Thread Thomas Monjalon
30/01/2018 11:01, Jeff Guo: > udev could not detect remove and add event of device when hotplug in > and out devices, that related with the fix about using pointer of > rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, > that would result igb uio irq failure when kernel versio

Re: [dpdk-dev] [PATCH v1] doc: update dpdk proc info limitations

2018-02-08 Thread Thomas Monjalon
> > Updated the limitations for dpdk-procinfo to inform user of the proper > > use. To avoid failures and build issues > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: add note on increased ring size to release notes

2018-02-08 Thread Thomas Monjalon
08/02/2018 14:08, Ferruh Yigit: > On 2/8/2018 12:47 PM, John McNamara wrote: > > Added note on the increased ring size in testpmd and the sample > > applications to the release note. > > > > Signed-off-by: John McNamara > > Acked-by: Ferruh Yigit Fixes: bd8f10f6d69f ("app/testpmd: increase def

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-02-08 Thread Thomas Monjalon
07/02/2018 11:17, Yulong Pei: > Add tested Intel platforms with Intel NICs to the release note. > > Signed-off-by: Yulong Pei Applied, thanks

[dpdk-dev] [dpdk-announce] release candidate 18.02-rc4

2018-02-08 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v18.02-rc4 The release notes should be closed now: http://dpdk.org/doc/guides/rel_notes/release_18_02.html There are a lot of deprecation notices waiting for merge in the 18.02 release notes. Pl

[dpdk-dev] OPDL and 18.02 Release Notes

2018-02-08 Thread Rosen, Rami
Hi all, Following the recent announcement of DPDK 18.02-RC4, I went over 18.02 release notes and I have this minor query which I am not sure about: In the release notes: http://dpdk.org/doc/guides/rel_notes/release_18_02.html we have the following: ... The OPDL (Ordered Packet Distribution Library)

Re: [dpdk-dev] [PATCH] vhost: fix check if cmsg is NULL

2018-02-08 Thread Tan, Jianfeng
Hi Tomasz, > -Original Message- > From: Kulasek, TomaszX > Sent: Friday, February 9, 2018 1:03 AM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; Tan, Jianfeng; sta...@dpdk.org; Wodkowski, PawelX > Subject: [PATCH] vhost: fix check if cmsg is NULL > > Fixes: 6a84c37e3975 ("net/virtio-user:

Re: [dpdk-dev] [PATCH] vhost: fix offset while mmaping log base address

2018-02-08 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Friday, February 9, 2018 1:00 AM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; yuanhan@linux.intel.com; sta...@dpdk.org; > Wodkowski, PawelX > Subject: [dpdk-dev] [PATCH] vhost: fix off

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-08 Thread Hemant Agrawal
On 2/8/2018 7:18 PM, Daly, Lee wrote: Subject: Re: [PATCH] examples: update copyrights and license Hi Lee, Hasan Alayli's license seems to be BSD-2-Clause, which is typically compatible with BSD-3-Clause. It will be ideal to get ACK from Hasan Alayli to re-license it as BSD-3- cl

[dpdk-dev] [PATCH] doc: add VxLAN GRO to release notes

2018-02-08 Thread Jiayu Hu
Signed-off-by: Jiayu Hu --- doc/guides/rel_notes/release_18_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index c42a1d6..c2078b5 100644 --- a/doc/guides/rel_notes/release_18_02.rst +++ b/doc/gui

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2018-02-08 Thread Wang, Zhihong
Hi Olivier, Given the situation that the vec path can be selected silently now once condition is met. So theoretically speaking this issue impacts the whole virtio pmd. If you plan to fix it in the next release, do you want to do a temporary workaround to disable the vec path selection till then?

[dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

2018-02-08 Thread Xiao Wang
Signed-off-by: Xiao Wang --- doc/guides/rel_notes/release_18_02.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index c42a1d64b..d9718c174 100644 --- a/doc/guides/rel_notes/release_18_02.rst +++ b/doc/g

[dpdk-dev] [PATCH] doc: add vhost-user live migration features to release notes

2018-02-08 Thread Jiayu Hu
Signed-off-by: Jiayu Hu --- doc/guides/rel_notes/release_18_02.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index c42a1d6..116ca2a 100644 --- a/doc/guides/rel_notes/release_18_02.rst +++ b/doc/

[dpdk-dev] [PATCH v2] doc: add vhost-user live migration features to release notes

2018-02-08 Thread Jiayu Hu
Signed-off-by: Jiayu Hu --- change in v2: - add VIRTIO_F_ANY_LAYOUT feature doc/guides/rel_notes/release_18_02.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index c42a1d6..1d31329 100644 --- a