Re: [dpdk-dev] [PATCH] ether: fix invalid string length in ethdev name comparison

2018-02-27 Thread Mohammad Abdul Awal
On 27/02/2018 00:15, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal + len1 = strlen(name); for (pid = 0; pid < RTE_MAX_ETHPORTS; pid++) { + len2 = strlen(rte_eth_dev_shared_data->data[

[dpdk-dev] [PATCH v2] ether: fix invalid string length in ethdev name comparison

2018-02-27 Thread Mohammad Abdul Awal
The current code compares two strings upto the length of 1st string (searched name). If the 1st string is prefix of 2nd string (existing name), the string comparison returns the port_id of earliest prefix matches. This patch fixes the bug by using strcmp instead of strncmp. Fixes: 9c5b8d8b9fe ("et

Re: [dpdk-dev] Back-up committers for subtrees

2018-02-27 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, February 21, 2018 11:05 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Back-up committers for subtrees > > Hi everyone, > > In the last few releases, the DPDK community

[dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-27 Thread Qi Zhang
This is the vanilla version. Packet data will copy between af_xdp memory buffer and mbuf mempool. indexes of memory buffer is simply managed by a fifo ring. Signed-off-by: Qi Zhang --- config/common_base| 5 + config/common_linuxapp| 1 + d

[dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-27 Thread Qi Zhang
The RFC patches add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below link for detail AF_XDP introduction: https://fosdem.org/2018/schedule/event/af_xdp/ https://lwn.net/Articles/745934/ This patchset is base on v18.02. It also require a lin

[dpdk-dev] [RFC 3/7] lib/mempool: allow page size aligned mempool

2018-02-27 Thread Qi Zhang
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang --- lib/librte_mempool/rte_mempool.c | 2 ++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 54f7f4

[dpdk-dev] [RFC 2/7] lib/mbuf: enable parse flags when create mempool

2018-02-27 Thread Qi Zhang
This give the option that applicaiton can configure each memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD). Signed-off-by: Qi Zhang --- lib/librte_mbuf/rte_mbuf.c | 15 --- lib/librte_mbuf/rte_mbuf.h | 8 +++- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [RFC 5/7] net/af_xdp: enable share mempool

2018-02-27 Thread Qi Zhang
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 191 +++- 1 fi

[dpdk-dev] [RFC 4/7] net/af_xdp: use mbuf mempool for buffer management

2018-02-27 Thread Qi Zhang
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be allocated from rte_mempool can be convert to descriptor index and vice versa. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 165 +--- 1 file changed, 97 insertions(+), 68 d

[dpdk-dev] [RFC 6/7] net/af_xdp: load BPF file

2018-02-27 Thread Qi Zhang
Add libbpf and libelf dependency in Makefile. Durring initialization, bpf file "xdpsock_kern.o" will be loaded. Then the driver will always try to link XDP fd with DRV mode first, then SKB mode if failed in previoius. Link will be released during dev_close. Note: this is workaround solution, af_xd

[dpdk-dev] [RFC 7/7] app/testpmd: enable parameter for mempool flags

2018-02-27 Thread Qi Zhang
Now, it is possible for testpmd to create a af_xdp friendly mempool. Signed-off-by: Qi Zhang --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c| 15 +-- app/test-pmd/testpmd.h| 1 + 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/app/test

[dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-27 Thread Qi Zhang
The RFC patches add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below link for detail AF_XDP introduction: https://fosdem.org/2018/schedule/event/af_xdp/ https://lwn.net/Articles/745934/ This patchset is base on v18.02. It also require a lin

[dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-27 Thread Qi Zhang
This is the vanilla version. Packet data will copy between af_xdp memory buffer and mbuf mempool. indexes of memory buffer is simply managed by a fifo ring. Signed-off-by: Qi Zhang --- config/common_base| 5 + config/common_linuxapp| 1 + d

[dpdk-dev] [RFC 3/7] lib/mempool: allow page size aligned mempool

2018-02-27 Thread Qi Zhang
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang --- lib/librte_mempool/rte_mempool.c | 2 ++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 54f7f4

[dpdk-dev] [RFC 2/7] lib/mbuf: enable parse flags when create mempool

2018-02-27 Thread Qi Zhang
This give the option that applicaiton can configure each memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD). Signed-off-by: Qi Zhang --- lib/librte_mbuf/rte_mbuf.c | 15 --- lib/librte_mbuf/rte_mbuf.h | 8 +++- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [RFC 6/7] net/af_xdp: load BPF file

2018-02-27 Thread Qi Zhang
Add libbpf and libelf dependency in Makefile. Durring initialization, bpf file "xdpsock_kern.o" will be loaded. Then the driver will always try to link XDP fd with DRV mode first, then SKB mode if failed in previoius. Link will be released during dev_close. Note: this is workaround solution, af_xd

[dpdk-dev] [RFC 7/7] app/testpmd: enable parameter for mempool flags

2018-02-27 Thread Qi Zhang
Now, it is possible for testpmd to create a af_xdp friendly mempool. Signed-off-by: Qi Zhang --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c| 15 +-- app/test-pmd/testpmd.h| 1 + 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/app/test

[dpdk-dev] [RFC 5/7] net/af_xdp: enable share mempool

2018-02-27 Thread Qi Zhang
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 191 +++- 1 fi

[dpdk-dev] [RFC 4/7] net/af_xdp: use mbuf mempool for buffer management

2018-02-27 Thread Qi Zhang
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be allocated from rte_mempool can be convert to descriptor index and vice versa. Signed-off-by: Qi Zhang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 165 +--- 1 file changed, 97 insertions(+), 68 d

Re: [dpdk-dev] [PATCH v2] ether: fix invalid string length in ethdev name comparison

2018-02-27 Thread Ananyev, Konstantin
> -Original Message- > From: Awal, Mohammad Abdul > Sent: Tuesday, February 27, 2018 8:58 AM > To: tho...@monjalon.net > Cc: rke...@gmail.com; dev@dpdk.org; Ananyev, Konstantin > ; Awal, Mohammad Abdul > > Subject: [PATCH v2] ether: fix invalid string length in ethdev name comparison >

[dpdk-dev] NXP's DPDK Roadmap for 18.05

2018-02-27 Thread Shreyansh Jain
Following are some of the key work items which we are planning for DPDK 1805: 1. Two rawdevice drivers - for communication interface to interact with a specialized block (AIOP: Advanced I/O Processor) on dpaa2. - and, for DMA accelerator support on dpaa2 devices to userspace 2. Crypto adapter

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-27 Thread Nicolau, Radu
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, February 27, 2018 6:57 AM > To: Nicolau, Radu ; Akhil Goyal > ; Doherty, Declan > Cc: Jerin Jacob ; Narayana Prasad > ; Nelio Laranjeiro > ; dev@dpdk.org > Subject: Re: [PATCH 1/5] lib/ethd

[dpdk-dev] [PATCH] ethdev: remove versioning of ethdev filter control function

2018-02-27 Thread Kirill Rybalchenko
In 18.02 release the ABI of ethdev component was changed. To keep compatibility with previous versions of the library the versioning of rte_eth_dev_filter_ctrl function was implemented. As soon as deprecation note was issued in 18.02 release, there is no need to keep compatibility with previous ver

Re: [dpdk-dev] [PATCH] ethdev: remove versioning of ethdev filter control function

2018-02-27 Thread Ferruh Yigit
On 2/27/2018 10:29 AM, Kirill Rybalchenko wrote: > In 18.02 release the ABI of ethdev component was changed. > To keep compatibility with previous versions of the library > the versioning of rte_eth_dev_filter_ctrl function was implemented. > As soon as deprecation note was issued in 18.02 release,

[dpdk-dev] [PATCH] maintainers: resign from GSO lib maintenance

2018-02-27 Thread Mark Kavanagh
I will not be directly working on the DPDK project anymore. Signed-off-by: Mark Kavanagh --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a646ca3..8fa79b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -792,7 +792,6 @@ F: doc/guides/prog_guide/gen

Re: [dpdk-dev] [RFC 1/3] vhost: invalidate vring addresses in cleanup_vq()

2018-02-27 Thread Jens Freimann
On Thu, Feb 22, 2018 at 07:19:08PM +0100, Maxime Coquelin wrote: When cleaning-up the virtqueue, we also need to invalidate its addresses to be sure outdated addresses won't be used later. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 6 -- lib/librte_vhost/vhost.h

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-27 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob On 27/02/18 15:49, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Tuesday, February 27, 2018 6:57 AM To: Nicolau, Radu ; Akhil Goyal ; Doherty, Declan Cc: Jerin Jacob ; Narayana Pras

Re: [dpdk-dev] [RFC 1/3] vhost: invalidate vring addresses in cleanup_vq()

2018-02-27 Thread Maxime Coquelin
Hi Jens, On 02/27/2018 12:22 PM, Jens Freimann wrote: On Thu, Feb 22, 2018 at 07:19:08PM +0100, Maxime Coquelin wrote: When cleaning-up the virtqueue, we also need to invalidate its addresses to be sure outdated addresses won't be used later. Signed-off-by: Maxime Coquelin --- lib/librte_vhos

Re: [dpdk-dev] [RFC 1/3] vhost: invalidate vring addresses in cleanup_vq()

2018-02-27 Thread Jens Freimann
On Tue, Feb 27, 2018 at 12:44:08PM +0100, Maxime Coquelin wrote: Hi Jens, On 02/27/2018 12:22 PM, Jens Freimann wrote: On Thu, Feb 22, 2018 at 07:19:08PM +0100, Maxime Coquelin wrote: [...] int?? slave_req_fd; +?? uint8_t?? virtio_status; Belongs

[dpdk-dev] [Bug 17] vhost example VLAN offloading not working on igb tx

2018-02-27 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=17 Bug ID: 17 Summary: vhost example VLAN offloading not working on igb tx Product: DPDK Version: 17.05 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

[dpdk-dev] [PATCH 00/14] net/sfc: support flow API for tunnels

2018-02-27 Thread Andrew Rybchenko
Update base driver and the PMD itself to support flow API patterns for tunnels: VXLAN, NVGRE and Geneve. Applicable to SFN8xxx NICs with full-feature firmware variant running. Andrew Rybchenko (1): doc: add net/sfc flow API support for tunnels Roman Zhukov (12): net/sfc/base: support filters

[dpdk-dev] [PATCH 04/14] net/sfc/base: distinguish filters for encapsulated packets

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Add filter match flag to distinguish filters applied only to encapsulated packets. Match flags set should allow to determine whether a filter is supported or not. The problem is that if specification has supported set outer match flags and specified encapsulation without any i

[dpdk-dev] [PATCH 06/14] net/sfc: add NVGRE in flow API filters support

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Exact match of virtual subnet ID is supported by parser. IP protocol match are enforced to GRE. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_flow.

[dpdk-dev] [PATCH 03/14] net/sfc/base: support VXLAN filter creation

2018-02-27 Thread Andrew Rybchenko
From: Vijay Srivastava Signed-off-by: Vijay Srivastava Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h| 7 +++ drivers/net/sfc/base/efx_filter.c | 36 2 files changed, 43 insertions(+) diff --git a/drivers/net/sfc/base/efx.h b/d

[dpdk-dev] [PATCH 14/14] doc: add net/sfc flow API support for tunnels

2018-02-27 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_18_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 3923dc2..894f636 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/do

[dpdk-dev] [PATCH 02/14] net/sfc/base: support VNI/VSID and inner frame local MAC

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov This supports VNI/VSID and inner frame local MAC fields to match in VXLAN, GENEVE, or NVGRE packets. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_filter.c | 18 ++ drivers/net/sfc/base/e

[dpdk-dev] [PATCH 11/14] net/sfc: multiply of specs w/o inner frame destination MAC

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Knowledge of a network identifier is not sufficient to construct a workable hardware filter for encapsulated traffic. It's obligatory to specify one of the match flags associated with inner frame destination MAC. If the address is unknown, then one needs to specify either unkno

[dpdk-dev] [PATCH 07/14] net/sfc: add GENEVE in flow API filters support

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Exact match of virtual network identifier is supported by parser. IP protocol match are enforced to UDP. Only Ethernet protocol type is supported. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/

[dpdk-dev] [PATCH 01/14] net/sfc/base: support filters for encapsulated packets

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov This adds filters for encapsulated packets to the list returned by ef10_filter_supported_filters(). Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/base/ef10_filter.c | 65 -- 1 f

[dpdk-dev] [PATCH 05/14] net/sfc: add VXLAN in flow API filters support

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Exact match of VXLAN network identifier is supported by parser. IP protocol match are enforced to UDP. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sf

[dpdk-dev] [PATCH 12/14] net/sfc: multiply of specs with an unknown destination MAC

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov To filter all traffic, need to create two hardware filter specifications with both unknown unicast and unknown multicast destination MAC address match flags. In terms of RTE flow API, this would require adding multiple flow rules with corresponding ETH items. In order to avoid

[dpdk-dev] [PATCH 10/14] net/sfc: multiply of specs with an unknown EtherType

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Hardware filter specification for encapsulated traffic must contain EtherType. In terms of RTE flow API, this would require L3 item to be used in the flow rule. In the simplest case, if the user needs to filter encapsulated traffic without knowledge of exact EtherType, they wil

[dpdk-dev] [PATCH 08/14] net/sfc: add inner frame ETH in flow API filters support

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Support destination MAC address match in inner frames. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 ++- drivers/net/sfc/sfc_flow.c | 73

[dpdk-dev] [PATCH 13/14] net/sfc: avoid creation of ineffective flow rules

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Despite being versatile, the hardware support for filtering has a number of special properties which must be taken into account. Namely, there is a known set of valid filters which don't take any effect despite being accepted by the hardware. The combinations of match flags an

[dpdk-dev] [PATCH 09/14] net/sfc: add infrastructure to make many filters from flow

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Not all flow rules can be expressed in one hardware filter, so some flow rules have to be expressed in terms of multiple hardware filters. This patch provides a means to produce a filter spec template from the flow rule which then can be used to produce a set of fully elaborate

Re: [dpdk-dev] [PATCH v2] net/tap: add tun support

2018-02-27 Thread Pascal Mazon
> Thanks, my first idea was use the same.       > Later argued myself in using 'tap_type' since the check for assigning MAC  

Re: [dpdk-dev] [PATCH 01/18] ethdev: support tunnel RSS level

2018-02-27 Thread Ferruh Yigit
On 2/26/2018 3:09 PM, Xueming Li wrote: > Currently PMD implementations default RSS on either tunnel outer or > inner fields. This patch introduced RSS level to allow user to specify > RSS hash field level of tunneled packets. > > 0: outer RSS. > 1: inner RSS. > 2-255: deep RSS level. > > Please

Re: [dpdk-dev] [RFC 2/3] vhost: add SET_VIRTIO_STATUS support

2018-02-27 Thread Jens Freimann
On Thu, Feb 22, 2018 at 07:19:09PM +0100, Maxime Coquelin wrote: This patch implements support for the new SET_VIRTIO_STATUS vhost-user request. The main use for this new request is for the backend to know when the driver sets the DRIVER_OK status bit. Starting Virtio 1.0, we know that once the

Re: [dpdk-dev] [PATCH 02/18] app/testpmd: support flow RSS level parsing

2018-02-27 Thread Ferruh Yigit
On 2/26/2018 3:09 PM, Xueming Li wrote: > Support new flow RSS level parameter to select inner or outer RSS > fields. Example: > > flow create 0 ingress pattern eth / ipv4 / udp dst is 4789 / vxlan / > end actions rss queues 1 2 end level 1 / end > > Signed-off-by: Xueming Li > --- > app/tes

[dpdk-dev] [PATCH 3/3] doc: add flow API drop action support to net/sfc

2018-02-27 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_18_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 894f636..d162daf 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/doc/guid

[dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API

2018-02-27 Thread Andrew Rybchenko
Update base driver and the PMD itself to support drop action in flow API. It should be applied on top of [1]. [1] http://dpdk.org/ml/archives/dev/2018-February/091530.html Andrew Rybchenko (1): doc: add flow API drop action support to net/sfc Roman Zhukov (2): net/sfc/base: support drop fil

[dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Add support for filters which drop packets when forming MCDI request for a filter. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_filter.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 2/3] net/sfc: support DROP action in flow API

2018-02-27 Thread Andrew Rybchenko
From: Roman Zhukov Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_flow.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst index f41ccdb..36e98d3 100644

[dpdk-dev] [PATCH v2 2/5] eal: don't process IPC messages before init finished

2018-02-27 Thread Anatoly Burakov
It is not possible for a primary process to receive any messages while initializing, because RTE_MAGIC value is not set in the shared config, and hence no secondary process can ever spin up during that time. However, it is possible for a secondary process to receive messages from the primary durin

[dpdk-dev] [PATCH v2 4/5] eal: prevent secondary process init while sending messages

2018-02-27 Thread Anatoly Burakov
Currently, it is possible to spin up a secondary process while either sendmsg or request is in progress. Fix this by adding directory locks during init, sendmsg and requests. Signed-off-by: Anatoly Burakov --- Notes: v2: added this patch lib/librte_eal/common/eal_common_proc.c | 47 +++

[dpdk-dev] [PATCH v2 1/5] eal: add internal flag indicating init has completed

2018-02-27 Thread Anatoly Burakov
Currently, primary process initialization is finalized by setting the RTE_MAGIC value in the shared config. However, it is not possible to check whether secondary process initialization has completed. Add such a value to internal config. Signed-off-by: Anatoly Burakov --- Notes: This patch i

[dpdk-dev] [PATCH v2 5/5] eal: don't hardcode socket filter value in IPC

2018-02-27 Thread Anatoly Burakov
Currently, filter value is hardcoded and disconnected from actual value returned by eal_mp_socket_path(). Fix this to generate filter value by deriving it from eal_mp_socket_path() instead. Signed-off-by: Anatoly Burakov --- Notes: v2: added this patch lib/librte_eal/common/eal_common_proc

[dpdk-dev] [PATCH v2 3/5] eal: use locks to determine if secondary process is active

2018-02-27 Thread Anatoly Burakov
Previously, IPC would remove sockets it considers to be "inactive" based on whether they have responded. Change this to create lock files in addition to socket files, so that we can determine if secondary process is active before attempting to communicate with it. That way, we can distinguish secon

Re: [dpdk-dev] [PATCH] ethdev: remove versioning of ethdev filter control function

2018-02-27 Thread Thomas Monjalon
27/02/2018 12:01, Ferruh Yigit: > On 2/27/2018 10:29 AM, Kirill Rybalchenko wrote: > > In 18.02 release the ABI of ethdev component was changed. > > To keep compatibility with previous versions of the library > > the versioning of rte_eth_dev_filter_ctrl function was implemented. > > As soon as dep

Re: [dpdk-dev] [PATCH 0/5] remove void pointer explicit cast

2018-02-27 Thread Ferruh Yigit
On 2/26/2018 8:10 AM, Zhiyong Yang wrote: > The patch series cleanup void pointer explicit cast related to > struct rte_flow_item fields in librte_flow_classify and make > code more readable. > > Zhiyong Yang (5): > flow_classify: remove void pointer cast > net/ixgbe: remove void pointer cast

Re: [dpdk-dev] [RFC 2/3] vhost: add SET_VIRTIO_STATUS support

2018-02-27 Thread Maxime Coquelin
On 02/27/2018 02:10 PM, Jens Freimann wrote: On Thu, Feb 22, 2018 at 07:19:09PM +0100, Maxime Coquelin wrote: This patch implements support for the new SET_VIRTIO_STATUS vhost-user request. The main use for this new request is for the backend to know when the driver sets the DRIVER_OK status

[dpdk-dev] [PATCH v2] ethdev: remove versioning of ethdev filter control function

2018-02-27 Thread Kirill Rybalchenko
In 18.02 release the ABI of ethdev component was changed. To keep compatibility with previous versions of the library the versioning of rte_eth_dev_filter_ctrl function was implemented. As soon as deprecation note was issued in 18.02 release, there is no need to keep compatibility with previous ver

[dpdk-dev] [PATCH] net/vdev_netvsc: fix routed devices probing

2018-02-27 Thread Matan Azrad
NetVSC netdevices which are already routed should not be probed because they are used for management purposes by the HyperV. The corrupted code got the routed devices from the system file /proc/net/route and wrongly parsed only the odd lines, so devices which their routes were in even lines, were

[dpdk-dev] [PATCH] event/sw: add unlikely branch predict

2018-02-27 Thread Vipin Varghese
For most run cases 'sw->started' holds true. Adding a branch prediction suggestion to compiler helps as this is first conditional check just after entering the function. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [dpdk-announce] DPDK 17.11.1 (LTS) released

2018-02-27 Thread Yuanhan Liu
Hi all, Here is a new LTS release: http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Thanks. --yliu --- app/Makefile | 2 +- app/test-pmd/Makefile |

[dpdk-dev] [RFC v2 0/3] host: multiqueue improvements

2018-02-27 Thread Maxime Coquelin
This second revision takes Jens comments into account, main change is fixing an off-by-one error in patch 2. The series introduce support for a new protocol request that notifies the backend with Virtio device status updates. Main goal is to be able with Virtio 1.0 devices to start the port even

[dpdk-dev] [RFC v2 1/3] vhost: invalidate vring addresses in cleanup_vq()

2018-02-27 Thread Maxime Coquelin
When cleaning-up the virtqueue, we also need to invalidate its addresses to be sure outdated addresses won't be used later. Signed-off-by: Maxime Coquelin Reviewed-by: Jens Freimann --- lib/librte_vhost/vhost.c | 6 -- lib/librte_vhost/vhost.h | 3 ++- lib/librte_vhost/vhost_user.

[dpdk-dev] [RFC v2 2/3] vhost: add SET_VIRTIO_STATUS support

2018-02-27 Thread Maxime Coquelin
This patch implements support for the new SET_VIRTIO_STATUS vhost-user request. The main use for this new request is for the backend to know when the driver sets the DRIVER_OK status bit. Starting Virtio 1.0, we know that once the the bit is set, no more queues will be initialized. When it happens

[dpdk-dev] [RFC v2 3/3] vhost_user: work around invalid rings addresses sent by QEMU

2018-02-27 Thread Maxime Coquelin
When the guest driver driver does not initialize all the queues, QEMU currently sends SET_VRING_ADDR request for these queues. In this case all the desc, avail and used addresses have GPA 0, so translating them likely succeed. The problem is that even if the uninitialized queues remain disabled, t

[dpdk-dev] [PATCH] event/sw: move stats code for better cache access

2018-02-27 Thread Vipin Varghese
variables 'out_pkts_total' and 'out_pkts_total' will be in registers. Hence shifting the code after the loop, helps the update from registers. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

[dpdk-dev] [PATCH v3 2/5] eal: don't process IPC messages before init finished

2018-02-27 Thread Anatoly Burakov
It is not possible for a primary process to receive any messages while initializing, because RTE_MAGIC value is not set in the shared config, and hence no secondary process can ever spin up during that time. However, it is possible for a secondary process to receive messages from the primary durin

[dpdk-dev] [PATCH v3 1/5] eal: add internal flag indicating init has completed

2018-02-27 Thread Anatoly Burakov
Currently, primary process initialization is finalized by setting the RTE_MAGIC value in the shared config. However, it is not possible to check whether secondary process initialization has completed. Add such a value to internal config. Signed-off-by: Anatoly Burakov --- Notes: This patch i

[dpdk-dev] [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC

2018-02-27 Thread Anatoly Burakov
Currently, filter value is hardcoded and disconnected from actual value returned by eal_mp_socket_path(). Fix this to generate filter value by deriving it from eal_mp_socket_path() instead. Signed-off-by: Anatoly Burakov --- Notes: v3: no changes v2: no changes lib/librte_eal/comm

[dpdk-dev] [PATCH v3 4/5] eal: prevent secondary process init while sending messages

2018-02-27 Thread Anatoly Burakov
Currently, it is possible to spin up a secondary process while either sendmsg or request is in progress. Fix this by adding directory locks during init, sendmsg and requests. Signed-off-by: Anatoly Burakov --- Notes: v3: no changes v2: no changes lib/librte_eal/common/eal_common_p

[dpdk-dev] [PATCH v3 3/5] eal: use locks to determine if secondary process is active

2018-02-27 Thread Anatoly Burakov
Previously, IPC would remove sockets it considers to be "inactive" based on whether they have responded. Change this to create lock files in addition to socket files, so that we can determine if secondary process is active before attempting to communicate with it. That way, we can distinguish secon

[dpdk-dev] meson support : cross compile issues

2018-02-27 Thread Hemant Agrawal
Hi, How do we set CROSS COMPILE kernel path support. E.g. something equivalent to RTE_KERNELDIR for Makefile * Currently the Igb_uio compilation fails. * Also, there is no check to disable igb_uio compilation by flag e.g. CONFIG_RTE_EAL_IGB_UIO=n Other minor issue observed is

[dpdk-dev] [PATCH 1/4] eal: use sizeof to avoid a double use of a define

2018-02-27 Thread Olivier Matz
Only a cosmetic change: the *_LEN defines are already used when defining the buffer. Using sizeof() ensures that the length stays consistent, even if the definition is modified. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/bsdapp/eal/eal_thread.

[dpdk-dev] [PATCH 0/4] fix control thread affinities

2018-02-27 Thread Olivier Matz
Some parts of dpdk use their own management threads. Most of the time, the affinity of the thread is not properly set: it should not be scheduled on the dataplane cores, because interrupting them can cause packet losses. This patchset introduces a new wrapper for thread creation that does the job

[dpdk-dev] [PATCH 2/4] eal: new function to create control threads

2018-02-27 Thread Olivier Matz
Many parts of dpdk use their own management threads. Introduce a new wrapper for thread creation that will be extended in next commits to set the name and affinity. To be consistent with other DPDK APIs, the return value is negative in case of error, which was not the case for pthread_create(). S

[dpdk-dev] [PATCH 3/4] eal: set name when creating a control thread

2018-02-27 Thread Olivier Matz
To avoid code duplication, add a parameter to rte_ctrl_thread_create() to specify the name of the thread. This requires to add a wrapper for the thread start routine in rte_thread_init(), which will first wait that the thread is configured. Signed-off-by: Olivier Matz --- drivers/net/kni/rte_et

[dpdk-dev] [PATCH 4/4] eal: set affinity for control threads

2018-02-27 Thread Olivier Matz
The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 20 +++- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 22 inse

Re: [dpdk-dev] meson support : cross compile issues

2018-02-27 Thread Bruce Richardson
On Tue, Feb 27, 2018 at 02:38:53PM +, Hemant Agrawal wrote: > Hi, > > How do we set CROSS COMPILE kernel path support. E.g. something equivalent to > RTE_KERNELDIR for Makefile > > * Currently the Igb_uio compilation fails. > * Also, there is no check to disable igb_uio compil

[dpdk-dev] [PATCH] eal: add asynchronous request API to DPDK IPC

2018-02-27 Thread Anatoly Burakov
This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller. Under the hood, we create a separate thread to deal with replies to asynchronous requests, that will just wait to be notified by the main thread, or woken up on a timer

[dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-02-27 Thread Olivier Matz
Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation is successful. The patch also updates all th

[dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause

2018-02-27 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch fixes the compilation problem with rte_smp_mb, when there is else clause following it, as in test_barrier.c. Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- lib/librte_

Re: [dpdk-dev] [PATCH] maintainers: resign from GSO lib maintenance

2018-02-27 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mark Kavanagh > Sent: Tuesday, February 27, 2018 7:01 PM > To: dev@dpdk.org > Cc: Hu, Jiayu; Kavanagh, Mark B > Subject: [dpdk-dev] [PATCH] maintainers: resign from GSO lib maintenance > > I will not be directly

Re: [dpdk-dev] [PATCH 03/18] ethdev: introduce new tunnel VXLAN-GPE

2018-02-27 Thread Mohammad Abdul Awal
On 26/02/2018 15:09, Xueming Li wrote: diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 45daa91..fe02ad8 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -310,6 +310,31 @@ struct vxlan_hdr { /**< VXLAN tunnel header length. */ /** + *

[dpdk-dev] [PATCH] event/sw: code refractor for counter set

2018-02-27 Thread Vipin Varghese
Counter variable 'out_pkts' had been set to 0, then updated. Current code change elimates double assignment to direct assignment. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evde

[dpdk-dev] tunnel endpoint hw acceleration enablement

2018-02-27 Thread Doherty, Declan
Invite for a DPDK community call to discuss the tunnel endpoint hw acceleration proposal in this RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html) and the related community feedback. Proposed agenda: - Summary of RFC proposal, treating TEPs as standalone entities which flows get

[dpdk-dev] Issue building for ppc64le

2018-02-27 Thread Marco Varlese
Hi, Is anybody else experiencing issues with building DPDK 17.11 for ppc64le? Any help would be very much appreciated. I get the below error: == START == [ 326s] gcc -Wp,-MD,./.power_manager.o.d.tmp -m64 -pthread -fPIC - DRTE_MACHINE_CPUFLAG_PPC64 -DRTE_MACHINE_CPUFLAG_ALTIVEC -DRTE_MACHINE_

[dpdk-dev] [PATCH 1/4] net/ixgbe: support VLAN strip per queue offloading in PF

2018-02-27 Thread Wei Dai
VLAN strip is a per queue offloading in PF. With this patch it can be enabled or disabled on any Rx queue in PF. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 109 +-- drivers/net/ixgbe/ixgbe_ethdev.h | 4 +- drivers/net/ixgbe/ixgbe_pf.c

[dpdk-dev] [PATCH 0/4] ixgbe: convert to new offloads API

2018-02-27 Thread Wei Dai
This patch set adds support of per queue VLAN strip offloading in ixgbe PF and VF. This patch support new offloads API in ixgbe PF and VF. Wei Dai (4): net/ixgbe: support VLAN strip per queue offloading in PF net/ixgbe: support VLAN strip per queue offloading in VF net/ixgbe: convert to new

[dpdk-dev] [PATCH 4/4] net/ixgbe: convert to new Tx offloads API

2018-02-27 Thread Wei Dai
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 40 +++-- drivers/net/ixgbe/ixgbe_ipsec.c | 5 +++- drivers/n

[dpdk-dev] [PATCH 3/4] net/ixgbe: convert to new Rx offloads API

2018-02-27 Thread Wei Dai
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 88 +- drivers/net/ixgbe/ixgbe_ipsec.c | 8 +-

[dpdk-dev] [PATCH 2/4] net/ixgbe: support VLAN strip per queue offloading in VF

2018-02-27 Thread Wei Dai
VLAN strip is a per queue offloading in VF. With this patch it can be enabled or disabled on any Rx queue in VF. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH v2 02/10] lib/librte_vhost: add virtio-crypto user message structure

2018-02-27 Thread Fan Zhang
This patch adds virtio-crypto spec user message structure to vhost_user. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_user.c | 2 ++ lib/librte_vhost/vhost_user.h | 31 ++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_u

[dpdk-dev] [PATCH v2 01/10] lib/librte_vhost: add vhost user private info structure

2018-02-27 Thread Fan Zhang
This patch adds a vhost_user_dev_priv structure and a vhost_user message handler function prototype to vhost_user. This allows different types of devices to add private information and their device-specific vhost-user message function handlers to virtio_net structure. The change to vhost_user_msg_h

[dpdk-dev] [PATCH v2 03/10] lib/librte_vhost: add session message handler

2018-02-27 Thread Fan Zhang
This patch adds session message handler to vhost crypto Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 399 1 file changed, 399 insertions(+) create mode 100644 lib/librte_vhost/vhost_crypto.c diff --git a/lib/librte_vhost/vhost_crypto.c

[dpdk-dev] [PATCH v2 04/10] lib/librte_vhost: add request handler

2018-02-27 Thread Fan Zhang
This patch adds the implementation that parses virtio crypto request to dpdk crypto operation Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 607 1 file changed, 607 insertions(+) diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_

[dpdk-dev] [PATCH v2 05/10] lib/librte_vhost: add head file

2018-02-27 Thread Fan Zhang
This patch adds public head file API for vhost crypto Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost_crypto.h | 122 1 file changed, 122 insertions(+) create mode 100644 lib/librte_vhost/rte_vhost_crypto.h diff --git a/lib/librte_vhost/rte_vhost_cr

  1   2   >