Re: [dpdk-dev] [PATCH 1/4] vhost: move fdset functions from fd_man.c to fd_man.h

2018-03-05 Thread Thomas Monjalon
05/03/2018 08:43, Yang, Zhiyong: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 01/03/2018 07:02, Tan, Jianfeng: > > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > > > On 02/28/2018 02:36 AM, Yang, Zhiyong wrote: > > > > > From: Maxime Coquelin [mailto:maxime.coque...@red

Re: [dpdk-dev] [PATCH 31/41] ethdev: use contiguous allocation for DMA memory

2018-03-05 Thread Burakov, Anatoly
On 03-Mar-18 2:05 PM, Andrew Rybchenko wrote: On 03/03/2018 04:46 PM, Anatoly Burakov wrote: This fixes the following drivers in one go: Does it mean that these drivers are broken in the middle of patch set and fixed now? If so, it would be good to avoid it. It breaks bisect. Depends on t

Re: [dpdk-dev] [PATCH 31/41] ethdev: use contiguous allocation for DMA memory

2018-03-05 Thread Andrew Rybchenko
On 03/05/2018 12:08 PM, Burakov, Anatoly wrote: On 03-Mar-18 2:05 PM, Andrew Rybchenko wrote: On 03/03/2018 04:46 PM, Anatoly Burakov wrote: This fixes the following drivers in one go: Does it mean that these drivers are broken in the middle of patch set and fixed now? If so, it would be go

[dpdk-dev] [PATCH v2 1/6] vhost: export vhost feature definitions

2018-03-05 Thread Zhihong Wang
This patch exports vhost-user protocol features to support device driver development. Signed-off-by: Zhihong Wang --- lib/librte_vhost/rte_vhost.h | 8 lib/librte_vhost/vhost.h | 4 +--- lib/librte_vhost/vhost_user.c | 9 + lib/librte_vhost/vhost_user.h | 20 +++

[dpdk-dev] [PATCH v2 0/6] vhost: support selective datapath

2018-03-05 Thread Zhihong Wang
This patch set introduces support for selective datapath in DPDK vhost-user lib. vDPA stands for vhost Data Path Acceleration. The idea is to enable various types of virtio-compatible devices to do data transfer with virtio driver directly to enable acceleration. The default datapath is the existi

[dpdk-dev] [PATCH v2 3/6] vhost: add apis for datapath configuration

2018-03-05 Thread Zhihong Wang
This patch adds APIs for datapath configuration. The eid and did of the vhost-user socket can be configured to identify the actual device. When the default software datapath is used, eid and did are set to -1. When alternative datapath is used, eid and did are set by app to specify which device to

[dpdk-dev] [PATCH v2 2/6] vhost: support selective datapath

2018-03-05 Thread Zhihong Wang
This patch introduces support for selective datapath in DPDK vhost-user lib to enable various types of virtio-compatible devices to do data transfer with virtio driver directly to enable acceleration. The default datapath is the existing software implementation, more options will be available when

[dpdk-dev] [PATCH v2 4/6] vhost: adapt vhost lib for selective datapath

2018-03-05 Thread Zhihong Wang
This patch adapts vhost lib for selective datapath by calling device ops at the corresponding stage. Signed-off-by: Zhihong Wang --- Changes in v2: 1. Ensure negotiated capabilities are supported in vhost-user lib. 2. Configure the data path at the right time. lib/librte_vhost/rte_vhost.h

[dpdk-dev] [PATCH v2 5/6] vhost: add apis for live migration

2018-03-05 Thread Zhihong Wang
This patch adds APIs to enable live migration for non-builtin data paths. At src side, last_avail/used_idx from the device need to be set into the virtio_net structure, and the log_base and log_size from the virtio_net structure need to be set into the device. At dst side, last_avail/used_idx nee

[dpdk-dev] [PATCH v2 6/6] vhost: export new apis

2018-03-05 Thread Zhihong Wang
This patch exports new APIs as experimental. Signed-off-by: Zhihong Wang --- lib/librte_vhost/rte_vdpa.h| 16 +++- lib/librte_vhost/rte_vhost.h | 33 ++--- lib/librte_vhost/rte_vhost_version.map | 19 +++ 3 files chang

[dpdk-dev] [PATCH] usertools: add support for AVP device

2018-03-05 Thread Xiaohua Zhang
Signed-off-by: Xiaohua Zhang --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 18d9386..ff4b186 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -22,8 +22,10 @@

Re: [dpdk-dev] [PATCH] usertools: add support for AVP device

2018-03-05 Thread Ferruh Yigit
On 3/5/2018 9:16 AM, Xiaohua Zhang wrote: > Signed-off-by: Xiaohua Zhang Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 2/4] bus/vdev: bus scan by multi-process channel

2018-03-05 Thread Burakov, Anatoly
On 04-Mar-18 3:30 PM, Jianfeng Tan wrote: To scan the vdevs in primary, we send request to primary process to obtain the names for vdevs. Only the name is shared from the primary. In probe(), the device driver is supposed to locate (or request more) the detail information from the primary. Sign

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-03-05 Thread Luca Boccassi
On Mon, 2018-02-26 at 11:34 +, Luca Boccassi wrote: > Hi all, > > Here is a list of patches targeted for LTS release 16.11.5. Please > help review and test. The planned date for the final release is March > the 5th, pending results from regression tests. > Before that, please shout if anyone h

Re: [dpdk-dev] [PATCH 31/41] ethdev: use contiguous allocation for DMA memory

2018-03-05 Thread Burakov, Anatoly
On 05-Mar-18 9:15 AM, Andrew Rybchenko wrote: On 03/05/2018 12:08 PM, Burakov, Anatoly wrote: On 03-Mar-18 2:05 PM, Andrew Rybchenko wrote: On 03/03/2018 04:46 PM, Anatoly Burakov wrote: This fixes the following drivers in one go: Does it mean that these drivers are broken in the middle of p

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-03-05 Thread Luca Boccassi
On Mon, 2018-03-05 at 11:31 +0530, gowrishankar muthukrishnan wrote: > Hi Luca, > In powerpc to support i40e, we wish below patch be merged: > > c3def6a8724 net/i40e: implement vector PMD for altivec > > I have verified br-16.11 with the above commit (in cherry-pick, I > needed  > to remove relea

Re: [dpdk-dev] librte_power w/ intel_pstate cpufreq governor

2018-03-05 Thread Hunt, David
Hi BL, I have always used "intel_pstate=disable" in my kernel parameters at boot so as to disable the intel_pstate driver, and force the kernel to use the acpi-cpufreq driver: # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver acpi-cpufreq This then gives me the following options for

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-05 Thread Adrien Mazarguil
On Tue, Feb 27, 2018 at 04:11:29PM +0100, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

Re: [dpdk-dev] [PATCH 02/18] app/testpmd: support flow RSS level parsing

2018-03-05 Thread Xueming(Steven) Li
Thanks for reminding, I'll update in next version. > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, February 27, 2018 9:10 PM > To: Xueming(Steven) Li ; Wenzhuo Lu > ; Jingjing Wu ; Thomas > Monjalon ; NĂ©lio Laranjeiro > ; Adrien Mazarguil > ; Shah

Re: [dpdk-dev] librte_power w/ intel_pstate cpufreq governor

2018-03-05 Thread longtb5
Hi Dave, Actually in my test lab which is a HP box running CentOS 7 on kernel version 3.10.0-693.5.2.el7.x86_64, the default cpufreq driver is pcc_cpufreq. So I guess disabling intel_pstate wouldn't help in my case. # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver pcc-cpufreq # cat /s

Re: [dpdk-dev] [PATCH 32/41] crypto/qat: use contiguous allocation for DMA memory

2018-03-05 Thread Trahe, Fiona
> -Original Message- > From: Burakov, Anatoly > Sent: Saturday, March 3, 2018 1:46 PM > To: dev@dpdk.org > Cc: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K > ; Wiles, Keith ; Tan, Jianfeng > ; andras.kov...@ericsson.com; > laszlo.vadk...@ericsson.com; Walker, > Benjamin ; Richardson,

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Ferruh Yigit
On 1/18/2018 4:35 PM, Matan Azrad wrote: > rte_eth_dev_data structure is allocated per ethdev port and can be > used to get a data of the port internally. > > rte_eth_dev_attach_secondary tries to find the port identifier using > rte_eth_dev_data name field comparison and may get an identifier of

Re: [dpdk-dev] librte_power w/ intel_pstate cpufreq governor

2018-03-05 Thread Hunt, David
Hi BL, On 5/3/2018 10:48 AM, long...@viettel.com.vn wrote: Hi Dave, Actually in my test lab which is a HP box running CentOS 7 on kernel version 3.10.0-693.5.2.el7.x86_64, the default cpufreq driver is pcc_cpufreq. So I guess disabling intel_pstate wouldn't help in my case. # cat /sys/device

[dpdk-dev] [PATCH v3 02/10] net/mlx5: name parameters in function prototypes

2018-03-05 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 191 --- drivers/net/mlx5/mlx5_rxtx.h | 162 2 files changed, 195 insertions(+), 158 deletions(-) diff --git a/drivers/net/m

[dpdk-dev] [PATCH v3 03/10] net/mlx5: mark parameters with unused attribute

2018-03-05 Thread Nelio Laranjeiro
Replaces all (void)foo; by __rte_unused macro except when variables are under #if statements. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 4 ++-- drivers/net/mlx5/mlx5_ethdev.c | 18 +-- drivers/net/mlx5/mlx5_flow.c| 25

[dpdk-dev] [PATCH v3 01/10] net/mlx5: fix sriov flag

2018-03-05 Thread Nelio Laranjeiro
priv_get_num_vfs() was used to help the PMD in prefetching the mbuf in datapath when the PMD was behaving in VF mode. This knowledge is no more used. Fixes: 528a9fbec6de ("net/mlx5: support ConnectX-5 devices") Cc: ys...@mellanox.com Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --

[dpdk-dev] [PATCH v3 04/10] net/mlx5: normalize function prototypes

2018-03-05 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 2 +- drivers/net/mlx5/mlx5_mr.c | 11 ++- drivers/net/mlx5/mlx5_rxq.c | 16 drivers/net/mlx5/mlx5_txq.c | 8 4 files changed, 19 insertions(+), 18 deletions(-)

[dpdk-dev] [PATCH v3 00/10] net/mlx5: clean driver

2018-03-05 Thread Nelio Laranjeiro
- Removes unused SR-IOV flag. - Adds missing documentation on some functions. - Removes the spin-lock on the private structure. - Standardize the return values of all functions as discussed on the mailing list [1]. [1] https://dpdk.org/ml/archives/dev/2018-January/087991.html Changes in v2: -

[dpdk-dev] [PATCH v3 06/10] net/mlx5: remove useless empty lines

2018-03-05 Thread Nelio Laranjeiro
Some empty lines have been added in the middle of the code without any reason. This commit removes them. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c| 22 -- drivers/net/mlx5/mlx5_ethdev.c | 7 --- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v3 05/10] net/mlx5: add missing function documentation

2018-03-05 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 18 ++ drivers/net/mlx5/mlx5_mr.c | 7 +-- drivers/net/mlx5/mlx5_rxq.c | 20 drivers/net/mlx5/mlx5_trigger.c | 30 ++ dr

[dpdk-dev] [PATCH v3 07/10] net/mlx5: remove control path locks

2018-03-05 Thread Nelio Laranjeiro
In priv struct only the memory region needs to be protected against concurrent access between the control plane and the data plane. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 2 -- drivers/net/mlx5/mlx5.h | 43 +-

[dpdk-dev] [PATCH v3 09/10] net/mlx5: change non failing function return values

2018-03-05 Thread Nelio Laranjeiro
These functions return int although they are not supposed to fail, resulting in unnecessary checks in their callers. Some are returning error where is should be a boolean. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 4 ++-- drivers/net/mlx5/

[dpdk-dev] [PATCH v3 10/10] net/mlx5: standardize on negative errno values

2018-03-05 Thread Nelio Laranjeiro
Set rte_errno systematically as well. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 88 ++- drivers/net/mlx5/mlx5_ethdev.c | 231 - drivers/net/mlx5/mlx5_flow.c| 317 +++-

Re: [dpdk-dev] librte_power w/ intel_pstate cpufreq governor

2018-03-05 Thread longtb5
Hi Dave, Unfortunately I do not have access to our server BIOS settings. The power management task for our appliance is also on pending. I'm expecting to return to this task in April. Maybe we can still work out a patch before 18.05 (not sure about DPDK roadmap). Regards, -BL > -Original

[dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-05 Thread Vipin Varghese
dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to the device-queue pair. Updating Makefile to check for the same. Signed-off-by: Vipin Varghese --- app/pdump/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/app/pdump/Makefile b/app/pdump/Makefile index bd3c208..

[dpdk-dev] [PATCH 0/2] net/mlx5: convert to dynamic logs

2018-03-05 Thread Nelio Laranjeiro
This series applies on top of [1] [1] https://dpdk.org/dev/patchwork/patch/35650/ Nelio Laranjeiro (2): net/mlx5: use port id in PMD log net/mlx5: use dynamic logging drivers/net/mlx5/mlx5.c | 227 +++- drivers/net/mlx5/mlx5_ethdev.c | 112 ++

[dpdk-dev] [PATCH 1/2] net/mlx5: use port id in PMD log

2018-03-05 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 79 +--- drivers/net/mlx5/mlx5_ethdev.c | 86 + drivers/net/mlx5/mlx5_flow.c| 82 +--- drivers/net/mlx5/mlx5_mac.c | 9 +- drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH 2/2] net/mlx5: use dynamic logging

2018-03-05 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 238 ++-- drivers/net/mlx5/mlx5_ethdev.c | 118 +--- drivers/net/mlx5/mlx5_flow.c| 109 --- drivers/net/mlx5/mlx5_mac.c | 12 +- drivers/

Re: [dpdk-dev] [PATCH] net/null:Different mac address support

2018-03-05 Thread Ferruh Yigit
On 2/3/2018 2:11 AM, Mallesh Koujalagi wrote: > After attaching two Null device to ovs, seeing "00.00.00.00.00.00" mac > address for both null devices. Fix this issue, by setting different mac > address. > > Signed-off-by: Mallesh Koujalagi > --- > drivers/net/null/rte_eth_null.c | 23 ++

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-05 Thread Verma, Shally
>-Original Message- >From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >Sent: 03 March 2018 01:19 >To: Trahe, Fiona ; Verma, Shally >; dev@dpdk.org >Cc: De Lara Guarch, Pablo ; Athreya, Narayana >Prasad ; >Gupta, Ashish ; Sahu, Sunila >; Challa, Mahipal >; Jain, Deepak K ; Hemant >Ag

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-05 Thread Ferruh Yigit
On 3/5/2018 7:57 AM, Vipin Varghese wrote: > dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to > the device-queue pair. Updating Makefile to check for the same. > > Signed-off-by: Vipin Varghese > --- > app/pdump/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --

[dpdk-dev] [PATCH v3 4/7] app/testpmd: introduce VXLAN GPE to csum forwarding engine

2018-03-05 Thread Xueming Li
This patch introduced VXLAN-GPE support to csum forwarding engine by recognizing VXLAN-GPE UDP port and parsing tunnel payload according to next-protocol type. Signed-off-by: Xueming Li --- app/test-pmd/csumonly.c | 96 +-- app/test-pmd/parameters.c

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Matan Azrad
HI From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM > On 1/18/2018 4:35 PM, Matan Azrad wrote: > > rte_eth_dev_data structure is allocated per ethdev port and can be > > used to get a data of the port internally. > > > > rte_eth_dev_attach_secondary tries to find the port identifier using >

[dpdk-dev] [PATCH v3 1/7] ethdev: introduce Tx generic tunnel L3/L4 offload

2018-03-05 Thread Xueming Li
This patch introduce new TX offload flags for device that supports tunnel agnostic L3/L4 checksum and TSO offload. The support from the device is for inner and outer checksums on IPV4/TCP/UDP and TSO for *any packet with the following format*: < some headers > / [optional IPv4/IPv6] / [optional T

[dpdk-dev] [PATCH v3 3/7] app/testpmd: add more GRE extension to csum engine

2018-03-05 Thread Xueming Li
This patch adds GRE checksum and sequence extension supports in addtion to key extension to csum forwarding engine. Signed-off-by: Xueming Li --- app/test-pmd/csumonly.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-p

[dpdk-dev] [PATCH v3 5/7] net/mlx5: separate TSO function in Tx data path

2018-03-05 Thread Xueming Li
Separate TSO function to make logic of mlx5_tx_burst clear. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_rxtx.c | 112 ++- 1 file changed, 67 insertions(+), 45 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c in

[dpdk-dev] [PATCH v3 0/7] support generic tunnel Tx checksum and TSO

2018-03-05 Thread Xueming Li
- Add VXLAN-GPE and GRE extention support to testpmd csum forwarding enginee - Split DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM_TSO into DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM and DEV_TX_OFFLOAD_GENERIC_TNL_TSO - Add PKT_TX_TUNNEL_UNKNOWN and PKT_TX_OUTER_UDP http://www.dpdk.org/dev/patchwork/patch/34655/

[dpdk-dev] [PATCH v3 6/7] net/mlx5: support generic tunnel offloading

2018-03-05 Thread Xueming Li
This commit adds support for generic tunnel TSO and checksum offload. PMD will compute the inner/outer headers offset according to the mbuf fields. Hardware will do calculation based on offsets and types. Signed-off-by: Xueming Li --- doc/guides/nics/mlx5.rst | 8 +++ drivers/net/

[dpdk-dev] [PATCH v3 2/7] app/testpmd: testpmd support Tx generic tunnel offloads

2018-03-05 Thread Xueming Li
"show port cap" and "csum parse tunnel" command support TX generic tunnel offloads Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 9 +++-- app/test-pmd/config.c | 18 ++ app/test-pmd/csumonly.c | 3 ++- 3 files changed, 27 insertions(+), 3 deletions(-) diff --gi

[dpdk-dev] [PATCH v3 7/7] net/mlx5: allow max 192B TSO inline header length

2018-03-05 Thread Xueming Li
Change max inline header length to 192B to allow IPv6 VXLAN TSO headers and header with options that more than 128B. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-03-05 Thread Ferruh Yigit
On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > @@ -2082,3 +2084,14 @@ RTE_PMD_REGISTER_PARAM_STRING(net_sfc_efx, > SFC_KVARG_STATS_UPDATE_PERIOD_MS "= " > SFC_KVA

Re: [dpdk-dev] [PATCH 0/6] net/sfc: implement dynamic logging

2018-03-05 Thread Ferruh Yigit
On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: > Unfortunately we're a bit late with dynamic logging implementation. > So, it can wait for 18.05 release cycle if required. > > The series adds EXPERIMENTAL EAL feature which removes dependency > on EAL arguments processing and log types registration.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Ferruh Yigit
On 3/5/2018 2:52 PM, Matan Azrad wrote: > HI > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM >> On 1/18/2018 4:35 PM, Matan Azrad wrote: >>> rte_eth_dev_data structure is allocated per ethdev port and can be >>> used to get a data of the port internally. >>> >>> rte_eth_dev_attach_seco

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-05 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM > On 3/5/2018 2:52 PM, Matan Azrad wrote: > > HI > > > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM > >> On 1/18/2018 4:35 PM, Matan Azrad wrote: > >>> rte_eth_dev_data structure is allocated per ethdev port and can be

Re: [dpdk-dev] [PATCH] net/null: Support bulk alloc and free.

2018-03-05 Thread Ferruh Yigit
On 2/3/2018 3:11 AM, Mallesh Koujalagi wrote: > After bulk allocation and freeing of multiple mbufs increase more than ~2% > throughput on single core. > > Signed-off-by: Mallesh Koujalagi > --- > drivers/net/null/rte_eth_null.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletio

Re: [dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-03-05 Thread Ferruh Yigit
On 2/6/2018 11:21 AM, zhouyangchao wrote: Can you please provide more information why this patch is needed? > Signed-off-by: Yangchao Zhou > --- > drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/dr

Re: [dpdk-dev] [PATCH] net/null: Support bulk alloc and free.

2018-03-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, March 5, 2018 3:25 PM > To: Koujalagi, MalleshX ; dev@dpdk.org > Cc: mtetsu...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] net/null: Support bulk alloc and free. > > On 2/3/2018 3:11

[dpdk-dev] [PATCH] vhost: maintain separate virtio features field

2018-03-05 Thread Tomasz Kulasek
There are two separate abstraction layers: * vsocket - which represents a unix domain socket * virtio_net - which represents a vsocket connection There can be many connections on the same socket. vsocket provides an API to enable/disable particular virtio features on the fly, but it's the virtio_n

[dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings

2018-03-05 Thread Tomasz Kulasek
vhost-net devices might keep track of last descriptors indices by themselves, and assuming they initially start at 0, but that is not the case for vhost-scsi. Initial last descriptor indices are set via VHOST_USER_SET_VRING_BASE message, and we cannot possibly predict what will they be. Setting the

[dpdk-dev] [PATCH] vhost: stop device before updating public vring data

2018-03-05 Thread Tomasz Kulasek
For now DPDK assumes that callfd, kickfd and last_idx are being set just once during vring initialization and device cannot be running while DPDK receives SET_VRING_KICK, SET_VRING_CALL and SET_VRING_BASE messages. However, that assumption is wrong. For Vhost SCSI messages might arrive at any point

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-03-05 Thread Adrien Mazarguil
On Mon, Feb 26, 2018 at 05:44:01PM +, Doherty, Declan wrote: > On 13/02/2018 5:05 PM, Adrien Mazarguil wrote: > > Hi, > > > > Apologies for being late to this thread, I've read the ensuing discussion > > (hope I didn't miss any) and also think rte_flow could be improved in > > several ways to

Re: [dpdk-dev] OPDL and 18.02 Release Notes

2018-03-05 Thread Ferruh Yigit
On 2/9/2018 12:08 AM, Rosen, Rami wrote: > Hi all, > Following the recent announcement of DPDK 18.02-RC4, I went over > 18.02 release notes and I have this minor query which I am not sure about: > In the release notes: > http://dpdk.org/doc/guides/rel_notes/release_18_02.html > we have the followin

Re: [dpdk-dev] [PATCH 37/41] net/enic: use contiguous allocation for DMA memory

2018-03-05 Thread John Daley (johndale)
Hi Anatoly, Looks good, see inline for details. Acked-by: John Daley Thanks, John > -Original Message- > From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > Sent: Saturday, March 03, 2018 5:46 AM > To: dev@dpdk.org > Cc: John Daley (johndale) ; Hyong Youb Kim (hyonkim) > ; keith.w

Re: [dpdk-dev] [PATCH 01/80] net/sfc: add missing defines for SAL annotation

2018-03-05 Thread Ferruh Yigit
On 2/20/2018 7:33 AM, Andrew Rybchenko wrote: > Fixes: e1b944598579 ("net/sfc: build libefx") > > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, thanks. This was a big set, can be holding the record on number of patches. Also thanks for your effort on splitting base dri

[dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback

2018-03-05 Thread Gage Eads
This commit also adds a flush callback test to the sw eventdev's selftest suite. Signed-off-by: Gage Eads --- drivers/event/sw/sw_evdev.c | 25 +++- drivers/event/sw/sw_evdev_selftest.c | 75 +++- 2 files changed, 97 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH 1/2] eventdev: add device stop flush callback

2018-03-05 Thread Gage Eads
When an event device is stopped, it drains all event queues. These events may contain pointers, so to prevent memory leaks eventdev now supports a user-provided flush callback that is called during the queue drain process. This callback is stored in process memory, so the callback must be registere

Re: [dpdk-dev] [PATCH 2/4] bus/vdev: bus scan by multi-process channel

2018-03-05 Thread Tan, Jianfeng
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, March 5, 2018 5:37 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net; > maxime.coque...@redhat.com; Yigit, Ferruh > Subject: Re: [PATCH 2/4] bus/vdev: bus scan by

[dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-05 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/bus/ifpga/Makefile | 64 drivers/bus/ifpga/ifpga_bus.c | 527 drivers/bus/ifpga/ifpga_common.c| 168 + drivers/bus/ifpga/ifpga_common.h| 46 +++ drivers/bus/ifpga

[dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scanned after PCI Bus

2018-03-05 Thread Rosen Xu
Signed-off-by: Rosen Xu --- lib/librte_eal/common/eal_common_bus.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index 3e022d5..74bfa15 100644 --- a/lib/librte_eal/common/eal_comm

[dpdk-dev] [RFC 0/4] Intel FPGA Bus

2018-03-05 Thread Rosen Xu
With Partial Reconfigure(PR) parts of Bitstream, Field Programmable Gate Array(FPGA) not only provides one kinds of accelerator but also provides many types of accelerators at the same time. How DPDK fully support FPGA? - We use Rawdev to provide FPGA PR - DPDK Driver will not bind to PCI Dev

[dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager

2018-03-05 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/raw/ifpga_rawdev/Makefile | 59 drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 343 + drivers/raw/ifpga_rawdev/ifpga_rawdev.h| 109 +++ drivers/raw/ifpga_rawdev/ifpga_rawdev_example.c| 121 +++

[dpdk-dev] [RFC 2/4] lib/librte_eal/common:Add Intel FPGA Bus Running Command Parse Code

2018-03-05 Thread Rosen Xu
Signed-off-by: Rosen Xu --- lib/librte_eal/common/eal_common_options.c | 8 +++- lib/librte_eal/common/eal_options.h| 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 9f2f

[dpdk-dev] [PATCH v2 01/10] net/enic: remove 'extern' in .h file function declarations

2018-03-05 Thread John Daley
Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic.h | 80 - 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h index c083985ee..e88af6bc9 100644 --- a/driv

[dpdk-dev] [PATCH v2 04/10] net/enic: remove the VLAN filter handler

2018-03-05 Thread John Daley
From: Hyong Youb Kim VIC does not support VLAN filtering at the moment. The firmware does accept the filter add/del commands and returns success. But, they are no-ops. To avoid confusion, remove the filter set handler so the app sees an error instead of silent failure. Also during the device con

[dpdk-dev] [PATCH v2 00/10] enic patchset

2018-03-05 Thread John Daley
v2: rebase, submit as patchset instead of individual patches so they apply correctly. Hyong Youb Kim (9): net/enic: allow the user to change RSS settings net/enic: heed the requested max Rx packet size net/enic: remove the VLAN filter handler net/enic: add Rx/Tx queue configuration getters

[dpdk-dev] [PATCH v2 05/10] net/enic: add Rx/Tx queue configuration getters

2018-03-05 Thread John Daley
From: Hyong Youb Kim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 76 -- 1 file changed, 65 insertions(+), 11 deletions(-) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index e

[dpdk-dev] [PATCH v2 03/10] net/enic: heed the requested max Rx packet size

2018-03-05 Thread John Daley
From: Hyong Youb Kim Currently, enic completely ignores the requested max Rx packet size (rxmode.max_rx_pkt_len). The desired behavior is that the NIC hardware drops packets larger than the requested size, even though they are still smaller than MTU. Cisco VIC does not have such a feature. But,

[dpdk-dev] [PATCH v2 06/10] net/enic: allocate stats DMA buffer upfront during probe

2018-03-05 Thread John Daley
From: Hyong Youb Kim The driver provides a DMA buffer to the firmware when it requests port stats. The NIC then fills that buffer with latest stats. Currently, the driver allocates the DMA buffer the first time it requests stats and saves it for later use. This can lead to crashes when primary/se

[dpdk-dev] [PATCH v2 08/10] doc: describe Rx bytes counter behavior for enic

2018-03-05 Thread John Daley
From: Hyong Youb Kim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/enic.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst index 7e19cf88a..0bc55936a 100644 --- a/doc/guides/nics/enic.rst +++ b/doc/gui

[dpdk-dev] [PATCH v2 02/10] net/enic: allow the user to change RSS settings

2018-03-05 Thread John Daley
From: Hyong Youb Kim Currently, when more than 1 receive queues are configured, the driver always enables RSS with the driver's own default hash type, key, and RETA. The user is unable to change any of the RSS settings. Address this by implementing the ethdev RSS API as follows. Correctly report

[dpdk-dev] [PATCH v2 10/10] net/enic: support for meson

2018-03-05 Thread John Daley
From: Hyong Youb Kim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/meson.build | 19 +++ drivers/net/meson.build | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/net/enic/meson.build diff --git a/drivers/n

[dpdk-dev] [PATCH v2 07/10] net/enic: support Rx queue interrupts

2018-03-05 Thread John Daley
From: Hyong Youb Kim Enable rx queue interrupts if the app requests them, and vNIC has enough interrupt resources. Use interrupt vector 0 for link status and errors. Use vector 1 for rx queue 0, vector 2 for rx queue 1, and so on. So, with n rx queues, vNIC needs to have at n + 1 interrupts. For

[dpdk-dev] [PATCH v2 09/10] net/enic: use memcpy to avoid strict aliasing warnings

2018-03-05 Thread John Daley
From: Hyong Youb Kim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_clsf.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index 3ef1d0832..9d95201ec 100644 -

[dpdk-dev] [PATCH v2] net/null:Different mac address support

2018-03-05 Thread Mallesh Koujalagi
After attaching two Null device to ovs, seeing "00.00.00.00.00.00" mac address for both null devices. Fix this issue, by setting different mac address. Signed-off-by: Mallesh Koujalagi --- drivers/net/null/rte_eth_null.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deleti

Re: [dpdk-dev] [PATCH v2] net/null:Different mac address support

2018-03-05 Thread Stephen Hemminger
On Mon, 5 Mar 2018 19:35:14 -0800 Mallesh Koujalagi wrote: > After attaching two Null device to ovs, seeing "00.00.00.00.00.00" mac > address for both null devices. Fix this issue, by setting different mac > address. > > Signed-off-by: Mallesh Koujalagi > --- > drivers/net/null/rte_eth_null.c

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-03-05 Thread gowrishankar muthukrishnan
On Monday 05 March 2018 03:42 PM, Luca Boccassi wrote: On Mon, 2018-03-05 at 11:31 +0530, gowrishankar muthukrishnan wrote: Hi Luca, In powerpc to support i40e, we wish below patch be merged: c3def6a8724 net/i40e: implement vector PMD for altivec I have verified br-16.11 with the above commit

Re: [dpdk-dev] [PATCH 3/4] drivers/net: do not allocate rte_eth_dev_data privately

2018-03-05 Thread Matan Azrad
Hi Jianfeng Please see a comment below. > From: Jianfeng Tan, Sent: Sunday, March 4, 2018 5:30 PM > We introduced private rte_eth_dev_data to allow vdev to be created both in > primary process and secondary process(es). This is not friendly to multi- > process model, for example, it leads to port

Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-05 Thread Shreyansh Jain
Hello Rosen, I have some initial (and most of them trivial) comments inline... On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/bus/ifpga/Makefile | 64 > drivers/bus/ifpga/ifpga_bus.c | 527 > ++

Re: [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scanned after PCI Bus

2018-03-05 Thread Shreyansh Jain
On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > lib/librte_eal/common/eal_common_bus.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_bus.c > b/lib/librte_eal/common/eal_common_bus.c > in

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-03-05 Thread Akhil Goyal
Hi Abhinandan, Sorry for the delayed response, my office network had some issues wrt NNTP, so couldn't reply. On 2/28/2018 2:31 PM, Gujjar, Abhinandan S wrote: Hi Akhil, .. + * crypto operation directly to cryptodev or send it to the + cryptodev + * adapter via eventdev, the crypt

Re: [dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager

2018-03-05 Thread Shreyansh Jain
On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/raw/ifpga_rawdev/Makefile | 59 > drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 343 > + > drivers/raw/ifpga_rawdev/ifpga_rawdev.h| 109 +++

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-03-05 Thread Akhil Goyal
Hi Narender, On 3/4/2018 4:12 AM, Vangati, Narender wrote: Akhil, I'm probably missing a point somewhere but I don't follow the suggestions. To me, ethdev, cryptodev, eventdev, etc. are device abstractions, whereas the proposed ENQ mode isn't at the same level. The DEQ mode is a device abstract

Re: [dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager

2018-03-05 Thread Shreyansh Jain
Just wanted to rephrase my wordings as they seem to be presenting different meaning from what I was intending. On Tue, Mar 6, 2018 at 12:18 PM, Shreyansh Jain wrote: > On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: >> Signed-off-by: Rosen Xu >> --- >> drivers/raw/ifpga_rawdev/Makefile