Re: [dpdk-dev] [dpdk-stable] [PATCH v2 08/13] app/testpmd: fix RSS flow action configuration

2018-04-05 Thread Nélio Laranjeiro
On Wed, Apr 04, 2018 at 04:57:59PM +0200, Adrien Mazarguil wrote: > Except for a list of queues, RSS configuration (hash key and fields) cannot > be specified from the flow command line and testpmd does not provide safe > defaults either. > > In order to validate their implementation with testpmd,

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-05 Thread Jankowski, Konrad
Hi Zhang, If you look at the source of interrupt handlers in both the igb_uio and uio_pci_generic drivers (look for irqreturn_t type), you will see they can disable interrupts immediately after receipt of one. It's up to the user to make sure they're re-enabled. Also please compare with code in

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-04-05 Thread Jerin Jacob
-Original Message- > Date: Wed, 4 Apr 2018 23:38:41 + > From: "Ananyev, Konstantin" > To: Jerin Jacob , Olivier Matz > > CC: "dev@dpdk.org" , "Richardson, Bruce" > > Subject: RE: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring > structure > > Hi lads, > > > -Orig

[dpdk-dev] [PATCH] vhost: fix meson build issues

2018-04-05 Thread Tomasz Duszynski
This patch addresses following meson build issues: 1) Since rte_vdpa.h includes rte_pci.h it introduces pci dependency thus deps array should be updated accordingly. 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to the sources list. Otherwise we end up with linker errors ca

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 09/13] app/testpmd: fix missing RSS fields in flow action

2018-04-05 Thread Nélio Laranjeiro
On Wed, Apr 04, 2018 at 04:58:01PM +0200, Adrien Mazarguil wrote: > Users cannot override the default RSS settings when entering a RSS action, > only a list of queues can be provided. > > This patch enables them to set a RSS hash key and types for a flow rule. > > Fixes: 05d34c6e9d2c ("app/testpm

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 11/13] ethdev: fix missing boolean values in flow command

2018-04-05 Thread Nélio Laranjeiro
On Wed, Apr 04, 2018 at 04:58:05PM +0200, Adrien Mazarguil wrote: > Original implementation lacks the on/off toggle. > > This patch shows up as a fix because it has been a popular request ever > since the first DPDK release with the original implementation but was never > addressed. > > Fixes: ab

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 13/13] ethdev: fix missing include in flow API

2018-04-05 Thread Nélio Laranjeiro
On Wed, Apr 04, 2018 at 04:58:08PM +0200, Adrien Mazarguil wrote: > Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API") > Cc: sta...@dpdk.org > > Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro > --- > lib/librte_ether/rte_flow.h | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [dpdk-dev] [PATCH v6 4/8] lib/librte_vhost: add request handler

2018-04-05 Thread Maxime Coquelin
On 04/04/2018 04:25 PM, Fan Zhang wrote: This patch adds the implementation that parses virtio crypto request to dpdk crypto operation. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost_crypto.h | 14 + lib/librte_vhost/vhost_crypto.c | 622

Re: [dpdk-dev] [PATCH v3 09/11] mempool/dpaa: prepare to remove register memory area op

2018-04-05 Thread Hemant Agrawal
On 3/26/2018 9:39 PM, Andrew Rybchenko wrote: Populate mempool driver callback is executed a bit later than register memory area, provides the same information and will substitute the later since it gives more flexibility and in addition to notification about memory area allows to customize how

Re: [dpdk-dev] [PATCH v6 0/8] vhost: introduce vhost crypto backend

2018-04-05 Thread Maxime Coquelin
On 04/04/2018 04:24 PM, Fan Zhang wrote: This patchset adds crypto backend suppport to vhost library including a proof-of-concept sample application. The implementation follows the virtio-crypto specification and have been tested with qemu 2.11.50 (with several patches applied, detailed later)

[dpdk-dev] [PATCH] test/tun: add new test for tun

2018-04-05 Thread Vipin Varghese
Add TUN PMD validation for create, port setup, tx, rx and stats functions. Signed-off-by: Vipin Varghese --- test/test/Makefile | 4 + test/test/autotest_data.py | 13 ++ test/test/meson.build | 4 + test/test/test_tun.c | 333 +

Re: [dpdk-dev] [PATCH v5] net/virtio-user: add support for server mode

2018-04-05 Thread Tiwei Bie
On Thu, Apr 05, 2018 at 01:17:53AM +0800, zhiyong.y...@intel.com wrote: [...] > +static int > +virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un) > +{ > + int ret; > + int flag; > + int fd = dev->listenfd; > + > + ret = bind(fd, (struct sockaddr *)un, size

[dpdk-dev] [PATCH V19 0/4] add device event monitor framework

2018-04-05 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

[dpdk-dev] [PATCH V19 1/4] eal: add device event handle in interrupt thread

2018-04-05 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo --- v19->v18: fix some typo --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +- test/test/test_interr

[dpdk-dev] [PATCH V19 2/4] eal: add device event monitor framework

2018-04-05 Thread Jeff Guo
This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get started, users firstly call below new adde

[dpdk-dev] [PATCH V19 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Jeff Guo
In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo --- v19->18: fix some misunderstanding part --- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH V19 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Jeff Guo
Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by below commands, E.g. ./build/app/testpmd -c 0x3 --n 4 -- -i --hot-plug then tes

[dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve the error checking

2018-04-05 Thread Hemant Agrawal
From: Sunil Kumar Kori Reported by NXP's internal coverity Signed-off-by: Sunil Kumar Kori --- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index c5191ce..7

[dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: improve error handling

2018-04-05 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixed as reported by NXP's internal coverity. Also part of dpdk coverity. Coverity issue: 268331 Coverity issue: 268333 Signed-off-by: Sunil Kumar Kori --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 27 +++ 1 file changed, 23 insertions(+), 4

Re: [dpdk-dev] [PATCH V18 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Guo, Jia
On 4/5/2018 12:31 AM, Matan Azrad wrote: Hi all What do you think about adding the "--hotplug" parameter as a new EAL command line parameter? that just use testpmd for example at this stage, if the total solution is accept for all and got agreement for that i think could let it in EAL comma

Re: [dpdk-dev] [PATCH v3] event/sw: code refractor to reduce the fetch stall

2018-04-05 Thread Jerin Jacob
-Original Message- > Date: Thu, 5 Apr 2018 11:26:30 +0530 > From: Vipin Varghese > To: dev@dpdk.org, harry.van.haa...@intel.com > CC: jerin.ja...@caviumnetworks.com, Vipin Varghese > > Subject: [PATCH v3] event/sw: code refractor to reduce the fetch stall > X-Mailer: git-send-email 1.9.1

[dpdk-dev] [PATCH 2/8] bus/dpaa: fix the unchecked return value

2018-04-05 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Coverity issue: 268323 Cc: sta...@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletio

[dpdk-dev] [PATCH 1/8] bus/dpaa: fix the resource leak issue

2018-04-05 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 9d32ef0f5d61 ("bus/dpaa: support creating dynamic HW portal") Coverity issue: 268332 Cc: sta...@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH 4/8] net/dpaa: fix the oob access

2018-04-05 Thread Hemant Agrawal
Fixes: b21ed3e2a16d ("net/dpaa: support extended statistics") Coverity issue: 268318 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa

[dpdk-dev] [PATCH 3/8] net/dpaa: fix the array overrun

2018-04-05 Thread Hemant Agrawal
Fixes: 62f53995caaf ("net/dpaa: add frame count based tail drop with CGR") Coverity issue: 268342 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/

[dpdk-dev] [PATCH 5/8] bus/dpaa: fix resource leak

2018-04-05 Thread Hemant Agrawal
Fixes: 1459585888b5 ("bus/dpaa: fix memory allocation during scan") Coverity issue: 268337 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman

[dpdk-dev] [PATCH 7/8] net/dpaa2: fix the implementation of xstats

2018-04-05 Thread Hemant Agrawal
Fixes: 1d6329b2fc1f ("net/dpaa2: support extra stats") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index

[dpdk-dev] [PATCH 6/8] net/dpaa: update checksum for external pool obj

2018-04-05 Thread Hemant Agrawal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- drivers/net/dpaa/dpaa_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index bdb7f66..1316d2a 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@

[dpdk-dev] [PATCH 8/8] bus/fslmc: configure separate portal for Ethernet Rx

2018-04-05 Thread Hemant Agrawal
From: Nipun Gupta In case of Receive from Ethernet we add a new pull request (prefetch) but do not fetch the results from that pull request until next dequeue operation. This keeps the portal in busy mode. This patch updates the portals bifurcation to have separate portals to receive packets for

[dpdk-dev] [PATCH V19 1/4] eal: add device event handle in interrupt thread

2018-04-05 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo Reviewed-by: Jianfeng Tan --- v19->v18: fix some typo --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++

Re: [dpdk-dev] [PATCH V18 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Tan, Jianfeng
On 4/5/2018 12:31 AM, Matan Azrad wrote: Hi all What do you think about adding the "--hotplug" parameter as a new EAL command line parameter? +1 Thanks, Jianfeng From: Tan, Jianfeng, Wednesday, April 4, 2018 6:23 AM -Original Message- From: Guo, Jia Sent: Tuesday, April 3, 2018

[dpdk-dev] [PATCH V19 2/4] eal: add device event monitor framework

2018-04-05 Thread Jeff Guo
This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get started, users firstly call below new adde

[dpdk-dev] [PATCH V19 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Jeff Guo
Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by below commands, E.g. ./build/app/testpmd -c 0x3 --n 4 -- -i --hot-plug then tes

[dpdk-dev] [PATCH V19 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Jeff Guo
In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo --- v19->18: fix some misunderstanding part --- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH V19 0/4] add device event monitor framework

2018-04-05 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions

2018-04-05 Thread Wang, Xiao W
Hi Hemant, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday, April 4, 2018 3:49 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; tho...@monjalon.net > Subject: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions > >

Re: [dpdk-dev] [PATCH v5] net/virtio-user: add support for server mode

2018-04-05 Thread Yang, Zhiyong
Tiwei, Thanks a lot for your review and comments. Reply inline. > -Original Message- > From: Bie, Tiwei > Sent: Thursday, April 5, 2018 4:29 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net; > Tan, Jianfeng ; Wang, Zhihong > ; Wang, Dong1 > Su

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-05 Thread Ferruh Yigit
On 4/4/2018 6:57 PM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, April 3, 2018 10:50 AM >> To: David Marchand ; santosh >> >> Cc: dev@dpdk.org; Shreyansh Jain ; Legacy, Allain >> (Wind River

Re: [dpdk-dev] [PATCH v5] net/virtio-user: add support for server mode

2018-04-05 Thread Yang, Zhiyong
Ping Maxime, Jianfeng Do you have any comments about the patch? Thanks Zhiyong > -Original Message- > From: Yang, Zhiyong > Sent: Thursday, April 5, 2018 1:18 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; tho...@monjalon.net; Tan, Jianfeng > ; Wang, Zhihong ; Bie, > Tiwei ; Wan

Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3

2018-04-05 Thread Adrien Mazarguil
On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote: > Hi, > > http://docs.openvswitch.org/en/latest/howto/dpdk/ says: > > Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address > associated with multiple ports. Using a PCI device like above won’t > work. Instead, belo

[dpdk-dev] [PATCH v5 0/4] add ifcvf vdpa driver

2018-04-05 Thread Xiao Wang
This patch set has dependency on http://dpdk.org/dev/patchwork/patch/36772/ (vhost: support selective datapath). IFCVF driver The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works

[dpdk-dev] [PATCH v5 1/4] eal/vfio: add multiple container support

2018-04-05 Thread Xiao Wang
Currently eal vfio framework binds vfio group fd to the default container fd during rte_vfio_setup_device, while in some cases, e.g. vDPA (vhost data path acceleration), we want to put vfio group to a separate container and program IOMMU via this container. This patch adds some APIs to support con

[dpdk-dev] [PATCH v5 4/4] doc: add ifcvf driver document and release note

2018-04-05 Thread Xiao Wang
Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin --- doc/guides/nics/features/ifcvf.ini | 8 doc/guides/nics/ifcvf.rst | 85 ++ doc/guides/nics/index.rst | 1 + doc/guides/rel_notes/release_18_05.rst | 9 4 files cha

[dpdk-dev] [PATCH v5 2/4] net/virtio: skip device probe in vdpa mode

2018-04-05 Thread Xiao Wang
If we want a virtio device to work in vDPA (vhost data path acceleration) mode, we could add a "vdpa=1" devarg for this device to specify the mode. This patch let virtio pmd skip device probe when detecting this parameter. Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin --- drivers/net/v

[dpdk-dev] [PATCH v5 3/4] net/ifcvf: add ifcvf vdpa driver

2018-04-05 Thread Xiao Wang
The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works as a HW vhost backend which can send/receive packets to/from virtio directly by DMA. Different VF devices serve different virtio frontends

Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel

2018-04-05 Thread Pattan, Reshma
Hi > > Signed-off-by: Jianfeng Tan > --- > Note this patch needs this patch set: > http://dpdk.org/dev/patchwork/patch/36814/ > v2: > - Update doc for deprecation of API, rte_pdump_set_socket_dir, > and API change for rte_pdump_init. > - Add notice for known incompatibility issue in doc.

Re: [dpdk-dev] [PATCH v6 0/8] vhost: introduce vhost crypto backend

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 10:26 AM, Maxime Coquelin wrote: On 04/04/2018 04:24 PM, Fan Zhang wrote: This patchset adds crypto backend suppport to vhost library including a proof-of-concept sample application. The implementation follows the virtio-crypto specification and have been tested with qemu 2.11.

Re: [dpdk-dev] [PATCH] ethdev: Additions to rte_flows to support vTEP encap/decap offload

2018-04-05 Thread Thomas Monjalon
+Cc Adrien, please review 10/03/2018 01:25, Declan Doherty: > This V1 patchset contains the revised proposal to manage virtual > tunnel endpoints (vTEP) hardware accleration based on community > feedback on RFC > (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This > proposal is purel

Re: [dpdk-dev] [PATCH v1 11/16] ethdev: refine TPID handling in flow API

2018-04-05 Thread Nélio Laranjeiro
On Wed, Apr 04, 2018 at 05:56:49PM +0200, Adrien Mazarguil wrote: > TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not > consistent with the normal stacking order of pattern items, which is > confusing to applications. > > Problem is that when followed by one of these layers,

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-05 Thread Thomas Monjalon
20/03/2018 15:12, Ferruh Yigit: > On 3/18/2018 1:45 AM, Chas Williams wrote: > > From: Chas Williams > > > > The vmxnet3 never attempts link speed negotiation. As a virtual device > > the link speed is vague at best. However, it is important for certain > > applications, like bonding, to see a

Re: [dpdk-dev] [PATCH v1 01/16] ethdev: update ABI for flow API functions

2018-04-05 Thread Thomas Monjalon
04/04/2018 17:56, Adrien Mazarguil: > Subsequent patches will modify existing types and slightly alter the > behavior of the flow API. This warrants a major ABI breakage. > > While it is already taken care of for 18.05 (LIBABIVER was updated to > version 9 by a prior commit), this patch explicitly

[dpdk-dev] [PATCH v3 00/21] implement packed virtqueues

2018-04-05 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf It does not

[dpdk-dev] [PATCH v3 03/21] net/virtio: add virtio 1.1 defines

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index 1bd7ba98e..54a11d2a9 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/

[dpdk-dev] [PATCH v3 02/21] net/virtio: vring init for packed queues

2018-04-05 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 22 +--- drivers/net/virtio/virtio_pci.h| 8 ++ drivers/net/virtio/virtio_ring.h | 53 ++ drivers/net/virtio/virtqueue.h

[dpdk-dev] [PATCH v3 01/21] net/virtio: by default disable packed virtqueues

2018-04-05 Thread Jens Freimann
Disable packed virtqueues for now and make it dependend on a build-time config option. This can be reverted once we have missing features like indirect descriptors implemented. Signed-off-by: Jens Freimann --- config/common_base | 1 + drivers/net/virtio/virtio_ethdev.c | 4

[dpdk-dev] [PATCH v3 05/21] net/virtio: dump packed virtqueue data

2018-04-05 Thread Jens Freimann
Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index cc2e7c0f6..7e265bf93 100644 --

[dpdk-dev] [PATCH v3 06/21] net/virtio-user: add option to use packed queues

2018-04-05 Thread Jens Freimann
From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 ++-- drivers/net/virtio/virtio_user/virtio_user_dev.h | 3 ++- drivers/net/virtio/virtio_user_ethdev.c |

[dpdk-dev] [PATCH v3 07/21] net/virtio: implement transmit path for packed queues

2018-04-05 Thread Jens Freimann
This implements the transmit path for devices with support for Virtio 1.1. Add the feature bit for Virtio 1.1 and enable code to add buffers to vring and mark descriptors as available. This is based on a patch by Yuanhan Liu. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c |

[dpdk-dev] [PATCH v3 04/21] net/virtio: add packed virtqueue helpers

2018-04-05 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 33 + drivers/net/virtio/virtqueue.c | 10 ++ 2 files changed, 43 insertions(+) diff --git a/drivers/net/virtio/virtio_ring

[dpdk-dev] [PATCH v3 08/21] net/virtio: implement receive path for packed queues

2018-04-05 Thread Jens Freimann
From: Yuanhan Liu Implement the receive part here. No support for mergeable buffers yet. Signed-off-by: Jens Freimann Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 10 ++- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 137 +

[dpdk-dev] [PATCH v3 11/21] vhost: add virtio 1.1 defines

2018-04-05 Thread Jens Freimann
This should actually be in the kernel header file, but it isn't yet. For now let's use our own headers. Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 4 lib/librte_vhost/virtio-1.1.h | 18 ++ 2 files changed, 22 insertions(+) create mode 100644 lib/librt

[dpdk-dev] [PATCH v3 09/21] vhost: disable packed virtqueues by default

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freimann --- config/common_base| 1 + lib/librte_vhost/socket.c | 4 2 files changed, 5 insertions(+) diff --git a/config/common_base b/config/common_base index cd4b419b4..bf969d82d 100644 --- a/config/common_base +++ b/config/common_base @@ -783,6 +783,7 @@ CONF

[dpdk-dev] [PATCH v3 10/21] vhost: turn of indirect descriptors for packed virtqueues

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freimann --- lib/librte_vhost/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 72d769e6a..05193e368 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -852,6 +852,7 @@ rte_vhost_driv

[dpdk-dev] [PATCH v3 13/21] vhost: add helpers for packed virtqueues

2018-04-05 Thread Jens Freimann
Add some helper functions to set/check descriptor flags and toggle the used wrap counter. Signed-off-by: Jens Freimann --- lib/librte_vhost/virtio-1.1.h | 44 +++ 1 file changed, 44 insertions(+) diff --git a/lib/librte_vhost/virtio-1.1.h b/lib/librte_vho

[dpdk-dev] [PATCH v3 15/21] vhost: packed queue enqueue path

2018-04-05 Thread Jens Freimann
Implement enqueue of packets to the receive virtqueue. Set descriptor flag VIRTQ_DESC_F_USED and toggle used wrap counter if last descriptor in ring is used. Perform a write memory barrier before flags are written to descriptor. Chained descriptors are not supported with this patch. Signed-off-b

[dpdk-dev] [PATCH v3 12/21] vhost: vring address setup for packed queues

2018-04-05 Thread Jens Freimann
From: Yuanhan Liu Add code to set up packed queues when enabled. Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 21 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v3 14/21] vhost: dequeue for packed queues

2018-04-05 Thread Jens Freimann
Implement code to dequeue and process descriptors from the vring if VIRTIO_F_RING_PACKED is enabled. Check if descriptor was made available by driver by looking at VIRTIO_F_DESC_AVAIL flag in descriptor. If so dequeue and set the used flag VIRTIO_F_DESC_USED to the current value of the used wrap c

[dpdk-dev] [PATCH v3 19/21] vhost: support mergeable rx buffers with packed queues

2018-04-05 Thread Jens Freimann
This implements support for mergeable receive buffers in vhost when using packed virtqueues. The difference to split virtqueues is not big, it differs mostly where descriptor flags are touched and virtio features are checked. Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.c | 2 +

[dpdk-dev] [PATCH v3 17/21] net/virtio: disable ctrl virtqueue for packed rings

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index dc220c743..7367d9c5d 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virti

[dpdk-dev] [PATCH v3 21/21] vhost: add event suppression for packed queues

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.c | 17 +--- lib/librte_vhost/vhost.h | 62 --- lib/librte_vhost/vhost_user.c | 19 + lib/librte_vhost/virtio_net.c | 1 + 4 files changed, 86 insertions(+), 13 deletions

[dpdk-dev] [PATCH v3 16/21] vhost: enable packed virtqueues

2018-04-05 Thread Jens Freimann
From: Yuanhan Liu This patch enables the code do enqueue and dequeue packed to/from a packed virtqueue. Add feature bit for packed virtqueues as defined in Virtio 1.1 draft. Signed-off-by: Jens Freimann Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/virt

[dpdk-dev] [PATCH v3 18/21] net/virtio: add support for mergeable buffers with packed virtqueues

2018-04-05 Thread Jens Freimann
Implement support for receiving merged buffers in virtio when packed virtqueues are enabled. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 10 ++-- drivers/net/virtio/virtio_rxtx.c | 107 + drivers/net/virtio/virtqueue.h | 1 +

[dpdk-dev] [PATCH v3 20/21] net/virtio: add support for event suppression

2018-04-05 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 15 +++- drivers/net/virtio/virtqueue.h | 73 -- 4 files changed, 86 insertions(+), 6 deletions

Re: [dpdk-dev] [PATCH v4] lib/librte_meter: add meter configuration profile

2018-04-05 Thread Thomas Monjalon
19/02/2018 22:12, Thomas Monjalon: > 08/01/2018 16:43, Jasvinder Singh: > > Signed-off-by: Cristian Dumitrescu > > Signed-off-by: Jasvinder Singh > > Applied for 18.05 (was postponed to preserve 18.02 ABI), thanks. We forgot to update the release notes about the API change. Please, could you se

Re: [dpdk-dev] [PATCH V19 2/4] eal: add device event monitor framework

2018-04-05 Thread Tan, Jianfeng
On 4/5/2018 4:32 PM, Jeff Guo wrote: This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get s

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-04-05 Thread Thomas Monjalon
04/04/2018 20:56, De Lara Guarch, Pablo: > > API and ABI changes should be documented in release notes. When sending a v4 for the API change, you can add my ack: Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions

2018-04-05 Thread Thomas Monjalon
05/04/2018 11:03, Wang, Xiao W: > > +int rte_vfio_get_group_num(const char *sysfs_base, const char *dev_addr, > > + int *iommu_group_num); > > +int rte_vfio_get_container_fd(void); > > +int rte_vfio_get_group_fd(int iommu_group_num); > > Considering the "group_no" field defin

Re: [dpdk-dev] [PATCH] vhost: fix meson build issues

2018-04-05 Thread Bruce Richardson
On Thu, Apr 05, 2018 at 10:08:16AM +0200, Tomasz Duszynski wrote: > This patch addresses following meson build issues: > > 1) Since rte_vdpa.h includes rte_pci.h it introduces pci >dependency thus deps array should be updated accordingly. > > 2) Since vhost.h includes rte_vdpa.h vdpa.c should

Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel

2018-04-05 Thread Pattan, Reshma
Hi, > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, April 4, 2018 4:08 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Pattan, Reshma > > Subject: [PATCH v2] pdump: change to use generic multi-process channel > > The original code replies on the private channel for primary and

Re: [dpdk-dev] [PATCH v2] net/bonding: clear dev_started if start fails

2018-04-05 Thread Radu Nicolau
On 3/23/2018 5:05 PM, Chas Williams wrote: From: "Charles (Chas) Williams" There are several error paths where the bonding device may not start. Clear dev_started before we return if we take one of these paths. Fixes: 2efb58cbab ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-

Re: [dpdk-dev] [pull-request] next-pipeline 18.05 PRE-RC1

2018-04-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 5, 2018 1:03 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder > Subject: Re: [dpdk-dev] [pull-request] next-pipeline 18.05 PRE-RC1 > > > > Hi, > > > > > > 30/03/2018 14:4

Re: [dpdk-dev] [PATCH v4] lib/librte_meter: add meter configuration profile

2018-04-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 5, 2018 11:12 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] lib/librte_meter: add meter > configuration profile > > 19/02/2018 2

Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions

2018-04-05 Thread Wang, Xiao W
Yes, it's private. We could do that if really needed. BRs, Xiao > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 5, 2018 6:23 PM > To: Wang, Xiao W > Cc: Hemant Agrawal ; dev@dpdk.org; Burakov, > Anatoly > Subject: Re: [dpdk-dev] [PATCH v5

Re: [dpdk-dev] [PATCH V19 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Tan, Jianfeng
On 4/5/2018 5:02 PM, Jeff Guo wrote: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo --- v19->18: fix some misunderstandin

Re: [dpdk-dev] [PATCH] net/bonding: fix setting VLAN ID on slave ports

2018-04-05 Thread Radu Nicolau
On 4/3/2018 5:01 PM, Chas Williams wrote: From: Chas Williams The pos returned is just the offset of the slab. You need to use this to offset the bits in the slab. Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter") Cc:sta...@dpdk.org Signed-off-by: Chas Williams --- Acked-by: Rad

Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel

2018-04-05 Thread Tan, Jianfeng
On 4/5/2018 6:37 PM, Pattan, Reshma wrote: Hi, -Original Message- From: Tan, Jianfeng Sent: Wednesday, April 4, 2018 4:08 PM To: dev@dpdk.org Cc: Tan, Jianfeng ; Pattan, Reshma Subject: [PATCH v2] pdump: change to use generic multi-process channel The original code replies on the pr

[dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-04-05 Thread Shally Verma
Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its qps. If PMD support b

[dpdk-dev] [PATCH v2 0/6] crypto: add asym crypto support

2018-04-05 Thread Shally Verma
This patch series add support for asymmetric crypto in DPDK librte_cryptodev framework along with unit test, PMD and documentation updates and addresses patch apply failure raised on asym crypto v1 patch series: https://dpdk.org/dev/patchwork/patch/36575/ https://dpdk.org/dev/patchwork/patch/36576/

[dpdk-dev] [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-04-05 Thread Shally Verma
Extend cryptodev with asymmetric capability APIs and definitions. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- User must apply patch "lib/cryptodev: add asymmetric algos in cryptodev" before compilation --- lib/librte_cryptodev/rte_cryptodev.c

[dpdk-dev] [PATCH v2 4/6] test/crypto: add unit testcase for asym crypto

2018-04-05 Thread Shally Verma
Add unit test case to test openssl PMD asym crypto operations. Test case invoke asymmetric operation on DPDK Openssl PMD and cross-verify results via Openssl SW library. Tests have been verified with openssl 1.0.2m release. Tested for: * RSA Encrypt, Decrypt, Sign and Verify using pre-defined t

[dpdk-dev] [PATCH v2 1/6] lib/cryptodev: add asymmetric algos in cryptodev

2018-04-05 Thread Shally Verma
Add rte_crypto_asym.h with supported xfrms and associated op structures and APIs API currently supports: - RSA Encrypt, Decrypt, Sign and Verify - Modular Exponentiation and Inversion - DSA Sign and Verify - Deffie-hellman private key exchange - Deffie-hellman public key exchange - Deffie-hellman

[dpdk-dev] [PATCH v2 5/6] crypto/openssl: add asym crypto support

2018-04-05 Thread Shally Verma
Add asymmetric crypto operation support in openssl PMD. Current list of supported asym xforms: * RSA * DSA * Deffie-hellman * Modular Operations changes from v1: - resolve new line error in dod/guides/cryptodevs/openssl.rst Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: A

[dpdk-dev] [PATCH v2 6/6] doc: add asym crypto in cryptodev programmer guide

2018-04-05 Thread Shally Verma
Update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- doc/guides/prog_guide/cryptodev_lib.rst | 338 +++- 1 file changed, 329 inserti

Re: [dpdk-dev] [PATCH v3 46/68] vfio: allow to map other memory regions

2018-04-05 Thread Burakov, Anatoly
On 04-Apr-18 12:21 AM, Anatoly Burakov wrote: Currently it is not possible to use memory that is not owned by DPDK to perform DMA. This scenarion might be used in vhost applications (like SPDK) where guest send its own memory table. To fill this gap provide API to allow registering arbitrary addr

Re: [dpdk-dev] [PATCH v4 01/17] net/axgbe: add minimal dev init and uninit support

2018-04-05 Thread Ferruh Yigit
On 4/5/2018 7:39 AM, Ravi Kumar wrote: > add ethernet poll mode driver for AMD 10G devices embedded in > AMD EPYC™ EMBEDDED 3000 family processors > > Signed-off-by: Ravi Kumar <...> > @@ -410,6 +410,12 @@ CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16 > CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y > > # > +# Compi

Re: [dpdk-dev] [PATCH v4 17/17] net/axgbe: add workaround for axgbe ethernet training bug

2018-04-05 Thread Ferruh Yigit
On 4/5/2018 7:39 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar Can you please give more information what is the bug solved here? What problem observed if it is not fixed? This may help people having problem.

Re: [dpdk-dev] [PATCH v4 10/17] net/axgbe: add transmit and receive data path apis

2018-04-05 Thread Ferruh Yigit
On 4/5/2018 7:39 AM, Ravi Kumar wrote: > Supported scalar implementation for RX data path > Supported scalar and vector implementation for TX data path > > Signed-off-by: Ravi Kumar > --- > drivers/net/axgbe/Makefile | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 22 +- > drive

[dpdk-dev] [PATCH] doc: add meter API change to release notes

2018-04-05 Thread Jasvinder Singh
Update the release notes with meter api change to support configuration profiles. Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/release_18_05.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05

[dpdk-dev] [PATCH v3] pdump: change to use generic multi-process channel

2018-04-05 Thread Jianfeng Tan
The original code replies on the private channel for primary and secondary communication. Change to use the generic multi-process channel. Note with this change, dpdk-pdump will be not compatible with old version DPDK applications. Cc: reshma.pat...@intel.com Signed-off-by: Jianfeng Tan --- v3:

[dpdk-dev] [PATCH v3 1/4] app/eventdev: add event timer adapter as a producer

2018-04-05 Thread Pavan Nikhilesh
Add event timer adapter as producer option that can be selected by passing --prod_type_timerdev. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Add detailed options dump. - Fix few typos. v2 Changes: - set timer to NOT_ARMED before trying to arm it. - prevent edge cases for timeout_tick

  1   2   3   >