[dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD

2020-03-25 Thread zhihongx . peng
From: Peng Zhihong DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization. Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) Cc: liang-min.w...@intel.com Signed-off-by: Peng Zhihong --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + 1 file changed,

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-25 Thread David Marchand
Hello Andrzej, On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka wrote: > > What is this useful for > === > > Usually, when an ethernet port is assigned to DPDK it vanishes from the > system and user looses ability to control it via normal configuration > utilities (e.g. thos

[dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support

2020-03-25 Thread Dekel Peled
This patch adds CLI option to enter the v_pt_rsv_flags value for GTP flow pattern item. It also adds GTP as valid item in raw_encap and raw_decap setting. Signed-off-by: Dekel Peled --- v2: remove redundant hton flag. --- app/test-pmd/cmdline_flow.c | 15 +-- 1 file changed, 13 inser

[dpdk-dev] [Bug 422] Typing error in patches.rst in doc/guides/contributing at line 177

2020-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=422 Bug ID: 422 Summary: Typing error in patches.rst in doc/guides/contributing at line 177 Product: DPDK Version: 20.02 Hardware: All OS: All Status: UNCONF

Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support

2020-03-25 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, March 25, 2020 10:13 AM > To: Ori Kam ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com > Cc: Matan Azrad ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP supp

Re: [dpdk-dev] [PATCH 00/17] Add CPU flags

2020-03-25 Thread David Marchand
On Tue, Mar 24, 2020 at 12:49 PM Kevin Laatz wrote: > This patch set adds CPU flags which will enable the detection of ISA > features available on more recent x86 based CPUs. > > The CPUID leaf information can be found in Section 1.7 of this > document: > https://software.intel.com/sites/default/f

[dpdk-dev] [Bug 423] usertools/dpdk-setup.sh can not be used to run an application without compiling dpdk first

2020-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=423 Bug ID: 423 Summary: usertools/dpdk-setup.sh can not be used to run an application without compiling dpdk first Product: DPDK Version: unspecified Hardware: All OS:

Re: [dpdk-dev] [PATCH v2 1/2] crypto/nitrox: fix invalid CSR register address generation

2020-03-25 Thread Akhil Goyal
> > If the NPS_PKT ring/port is greater than 8191 the NPS_PKT*() macros will > evaluate to incorrect values due to unintended sign extension from int > to unsigned long. To fix this, add UL suffix to the constants in these > macros. > > Coverity issue: 349899, 349905, 349911, 349921, 349923 >

Re: [dpdk-dev] [PATCH v4 0/4] net/mlx5: move to non-cached mode for flow rules

2020-03-25 Thread Matan Azrad
From: Bing Zhao > This patch set will remove the flow rules cache and move to the non-cached > mode for both DV and Verbs mode. > > In the device closing stage, all the software resources for flows created will > be freed and corresponding hardware resources will be released. Then the > total c

Re: [dpdk-dev] [PATCH v3 06/12] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-03-25 Thread Phil Yang
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 24, 2020 7:04 PM > To: Phil Yang ; Honnappa Nagarahalli > ; tho...@monjalon.net; Van Haaren, > Harry ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org; Richardson, Bruce > > Cc: david.march...@r

Re: [dpdk-dev] [PATCH v5] net/i40e: implement hash function in rte flow API

2020-03-25 Thread Iremonger, Bernard
Hi Chenxu, > [snip] > > > > --- a/drivers/net/i40e/i40e_flow.c > > > +++ b/drivers/net/i40e/i40e_flow.c > > > @@ -4424,10 +4424,10 @@ i40e_flow_parse_qinq_filter(struct > > > rte_eth_dev *dev, > > > * function for RSS, or flowtype for queue region configuration. > > > * For example: > > >

Re: [dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-25 Thread Akhil Goyal
> From: Nic Chautru > > Adding capability flag for device variants when HARQ buffer > may or may not include the filler bits. > Minor cosmetic changes in same file. > > Signed-off-by: Nic Chautru > --- > lib/librte_bbdev/rte_bbdev.h| 2 ++ > lib/librte_bbdev/rte_bbdev_op.h | 12 ++

Re: [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block

2020-03-25 Thread Akhil Goyal
> > From: Nic Chautru > > This is to support cases when the input data for > decoding a code block is larger than 64kB and would > not fit as a contiguous block of data into one > mbuf. In that case the length from the opearation > supersedes the mbug default structure. Spell check Operation

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: add option to configure port pairs

2020-03-25 Thread Sunil Kumar Kori
Comments inline. Regards Sunil Kumar Kori >-Original Message- >From: pbhagavat...@marvell.com >Sent: Tuesday, March 24, 2020 6:05 PM >To: Jerin Jacob Kollanukkaran ; Marko Kovacevic >; Ori Kam ; Bruce >Richardson ; Radu Nicolau >; Akhil Goyal ; Tomasz >Kantecki ; Sunil Kumar Kori >; Pava

[dpdk-dev] [PATCH v2] eal/cpuflags: add x86 based cpu flags

2020-03-25 Thread Kevin Laatz
This patch adds CPU flags which will enable the detection of ISA features available on more recent x86 based CPUs. The CPUID leaf information can be found in Section 1.7 of this document: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programmi

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-25 Thread Morten Brørup
Andrzej, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, March 25, 2020 9:08 AM > > Hello Andrzej, > > On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka > wrote: > > > > > > What has changed since the RFC > > == > > > > -

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-03-25 Thread Pei Zhang
Hi Kevin, Testing with dpdk 18.11.7-rc1 from Red Hat looks good. We cover below 13 scenarios and and all get PASS on RHEL8 testing: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gu

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-03-25 Thread Kevin Traynor
On 25/03/2020 11:59, Pei Zhang wrote: > Hi Kevin, > > Testing with dpdk 18.11.7-rc1 from Red Hat looks good. > Thanks for testing Pei, Kevin. > We cover below 13 scenarios and and all get PASS on RHEL8 testing: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS

Re: [dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks

2020-03-25 Thread David Marchand
On Thu, Mar 19, 2020 at 9:48 AM David Marchand wrote: > > On Mon, Mar 16, 2020 at 6:36 PM Bruce Richardson > wrote: > > > > On Wed, Nov 20, 2019 at 02:10:56PM -0600, Mit Matelske wrote: > > > The source callback list grows infinitely when more than alarm > > > is queued. > > > > > > This fix reco

Re: [dpdk-dev] [PATCH] eal: store control thread CPU affinity in TLS

2020-03-25 Thread David Marchand
On Fri, Mar 13, 2020 at 9:34 AM David Marchand wrote: > On Wed, Feb 5, 2020 at 11:24 AM wrote: > > > > From: Jerin Jacob > > > > _cpuset TLS variable stores the CPU affinity of eal thread. > > Populate the _cpuset TLS variable for control thread to > > > > 1) Make rte_thread_get_affinity() and e

Re: [dpdk-dev] [dpdk.org] [PATCH] fib: add "C" extern linkage for C++ programs

2020-03-25 Thread David Marchand
Cc: maintainer. On Mon, Mar 16, 2020 at 8:22 PM Muhammad Asim Jamshed wrote: > > This patch allows C++ programs to use librte_fib library routines. > Previously C++ programs were not able to link this library and programs > would fail to get linked. With this patch compilation and linking > will

Re: [dpdk-dev] [PATCH v3 06/14] test-bbdev: support HARQ validation

2020-03-25 Thread Akhil Goyal
rte_bbdev_dec_op *op, > unsigned int order_idx, const int expected_status) > { > - TEST_ASSERT(op->status == expected_status, > + int status = op->status; > + /* ignore parity mismatch false alarms for long iterations */ > + { > + if (!(expected_status & (

Re: [dpdk-dev] [PATCH 0/2] bitmap: add create bitmap with all bits set

2020-03-25 Thread Thomas Monjalon
Call for review, please. 10/03/2020 09:21, Suanming Mou: > Currently, in the case to use bitmap as resource allocator, after > bitmap creation, all the bitmap bits should be set to indicate the > bit available. Every time when allocate one bit, search for the set > bits and clear it to make it in

Re: [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests

2020-03-25 Thread Akhil Goyal
> > From: Nic Chautru > > Includes support for BLER wireless performance test with > new arguments for SNR and number of iterations for 5G. > It would be better to add more info in the commit log. You can add reference to some standard link which is being Followed so that patch can be reviewe

Re: [dpdk-dev] [PATCH v3 09/14] test-bbdev: support for offload test for LDPC

2020-03-25 Thread Akhil Goyal
> @@ -4552,7 +4552,12 @@ typedef int (test_case_function)(struct active_device > *ad, > > if (unlikely(num_to_process - deq_total < burst_sz)) > burst_sz = num_to_process - deq_total; > - rte_bbdev_dequeue_dec_ops(dev_id, queue_id, ops, burst_sz); >

Re: [dpdk-dev] [PATCH v3 10/14] test-bbdev: vectors update

2020-03-25 Thread Akhil Goyal
> From: Nic Chautru > > Modification to vectors parameters used for unit test > for coverage and performance test of bbdev drivers > across all devices. > Reducing list for focused coverage when required. > > Signed-off-by: Nic Chautru Not able to get the reason for removing these vectors. Ple

[dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings

2020-03-25 Thread Kevin Traynor
Disable this warning at the top level as it is being raised on several components. Bugzilla ID: 421 Signed-off-by: Kevin Traynor --- config/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index abedd76f2..522368a29 100644

[dpdk-dev] [RFC 2/2] mk: gcc 10 disable stringop-overflow warnings

2020-03-25 Thread Kevin Traynor
Disable this warning at the top level as it is being raised on several components. Bugzilla ID: 421 Signed-off-by: Kevin Traynor --- mk/toolchain/gcc/rte.vars.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index f19305e49..f

[dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning

2020-03-25 Thread Kevin Traynor
This is a blunt way to remove this warning. Some alternatives are: - disable the warning for individual components - components rework to statically allocate memory for parts of structs impacted Maybe there's some other solutions? Impacted components: ../drivers/crypto/caam_jr/caam_jr_pvt.h ../d

Re: [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning

2020-03-25 Thread Thomas Monjalon
25/03/2020 15:11, Kevin Traynor: > This is a blunt way to remove this warning. > > Some alternatives are: > - disable the warning for individual components > - components rework to statically allocate memory for parts of structs > impacted > > Maybe there's some other solutions? In general, I a

Re: [dpdk-dev] [PATCH] doc: update mlx5 firmware configuration guidelines

2020-03-25 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, March 24, 2020 1:31 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > john.mcnam...@intel.com; marko.kovace...@intel.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: update mlx5 firmware con

Re: [dpdk-dev] [PATCH] net/mlx5: creating relaxed ordering memory regions

2020-03-25 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shiri Kuzin > Sent: Tuesday, March 24, 2020 1:40 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: creating relaxed ordering memory regions > > In the current state, when preforming read/write > t

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode

2020-03-25 Thread David Marchand
On Fri, Feb 7, 2020 at 12:11 PM Anatoly Burakov wrote: > > When --no-huge mode is used, the memory is currently allocated with > mmap(NULL, ...). This is fine in most cases, but can fail in cases > where DPDK is run on a machine with an IOMMU that is of more limited > address width than that of a

Re: [dpdk-dev] [PATCH v3 11/14] doc: update of testbbdev documentation

2020-03-25 Thread Akhil Goyal
> > From: Nic Chautru > > Update related to the changes introduced by the > previous commits. > > Signed-off-by: Nic Chautru > --- Please split this patch and merge the relevant sections in the respective patches. And it would be better to add reference to the Standards which were followed.

Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-25 Thread Akhil Goyal
> > From: Nic Chautru > > Supports for FEC 5G PMD Driver on FPGA card PAC N3000 > > Signed-off-by: Nic Chautru > --- I cannot review this patch. This patch should be a separate series. This should be split into logical parts as a new PMD is submitted for review. I can see that all the MACROS

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata for compressed Rx CQEs

2020-03-25 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, March 24, 2020 2:15 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix metadata for compressed Rx CQEs > > If packets with the same metadata are rece

[dpdk-dev] [PATCH v2 0/3] configure RSS hash

2020-03-25 Thread Bernard Iremonger
Configure the RSS hash for the i40e PMD using the rte_flow API RSS pattern. The i40e patch depends on the following patch: http://patches.dpdk.org/patch/67042/ [v5] net/i40e: implement hash function in rte flow API Changes in v2: -- i40e changes are based on http://patches.dpdk.org/

[dpdk-dev] [PATCH v2 1/3] librte_ethdev: add RSS offload types for ESP and AH

2020-03-25 Thread Bernard Iremonger
add ETH_RSS_ESP and ETH_RSS_AH macros Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index d1a593a..113e953 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b

[dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH

2020-03-25 Thread Bernard Iremonger
parse RSS offload types ESP and AH add printf for rss_hf Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 4 +++- app/test-pmd/config.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a037a55..997f063 1

[dpdk-dev] [PATCH v2 3/3] net/i40e: add ESP patterns

2020-03-25 Thread Bernard Iremonger
add ESP patterns to i40e_flow_parse_rss_pattern(). update i40e PMD user guide with download link for esp-ah.pkg file. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 3 ++- drivers/net/i40e/i40e_flow.c | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/do

Re: [dpdk-dev] [PATCH] net/mlx5: prefetch CQEs for a faster decompression

2020-03-25 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, March 24, 2020 4:46 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: prefetch CQEs for a faster decompression > > Invalidation of consumed CQEs incurs a perform

Re: [dpdk-dev] [PATCH] kvargs: fix a heap-buffer-overflow when detect list

2020-03-25 Thread Olivier Matz
Hi, On Thu, Mar 19, 2020 at 12:38:00PM +0800, wangyunjian wrote: > From: Yunjian Wang > > When an input params'value is '[', leading to the 'str' over read > or heap-buffer-overflow. So we can check the 'ctx1' length to avoid > this problem. > > Fixes: cc0579f2339a ("kvargs: support list value"

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: support 192/256 AES key sizes

2020-03-25 Thread Akhil Goyal
> > Adding support for the following, > 1. AES-192-GCM > 2. AES-256-GCM > 3. AES-192-CBC > > Signed-off-by: Anoob Joseph > Signed-off-by: Tejasree Kondoj > --- > examples/ipsec-secgw/ipsec.h | 2 +- > examples/ipsec-secgw/sa.c| 25 + > 2 files changed, 26 inserti

[dpdk-dev] [PATCH v4] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2020-03-25 Thread Eduard Serra
(Picked up from @Charles Myers patch https://patchwork.dpdk.org/patch/57771/) When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hype

[dpdk-dev] [PATCH v5] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2020-03-25 Thread Eduard Serra
(Picked up from @Charles Myers patch https://patchwork.dpdk.org/patch/57771/) When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hype

Re: [dpdk-dev] [PATCH] crypto/nitrox: add 3DES-CBC support

2020-03-25 Thread Akhil Goyal
> > This patch adds 3DES CBC mode cipher algorithm. > > Signed-off-by: Nagadheeraj Rottela > --- Is it worth mentioning in release notes?

Re: [dpdk-dev] [PATCH v1] test: fix ipsec unit test segfault

2020-03-25 Thread Akhil Goyal
> > > > Segfault was observed when running ipsec unit test: > > > > + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper > >succeeded > > + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper > >succeeded > > + TestCase [12] :

Re: [dpdk-dev] [PATCH 1/2] crypto/qat: add aes-gcm J0 handling

2020-03-25 Thread Akhil Goyal
> > > > This patch adds J0 capability to Intel QuickAssist Technology driver > > > > Signed-off-by: Arek Kusztal > Acked-by: Fiona Trahe > > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 2/2] test: add crypto aes-gcm J0 test case

2020-03-25 Thread Akhil Goyal
> > > > This patch adds crypto J0 test case to AES-GCM > > > > Signed-off-by: Arek Kusztal > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/3] crypto/qat: improve out-of-place conditional check

2020-03-25 Thread Akhil Goyal
> > From: Fiona Trahe > > > > Improve case where application set m_dst to same as m_src so really an in- > > place operation, though would have been treated as out-of-place. No > > functional change but this path can now benefit from DMA alignment. > > > > Signed-off-by: Fiona Trahe > > --- > >

Re: [dpdk-dev] [EXT] [PATCH 1/3] drivers/crypto: remove unused element from device operations

2020-03-25 Thread Akhil Goyal
> > > This commit removes unused function pointer (queue_pair_count) from > > rte_cryptodev_ops objects. Related functions removed as well. > > > > Signed-off-by: Artur Trybula > > Acked-by: Anoob Joseph Series applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix QAT GEN3 marketing name

2020-03-25 Thread Akhil Goyal
> > > > This patch fixes the marketing name of the QAT GEN3 to P5xxx. > > Updates this name mentioned in the compression PMD as well as > > in the documentation. > > > > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") > > Fixes: 1f5e4053f9b4 ("common/qat: support GEN3 devices"

Re: [dpdk-dev] [PATCH v2 1/2] crypto/qat: support DOCSIS AES-256

2020-03-25 Thread Akhil Goyal
> > > > This patch adds support for DOCSIS AES-256 when using qat > > > > Signed-off-by: Mairtin o Loingsigh > Acked-by: Fiona Trahe Series Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-03-25 Thread Akhil Goyal
> -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, March 13, 2020 12:50 PM > To: Adam Dybkowski ; dev@dpdk.org; > fiona.tr...@intel.com > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range > checking > > > Fixes: 3dd4435

[dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2020-03-25 Thread Eduard Serra
(Picked up from @Charles Myers patch https://patchwork.dpdk.org/patch/57771/) When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() fails with -ENOTSUP and mtu is not stored in the mtu field in the rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is shared with hype

[dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-25 Thread Asaf Penso
The item is being set according to the attribute value, whether it is udp/tcp or ipv4/6. Also, there are two condition calls. If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at all, but the call to the flow_dv_convert_modify_action is still being done. Also, even if the a

Re: [dpdk-dev] [RFC 1/1] lib/ring: add scatter gather and serial dequeue APIs

2020-03-25 Thread Honnappa Nagarahalli
> > > > > > > > > > +/** > > > > > > + * @internal Reserve ring elements to enqueue several objects > > > > > > +on the ring > > > > > > + * > > > > > > + * @param r > > > > > > + * A pointer to the ring structure. > > > > > > + * @param esize > > > > > > + * The size of ring element, in byt

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-03-25 Thread Honnappa Nagarahalli
> Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring > > Upfront note - that RFC is not a complete patch. > It introduces an ABI breakage, plus it doesn't update ring_elem code properly, As per the current rules, these changes (in the current form) will be accepted only for 20.11 release. Ho

Re: [dpdk-dev] [RFC 5/6] ring: introduce HTS ring mode

2020-03-25 Thread Honnappa Nagarahalli
> > Introduce head/tail sync mode for MT ring synchronization. > In that mode enqueue/dequeue operation is fully serialized: > only one thread at a time is allowed to perform given op. > Suppose to reduce stall times in case when ring is used on overcommitted > cpus (multiple active threads on t

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: select iova-mode va with no-huge option

2020-03-25 Thread dwilder
On 2020-03-23 23:19, Jerin Jacob wrote: On Mon, Mar 23, 2020 at 11:11 PM dwilder wrote: Thanks you for your review Jerin. See my responses are inline. On 2020-03-20 06:24, Jerin Jacob wrote: > On Fri, Feb 21, 2020 at 4:22 AM David Wilder > wrote: >> >> If --no-huge is set and iova-mode has

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-25 Thread Jerin Jacob
On Fri, Mar 20, 2020 at 10:11 PM Konstantin Ananyev wrote: > > As was discussed here: > http://mails.dpdk.org/archives/dev/2020-February/158586.html > this RFC aimed to hide ring internals into .c and make all > ring functions non-inlined. In theory that might help to > maintain ABI stability in f

[dpdk-dev] [PATCH v2 00/32] DPDK Trace support

2020-03-25 Thread jerinj
From: Jerin Jacob v2: Addressed the following review comments from Mattias Rönnblom: 1) Changed from: typedef uint64_t* rte_trace_t; to typedef uint64_t rte_trace_t; Initially thought to make the handle as struct rte_trace { uint64_t val; } but changed to uint64_t for the following reas

[dpdk-dev] [PATCH v2 01/32] eal: introduce API for getting thread name

2020-03-25 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v2 04/32] eal/trace: implement trace operation APIs

2020-03-25 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v2 06/32] eal/trace: get bootup timestamp for trace

2020-03-25 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v2 07/32] eal/trace: create CTF TDSL metadata in memory

2020-03-25 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v2 03/32] eal/trace: implement trace register API

2020-03-25 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v2 02/32] eal: define the public API for trace support

2020-03-25 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v2 05/32] eal/trace: add internal trace init and fini interface

2020-03-25 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v2 09/32] eal/trace: implement trace memory allocation

2020-03-25 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v2 08/32] eal/trace: handle CTF keyword collision

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v2 10/32] eal/trace: implement debug dump function

2020-03-25 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v2 14/32] eal/trace: hook internal trace APIs to Linux

2020-03-25 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal/eal.c| 9 + lib/librte_eal/linux/eal/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v2 11/32] eal/trace: implement trace save

2020-03-25 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v2 13/32] eal/trace: implement provider payload

2020-03-25 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v2 12/32] eal/trace: implement registration payload

2020-03-25 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v2 16/32] eal/trace: add generic tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v2 18/32] eal/trace: add memory tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v2 19/32] eal/trace: add memzone tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v2 20/32] eal/trace: add thread tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 14 +++

[dpdk-dev] [PATCH v2 15/32] eal/trace: hook internal trace APIs to FreeBSD

2020-03-25 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal/eal.c| 10 ++ lib/librte_eal/freebsd/eal/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal/eal.c

[dpdk-dev] [PATCH v2 17/32] eal/trace: add alarm tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/common/include/rte_trace_eal.h | 18 ++ lib/

[dpdk-dev] [PATCH v2 21/32] eal/trace: add interrupt tracepoints

2020-03-25 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v2 23/32] eal/trace: add trace dir configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v2 22/32] eal/trace: add trace level configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v2 26/32] eal/trace: add unit test cases

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v2 24/32] eal/trace: add trace bufsize configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v2 27/32] eal/trace: add trace performance test cases

2020-03-25 Thread jerinj
From: Jerin Jacob This test case shall be used to measure the trace overhead. Example command to run the performance test case. echo "trace_perf" | ./build/app/test/dpdk-test -c 0x3 --trace-level=8 Signed-off-by: Jerin Jacob --- app/test/Makefile | 1 + app/test/meson.build

[dpdk-dev] [PATCH v2 25/32] eal/trace: add trace mode configuration parameter

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v2 30/32] cryptodev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/crypto/ccp/Makefile | 1 + drivers/crypto/ccp/meson.build| 2 + d

[dpdk-dev] [PATCH v2 28/32] ethdev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + app/pdump/Makefile| 1 + app/pdump/meson.build | 1 + app/

[dpdk-dev] [PATCH v2 32/32] doc: add trace library guide

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add programmar's guide for trace library support. Signed-off-by: Sunil Kumar Kori Signed-off-by: Jerin Jacob --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/trace_lib.rst| 265 + doc/guides/rel_notes/release_20_05.rs

[dpdk-dev] [PATCH v2 31/32] mempool: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS| 2 + drivers/common/cpt/Makefile| 1 + drivers/mempool/ring/Makefile | 1 + drivers/me

[dpdk-dev] [PATCH v2 29/32] eventdev: add tracepoints

2020-03-25 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 2 + drivers/event/skeleton/Makefile | 1 + drivers/event/skeleton/meson.build| 1 + l

[dpdk-dev] [Bug 424] malloc_autotest fails with message "Unexpected - ptr4 != ptr3"

2020-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=424 Bug ID: 424 Summary: malloc_autotest fails with message "Unexpected - ptr4 != ptr3" Product: DPDK Version: 20.05 Hardware: All OS: Linux Status: UNCONFIR

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-25 Thread Ananyev, Konstantin
Hi Jerin, > > On Fri, Mar 20, 2020 at 10:11 PM Konstantin Ananyev > wrote: > > > > As was discussed here: > > http://mails.dpdk.org/archives/dev/2020-February/158586.html > > this RFC aimed to hide ring internals into .c and make all > > ring functions non-inlined. In theory that might help to >

Re: [dpdk-dev] [PATCH 0/4] iavf share code update

2020-03-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 10, 2020 8:37 AM > To: Yang, Qiming ; Xing, Beilei > > Cc: Ye, Xiaolong ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 0/4] iavf share code update > > Main change: > > update virtual channel to support DCF > > Qi Zhan

Re: [dpdk-dev] [PATCH v2 0/2] examples/vmdq: fix RSS configuration

2020-03-25 Thread Han, YingyaX
Tested-by: Han,YingyaX -Original Message- From: dev On Behalf Of Junyu Jiang Sent: Wednesday, March 25, 2020 2:33 PM To: dev@dpdk.org Cc: Yang, Qiming ; Yigit, Ferruh ; Jiang, JunyuX Subject: [dpdk-dev] [PATCH v2 0/2] examples/vmdq: fix RSS configuration This patch set fixed a bug of

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-03-25 Thread Ananyev, Konstantin
> > > > > Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring > > > > Upfront note - that RFC is not a complete patch. > > It introduces an ABI breakage, plus it doesn't update ring_elem code > > properly, > As per the current rules, these changes (in the current form) will be > accepted onl

Re: [dpdk-dev] [PATCH] net/ice: fix RSS advanced rule invalid issue

2020-03-25 Thread Yang, Qiming
Hi, Junyu Comments inline. And I have a proposal, why we don't put ice_rss_init into ice_dev_init, so the rss rule will not recovery. Qiming > -Original Message- > From: Jiang, JunyuX > Sent: Thursday, March 19, 2020 15:48 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Jiang, J

  1   2   >