[dpdk-dev] [21.08 PATCH v3 1/1] power: refactor pstate sysfs handling

2021-04-22 Thread Anatoly Burakov
Currently, pstate sysfs handling code is a bit of an unmaintainable mess, which has contributed to various errors leading to bugs. Refactor the code in a way that makes it more maintainable and less error prone. Signed-off-by: Anatoly Burakov --- lib/power/meson.build| 7 + lib

[dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor

2021-04-23 Thread Anatoly Burakov
e is empty. Fix it by saving the original pstate governor first. While we're at it, replace `strlcpy` with `rte_strscpy`. Fixes: 445c6528b55f ("power: common interface for guest and host") Cc: david.h...@intel.com Signed-off-by: Anatoly Burakov --- lib/power/power_acpi_cpufreq.c

[dpdk-dev] [21.08 PATCH v4 1/2] power: don't use rte prefix in internal code

2021-04-23 Thread Anatoly Burakov
Currently, ACPI code uses rte_power_info as the struct name, which gives the appearance that this is an externally visible API. Fix to use internal namespace. Signed-off-by: Anatoly Burakov --- lib/power/power_acpi_cpufreq.c | 34 +- 1 file changed, 17 insertions

[dpdk-dev] [21.08 PATCH v4 2/2] power: refactor pstate and acpi code

2021-04-23 Thread Anatoly Burakov
Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writing for ACPI and PSTATE drivers. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
any more, as currently i40e VF devices are supposed to be managed by iavf drier, but add this just in case it needs backporting later. Fixes: a683abf90a22 ("net/i40e: implement power management API") Signed-off-by: Anatoly Burakov --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file

[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
power management API") Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ff65145f55..6cca039a11 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/d

[dpdk-dev] [PATCH v2 0/7] Enhancements for PMD power management

2021-06-25 Thread Anatoly Burakov
feedback from Konstantin - Added doc updates where necessary [1] http://patches.dpdk.org/project/dpdk/list/?series=16930&state=* [2] http://patches.dpdk.org/project/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.bura...@intel.com/#133274 Anatoly Burako

[dpdk-dev] [PATCH v2 1/7] power_intrinsics: use callbacks for comparison

2021-06-25 Thread Anatoly Burakov
-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v2: - Use callback mechanism for more flexibility - Address feedback from Konstantin doc/guides/rel_notes/release_21_08.rst| 1 + drivers/event/dlb2/dlb2.c | 16 -- drivers/net/i40e

[dpdk-dev] [PATCH v2 2/7] net/af_xdp: add power monitor support

2021-06-25 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v2 3/7] eal: add power monitor for multiple events

2021-06-25 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v2: - Adapt to callback mechanism doc/guides/rel_notes/release_21_08.rst| 2 + lib/ea

[dpdk-dev] [PATCH v2 4/7] power: remove thread safety from PMD power API's

2021-06-25 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 5 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v2 6/7] power: support monitoring multiple Rx queues

2021-06-25 Thread Anatoly Burakov
: Anatoly Burakov --- doc/guides/prog_guide/power_man.rst | 9 ++-- lib/power/rte_power_pmd_mgmt.c | 76 - 2 files changed, 80 insertions(+), 5 deletions(-) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index 38f876466a

[dpdk-dev] [PATCH v2 5/7] power: support callbacks for multiple Rx queues

2021-06-25 Thread Anatoly Burakov
r core it is obvious which queue is the "power saving" one, so things will still work without this new API for use cases that were previously working without it. - The limitation on UMWAIT-based polling is not removed because UMWAIT is incapable of monitoring more than one address.

[dpdk-dev] [PATCH v2 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-25 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation, and always mark the last queue in qconf as the power save queue. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 39

[dpdk-dev] [PATCH v3 0/7] Enhancements for PMD power management

2021-06-28 Thread Anatoly Burakov
bura...@intel.com/#133274 Anatoly Burakov (7): power_intrinsics: use callbacks for comparison net/af_xdp: add power monitor support eal: add power monitor for multiple events power: remove thread safety from PMD power API's power: support callbacks for multiple Rx queues power

[dpdk-dev] [PATCH v3 1/7] power_intrinsics: use callbacks for comparison

2021-06-28 Thread Anatoly Burakov
-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v2: - Use callback mechanism for more flexibility - Address feedback from Konstantin doc/guides/rel_notes/release_21_08.rst| 1 + drivers/event/dlb2/dlb2.c | 16 -- drivers/net/i40e

[dpdk-dev] [PATCH v3 2/7] net/af_xdp: add power monitor support

2021-06-28 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v3 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v2: - Adapt to callback mechanism doc/guides/rel_notes/release_21_08.rst| 2 + lib/ea

[dpdk-dev] [PATCH v3 4/7] power: remove thread safety from PMD power API's

2021-06-28 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 5 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v3 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread Anatoly Burakov
while we're at it, update and improve the docs. Signed-off-by: Anatoly Burakov --- Notes: v3: - Move the list of supported NICs to NIC feature table v2: - Use a TAILQ for queues instead of a static array - Address feedback from Konstantin - Add additional che

[dpdk-dev] [PATCH v3 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Anatoly Burakov
: Anatoly Burakov --- doc/guides/prog_guide/power_man.rst | 9 ++-- lib/power/rte_power_pmd_mgmt.c | 76 - 2 files changed, 80 insertions(+), 5 deletions(-) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index fac2c19516

[dpdk-dev] [PATCH v3 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-28 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation, and always mark the last queue in qconf as the power save queue. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 39

[dpdk-dev] [PATCH v4 0/7] Enhancements for PMD power management

2021-06-28 Thread Anatoly Burakov
* [2] http://patches.dpdk.org/project/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.bura...@intel.com/#133274 Anatoly Burakov (7): power_intrinsics: use callbacks for comparison net/af_xdp: add power monitor support eal: add power monitor for multiple events p

[dpdk-dev] [PATCH v4 1/7] power_intrinsics: use callbacks for comparison

2021-06-28 Thread Anatoly Burakov
semantics. Suggested-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v4: - Return error if callback is set to NULL - Replace raw number with a macro in monitor condition opaque data v2: - Use callback mechanism for more

[dpdk-dev] [PATCH v4 2/7] net/af_xdp: add power monitor support

2021-06-28 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v4 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v4: - Fixed bugs in accessing the monitor condition - Abort on any monitor condition not having a defined cal

[dpdk-dev] [PATCH v4 4/7] power: remove thread safety from PMD power API's

2021-06-28 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 5 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v4 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread Anatoly Burakov
while we're at it, update and improve the docs. Signed-off-by: Anatoly Burakov --- Notes: v3: - Move the list of supported NICs to NIC feature table v2: - Use a TAILQ for queues instead of a static array - Address feedback from Konstantin - Add additional che

[dpdk-dev] [PATCH v4 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Anatoly Burakov
: Anatoly Burakov --- Notes: v4: - Fix possible out of bounds access - Added missing index increment doc/guides/prog_guide/power_man.rst | 9 ++-- lib/power/rte_power_pmd_mgmt.c | 84 - 2 files changed, 88 insertions(+), 5 deletions(-) diff --git a

[dpdk-dev] [PATCH v4 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-28 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation, and always mark the last queue in qconf as the power save queue. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 39

[dpdk-dev] [PATCH v5 2/7] net/af_xdp: add power monitor support

2021-06-29 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v5 0/7] Enhancements for PMD power management

2021-06-29 Thread Anatoly Burakov
dback from Konstantin - Added doc updates where necessary [1] http://patches.dpdk.org/project/dpdk/list/?series=16930&state=* [2] http://patches.dpdk.org/project/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.bura...@intel.com/#133274 Anatoly Burakov (7): power_i

[dpdk-dev] [PATCH v5 3/7] eal: add power monitor for multiple events

2021-06-29 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v4: - Fixed bugs in accessing the monitor condition - Abort on any monitor condition not having a defined cal

[dpdk-dev] [PATCH v5 1/7] power_intrinsics: use callbacks for comparison

2021-06-29 Thread Anatoly Burakov
semantics. Suggested-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v4: - Return error if callback is set to NULL - Replace raw number with a macro in monitor condition opaque data v2: - Use callback mechanism for more

[dpdk-dev] [PATCH v5 4/7] power: remove thread safety from PMD power API's

2021-06-29 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 5 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v5 6/7] power: support monitoring multiple Rx queues

2021-06-29 Thread Anatoly Burakov
: Anatoly Burakov --- Notes: v4: - Fix possible out of bounds access - Added missing index increment doc/guides/prog_guide/power_man.rst | 9 ++-- lib/power/rte_power_pmd_mgmt.c | 81 - 2 files changed, 85 insertions(+), 5 deletions(-) diff --git a

[dpdk-dev] [PATCH v5 5/7] power: support callbacks for multiple Rx queues

2021-06-29 Thread Anatoly Burakov
of monitoring more than one address. Also, while we're at it, update and improve the docs. Signed-off-by: Anatoly Burakov --- Notes: v5: - Remove the "power save queue" API and replace it with mechanism suggested by Konstantin v3: - Move the list of su

[dpdk-dev] [PATCH v5 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-29 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples

[dpdk-dev] [PATCH v6 0/7] Enhancements for PMD power management

2021-07-05 Thread Anatoly Burakov
4579e3d9fb216e.1620747068.git.anatoly.bura...@intel.com/#133274 Anatoly Burakov (7): power_intrinsics: use callbacks for comparison net/af_xdp: add power monitor support eal: add power monitor for multiple events power: remove thread safety from PMD power API's power: support callba

[dpdk-dev] [PATCH v6 1/7] power_intrinsics: use callbacks for comparison

2021-07-05 Thread Anatoly Burakov
semantics. Suggested-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v4: - Return error if callback is set to NULL - Replace raw number with a macro in monitor condition opaque data v2: - Use callback mechanism for more

[dpdk-dev] [PATCH v6 2/7] net/af_xdp: add power monitor support

2021-07-05 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v6 3/7] eal: add power monitor for multiple events

2021-07-05 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v4: - Fixed bugs in accessing the monitor condition - Abort on any monitor condition not having a defined cal

[dpdk-dev] [PATCH v6 4/7] power: remove thread safety from PMD power API's

2021-07-05 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 5 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v6 5/7] power: support callbacks for multiple Rx queues

2021-07-05 Thread Anatoly Burakov
of monitoring more than one address. Also, while we're at it, update and improve the docs. Signed-off-by: Anatoly Burakov --- Notes: v6: - Track each individual queue sleep status (Konstantin) - Fix segfault (Dave) v5: - Remove the "power save queue" API

[dpdk-dev] [PATCH v6 6/7] power: support monitoring multiple Rx queues

2021-07-05 Thread Anatoly Burakov
: Anatoly Burakov --- Notes: v6: - Fix the missed feedback from v5 v4: - Fix possible out of bounds access - Added missing index increment doc/guides/prog_guide/power_man.rst | 9 ++-- lib/power/rte_power_pmd_mgmt.c | 82 - 2 files changed

[dpdk-dev] [PATCH v6 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-07-05 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples

[dpdk-dev] [PATCH v7 0/7] Enhancements for PMD power management

2021-07-07 Thread Anatoly Burakov
ect/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.bura...@intel.com/#133274 Anatoly Burakov (7): power_intrinsics: use callbacks for comparison net/af_xdp: add power monitor support eal: add power monitor for multiple events power: remove thread safety from PMD power API'

[dpdk-dev] [PATCH v7 1/7] power_intrinsics: use callbacks for comparison

2021-07-07 Thread Anatoly Burakov
semantics. Suggested-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v4: - Return error if callback is set to NULL - Replace raw number with a macro in monitor condition opaque data v2: - Use callback mechanism for more

[dpdk-dev] [PATCH v7 2/7] net/af_xdp: add power monitor support

2021-07-07 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp

[dpdk-dev] [PATCH v7 3/7] eal: add power monitor for multiple events

2021-07-07 Thread Anatoly Burakov
addresses we're interested in to the read-set, any write to those addresses will wake us up. Signed-off-by: Konstantin Ananyev Signed-off-by: Anatoly Burakov --- Notes: v4: - Fixed bugs in accessing the monitor condition - Abort on any monitor condition not having a defined cal

[dpdk-dev] [PATCH v7 4/7] power: remove thread safety from PMD power API's

2021-07-07 Thread Anatoly Burakov
simplifies the `rte_power_monitor`-related code. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add check for stopped queue - Clarified doc message - Added release notes doc/guides/rel_notes/release_21_08.rst | 4 + lib/power/meson.build | 3 + lib/power/rte_p

[dpdk-dev] [PATCH v7 5/7] power: support callbacks for multiple Rx queues

2021-07-07 Thread Anatoly Burakov
of monitoring more than one address. Also, while we're at it, update and improve the docs. Signed-off-by: Anatoly Burakov --- Notes: v7: - Fix bug where initial sleep target was always set to zero - Fix logic in handling of n_queues_ready_to_sleep counter - Update document

[dpdk-dev] [PATCH v7 6/7] power: support monitoring multiple Rx queues

2021-07-07 Thread Anatoly Burakov
: Anatoly Burakov --- Notes: v6: - Fix the missed feedback from v5 v4: - Fix possible out of bounds access - Added missing index increment doc/guides/prog_guide/power_man.rst | 15 -- lib/power/rte_power_pmd_mgmt.c | 82 - 2 files

[dpdk-dev] [PATCH v7 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-07-07 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples

[PATCH v1 1/1] malloc/mp: fix wait condition handling

2024-07-12 Thread Anatoly Burakov
ected by a mutex), so either we receive an event and modify entry state, or we exit wait on a timeout and do not care about request state. However, it's better to keep coverity happy. Coverity issue: 425709 Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") Cc: sta.

[PATCH v1 1/1] net/ice: fix E830 PTP phy model

2024-07-23 Thread Anatoly Burakov
") Signed-off-by: Anatoly Burakov --- drivers/net/ice/ice_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 29509b4329..304f959b7e 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/i

[RFC PATCH v1 0/1] Add Visual Studio Code configuration script

2024-07-26 Thread Anatoly Burakov
I've never needed this functionality. Please feel free to make any suggestions! Anatoly Burakov (1): devtools: add vscode configuration generator devtools/gen-vscode-config.py | 640 ++ 1 file changed, 640 insertions(+) create mode 100755 devtools/gen-vscode-config.py -- 2.43.5

[RFC PATCH v1 1/1] devtools: add vscode configuration generator

2024-07-26 Thread Anatoly Burakov
configuration supplied from command-line arguments. Signed-off-by: Anatoly Burakov --- devtools/gen-vscode-config.py | 640 ++ 1 file changed, 640 insertions(+) create mode 100755 devtools/gen-vscode-config.py diff --git a/devtools/gen-vscode-config.py b/devtools/gen

[RFC PATCH v2 0/1] Add Visual Studio Code configuration script

2024-07-29 Thread Anatoly Burakov
d apps/examples/drivers. Thus, we address the "simple" usecase of "let's build everything by default", we handle some common use cases smarter than we otherwise would have, and we allow user to be as in-depth as they want by allowing to specify explicit meson command stri

[RFC PATCH v2 1/1] devtools: add vscode configuration generator

2024-07-29 Thread Anatoly Burakov
configuration supplied from command-line arguments. Signed-off-by: Anatoly Burakov --- Notes: RFCv1 -> RFCv2: - No longer disable apps and drivers if nothing was specified via command line or TUI, and warn user about things being built by default - Generate app lau

[RFC PATCH v3 0/1] Add Visual Studio Code configuration script

2024-07-31 Thread Anatoly Burakov
isualstudio.com/docs/remote/ssh Anatoly Burakov (1): buildtools: add vscode configuration generator app/meson.build | 12 +- buildtools/gen-vscode-conf.py | 442 ++ buildtools/meson.build| 5 + examples/meson.build | 13

[RFC PATCH v3 1/1] buildtools: add vscode configuration generator

2024-07-31 Thread Anatoly Burakov
Multiple, as well as out-of-source-tree, build directories are supported, and the script will generate separate configuration items for each build directory created by user, tagging them for convenience. Signed-off-by: Anatoly Burakov --- Notes: RFCv3 -> RFCv2: - Following feedback f

[PATCH v1 1/2] usertools/cpu_layout: update coding style

2024-08-14 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by: Anatoly Burakov --- usertools/cpu_layout.py | 162

[PATCH v1 2/2] usertools/cpu_layout: print out NUMA nodes

2024-08-14 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- usertools/cpu_layout.py | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index 843b29a134..be89909464 100755 --- a/usertools/cpu_layout.py +++ b/usertools/cpu_layo

[PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-16 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by: Anatoly Burakov --- usertools/cpu_layout.py | 162

[PATCH v2 2/4] usertools/cpu_layout: print out NUMA nodes

2024-08-16 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- usertools/cpu_layout.py | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index be86f06938..e43bdbf343 100755 --- a/usertools/cpu_layout.py +++ b/usertools/cpu_layo

[PATCH v2 3/4] usertools/dpdk-hugepages.py: sort by NUMA node

2024-08-16 Thread Anatoly Burakov
Currently, the list of per-NUMA node hugepages is displayed in glob order, which can be arbitrary. Fix it to sort the glob order. Signed-off-by: Anatoly Burakov --- usertools/dpdk-hugepages.py | 40 ++--- 1 file changed, 28 insertions(+), 12 deletions(-) diff

[PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

2024-08-16 Thread Anatoly Burakov
Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 27

[PATCH v3 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-off-by: Anatoly Bura

[PATCH v3 2/4] usertools/cpu_layout: print out NUMA nodes

2024-08-20 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- Notes: v2 -> v3: - Sort imports alphabetically usertools/cpu_layout.py | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index 1c255ff1a1..78b119d729 1007

[PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style

2024-08-20 Thread Anatoly Burakov
- Sort output by NUMA node Signed-off-by: Anatoly Burakov --- Notes: v1 -> v2: - Added commit that sorted output by NUMA node v2 -> v3: - Rewrite of the script as suggested by reviewers usertools/dpdk-hugepages.py | 456 +--- 1 file change

[PATCH v3 4/4] usertools/dpdk-devbind: print NUMA node

2024-08-20 Thread Anatoly Burakov
Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry --- Notes: v1 ->

[PATCH v4 2/4] usertools/cpu_layout: print out NUMA nodes

2024-08-21 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- Notes: v2 -> v3: - Sort imports alphabetically usertools/cpu_layout.py | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index 8812ea286b..e4720e27db 1007

[PATCH v4 4/4] usertools/dpdk-devbind: print NUMA node

2024-08-21 Thread Anatoly Burakov
Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry --- Notes: v1 ->

[PATCH v4 3/4] usertools/dpdk-hugepages.py: update coding style

2024-08-21 Thread Anatoly Burakov
output by NUMA node Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- Notes: v3 -> v4: - Format code with Ruff, line width 79 to avoid flake8 warnings (Flake8 is by default configured with line width 79 on my system) v2 -> v3: - Rewrite of the scr

[PATCH v4 1/4] usertools/cpu_layout: update coding style

2024-08-21 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-off-by: Anatoly Bura

[PATCH v5 1/4] usertools/cpu_layout: update coding style

2024-08-21 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - format code with Ruff - address all mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-off-by:

[PATCH v5 2/4] usertools/cpu_layout: print out NUMA nodes

2024-08-21 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- Notes: v2 -> v3: - Sort imports alphabetically usertools/cpu_layout.py | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index e133fb8ad3..976be1f8b2 1007

[PATCH v5 3/4] usertools/dpdk-hugepages.py: update coding style

2024-08-21 Thread Anatoly Burakov
huge page reservation status output by NUMA node Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger --- Notes: v4 -> v5: - Format with Ruff on default settings - Replaced all instances of raw path strings with os.path.join v3 -> v4: - Format code with Ruff

[PATCH v5 4/4] usertools/dpdk-devbind: print NUMA node

2024-08-21 Thread Anatoly Burakov
Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry --- Notes: v1 ->

[PATCH v6 1/4] usertools/cpu_layout: update coding style

2024-08-22 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - format code with Ruff - address all mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-off-by:

[PATCH v6 2/4] usertools/cpu_layout: print out NUMA nodes

2024-08-22 Thread Anatoly Burakov
ff-by: Anatoly Burakov --- Notes: v5 -> v6: - Track NUMA changes per socket to avoid issues with missing cores v2 -> v3: - Sort imports alphabetically usertools/cpu_layout.py | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) d

[PATCH v6 3/4] usertools/dpdk-hugepages.py: update coding style

2024-08-22 Thread Anatoly Burakov
huge page reservation status output by NUMA node Signed-off-by: Anatoly Burakov Acked-by: Stephen Hemminger Acked-by: Robin Jarry --- Notes: v4 -> v5: - Format with Ruff on default settings - Replaced all instances of raw path strings with os.path.join v3 -> v4: -

[PATCH v6 4/4] usertools/dpdk-devbind: print NUMA node

2024-08-22 Thread Anatoly Burakov
Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry --- Notes: v1 ->

[PATCH v1 1/3] fbarray: rename tests to be more meaningful

2024-08-23 Thread Anatoly Burakov
details. Also, add more tests that fill up exactly one mask, with and without neighbouring set bits. Signed-off-by: Anatoly Burakov --- app/test/test_fbarray.c | 99 - 1 file changed, 67 insertions(+), 32 deletions(-) diff --git a/app/test/test_fbarray.c

[PATCH v1 2/3] fbarray: rework find_next_n to flatten the loop

2024-08-23 Thread Anatoly Burakov
stead replacing it with state machine-like behavior. This makes the code simpler to reason about. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_fbarray.c | 195 +--- 1 file changed, 93 insertions(+), 102 deletions(-) diff --git a/lib/eal/common/eal_common_fbarray

[PATCH v1 3/3] fbarray: rework find_prev_n to flatten the loop

2024-08-23 Thread Anatoly Burakov
stead replacing it with state machine-like behavior. This makes the code simpler to reason about. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_fbarray.c | 223 +--- 1 file changed, 101 insertions(+), 122 deletions(-) diff --git a/lib/eal/c

[PATCH v1 01/15] net/ixgbe/base: remove minsrevs code from DPDK

2024-08-29 Thread Anatoly Burakov
river code snapshot was generated. Remove this code from DPDK driver. Fixes: add44414762c ("net/ixgbe/base: add E610 NVM-related operations") Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 54 - drivers/net/ixgbe/base/ixgbe_e610.h |

[PATCH v1 02/15] net/ixgbe/base: add missing ACI definitions

2024-08-29 Thread Anatoly Burakov
"net/ixgbe/base: detect E610 device capabilities") Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 49 drivers/net/ixgbe/base/ixgbe_type_e610.h | 4 ++ 2 files changed, 53 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_e

[PATCH v1 03/15] net/ixgbe/base: add missing E610 definitions

2024-08-29 Thread Anatoly Burakov
When adding support for E610 bringup, some definitions and code paths were accidentally omitted due to the way the shared driver snapshot was created. Add missing definitions and code paths. Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device") Signed-off-by: Anatoly Burakov --

[PATCH v1 04/15] net/ixgbe/base: add missing legacy mailbox API

2024-08-29 Thread Anatoly Burakov
;) Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_mbx.c | 44 ++ drivers/net/ixgbe/base/ixgbe_mbx.h | 1 + 2 files changed, 45 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.c b/drivers/net/ixgbe/base/ixgbe_mbx.c index 444a0d339d..2365926

[PATCH v1 05/15] net/ixgbe/base: add E610 VF HV macro

2024-08-29 Thread Anatoly Burakov
From: Jedrzej Jagielski At this point there is no macro specific for E610 VF HV. Add it to ixgbe_type.h Signed-off-by: Jedrzej Jagielski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_type.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/base

[PATCH v1 06/15] net/ixgbe/base: fix unchecked return value

2024-08-29 Thread Anatoly Burakov
From: Barbara Skobiej There was unchecked return value in the ixgbe_stop_mac_link_on_d3_82599 function. Added checking of return value from the called function ixgbe_read_eeprom. Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_82599.c | 8

[PATCH v1 07/15] net/ixgbe/base: fix media type handling for E610

2024-08-29 Thread Anatoly Burakov
From: Krzysztof Galazka Media type information should not be updated by ixgbe_aci_get_link_info function because it will be incorrectly set as unknown when link is down. Do it only in ixgbe_get_media_type_E610. Signed-off-by: Krzysztof Galazka Signed-off-by: Anatoly Burakov --- drivers/net

[PATCH v1 08/15] net/ixgbe/base: fix speed autonegotiation on E610

2024-08-29 Thread Anatoly Burakov
them. Signed-off-by: Krzysztof Galazka Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c index b9b1ba32c3

[PATCH v1 09/15] net/ixgbe/base: FW API version update

2024-08-29 Thread Anatoly Burakov
From: Pawel Malinowski Update FW API version to 1.7. Signed-off-by: Pawel Malinowski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_type_e610.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_type_e610.h b/drivers/net/ixgbe

[PATCH v1 10/15] net/ixgbe/base: handle 5G link speed for E610

2024-08-29 Thread Anatoly Burakov
From: Piotr Kwapulinski When detecting the 5G link speed take into account the E610 VF MAC type in ixgbe_check_mac_link_vf(). Signed-off-by: Piotr Kwapulinski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_vf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v1 11/15] net/ixgbe/base: remove FW API version check

2024-08-29 Thread Anatoly Burakov
From: Krzysztof Galazka Only certain variants of drivers rely on FW API version check in shared code. Other drivers implement their own logic due to differences in requirements. DPDK does not require the FW API check. Signed-off-by: Krzysztof Galazka Signed-off-by: Anatoly Burakov

[PATCH v1 12/15] net/ixgbe/base: disable thermal sensor ops for E610

2024-08-29 Thread Anatoly Burakov
ff-by: Andrzej Wilczynski Co-authored-by: RemigiuszX Konca Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c index 7ea495db97..ab02b11d6a 100644

[PATCH v1 13/15] net/ixgbe/base: fix mailbox ACK handling

2024-08-29 Thread Anatoly Burakov
From: NorbertX Ciosek Check if CTS bit is set in the mailbox message before waiting for ACK. Otherwise ACK will never be received causing the function to timeout. Add a note for ixgbe_write_mbx that it should be called while holding a lock. Signed-off-by: NorbertX Ciosek Signed-off-by: Anatoly

  1   2   3   4   5   6   7   8   9   10   >