> Is there a application available in DPDK where we can specify the sending
> rate i.e. ask the application to send 1 Gbps traffic etc, so that it would
> send 1 Gb traffic uniformly in the second.
> Please guide us on this.
>
Hi
The DPDK based Pkt-gen is doing a very good job for such uniform pac
the
> Ubuntu numbering scheme of Year.Month. Should we consider adopting that
> convention? If we move in future to a model where we have long-term support
> releases (something that was touched on in Dublin), then we could append an
> LTS designation to the release number.
>
>
> Tim
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
*
yet.]
> * initially we plan to have the secondary process then write packets to a
> pcap
> file using a pcap PMD, but down the road if we get other PMDs, like a
> KNI PMD
> or a TAP device PMD, those could be used as targets instead.
>
> This implementation we hope should provide enough hooks to enable the
> standard
> tools to be used for monitoring and capturing packets. We will send out
> draft
> implementation code for various parts of this as soon as we have it.
>
> Additional feedback welcome, as always. :-)
>
> Regards,
> /Bruce
>
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
*
> appropriate destination
>
> Too complicated. Pcap and extcap should be working by default.
>
> > A note about packet ordering: Mirrored packets belonging to different
> flows
> > are probably out of order because of RSS, where multiple lcores
> contribute
> > to the mirror output.
>
> Where I worry is weird configurations where a flow can occur in >1 cores.
> But
> I think most users try not to do this.
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
*
Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky
Explicitly collect the output and result of the
multiple awk script calls, print and return error
if any of them fails
---
devtools/checkpatches.sh | 21 ++
The reason I did not use the && approach is that if both checks have errors,
only the first will be reported and we want all errors to be reported at
once
without discovering them one by one after every fix.
>
> No need for all those checks on $? and the output saving.
>
You blew my cover guys. I am not a shell scripts person :)
You are right. WIll change that
Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky
Explicitly collect the error code of the
multiple awk script calls
---
devtools/checkpatches.sh | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
di
If your patch arrived to your colleagues on the same domain but not to
dev@dpdk,
I would place a bet on your outgoing smtp server not sending it outside
your domain.
Hi Thomas
Glad the function gets to be reused :)
Now that it has more than one consumer apparently the function
check_forbidden_additions() cannot be fed by stdin.
I got it working with 3 changes:
1. call the awk script with $tmpinput as a parameter instead of stdin. This
aligns with Neils change
> > and added an extra backslash
>
> Are you sure we need an extra backslash?
> Note that I am using single quotes.
> I thought we need only 2 backslashes in this case.
>
You are right.
Its only required with double quotes
6:28 PM, Thomas Monjalon
wrote:
> Including svg files with the svg extension is a common mistake:
> .. figure:: example.svg
> must be
> .. figure:: example.*
> So it will work also when building pdf doc with figures converted
> to png files.
>
> A check is add
>
>
> Yes it is a good idea.
> I think it can be a separate patch. Would you like to send it please?
>
> Sure. Will do
>
>> Yes it is a good idea.
>> I think it can be a separate patch. Would you like to send it please?
>>
>> Sure. Will do
>
> Just to make sure - I am waiting for your patch to get in, so that I apply
the warning patch for both checks
--
*Arnon Warshavsk
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh| 3 +++
2 files changed, 4 insertions(+), 6
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
v2 - spelling typo
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh| 3 +++
2 files changed, 4
>
> > + message="Using explicit .svg extension in figures instead of .*"
> > awk -v FOLDERS='doc' \
> > -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
> > -v RET_ON_FAIL=1 \
> > + -v MESSAGE="$message" \
> > -f $(dirname $(readli
>
>
> I think I prefer passing the string directly.
> You can make a shorter message:
> Using explicit .svg extension in rST instead of .*
> or
> Using explicit .svg extension instead of .*
>
>
> Ok
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
v2 - fix typo
v3 - reduce message not to exceed 80 chars
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
> > +check_forbidden_additions() { #
>
> This function looks to work with stdin, not a file.
> Better to remove the comment about a .
>
It can actually work with both but you are right. The comment is not
beneficial there
Will fix with the rest of the list below
...
>
> > + if [ $? -ne 0 ]
> > + read -d '' awk_script << 'EOF'
>
> EOF must be quoted?
>
Missed that one. Yes, the quotes are there to prevent parameter expansion
of the awk variables.
The script breaks without them
>
> One more nit: the title says "additions/removals" but the function is
> only about additions.
>
>
> Yup. No removals there..
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
> + awk -v FOLDERS="lib net drivers" \
>
> I don't know why net is listed as a root directory here?
> I am going to apply the patch without the "net" directory. OK?
>
Yes please. Its not necessarily root rather in any location of the path,
but having added drivers, net is now redundant.
thank
Hi Ilya
Let's use single quotes instead of variable.
Using the script directly with single quotes loses the ability to reuse it
with an additional set of folders , expressions and RET_ON_FAIL.
If we wish to keep the awk code in this file and not in a separate file,
maybe receiving the awk script
++ b/devtools/checkpatches.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2015 6WIND S.A.
>
> --
> 2.7.4
>
>
Acked-By: Arnon Warshavsky
thanks
/Arnon
replace panic calls with log and retrun value.
Local functions to this file,
changing from void to int are non-abi-breaking
--
v4 - fix split literal strings in log messages
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 28
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
--
v4 - keep error message literal string in a singhle line
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c
replace panic calls with log and return value.
--
v2:
- reformat error message to include literal string in a single line
v4: replace -1 return value with -ENOMEM
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 13
de to doxigen of rte_memzone_free()
v3:
- submit all 13 patches changed and unchanged in the same patchset
v4:
- remove 2 patches that are no more relevant
- fix split literal string in error message
- change return value -1 to enum
- split value and success code in a static function
Arnon Warsh
replace panic calls with log and retrun value.
--
v4 - fix split literal strings in log messages
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and retrun value.
v4
static size calculation function changed to return success/fail code
in addition to filling the size result.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 32 -
1 file changed, 21
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 94
- fix split literal strings in log messages
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 86 ++---
lib/librte_eal/bsdapp/eal/eal_thread.c| 65 +++-
lib/librte_eal/common/eal_common_launch.c | 21 ++
lib/librte_eal/common
replace panic calls with log and retrun value.
Thread function removes the noretrun attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal
nnot allocate memzone for private "
> > - "device data");
> > + if (cryptodev->data->dev_private == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone
> for private device data",
> > + __func__);
> > + return -ENOMEM;
> > + }
> > }
> >
> > dpaa_dev->crypto_dev = cryptodev;
> > --
> > 1.8.3.1
>
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | ar...@qwilt.com
*
Thanks Anatoly. Will fix that in v5.
Is it preferred to keep all version notes in the cover letter alone?
On Thu, Apr 19, 2018 at 5:03 PM, Burakov, Anatoly wrote:
> On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote:
>
>> replace panic calls with log and retrun value.
>>
>
>
al only.
>
> (see below for comments on lcore changes)
>
>
>> --
>>
>> v4 - fix split literal strings in log messages
>>
>> Signed-off-by: Arnon Warshavsky
>>
>
> Again, please do not add patch/version notes to the commit message, put
> them afte
Thanks Kevin
Will address that
On Thu, Apr 19, 2018 at 5:36 PM, Kevin Traynor wrote:
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> >
> > v4
> > static size calculation function changed to return success/f
Will do. Thanks
On Thu, Apr 19, 2018 at 8:25 PM, Kevin Traynor wrote:
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> > Local functions to this file,
> > changing from void to int are non-abi-breaking
> > --
Same as in the other patches. Will do. Thanks
On Thu, Apr 19, 2018 at 8:25 PM, Kevin Traynor wrote:
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> > Local function to this file,
> > changing from void to in
Now clear.Thanks
On Thu, Apr 19, 2018 at 5:50 PM, Burakov, Anatoly wrote:
> On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote:
>
>> On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote:
>>
>>> Thanks Anatoly. Will fix that in v5.
>>> Is it preferred to keep all ver
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
>
> typo return, seems to be in a few commit msgs
>
Yup. They were not even copy pasted so at least I am consistent :)
> + return -1;
>
> similar comm
Ok. Thanks
On Thu, Apr 19, 2018 at 8:26 PM, Kevin Traynor wrote:
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> >
> > --
> > v4 - fix split literal strings in log messages
> >
> > Signed-off
Not deliberate.Thanks
On Thu, Apr 19, 2018 at 8:27 PM, Kevin Traynor wrote:
> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> > Thread function removes the noretrun attribute.
> >
> > Signed-off-by: Arnon W
>
> Lots of "!= 0"'s - you might gather by now that I don't like them :-)
>
No way. Would have never guessed that :)
Sure. When in Rome..
>
> hmm, I'm wondering should void __rte_experimental
> rte_eth_dev_owner_delete change to return an int, now that there is a
> fail case and it is still expe
On Thu, Apr 19, 2018 at 5:57 PM, Burakov, Anatoly wrote:
> On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote:
>
>> Copy on the commit message and volatile.
>>
>> Regarding the new function defunct_and_remain_in_endless_loop ()
>> I don't think I can put that in a
Agree. As I wrote below - I will put this instance back in place for this
patchset and handle it on a different one
On Thu, Apr 19, 2018 at 8:31 PM, Kevin Traynor wrote:
> On 04/19/2018 03:57 PM, Burakov, Anatoly wrote:
> > On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote:
> >>
Thanks Aaron
Previously, it wasn't possible for mem_cfg_fd to be reused after a
> failure. Now it is - please reset it to -1. in these close conditions.
>
> Will do.
>
>
> Again, previously this would have aborted on a failure. So it needs to
> be reset to a value that allows retry.
>
Same h
>
> I don't think rte_panic should be considered forbidden. Rather their
> use should be flagged (as this patch does). However, the 'exit 1'
> (which will return a failure for the automatic checkpatch script bot)
> might end up problematic as maintainers might consider it a patch that
> is not re
app back to void and
added this workaround to prevent ABI break on this patch.
I will align both linuxapp and bsd to remain at panic for this function as
well , and address it together with the thread itself
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | ar...@qwilt.com
*
enum
- split value and success code in a static function
v5:
- reword commit messages
- revert thread related instances back to panicing
- handle file descriptors with state to reset after eal init failure
in case re initialization takes place
Arnon Warshavsky (11):
crypto/dpaa: replace rte_
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 70
lib/librte_eal
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
> + if (*vfinfo == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memory for private
> VF data\n",
> > + __func__);
>
> Please use PMD_DRV_LOG since that has per driver logging control rather
> than global log.
>
Missed that one..Thanks
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
enum
- split value and success code in a static function
v5:
- reword commit messages
- revert thread related instances back to panicing
- handle file descriptors with state to reset after eal init failure
in case re initialization takes place
v6:
- Use pmd log macro rather than rte_log
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
v6:
- replaced rte_log with pmd log macro
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
v6:
- replaced rte_log with pmd log macro
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 70
lib/librte_eal
please ignore this patchset.
The v6 formatting is messed up. resending
Sorry for the mess
On Tue, Apr 24, 2018 at 9:41 AM, Arnon Warshavsky wrote:
> The purpose of this patch series is to cleanup the library code
> from paths that end up aborting the process,
> and move to checking err
On Tue, Apr 24, 2018 at 9:44 AM, Arnon Warshavsky wrote:
> please ignore this patchset.
> The v6 formatting is messed up. resending
> Sorry for the mess
>
My bad. Ignore the ignore request
Its gmail thread aggregation view that made me think I mixed v5 and v6.
thanks
/Arnon
>
>
> > + if (cryptodev->data->dev_private == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone
> for private device data",
> > + __func__);
>
> dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro.
>
> You should go th
Thanks. Same as with dpaa
On Tue, Apr 24, 2018 at 6:06 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Tue, 24 Apr 2018 09:41:57 +0300
> Arnon Warshavsky wrote:
>
> > + if (eventdev->data->dev_private == NULL) {
> > +
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/net/bonding/rte_eth_bond_8023ad.c | 29
bond specific , dpaa2 specific and eventdev specific log macros
Arnon Warshavsky (11):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_panic instances in
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 78 +++
lib
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
<...>
>
> + if (rte_config_init() != 0) {
>> + rte_eal_init_alert("Failed to init configuration");
>> + rte_errno = EFAULT;
>> + return -1;
>> + }
>> +
>> + if (rte_mp_channel_init() < 0) {
>> + rte_eal_init_alert("failed to
> Just a general comment - i'm not too familiar with this code, but it looks
> like all of these failures will only happen on thread init. Can we make
> sure it starts?
>
> You can use similar approach to Olivier's (recently merged) thread
> affinity patches, with pthread barriers etc. to ensure th
>
>
> You mixed dpaa2 with bonding in this set.
>
Indeed. Thanks
1 - 100 of 230 matches
Mail list logo
