Re: [dpdk-dev] [PATCH 0/4] maintainers: update for igc/e1000/ixgbe/i40e

2021-04-29 Thread Guo, Jia
Thanks Ferruh, Thomas and drivers maintainers. Thanks all DPDK contributor! Good luck and see you somewhere! > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 29, 2021 9:58 PM > To: Guo, Jia ; Xing, Beilei ; Wang, > Haiyue ; tho...@monjalon.net > Cc:

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet

2021-04-01 Thread Guo, Jia
Hi, ting > -Original Message- > From: Xu, Ting > Sent: Thursday, April 1, 2021 10:08 AM > To: Guo, Jia ; Yang, Qiming ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet > > Hi, Jeff > > See in

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet

2021-04-01 Thread Guo, Jia
Hi, ting > -Original Message- > From: Xu, Ting > Sent: Tuesday, March 30, 2021 11:25 AM > To: Guo, Jia ; Yang, Qiming ; > Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet > > Hi, Jeff > > >

Re: [dpdk-dev] [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-12 Thread Guo, Jia
Hi, Ting > -Original Message- > From: Xu, Ting > Sent: Monday, April 12, 2021 4:31 PM > To: Guo, Jia ; Zhang, Qi Z ; Yang, > Qiming > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR > > Hi, Jeff, &

Re: [dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet

2021-04-12 Thread Guo, Jia
Hi, Ting > -Original Message- > From: Xu, Ting > Sent: Monday, April 12, 2021 4:45 PM > To: Guo, Jia ; or...@nvidia.com; Zhang, Qi Z > ; Xing, Beilei ; Li, Xiaoyun > ; Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 4/4] net/iavf: s

Re: [dpdk-dev] [PATCH] net/ixgbe: disable NFS filtering

2021-01-21 Thread Guo, Jia
Hi, dapeng > -Original Message- > From: dapengx...@intel.com > Sent: Wednesday, January 20, 2021 5:27 PM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: disable NFS filtering

Re: [dpdk-dev] [PATCH v2] net/ixgbe: disable NFS filtering

2021-01-25 Thread Guo, Jia
Hi, dapeng > -Original Message- > From: dapengx...@intel.com > Sent: Monday, January 25, 2021 11:11 AM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: disable NFS filtering

Re: [dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering

2021-01-25 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: dapengx...@intel.com > Sent: Tuesday, January 26, 2021 11:03 AM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v3] net/ixgbe: disable NFS filtering

Re: [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722

2021-02-23 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Xing, Beilei > Sent: Wednesday, February 24, 2021 10:09 AM > To: Guo, Jia > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org; > Zhang, HengjianX > Subject: [PATCH] net/i40evf: fix packet loss issue for X722 &

Re: [dpdk-dev] [PATCH] net/e1000: remove MTU setting limitation

2021-02-23 Thread Guo, Jia
Seems that this is align with the fixing process of the other pmds(ixgbe/txgbe) and it is not bad. Thanks. Acked-by: Jeff Guo > -Original Message- > From: Yu, DapengX > Sent: Friday, February 19, 2021 6:03 PM > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; Yu

Re: [dpdk-dev] [PATCH v2] net/igc: remove MTU setting limitation

2021-02-23 Thread Guo, Jia
Seems that v2 is the same as v1, but v1 exposure the coding style issue. Anyway please add the change when update new version. Thanks. Acked-by: Jeff Guo > -Original Message- > From: Yu, DapengX > Sent: Friday, February 19, 2021 6:01 PM > To: Guo, Jia ; Wang, Haiyu

Re: [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing

2021-03-12 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Zhang, RobinX > Sent: Friday, March 12, 2021 4:52 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Zhang, > RobinX > Subject: [PATCH] net/i40e: fix Virtchnl Offload Caps missing > > A new feature requestin

Re: [dpdk-dev] [PATCH v1 4/4] net/iavf: support FDIR for IP fragment packet

2021-03-22 Thread Guo, Jia
Hi, xiaoyun > -Original Message- > From: Li, Xiaoyun > Sent: Friday, March 19, 2021 3:57 PM > To: Guo, Jia ; or...@nvidia.com; Zhang, Qi Z > ; Xing, Beilei ; Wu, Jingjing > > Cc: Zhang, Yuying ; Xu, Ting ; > dev@dpdk.org > Subject: RE: [PATCH v1 4/4] ne

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR issue for ETH + VLAN pattern

2020-10-26 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Xing, Beilei > Sent: Tuesday, October 27, 2020 2:22 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix FDIR issue for ETH + VLAN pattern > > From: Beilei

Re: [dpdk-dev] [PATCH v10] net/iavf: support flex desc metadata extraction

2020-10-27 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, October 27, 2020 1:22 PM > To: Guo, Jia ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei ; > Yigit, Ferruh > Cc: dev@dpdk.org; Richardson, Bruce > Subject: RE: [PATCH v10] net/iavf: support flex

Re: [dpdk-dev] [PATCH v2] doc: add known uio_pci_generic issue for i40e

2017-01-17 Thread Guo, Jia
On 1/18/2017 1:36 AM, Ferruh Yigit wrote: On 1/17/2017 5:00 PM, Wu, Jingjing wrote: -Original Message- From: Yigit, Ferruh Sent: Tuesday, January 17, 2017 4:31 AM To: Guo, Jia ; Zhang, Helin ; Wu, Jingjing Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] doc: add known

Re: [dpdk-dev] [PATCH v3] doc: add known uio_pci_generic issue for i40e

2017-01-19 Thread Guo, Jia
7:17 PM To: Guo, Jia ; Zhang, Helin ; Wu, Jingjing Cc: dev@dpdk.org; Guo, Jia ; g...@dpdk.org Subject: RE: [dpdk-dev] [PATCH v3] doc: add known uio_pci_generic issue for i40e > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Thursd

Re: [dpdk-dev] [PATCH v3] doc: add known uio_pci_generic issue for i40e

2017-01-19 Thread Guo, Jia
Yes, rerruh, I will recheck the gitconfig and consistent the sign-off name in v4. thanks for your suggestion. Best regards, Jeff Guo -Original Message- From: Yigit, Ferruh Sent: Thursday, January 19, 2017 8:06 PM To: Guo, Jia ; Zhang, Helin ; Wu, Jingjing Cc: dev@dpdk.org; g

Re: [dpdk-dev] [PATCH v3] doc: add known uio_pci_generic issue for i40e

2017-01-19 Thread Guo, Jia
Ok, that make sense, I will re-correct it then. Thanks. Best regards, Jeff Guo -Original Message- From: Mcnamara, John Sent: Thursday, January 19, 2017 10:54 PM To: Guo, Jia ; Zhang, Helin ; Wu, Jingjing Cc: dev@dpdk.org; g...@dpdk.org Subject: RE: [dpdk-dev] [PATCH v3] doc: add known

Re: [dpdk-dev] [PATCH v4 17/17] net/i40e: flush tunnel filters

2017-01-02 Thread Guo, Jia
On 12/30/2016 11:25 AM, Beilei Xing wrote: This patch adds i40e_tunnel_filter_flush function to flush all tunnel filters, including filters in SW and HW. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 37 + 1 file changed, 37 insertions(+)

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-07-04 Thread Guo, Jia
hi, thomas On 7/5/2017 7:45 AM, Thomas Monjalon wrote: Hi, This is an interesting step for hotplug in DPDK. 28/06/2017 13:07, Jeff Guo: + netlink_fd = socket(PF_NETLINK, SOCK_DGRAM, NETLINK_KOBJECT_UEVENT); It is monitoring the whole system... +int +rte_uevent_get(int fd, struct rte

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-07-05 Thread Guo, Jia
On 7/5/2017 3:32 PM, Thomas Monjalon wrote: 05/07/2017 05:02, Guo, Jia: hi, thomas On 7/5/2017 7:45 AM, Thomas Monjalon wrote: Hi, This is an interesting step for hotplug in DPDK. 28/06/2017 13:07, Jeff Guo: + netlink_fd = socket(PF_NETLINK, SOCK_DGRAM, NETLINK_KOBJECT_UEVENT

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-07 Thread Guo, Jia
On 7/7/2017 6:17 PM, Thomas Monjalon wrote: 07/07/2017 09:56, Thomas Monjalon: 29/06/2017 07:01, Jeff Guo: --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw) /* enable uio intr after c

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-07-12 Thread Guo, Jia
On 7/10/2017 6:35 AM, Thomas Monjalon wrote: 07/07/2017 16:08, Guo, Jia: On 7/7/2017 6:17 PM, Thomas Monjalon wrote: 07/07/2017 09:56, Thomas Monjalon: 29/06/2017 07:01, Jeff Guo: --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1283,6 +1283,7 @@ static inline

Re: [dpdk-dev] [PATCH] net/i40e: fix link down and negotiation issue

2017-07-20 Thread Guo, Jia
Yes, I have already use cpu_to_le32 to translator, but I agree first defend it as uint32_t might be better to read . I will send v2 , thanks for review. Best regards, Jeff Guo -Original Message- From: Wu, Jingjing Sent: Friday, July 21, 2017 10:26 AM To: Guo, Jia ; Xing, Beilei Cc

Re: [dpdk-dev] [dpdk-dev v2 3/3] test: enable HW CRC strip by default

2017-03-22 Thread Guo, Jia
Accept that, and will send v3 to fix it. Thanks for review. Best regards, Jeff Guo -Original Message- From: Wu, Jingjing Sent: Wednesday, March 22, 2017 8:27 PM To: Guo, Jia ; Zhang, Helin Cc: dev@dpdk.org; sta...@dpdk.org Subject: RE: [dpdk-dev v2 3/3] test: enable HW CRC strip by

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-17 Thread Guo, Jia
ntin wrote: > Hi Jeff, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jeff Guo >> Sent: Sunday, October 16, 2016 2:40 AM >> To: Zhang, Helin ; Wu, Jingjing > intel.com> >> Cc: dev at dpdk.org; Guo, Jia >> Subje

[dpdk-dev] [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile

2016-10-19 Thread Guo, Jia
hi,yigit Because of remove "#ifdef x722" will related with some prior patch and need related folks to make agreement on that, so we need to make a discuss later to get a conclusion. we definitely confidence that we will get the better balance base on the code maintenance effective. so just

[dpdk-dev] [PATCH] net/i40e: fix the hash filter invalid calculation in X722

2016-10-25 Thread Guo, Jia
Jeff Guo -Original Message- From: Wu, Jingjing Sent: Monday, October 24, 2016 5:10 PM To: Guo, Jia ; Zhang, Helin Cc: dev at dpdk.org; Yigit, Ferruh Subject: RE: [PATCH] net/i40e: fix the hash filter invalid calculation in X722 > -Original Message- > From: Guo,

Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-20 Thread Guo, Jia
hi,gaetan On 6/16/2017 5:22 AM, Gaëtan Rivet wrote: Hi Jingjing, On Wed, Jun 07, 2017 at 07:40:37AM +, Wu, Jingjing wrote: Secondly, in order to read out the uevent that monitoring, we need to add uevent API in rte layer. We plan add 2 , rte_uevent_connect and rte_get_uevent. All drive

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-06-28 Thread Guo, Jia
The buf have contain lot of consistent '/0', so it is why I need to check that. anyway I will refine that and other return issue in v3. Thanks jingjing . Best regards, Jeff Guo -Original Message- From: Wu, Jingjing Sent: Thursday, June 29, 2017 10:25 AM To: Guo, Jia ; Zh

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Guo, Jia
: Thursday, June 29, 2017 9:42 AM To: Guo, Jia ; Zhang, Helin Cc: dev@dpdk.org Subject: RE: [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e > -Original Message- > From: Guo, Jia > Sent: Wednesday, June 28, 2017 7:07 PM > To: Zhang, Helin ; Wu, Jingjing > > Cc: dev@

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-29 Thread Guo, Jia
: Thursday, June 29, 2017 12:48 PM To: Stephen Hemminger ; Guo, Jia Cc: Zhang, Helin ; dev@dpdk.org; Chang, Cunyin ; Liang, Cunming Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumb

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-06-15 Thread Guo, Jia
plug exception handler in this case, but it definitely should not affect any other failure process. i will cover all about this in my patch. 07/06/2018 04:14, Guo, Jia: On 6/6/2018 8:54 PM, Bruce Richardson wrote: +Tech-board as I think that this should have more input at the design stage ahead o

Re: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug

2018-06-15 Thread Guo, Jia
...@6wind.com; Wu, Jingjing ; tho...@monjalon.net; mo...@mellanox.com; ma...@mellanox.com; Van Haaren, Harry ; Tan, Jianfeng Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo, Jia ; Zhang, Helin Subject: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug Use

Re: [dpdk-dev] [PATCH v2 1/4] bus/pci: handle device hot unplug

2018-06-26 Thread Guo, Jia
hi, gaetan, thanks for your review, see comment as bellow On 6/22/2018 8:59 PM, Gaëtan Rivet wrote: Hi Jeff, Sorry, I followed this development from afar, I have a remark regarding this API, I think it can be made simpler. Details below. On Fri, Jun 22, 2018 at 07:51:05PM +0800, Jeff Guo wro

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Guo, Jia
hi, matan thanks for your review, see comment. On 6/26/2018 7:58 PM, Matan Azrad wrote: Hi Jeff Please see comments... From: Jeff Guo Sent: Friday, June 22, 2018 2:51 PM To: step...@networkplumber.org; bruce.richard...@intel.com; ferruh.yi...@intel.com; konstantin.anan...@intel.com; gaetan.r

Re: [dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Guo, Jia
hi, mantan On 6/27/2018 1:07 AM, Matan Azrad wrote: Hi Jeff Continue session from last version + more comments\question. From: Jeff Guo Sent: Tuesday, June 26, 2018 6:36 PM To: step...@networkplumber.org; bruce.richard...@intel.com; ferruh.yi...@intel.com; konstantin.anan...@intel.com; gaeta

Re: [dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-29 Thread Guo, Jia
matan On 6/27/2018 2:05 PM, Matan Azrad wrote: Hi Guo From: Guo, Jia Sent: Wednesday, June 27, 2018 6:56 AM To: Matan Azrad ; step...@networkplumber.org; bruce.richard...@intel.com; ferruh.yi...@intel.com; konstantin.anan...@intel.com; gaetan.ri...@6wind.com; jingjing...@intel.com; Thomas

Re: [dpdk-dev] [PATCH V4 6/9] eal: add failure handle mechanism for hot plug

2018-06-29 Thread Guo, Jia
hi,konstantin On 6/29/2018 6:49 PM, Ananyev, Konstantin wrote: Hi Jeff, This patch introduces a failure handler mechanism to handle device hot plug removal event. First register sigbus handler, once sigbus error be captured, will check the failure address and accordingly remap the invalid me

Re: [dpdk-dev] [PATCH V4 5/9] bus: add helper to handle sigbus

2018-06-29 Thread Guo, Jia
hi, konstantin On 6/29/2018 6:51 PM, Ananyev, Konstantin wrote: +int +rte_bus_sigbus_handler(const void *failure_addr) +{ + struct rte_bus *bus; + int old_errno = rte_errno; + int ret = 0; + + rte_errno = 0; + + bus = rte_bus_find(NULL, bus_handle_sigbus, failure_a

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
mantan, On 7/1/2018 3:46 PM, Matan Azrad wrote: Hi Jeff A good advance, thank you, but as I said in previous version, this patch inserts a bug and the next one fixes it. Patch 9 should be before patch 8 while this patch just add 1 more option for EAL hotplug. i agree that patch 9 before pa

Re: [dpdk-dev] [PATCH V4 5/9] bus: add helper to handle sigbus

2018-07-03 Thread Guo, Jia
hi, gaetan and konstantin answer both of your questions here as below. On 6/29/2018 8:52 PM, Gaëtan Rivet wrote: On Fri, Jun 29, 2018 at 12:21:39PM +, Ananyev, Konstantin wrote: -Original Message- From: Guo, Jia Sent: Friday, June 29, 2018 12:23 PM To: Ananyev, Konstantin

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
hi, thomas On 7/4/2018 6:44 AM, Thomas Monjalon wrote: 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum rte_dev_event_type type

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-04 Thread Guo, Jia
On 7/4/2018 6:21 AM, Thomas Monjalon wrote: 29/06/2018 12:30, Jeff Guo: /** + * Implementation a specific hot plug handler, which is responsible + * for handle the failure when hot remove the device, guaranty the system + * would not crash in the case. + * @param dev + * Pointer of the

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-04 Thread Guo, Jia
On 7/4/2018 3:55 PM, Thomas Monjalon wrote: 04/07/2018 09:16, Guo, Jia: On 7/4/2018 6:21 AM, Thomas Monjalon wrote: 29/06/2018 12:30, Jeff Guo: /** + * Implementation a specific hot plug handler, which is responsible + * for handle the failure when hot remove the device, guaranty the

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-05 Thread Guo, Jia
On 7/4/2018 3:06 PM, Matan Azrad wrote: Hi Thomas, Guo From: Thomas Monjalon 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name

Re: [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e

2018-11-07 Thread Guo, Jia
Hi, qi Mostly accept, please check v2 version for that, thanks. Best regards, Jeff Guo -Original Message- From: Zhang, Qi Z Sent: Saturday, October 20, 2018 2:05 AM To: Guo, Jia ; Xing, Beilei ; Mcnamara, John ; Kovacevic, Marko Cc: Wu, Jingjing ; dev@dpdk.org; Zhang, Helin

Re: [dpdk-dev] [PATCH V20 1/4] bus/pci: introduce device hot unplug handle

2018-05-02 Thread Guo, Jia
On 4/20/2018 6:32 PM, Ananyev, Konstantin wrote: Hi Jeff, As of device hot unplug, we need some preparatory measures so that we will not encounter memory fault after device be plug out of the system, and also let we could recover the running data path but not been break. This patch allows the

Re: [dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-05-02 Thread Guo, Jia
On 4/20/2018 7:14 PM, Ananyev, Konstantin wrote: This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let eal help

Re: [dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-05-02 Thread Guo, Jia
On 4/21/2018 12:16 AM, Ananyev, Konstantin wrote: + +static void sigbus_handler(int signum __rte_unused, siginfo_t *info, + void *ctx __rte_unused) +{ + int ret; + + RTE_LOG(ERR, EAL, "SIGBUS error, fault address:%p\n", info->si_addr); + ret = dev

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: show example to handler hot unplug

2018-05-03 Thread Guo, Jia
hi, matan On 5/3/2018 3:25 PM, Matan Azrad wrote: Hi Jeff From: Jeff Guo, Wednesday, April 18, 2018 4:38 PM Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. Once app detect the removal event, the callback would be called, it first stop

Re: [dpdk-dev] [PATCH V21 2/4] eal: add failure handle mechanism for hot plug

2018-05-08 Thread Guo, Jia
On 5/4/2018 11:56 PM, Ananyev, Konstantin wrote: Hi Jeff, This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let

Re: [dpdk-dev] [PATCH] net/i40e: fix link up failure issue

2018-05-16 Thread Guo, Jia
make sense , will split the patch more explicit. thanks ,qi. On 5/16/2018 10:43 PM, Zhang, Qi Z wrote: Hi Jeff: -Original Message- From: Guo, Jia Sent: Wednesday, May 16, 2018 2:29 PM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Guo, Jia Subject: [PATCH] net/i40e: fix link up

[dpdk-dev] [RFC] hot plug failure handle mechanism

2018-05-23 Thread Guo, Jia
As we know, hot plug is an importance feature whenever it use for the datacenter device's fail-safe and consumption management , or use for the dynamic deployment and SRIOV Live Migration in SDN/NFV, it could be bring the higher flexibility and continuality of the networking services in multipl

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-05-25 Thread Guo, Jia
hi,matan On 5/24/2018 10:57 PM, Matan Azrad wrote: Hi Guo Some questions. From: Guo Jia As we know, hot plug is an importance feature whenever it use for the datacenter device's fail-safe and consumption management , or use for the dynamic deployment and SRIOV Live Migration in SDN/NF

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-06-03 Thread Guo, Jia
hi,bruce On 5/29/2018 7:20 PM, Bruce Richardson wrote: On Thu, May 24, 2018 at 07:55:43AM +0100, Guo, Jia wrote: The hot plug failure handle mechanism should be come across as bellow: 1. Add a new bus ops “handle_hot-unplug”in bus to handle bus read/write error, it is bus

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-06-06 Thread Guo, Jia
On 6/6/2018 8:54 PM, Bruce Richardson wrote: +Tech-board as I think that this should have more input at the design stage ahead of any code patches being pushed. On Mon, Jun 04, 2018 at 09:56:10AM +0800, Guo, Jia wrote: hi,bruce On 5/29/2018 7:20 PM, Bruce Richardson wrote: On Thu, May 24

Re: [dpdk-dev] [PATCH V18 1/4] eal: add device event handle in interrupt thread

2018-04-03 Thread Guo, Jia
On 4/4/2018 9:47 AM, Tan, Jianfeng wrote: -Original Message- From: Guo, Jia Sent: Tuesday, April 3, 2018 6:34 PM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing; tho...@monjalon.net; mo...@mellanox.com; Van

Re: [dpdk-dev] [PATCH V18 2/4] eal: add device event monitor framework

2018-04-04 Thread Guo, Jia
On 4/4/2018 10:53 AM, Tan, Jianfeng wrote: -Original Message- From: Guo, Jia Sent: Tuesday, April 3, 2018 6:34 PM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing; tho...@monjalon.net; mo...@mellanox.com; Van

Re: [dpdk-dev] [PATCH V18 3/4] eal/linux: uevent parse and process

2018-04-04 Thread Guo, Jia
thanks for review. On 4/4/2018 11:15 AM, Tan, Jianfeng wrote: Hi Jeff, Looks much better now, but still have some issues to address. -Original Message- From: Guo, Jia Sent: Tuesday, April 3, 2018 6:34 PM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev

Re: [dpdk-dev] [PATCH V18 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Guo, Jia
it in EAL command in the coming patch set.. good suggestion, azrad. From: Tan, Jianfeng, Wednesday, April 4, 2018 6:23 AM -Original Message----- From: Guo, Jia Sent: Tuesday, April 3, 2018 6:34 PM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Guo, Jia
thanks. On 4/6/2018 12:22 AM, Tan, Jianfeng wrote: On 4/6/2018 12:10 AM, Jeff Guo wrote: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:48 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by belo

Re: [dpdk-dev] [PATCH V20 2/4] eal: add device event monitor framework

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:54 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -260,3 +260,13 @@ EXPERIMENTAL { rte_socket_id_by_idx; } DPDK_18.02; + +EXPERIMENTAL { + global: + + rte_dev_e

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:58 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo -

Re: [dpdk-dev] [PATCH V18 3/5] eal: add failure handler mechanism for hot plug

2018-04-06 Thread Guo, Jia
, Jingjing ; tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry ; Tan, Jianfeng Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo, Jia ; Zhang, Helin Subject: [dpdk-dev] [PATCH V18 3/5] eal: add failure handler mechanism for hot plug This patch introduces an API

Re: [dpdk-dev] [PATCH V18 1/5] bus: introduce device hot unplug handle

2018-04-06 Thread Guo, Jia
thanks. On 4/4/2018 12:31 PM, Tan, Jianfeng wrote: -Original Message- From: Guo, Jia Sent: Wednesday, April 4, 2018 2:17 AM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing; tho...@monjalon.net; mo

Re: [dpdk-dev] [PATCH V18 2/5] bus/pci: implement handle hot unplug operation

2018-04-06 Thread Guo, Jia
On 4/4/2018 1:25 PM, Tan, Jianfeng wrote: -Original Message- From: Guo, Jia Sent: Wednesday, April 4, 2018 2:17 AM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing; tho...@monjalon.net; mo...@mellanox.com; Van

Re: [dpdk-dev] [PATCH V19 2/4] eal: add failure handler mechanism for hot plug

2018-04-11 Thread Guo, Jia
thanks your review , Konstantin, comment below. On 4/10/2018 1:42 AM, Ananyev, Konstantin wrote: Hi Jeff, This patch introduces an API (rte_dev_handle_hot_unplug) to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be u

Re: [dpdk-dev] [PATCH V19 1/4] bus/pci: introduce device hot unplug handle

2018-04-11 Thread Guo, Jia
On 4/10/2018 1:47 AM, Ananyev, Konstantin wrote: -Original Message- From: Guo, Jia Sent: Friday, April 6, 2018 11:57 AM To: step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; Ananyev, Konstantin ; gaetan.ri...@6wind.com; Wu, Jingjing ; tho...@monjalon.net; mo

Re: [dpdk-dev] [PATCH V19 3/4] eal/linux: uevent parse and process

2018-04-11 Thread Guo, Jia
On 4/5/2018 7:05 PM, Tan, Jianfeng wrote: On 4/5/2018 5:02 PM, Jeff Guo wrote: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Je

Re: [dpdk-dev] [PATCH V19 2/4] eal: add failure handler mechanism for hot plug

2018-04-11 Thread Guo, Jia
, Jingjing ; tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry ; Tan, Jianfeng Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo, Jia ; Zhang, Helin Subject: [dpdk-dev] [PATCH V19 2/4] eal: add failure handler mechanism for hot plug This patch introduces an API

Re: [dpdk-dev] [PATCH V19 2/4] eal: add failure handler mechanism for hot plug

2018-04-11 Thread Guo, Jia
On 4/6/2018 10:24 PM, Zhang, Qi Z wrote: One more comment -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z Sent: Friday, April 6, 2018 10:04 PM To: Guo, Jia ; step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; Ananyev, Konstantin

Re: [dpdk-dev] [PATCH V19 4/4] app/testpmd: use auto handle for hotplug

2018-04-13 Thread Guo, Jia
hi matan On 4/12/2018 1:31 PM, Matan Azrad wrote: Hi All From: Jeff Guo, Friday, April 6, 2018 1:57 PM Use testpmd for example, to show how an application smoothly handle failure when device be hot removal, and show how to auto bind kernal driver to preparing attach device when device being h

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Guo, Jia
hi, all On 4/15/2018 4:10 AM, Matan Azrad wrote: Hi all From: Burakov, Anatoly, Friday, April 13, 2018 8:41 PM To: Bruce Richardson ; Thomas Monjalon Cc: dev@dpdk.org; pmati...@redhat.com; david.march...@6wind.com; jia@intel.com; Matan Azrad ; konstantin.anan...@intel.com; step...@networ

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-09 Thread Guo, Jia
, Jeff Guo -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, January 9, 2018 6:48 PM To: Guo, Jia Cc: Mordechay Haimovsky ; dev@dpdk.org; step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; gaetan.ri...@6wind.com; Ananyev, Konstantin

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-09 Thread Guo, Jia
Got it, seems that would be more complex work to do later, still need to debugging the feature more to fulfill for more driver. Best regards, Jeff Guo From: Mordechay Haimovsky [mailto:mo...@mellanox.com] Sent: Tuesday, January 9, 2018 6:32 PM To: Guo, Jia ; Thomas Monjalon Cc: dev@dpdk.org

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-09 Thread Guo, Jia
On 1/9/2018 7:38 PM, Thomas Monjalon wrote: 09/01/2018 09:25, Guo, Jia: On 1/9/2018 8:39 AM, Thomas Monjalon wrote: +int +_rte_dev_callback_process(struct rte_device *device, + enum rte_eal_dev_event_type event, + void *cb_arg, void *ret_param

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-09 Thread Guo, Jia
[mailto:tho...@monjalon.net] Sent: Tuesday, January 9, 2018 7:45 PM To: Guo, Jia Cc: Mordechay Haimovsky ; dev@dpdk.org; step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; gaetan.ri...@6wind.com; Ananyev, Konstantin ; shreyansh.j...@nxp.com; Wu, Jingjing ; Zhang, Helin ; Van

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-10 Thread Guo, Jia
On 1/9/2018 8:42 PM, Gaëtan Rivet wrote: Hi Jeff, On Tue, Jan 09, 2018 at 12:08:52PM +, Guo, Jia wrote: Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-10 Thread Guo, Jia
On 1/9/2018 9:44 PM, Thomas Monjalon wrote: 09/01/2018 13:08, Guo, Jia: Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake. Any other good idea or tip for that

Re: [dpdk-dev] [PATCH V9 1/5] eal: add uevent monitor api and callback func

2018-01-11 Thread Guo, Jia
On 1/11/2018 9:43 AM, Thomas Monjalon wrote: Hi, Thanks for splitting the patches. I will review the first one today. Please see below. 10/01/2018 10:12, Jeff Guo: --- /dev/null +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c +int +rte_dev_monitor_start(void) +{ + return -1; +} + +int +rte_d

Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function

2018-01-15 Thread Guo, Jia
On 1/15/2018 7:24 AM, Thomas Monjalon wrote: 11/01/2018 15:05, Jeff Guo: +enum rte_dev_state { + RTE_DEV_UNDEFINED, /**< unknown device state */ + RTE_DEV_FAULT, /**< device fault or error */ + RTE_DEV_PARSED, /**< device have been parsed on bus*/ + RTE_DEV_PROBED

Re: [dpdk-dev] [PATCH V10 1/2] eal: add uevent monitor api and callback func

2018-01-15 Thread Guo, Jia
On 1/15/2018 7:16 AM, Thomas Monjalon wrote: Hi, 11/01/2018 15:05, Jeff Guo: +/* A genaral callback for all registerd devices */ Typos: genaral, registerd So the callback is only for registered devices? What about hotplugged devices? the hotplugged devices is managed by the application, if

Re: [dpdk-dev] [PATCH V10 1/2] eal: add uevent monitor api and callback func

2018-01-15 Thread Guo, Jia
On 1/15/2018 7:32 PM, Thomas Monjalon wrote: 15/01/2018 11:55, Guo, Jia: On 1/15/2018 7:16 AM, Thomas Monjalon wrote: Hi, 11/01/2018 15:05, Jeff Guo: +/* A genaral callback for all registerd devices */ Typos: genaral, registerd So the callback is only for registered devices? What about

Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function

2018-01-15 Thread Guo, Jia
On 1/15/2018 7:29 PM, Thomas Monjalon wrote: 15/01/2018 11:52, Guo, Jia: On 1/15/2018 7:24 AM, Thomas Monjalon wrote: 11/01/2018 15:05, Jeff Guo: +enum rte_dev_subsystem { + RTE_DEV_SUBSYSTEM_UIO, + RTE_DEV_SUBSYSTEM_VFIO, + RTE_DEV_SUBSYSTEM_PCI

Re: [dpdk-dev] [PATCH V11 2/3] eal: add uevent pass and process function

2018-01-17 Thread Guo, Jia
On 1/18/2018 6:00 AM, Thomas Monjalon wrote: 15/01/2018 11:48, Jeff Guo: +enum rte_dev_event_subsystem { + RTE_DEV_EVENT_SUBSYSTEM_UIO, + RTE_DEV_EVENT_SUBSYSTEM_VFIO, + RTE_DEV_EVENT_SUBSYSTEM_PCI, + RTE_DEV_EVENT_SUBSYSTEM_MAX +}; I still don't understand this classi

Re: [dpdk-dev] [PATCH V11 1/3] eal: add uevent monitor api and callback func

2018-01-17 Thread Guo, Jia
On 1/18/2018 5:59 AM, Thomas Monjalon wrote: 15/01/2018 11:48, Jeff Guo: + * It registers the callback for the specific event. Multiple + * callbacks cal be registered at the same time. + * + * @param device_name + * The device name. + * @param cb_fn + * callback address. + * @param cb_arg +

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-18 Thread Guo, Jia
On 1/19/2018 9:13 AM, Thomas Monjalon wrote: 18/01/2018 05:12, Jeff Guo: + * It registers the callback for the specific device. + * Multiple callbacks cal be registered at the same time. + * + * @param device_name + * The device name, that is the param name of the struct rte_device, Why not

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-25 Thread Guo, Jia
thanks for your review. please check v13. On 1/24/2018 10:52 PM, Wu, Jingjing wrote: -Original Message- From: Guo, Jia Sent: Thursday, January 18, 2018 12:12 PM To: step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; gaetan.ri...@6wind.com Cc: Ananyev, Konstantin ; jblu

Re: [dpdk-dev] [PATCH V12 3/3] app/testpmd: use uevent to monitor hotplug

2018-01-25 Thread Guo, Jia
On 1/24/2018 11:21 PM, Wu, Jingjing wrote: + +static void +add_uevent_callback(void *arg) +{ + char *dev_name = (char *)arg; + + rte_eal_alarm_cancel(add_uevent_callback, arg); + + if (!in_hotplug_list(dev_name)) + return; + + RTE_LOG(ERR, EAL, "add device:

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-08-22 Thread Guo, Jia
--- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Guo, Jia Sent: Wednesday, July 5, 2017 5:04 PM To: Thomas Monjalon Cc: dev@dpdk.org; Zhang, Helin ; Wu, Jingjing Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug On 7/5/2017 3:32 PM, Thomas Monjalon wrote: > 05/07/2017

Re: [dpdk-dev] [PATCH v4 1/2] eal: add uevent monitor for hot plug

2017-09-04 Thread Guo, Jia
Thanks Stephen for your review and suggestion, I will involve them in next version. Best regards, Jeff Guo -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, September 4, 2017 12:12 AM To: Guo, Jia Cc: Richardson, Bruce ; dev@dpdk.org

Re: [dpdk-dev] [PATCH V15 2/5] eal: add uevent pass and process function

2018-03-22 Thread Guo, Jia
jianfeng, thanks for your review. almost make sense and comment as bellow. On 3/21/2018 10:20 PM, Tan, Jianfeng wrote: On 3/21/2018 1:27 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be exam

Re: [dpdk-dev] [PATCH V2] igb_uio: fix uevent montior issue

2018-03-27 Thread Guo, Jia
On 3/27/2018 2:28 AM, Ferruh Yigit wrote: On 2/27/2018 7:20 AM, Jeff Guo wrote: udev could not detect remove and add event of device when hotplug in and out devices, that related with the fix about using pointer of rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, that wo

Re: [dpdk-dev] [PATCH V16 2/4] eal: add device event monitor framework

2018-03-28 Thread Guo, Jia
jianfeng will correct every typo, and comment inline. On 3/28/2018 11:39 AM, Tan, Jianfeng wrote: -Original Message- From: Guo, Jia Sent: Monday, March 26, 2018 7:21 PM To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu

Re: [dpdk-dev] [PATCH V16 1/4] eal: add device event handle in interrupt thread

2018-03-28 Thread Guo, Jia
jianfeng On 3/27/2018 5:26 PM, Tan, Jianfeng wrote: Hi, On 3/26/2018 7:20 PM, Jeff Guo wrote: Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. A simple search of RTE_INTR_HANDLE_ALARM, we can see that we still need to update rte_intr_enable()

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-29 Thread Guo, Jia
hi, harry thanks for your review. On 3/29/2018 9:32 PM, Van Haaren, Harry wrote: Two additional input along with Jianfeng's existing comments; -Original Message- From: Tan, Jianfeng Sent: Wednesday, March 28, 2018 5:16 PM To: Guo, Jia ; step...@networkplumber.org; Richardson,

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-29 Thread Guo, Jia
jianfeng On 3/29/2018 12:15 AM, Tan, Jianfeng wrote: BTW, adding new .c file needs to update meson.build now. thanks for your info . On 3/26/2018 7:20 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent parse and process function to tr

  1   2   3   >