Malov ; Andrew Rybchenko
> ; dev@dpdk.org; Hanumanth Reddy Pothula
> ; Ferruh Yigit
> Cc: viachesl...@nvidia.com; Jerin Jacob Kollanukkaran ;
> Nithin Kumar
> Dabilpuram ; david.march...@redhat.com
> Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx
&g
Please see inline.
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, January 26, 2023 4:33 PM
> To: Nithin Kumar Dabilpuram
> Cc: Aman Singh ; Yuying Zhang
> ;
> Ivan Malov ; Andrew Rybchenko
> ; dev@dpdk.org; Hanumanth Reddy Pothula
> ;
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, January 27, 2023 2:25 PM
> To: Nithin Kumar Dabilpuram
> Cc: Aman Singh ; Yuying Zhang
> ;
> Ivan Malov ; Andrew Rybchenko
> ; dev@dpdk.org; Hanumanth Reddy Pothula
> ; Ferruh Yigit ;
> v
Please see inline.
> -Original Message-
> From: sk...@marvell.com
> Sent: Friday, September 8, 2023 4:19 PM
> To: Thomas Monjalon ; Sunil Kumar Kori
> ;
> Rakesh Kudurumalla
> Cc: dev@dpdk.org
> Subject: [EXT] [PATCH v3 1/1] app/graph: add example for different usecases
>
> External Em
Please ignore this particular patch 12/12. It is already part of other
patch.
https://patchwork.dpdk.org/project/dpdk/patch/20220612175612.3101-1-pbhagavat...@marvell.com/
Thanks
Nithin
On 2022-06-16 2:54 PM, Nithin Dabilpuram wrote:
Offset timestamp data only when enabled on the port instead
On 1/21/22 3:38 PM, Ferruh Yigit wrote:
On 1/19/2022 4:15 PM, Jerin Jacob wrote:
On Thu, Dec 9, 2021 at 2:43 PM Nithin Dabilpuram
wrote:
Fix shift offset for length disable flag in NIXX_AF_TL3X_SHAPE
register to be 24 instead of zero similar to other level SHAPE
registers. Also mask unused
On 2/7/22 3:22 PM, Ananyev, Konstantin wrote:
Enable Tx IPv4 checksum offload only when Tx inline crypto is needed.
In other cases such as Tx Inline protocol offload, checksum computation
is implicitly taken care by HW.
Why is that?
These is two separate HW offload and user has to enable e
Acked-by: Nithin Dabilpuram
On 7/30/21 9:38 PM, Harman Kalra wrote:
Adding a new callback for reading the link status. PF can read it's
link status and can forward the same to VF once it comes up.
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_ethdev.c | 9 +
drivers/net/
Acked-by: Nithin Dabilpuram
> -Original Message-
> From: Rakesh Kudurumalla
> Sent: Wednesday, February 15, 2023 11:56 AM
> To: Nithin Kumar Dabilpuram ; Kiran Kumar
> Kokkilagadda
> ; Sunil Kumar Kori ; Satha
> Koteswara Rao
> Kottidi
> Cc: Jerin Jacob K
Acked-by: Nithin Dabilpuram
From: jer...@marvell.com
Sent: Monday, May 29, 2023 2:53 PM
To: dev@dpdk.org ; Pavan Nikhilesh Bhagavatula
; Shijith Thotton ; Nithin
Kumar Dabilpuram ; Kiran Kumar Kokkilagadda
; Sunil Kumar Kori ; Satha
Koteswara Rao Kottidi
Acked-by: Nithin Dabilpuram
> -Original Message-
> From: Tyler Retzlaff
> Sent: Saturday, March 11, 2023 3:45 AM
> To: dev@dpdk.org
> Cc: honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; tho...@monjalon.net;
> Tyler Retzlaff
> Subject: [EXT] [PATCH 06/16] net/cnxk: use previous valu
On 10/6/21 9:51 PM, Ferruh Yigit wrote:
On 10/1/2021 2:40 PM, Nithin Dabilpuram wrote:
+static int
+nix_security_release(struct cnxk_eth_dev *dev)
+{
+ struct rte_eth_dev *eth_dev = dev->eth_dev;
+ struct cnxk_eth_sec_sess *eth_sec, *tvar;
+ struct roc_nix *nix = &dev->nix;
+ int
> -Original Message-
> From: Zhang, Fan
> Sent: Thursday, January 5, 2023 7:35 PM
> To: David Marchand ; dev@dpdk.org
> Cc: sta...@dpdk.org; Nithin Kumar Dabilpuram ; Kiran
> Kumar
> Kokkilagadda ; Sunil Kumar Kori ;
> Satha
> Koteswara Rao Kottidi ; Vidya
Ping.
On 2022-06-02 1:15 PM, Jerin Jacob wrote:
On Thu, Apr 21, 2022 at 7:47 PM Nithin Dabilpuram
wrote:
MTU configuration is missing for ethdev when using eventmode
when user provides it via "--max-pkt-len" config. It is only
done in poll mode setup. Fix the event mode setup code to
do the s
On 2022-08-30 10:21 AM, Jerin Jacob wrote:
External Email
--
On Wed, Aug 10, 2022 at 12:19 AM Nithin Dabilpuram
wrote:
From: Harman Kalra
Updating the logic for getting part and pass value for cn10k family,
as device tree
Ping. Any thoughts on this ?
This is just clarification of existing assumptions for Inline Outbound
that are being made.
On 2022-08-22 8:08 PM, Nithin Dabilpuram wrote:
Clarify mbuf meta data needed for Outbound Inline processing.
Application needs to provide mbuf.l3_len and L3 type in
mbuf.
On 2/18/22 12:47 AM, Ananyev, Konstantin wrote:
Enable Tx IPv4 checksum offload only when Tx inline crypto is needed.
In other cases such as Tx Inline protocol offload, checksum computation
is implicitly taken care by HW.
Why is that?
These is two separate HW offload and user has to enable
Please see inline.
On 2/17/22 6:50 PM, Jerin Jacob wrote:
On Mon, Feb 7, 2022 at 1:00 PM Nithin Dabilpuram
wrote:
From: Satha Rao
New api to get floor values for a requested shaper rate, which can assure
Since it is internal API, no need to mention in the comment log
packets should neve
Please see inline.
Thanks
Nithin
On 2/17/22 7:03 PM, Jerin Jacob wrote:
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram
wrote:
From: Satha Rao
Added rx_metadata_negotiate api to enable mark update RX offload.
Removed software logic to enable/disable mark update inside flow
create/destroy
On 2/18/22 7:28 PM, Nithin Kumar Dabilpuram wrote:
On 2/18/22 12:47 AM, Ananyev, Konstantin wrote:
Enable Tx IPv4 checksum offload only when Tx inline crypto is needed.
In other cases such as Tx Inline protocol offload, checksum
computation
is implicitly taken care by HW.
Why is that
Acked-by: Nithin Dabilpuram
On 2/22/22 11:48 PM, Weiguo Li wrote:
When node_add failed and function return, then the memory of 'node'
is leaked.
Fixes: 4435371b8fb1c0 ("net/cnxk: add TM shaper and node operations")
Signed-off-by: Weiguo Li
---
drivers/net/cnxk/cnxk_tm.c | 1 +
1 file chan
Ping.
On 3/22/22 11:28 PM, Nithin Dabilpuram wrote:
Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside
crypto/protocol or cpu crypto is needed.
For Tx Inline protocol offload, checksum computation
is implicitly taken care by HW.
Signed-off-by: Nithin Dabilpuram
---
example
Hi Konstantin,
Please see inline.
On 4/14/22 7:37 PM, Ananyev, Konstantin wrote:
Hi Nithin,
Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside
crypto/protocol or cpu crypto is needed.
For Tx Inline protocol offload, checksum computation
is implicitly taken care by HW.
Th
Hi Konstantin,
Any comments on this updated series ?
Thanks
Nithin
On 4/28/22 8:34 PM, Nithin Dabilpuram wrote:
Move fast path helper functions to header file for easy access.
Signed-off-by: Nithin Dabilpuram
---
v3:
- In patch 7/7, in Inline Protocol single sa mode's worker thread, further
Signed-off-by: Nithin Dabilpuram
---
lib/librte_ethdev/rte_ethdev.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 9d5107d..bd45445 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte
Hi Thomas,
Sorry, missed to notice that format changed by your commit recently got
overridden
during some of our internal branch merging. I'll send a v2 with same format.
--
Thanks
Nithin
From: Thomas Monjalon
Sent: Monday, January 7, 2019 8:20 PM
To: Nithin Kumar Dabilpuram
Cc: F
Sure. Format change was unintentional and happened during internal merge, I’ll
fix that and remove function name and send V2.
--
Thanks
Nithin
From: Andrew Rybchenko
Sent: Monday, January 7, 2019 8:17 PM
To: Nithin Kumar Dabilpuram ; Thomas Monjalon
; Ferruh Yigit ; Andrew Rybchenko
Cc: dev
Currently this api doesn't report error if name is
truncated and so user is not sure about uniqueness
of name. This change reports error to help user.
Signed-off-by: Nithin Dabilpuram
---
v2:
Fix issue caused by rebase and also fix log message
lib/librte_ethdev/rte_ethdev.c | 11 +--
1
Currently this api doesn't report error if name is
truncated and so user is not sure about uniqueness
of name. This change reports error to help user.
Signed-off-by: Nithin Dabilpuram
---
v3:
Change log message
v2:
Fix issue caused by rebase and also fix log message
lib/librte_ethdev/rte_ethdev
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. Also enable
DEV_TX_OFFLOAD_VLAN_INSERT for tx_qinq_set() as it takes
both vlan id's.
Signed-off-by: Nithin Dabilpuram
---
app/test-pmd/config.c | 15 ++-
1 file changed, 2 insertions(+), 13 delet
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shah...@mellanox.com
Signed-off-by: Nithin Dabilpuram
---
v2:
* Split change into two seper
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD.
Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN")
Cc: xiao.w.w...@intel.com
Signed-off-by: Nithin Dabilpuram
---
v2:
* Split change into two seperate patches as suggested.
app/tes
All the settings
could be completely disabled by cmdline "tx vlan reset"
--
Thanks
Nithin
-Original Message-
From: Ferruh Yigit
Sent: Thursday, March 21, 2019 10:41 PM
To: Nithin Kumar Dabilpuram ; Wenzhuo Lu
; Jingjing Wu ; Bernard I
Tx VLAN & QinQ insert enable need not depend on
Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN
insert enable, error check is now to see if QinQ was enabled
but only single VLAN id is set.
Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN")
Cc: xiao.w.w...@intel.com
S
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shah...@mellanox.com
Signed-off-by: Nithin Dabilpuram
---
v3:
* Rename headline
v2:
* Spli
On Wed, Jul 17, 2019 at 06:01:47AM +, Hyong Youb Kim (hyonkim) wrote:
> > -Original Message-
> > From: Nithin Dabilpuram
> > Sent: Wednesday, July 17, 2019 1:44 AM
> [...]
> > Subject: [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt
> > handlers
> >
> > Replace rte_intr_en
On Tue, Jul 16, 2019 at 07:30:23PM +0100, Ferruh Yigit wrote:
> External Email
>
> --
> On 7/10/2019 2:07 PM, Nithin Dabilpuram wrote:
> > With the latest published interface of
> > rte_eal_hotplug_[add,remove](), and rte_eth_dev_
On 7/17/2019 4:46 PM, Jerin Jacob Kollanukkaran wrote:
>> -Original Message-
>> From: Hyong Youb Kim (hyonkim)
>> Sent: Wednesday, July 17, 2019 4:36 PM
>> To: Jerin Jacob Kollanukkaran ; Nithin Kumar
>> Dabilpuram ; David Marchand
>> ; Thoma
On Wed, Jul 17, 2019 at 12:57:29PM +, Hyong Youb Kim (hyonkim) wrote:
> External Email
>
> --
> > -Original Message-
> > From: Nithin Dabilpuram
> > Sent: Wednesday, July 17, 2019 9:44 PM
> > To: Hyong Youb Kim (hyonk
On Wed, Jul 17, 2019 at 03:05:47PM +, Hyong Youb Kim (hyonkim) wrote:
> > -Original Message-
> > From: Nithin Kumar Dabilpuram
> > Sent: Wednesday, July 17, 2019 11:36 PM
> [...]
> > > > Subject: [PATCH v2 2/3] eal: add ack interrupt API
> > &
Hi Ferruh,
On 7/17/2019 10:21 PM, Ferruh Yigit wrote:
> External Email
>
> --
> On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote:
>> With the latest published interface of
>> rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(),
>
On 7/18/2019 6:57 PM, Jerin Jacob Kollanukkaran wrote:
>> -Original Message-
>> From: Burakov, Anatoly
>> Sent: Thursday, July 18, 2019 6:43 PM
>> To: Nithin Kumar Dabilpuram ; Hyong Youb Kim
>> ; David Marchand ;
>> Thomas Monjalon ; Ferruh Yigit
On 7/22/2019 11:31 AM, Hemant Agrawal wrote:
> HI,
>> On 7/18/2019 6:27 AM, Nithin Kumar Dabilpuram wrote:
>>> Hi Ferruh,
>>>
>>> On 7/17/2019 10:21 PM, Ferruh Yigit wrote:
>>>> External Email
>>>>
>>>> --
On 7/23/2019 1:08 AM, David Marchand wrote:
> External Email
>
> --
> On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram
> wrote:
>> A final patch for below mentioned RFC patch discussions.
>>
>> [RFC PATCH v3 1/3] vfio: revert ch
On 7/25/2019 1:50 PM, Sunil Kumar Kori wrote:
> External Email
>
> --
> Multi segmented packet may be spliced with indirect mbufs also.
> Currently driver causes buffer leak for indirect mbufs as they
> were not being freed to pa
Hi All,
Since Ian's change didn't include MTU interpretation issue, we want to see if
we can send out a patch for this discussion to conclude as we have a similar
problem.
Currently two ways are as below.
#1 Konstantin's solution of adding new api rte_ethdev_mtu_to_frame_size(devid,
mtu), that
46 matches
Mail list logo
