[dpdk-dev] [PATCH] fix testpmd show port info error

2015-02-05 Thread Olivier MATZ
.f = cmd_showport_parsed, > -- Thank you for reporting this. However I think it should be UINT8 instead of INT8. According to http://dpdk.org/dev, I think a better title could be "testpmd: fix port parsing in show port info command" Apart from this, Acked-by: Olivier Matz I think it would be less work for Thomas if you can submit a v2 that includes these 2 changes. Regards, Olivier

[dpdk-dev] [PATCH v2] testpmd: fix port parsing in show port info command

2015-02-06 Thread Olivier MATZ
m = > - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32); > + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8); > > cmdline_parse_inst_t cmd_showport = { > .f = cmd_showport_parsed, > Acked-by: Olivier Matz

[dpdk-dev] [PATCH 1/3] maintainers: dispatch more doc

2015-02-06 Thread Olivier MATZ
te_eal/common/include/* > F: lib/librte_eal/common/include/generic/ > +F: doc/guides/prog_guide/env_abstraction_layer.rst > F: app/test/test_alarm.c > F: app/test/test_atomic.c > F: app/test/test_byteorder.c > @@ -150,6 +155,7 @@ F: app/test/test_func_reentrancy.c > Ring queue

[dpdk-dev] [RFC PATCH] rte_timer: Fix rte_timer_reset return value

2015-02-06 Thread Olivier MATZ
Hi Robert, Please see some comments below. On 02/03/2015 09:42 PM, rsanford2 at gmail.com wrote: > From: Robert Sanford > > - API rte_timer_reset() should return -1 when the timer is in the > RUNNING or CONFIG state. Instead, it ignores the return value of > internal function

[dpdk-dev] upper limit on the size of allocation through rte_malloc in dpdk-1.8.0?

2015-02-06 Thread Olivier MATZ
Hi, On 02/06/2015 12:00 PM, Bruce Richardson wrote: > On Wed, Feb 04, 2015 at 05:24:58PM +0200, Stefan Puiu wrote: >> Hi, >> >> I'm trying to alter an existing program to use the Intel DPDK. I'm >> using 1.8.0, compiled by me as a shared library >> (CONFIG_RTE_BUILD_COMBINE_LIBS=y and

[dpdk-dev] [PATCH v4 16/17] ring: add sched_yield to avoid spin forever

2015-02-06 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Add a sched_yield() syscall if the thread spins for too long, waiting other > thread to finish its operations on the ring. > That gives pre-empted thread a chance to proceed and finish with ring > enqnue/dequeue operation. > The purpose is to

[dpdk-dev] [RFC PATCH] rte_timer: Fix rte_timer_reset return value

2015-02-08 Thread Olivier MATZ
Hi Robert, On 02/06/2015 06:26 PM, Robert Sanford wrote: > Hi Olivier, > > Thanks for reviewing this patch. > Please see my responses to your comments, below. > > I also have one request for you. You probably use git almost every day. > For people who only use git maybe once per year, could you

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The patch adds 'cpuset' into per-lcore configure 'lcore_config[]', > as the lcore no longer always 1:1 pinning with physical cpu. > The lcore now stands for a EAL thread rather than a logical cpu. > > It doesn't change the default behavior of

[dpdk-dev] [PATCH v4 02/17] eal: new eal option '--lcores' for cpu assignment

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > It supports one new eal long option '--lcores' for EAL thread cpuset > assignment. > > The format pattern: > --lcores='lcores[@cpus]<,lcores[@cpus]>' > lcores, cpus could be a single digit/range or a group. > '(' and ')' are necessary if

[dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return value in 32bit icc

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The problem is that strnlen() here may return invalid value with 32bit icc. > (actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)). > It starts to manifest hwen max_len parameter is > 2M and using icc ?m32 ?O2 > (or above). > >

[dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id from cpuset

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > It returns the socket_id if all cpus in the cpuset belongs > to the same NUMA node, otherwise it will return SOCKET_ID_ANY. > > Signed-off-by: Cunming Liang > --- > lib/librte_eal/bsdapp/eal/eal_lcore.c | 7 + >

[dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API declaration

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > 1. add two TLS *_socket_id* and *_cpuset* > 2. add two external API rte_thread_set/get_affinity > 3. add one internal API eal_thread_dump_affinity To me, it's a bit strage to add an API withtout the associated code. Maybe you have a good reason

[dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for common thread API

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The API works for both EAL thread and none EAL thread. > When calling rte_thread_set_affinity, the *_socket_id* and > *_cpuset* of calling thread will be updated if the thread > successful set the cpu affinity. > > [...] > +int >

[dpdk-dev] [PATCH v4 07/17] eal: add rte_gettid() to acquire unique system tid

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The rte_gettid() wraps the linux and freebsd syscall gettid(). > It provides a persistent unique thread id for the calling thread. > It will save the unique id in TLS on the first time. > > [...] > > +/** > + * A wrap API for syscall gettid. > +

[dpdk-dev] [PATCH v4 09/17] enic: fix re-define freebsd compile complain

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Some macro already been defined by freebsd 'sys/param.h'. > > Signed-off-by: Cunming Liang > --- > lib/librte_pmd_enic/enic.h| 1 + > lib/librte_pmd_enic/enic_compat.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git

[dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of SOCKET_ID_ANY

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Add check for rte_socket_id(), avoid get unexpected return like (-1). > > Signed-off-by: Cunming Liang > --- > lib/librte_malloc/malloc_heap.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

[dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For those non-EAL thread, *_lcore_id* is invalid and probably larger than > RTE_MAX_LCORE. > The patch adds the check and allows only EAL thread using EAL per thread log > level and log type. > Others shares the global log level. > >

[dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL thread

2015-02-08 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For non-EAL thread, bypass per lcore cache, directly use ring pool. > It allows using rte_mempool in either EAL thread or any user pthread. > As in non-EAL thread, it directly rely on rte_ring and it's none preemptive. > It doesn't suggest to run

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 12:33 PM, Liang, Cunming wrote: >> On 02/02/2015 03:02 AM, Cunming Liang wrote: >>> The patch adds 'cpuset' into per-lcore configure 'lcore_config[]', >>> as the lcore no longer always 1:1 pinning with physical cpu. >>> The lcore now stands for a EAL thread rather than a logical

[dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return value in 32bit icc

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 12:57 PM, Liang, Cunming wrote: >>> @@ -469,7 +469,7 @@ eal_parse_lcores(const char *lcores) >>> /* Remove all blank characters ahead and after */ >>> while (isblank(*lcores)) >>> lcores++; >>> - i = strnlen(lcores, sysconf(_SC_ARG_MAX)); >>> + i =

[dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id from cpuset

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 01:26 PM, Liang, Cunming wrote: >>> @@ -50,4 +54,52 @@ __attribute__((noreturn)) void *eal_thread_loop(void >> *arg); >>> */ >>> void eal_thread_init_master(unsigned lcore_id); >>> >>> +/** >>> + * Get the NUMA socket id from cpu id. >>> + * This function is private to EAL.

[dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API declaration

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 01:45 PM, Liang, Cunming wrote: >>> +/** >>> + * Dump the current pthread cpuset. >>> + * This function is private to EAL. >>> + * >>> + * @param str >>> + * The string buffer the cpuset will dump to. >>> + * @param size >>> + * The string buffer size. >>> + */ >>> +#define

[dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for common thread API

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 02:12 PM, Liang, Cunming wrote: >>> +int >>> +rte_thread_get_affinity(rte_cpuset_t *cpusetp) >>> +{ >>> + if (!cpusetp) >>> + return -1; >> >> Same here. This is the only reason why rte_thread_get_affinity() could >> fail. Removing this test would allow to change the

[dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread by assigned cpuset

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 02:48 PM, Liang, Cunming wrote: >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, February 09, 2015 4:01 AM >> To: Liang, Cunming; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 08/17] eal

[dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of SOCKET_ID_ANY

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:08 PM, Liang, Cunming wrote: > > >> -Original Message----- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, February 09, 2015 4:01 AM >> To: Liang, Cunming; dev at dpdk.org >> Subject: Re: [dpdk-dev] [P

[dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:19 PM, Liang, Cunming wrote: >>> --- a/lib/librte_eal/common/include/rte_log.h >>> +++ b/lib/librte_eal/common/include/rte_log.h >>> @@ -144,6 +144,11 @@ uint32_t rte_get_log_level(void); >>> void rte_set_log_type(uint32_t type, int enable); >>> >>> /** >>> + * Get the

[dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:24 PM, Liang, Cunming wrote: >>> --- a/lib/librte_eal/linuxapp/eal/eal_thread.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal_thread.c >>> @@ -57,8 +57,8 @@ >>> #include "eal_private.h" >>> #include "eal_thread.h" >>> >>> -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id); >>>

[dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL thread

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:41 PM, Liang, Cunming wrote: >>> #ifdef RTE_LIBRTE_MEMPOOL_DEBUG >>> -#define __MEMPOOL_STAT_ADD(mp, name, n) do { \ >>> - unsigned __lcore_id = rte_lcore_id(); \ >>> - mp->stats[__lcore_id].name##_objs += n; \ >>>

[dpdk-dev] [PATCH v4 16/17] ring: add sched_yield to avoid spin forever

2015-02-10 Thread Olivier MATZ
Hi Konstantin, On 02/09/2015 04:43 PM, Ananyev, Konstantin wrote: >> The ring library was designed with the assumption that the code is not >> preemptable. The code is lock-less but not wait-less. Actually, if the >> code is preempted at a bad moment, it can spin forever until it's >>

[dpdk-dev] [PATCH v2 02/20] mbuf: enhance the API documentation of offload flags

2015-02-10 Thread Olivier MATZ
Hi Helin, On 02/10/2015 06:38 AM, Zhang, Helin wrote: >> -/** Packet is IPv4 without requiring IP checksum offload. */ >> +/** >> + * Packet is IPv4. This flag must be set when using any offload feature >> + * (TSO, L3 or L4 checksum) to tell the NIC that the packet is an IPv4 >> + * packet. >> +

[dpdk-dev] [PATCH v2 03/20] i40e: call i40e_txd_enable_checksum only for offloaded packets

2015-02-10 Thread Olivier MATZ
Hi Helin, On 02/10/2015 07:03 AM, Zhang, Helin wrote: >> /* Enable checksum offloading */ >> cd_tunneling_params = 0; >> -i40e_txd_enable_checksum(ol_flags, _cmd, _offset, >> -l2_len, l3_len, outer_l2_len, >> -

[dpdk-dev] [PATCH v2 04/20] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag

2015-02-10 Thread Olivier MATZ
Hi Helin, On 02/10/2015 07:40 AM, Zhang, Helin wrote: >> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c >> b/lib/librte_pmd_i40e/i40e_rxtx.c >> index 9acdeee..0786255 100644 >> --- a/lib/librte_pmd_i40e/i40e_rxtx.c >> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c >> @@ -482,7 +482,7 @@

[dpdk-dev] [PATCH v4 07/17] eal: add rte_gettid() to acquire unique system tid

2015-02-10 Thread Olivier MATZ
Hi, On 02/10/2015 07:57 AM, Liang, Cunming wrote: >>> +/** >>> + * Get system unique thread id. >>> + * >>> + * @return >>> + * On success, returns the thread ID of calling process. >>> + * It always successful. >>> + */ >>> +static inline int rte_gettid(void) >>> +{ >>> + static

[dpdk-dev] [PATCH v4 17/17] timer: add support to non-EAL thread

2015-02-10 Thread Olivier MATZ
Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Allow to setup timers only for EAL (lcore) threads (__lcore_id < > MAX_LCORE_ID). > E.g. ? dynamically created thread will be able to reset/stop timer for lcore > thread, > but it will be not allowed to setup timer for itself or another

[dpdk-dev] [PATCH v2 02/20] mbuf: enhance the API documentation of offload flags

2015-02-11 Thread Olivier MATZ
Hi Jijiang, On 02/11/2015 08:15 AM, Liu, Jijiang wrote: >>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index >>> 41711fd..4b438d1 100644 >>> --- a/app/test-pmd/csumonly.c >>> +++ b/app/test-pmd/csumonly.c >>> @@ -183,16 +183,15 @@ process_inner_cksums(void *l3_hdr, uint16_t

[dpdk-dev] [PATCH v2 03/20] i40e: call i40e_txd_enable_checksum only for offloaded packets

2015-02-11 Thread Olivier MATZ
Hi Helin, On 02/11/2015 06:32 AM, Zhang, Helin wrote: >> On 02/10/2015 07:03 AM, Zhang, Helin wrote: /* Enable checksum offloading */ cd_tunneling_params = 0; - i40e_txd_enable_checksum(ol_flags, _cmd, _offset, -

[dpdk-dev] [PATCH v4 17/17] timer: add support to non-EAL thread

2015-02-11 Thread Olivier MATZ
Hi, On 02/11/2015 07:25 AM, Liang, Cunming wrote: >>> + tim_lcore = rte_get_next_lcore( >>> + priv_timer[lcore_id].prev_lcore, >>> + 0, 1); >>> + priv_timer[lcore_id].prev_lcore = tim_lcore; >>> + }

[dpdk-dev] [PATCH v5 18/19] ring: add sched_yield to avoid spin forever

2015-02-12 Thread Olivier MATZ
Hi, On 02/12/2015 09:16 AM, Cunming Liang wrote: > Add a sched_yield() syscall if the thread spins for too long, waiting other > thread to finish its operations on the ring. > That gives pre-empted thread a chance to proceed and finish with ring > enqnue/dequeue operation. > The purpose is to

[dpdk-dev] [PATCH v2 03/20] i40e: call i40e_txd_enable_checksum only for offloaded packets

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 03:25 AM, Zhang, Helin wrote: >> On 02/11/2015 06:32 AM, Zhang, Helin wrote: On 02/10/2015 07:03 AM, Zhang, Helin wrote: >> /* Enable checksum offloading */ >> cd_tunneling_params = 0; >> -

[dpdk-dev] [PATCH v3 00/20] enhance tx checksum offload API

2015-02-13 Thread Olivier Matz
is not UDP - add a likely() in i40e - remove a unlikely() in i40e - fix a patch split issue - rebase on head Jijiang Liu (2): ethdev: add outer IP offload capability flag i40e: advertise outer IPv4 checksum capability Olivier Matz (18): mbuf: remove PKT_TX_IPV4_CSUM mbuf: enhance the API

[dpdk-dev] [PATCH v3 01/20] mbuf: remove PKT_TX_IPV4_CSUM

2015-02-13 Thread Olivier Matz
This alias is only used in one place of i40e driver. Remove it and only keep the legacy flag PKT_TX_IP_CSUM. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 1 - lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v3 02/20] mbuf: enhance the API documentation of offload flags

2015-02-13 Thread Olivier Matz
Based on http://dpdk.org/ml/archives/dev/2015-January/011127.html Also adapt the csum forward engine code to the API. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 6 +++--- lib/librte_mbuf/rte_mbuf.h | 45 ++--- 2 files changed, 41

[dpdk-dev] [PATCH v3 03/20] i40e: call i40e_txd_enable_checksum only for offloaded packets

2015-02-13 Thread Olivier Matz
e same in the dpdk driver. The function i40e_txd_enable_checksum() that fills the offload registers can only be called for packets requiring an offload. Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[dpdk-dev] [PATCH v3 04/20] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag

2015-02-13 Thread Olivier Matz
15-January/011380.html [2] http://dpdk.org/ml/archives/dev/2015-January/011475.html [3] http://dpdk.org/ml/archives/dev/2015-January/011610.html Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v3 05/20] mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag

2015-02-13 Thread Olivier Matz
Since previous commit, this flag is not used by any PMD, remove it from mbuf API and from csumonly (testpmd). In csumonly, the PKT_TX_OUTER_IP_CKSUM flag is already set for vxlan checksum, providing enough information to the underlying driver. Signed-off-by: Olivier Matz --- app/test-pmd

[dpdk-dev] [PATCH v3 06/20] testpmd: replace tx_checksum command by csum

2015-02-13 Thread Olivier Matz
Replace the "tx_checksum" command by "csum". It has several advantages: - it's more coherent with the forward engine name - it's shorter - the next commit will introduce a command that is related to the csum forward engine, but about rx side. Signed-off-by: Olivier Mat

[dpdk-dev] [PATCH v3 07/20] testpmd: move csum_show in a function

2015-02-13 Thread Olivier Matz
No functional changes in this commit, we just move the code that displays the csum forward engine configuration in a function. This makes the next commit easier to read as it will also use this function. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 82

[dpdk-dev] [PATCH v3 08/20] testpmd: add csum parse_tunnel command

2015-02-13 Thread Olivier Matz
e first l4 layer. A tunnel packet is seens as "headers/data" (inner headers are included in payload). Note: the port argument is the tx_port. It's more coherent compared to all other testpmd csum flags. Signed-off-by: Olivier Matz --- app/test

[dpdk-dev] [PATCH v3 09/20] testpmd: rename vxlan in outer_ip in csum commands

2015-02-13 Thread Olivier Matz
The tx_checksum command concerns outer IP checksum, not VxLAN checksum. Actually there is no checkum in VxLAN header, there is one checksum in outer IP header, and one checksum in outer UDP header. This option only controls the outer IP checksum. Signed-off-by: Olivier Matz --- app/test-pmd

[dpdk-dev] [PATCH v3 10/20] testpmd: introduce parse_ipv* in csum fwd engine

2015-02-13 Thread Olivier Matz
These functions may be used to parse encapsulated layers when we will support IP over GRE tunnels. No functional change. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 51 + 1 file changed, 39 insertions(+), 12 deletions(-) diff --git

[dpdk-dev] [PATCH v3 11/20] testpmd: use a structure to store offload info in csum fwd engine

2015-02-13 Thread Olivier Matz
To simplify the API of parse_* functions, store all the offload information for the current packet in a structure. No functional change. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 222 +--- 1 file changed, 115 insertions(+), 107

[dpdk-dev] [PATCH v3 12/20] testpmd: introduce parse_vxlan in csum fwd engine

2015-02-13 Thread Olivier Matz
Move code parsing vxlan into a function. It will ease the support of GRE tunnels and IPIP tunnels in next commits. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 68 +++-- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/app

[dpdk-dev] [PATCH v3 13/20] testpmd: support gre tunnels in csum fwd engine

2015-02-13 Thread Olivier Matz
Add support for Ethernet over GRE and IP over GRE tunnels. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 6 ++-- app/test-pmd/csumonly.c | 91 + 2 files changed, 87 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b

[dpdk-dev] [PATCH v3 14/20] testpmd: support ipip tunnel in csum forward engine

2015-02-13 Thread Olivier Matz
Add support for IP over IP tunnels. Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/csumonly.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b19869c

[dpdk-dev] [PATCH v3 15/20] ethdev: add outer IP offload capability flag

2015-02-13 Thread Olivier Matz
Acked-by: Olivier Matz --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 1200c1c..84160c3 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -916,6 +916,7 @@

[dpdk-dev] [PATCH v3 16/20] i40e: advertise outer IPv4 checksum capability

2015-02-13 Thread Olivier Matz
From: Jijiang Liu <jijiang@intel.com> Advertise the DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM flag in the PMD features. It means that the i40e PMD supports the offload of outer IP checksum when transmitting tunneling packet. Signed-off-by: Jijiang Liu Acked-by: Olivier Matz --- lib/librte_pm

[dpdk-dev] [PATCH v3 17/20] testpmd: add a warning if outer ip cksum requested but not supported

2015-02-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index fc08183..9de3e7e 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2930,7 +2930,11 @@ csum_show

[dpdk-dev] [PATCH v3 18/20] testpmd: fix TSO when using outer checksum offloads

2015-02-13 Thread Olivier Matz
The l4_len has also to be copied in mbuf in case we are offloading outer IP checksum. Currently, TSO + outer checksum is not supported by any driver but it will soon be supported by i40e. Pointed-out-by: Jijiang Liu Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 1 + 1 file changed

[dpdk-dev] [PATCH v3 19/20] i40e: fix offloading of outer checksum for ip in ip tunnels

2015-02-13 Thread Olivier Matz
buf. It should avoid a test in dataplane processing and therefore slightly increase performance. Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c in

[dpdk-dev] [PATCH v3 20/20] i40e: add debug logs for tx context descriptors

2015-02-13 Thread Olivier Matz
This could be useful to have this values for debug purposes. Suggested-by: Konstantin Ananyev Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e

[dpdk-dev] [PATCH v5 19/19] timer: add support to non-EAL thread

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 01:55 AM, Liang, Cunming wrote: >> About ' lcore_id != LCORE_ID_ANY' vs ' lcore_id < RTE_MAX_LCORE'. >> I think both ways are valid right now. >> Though using ' lcore_id != LCORE_ID_ANY' means, that if user will setup >> PER_LCORE(_lcore_id) for dynamically created thread to

[dpdk-dev] [PATCH v6 00/19] support multi-pthread per core

2015-02-13 Thread Olivier MATZ
| 4 +- > lib/librte_pmd_enic/enic_compat.h | 2 +- > lib/librte_pmd_enic/vnic/vnic_dev.c| 6 +- > lib/librte_ring/rte_ring.h | 41 ++- > lib/librte_timer/rte_timer.c | 32 ++- > li

[dpdk-dev] [PATCH] bond: fix for kvlist memory leak on rte_kvargs_process failure identified by klockwork scan

2015-02-13 Thread Olivier MATZ
Hi, On 02/13/2015 11:27 AM, Declan Doherty wrote: > Signed-off-by: Declan Doherty > --- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 49 > ++ > 1 file changed, 26 insertions(+), 23 deletions(-) > Acked-by: Olivier Matz

[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-13 Thread Olivier MATZ
Hi Neil, On 02/13/2015 02:49 PM, Neil Horman wrote: > On Fri, Feb 13, 2015 at 09:38:06AM +0800, Cunming Liang wrote: >> The problem is that strnlen() here may return invalid value with 32bit icc. >> (actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)). >> It starts to manifest

[dpdk-dev] [PATCH] Add Q variable to external builds to be quite

2015-02-16 Thread Olivier MATZ
Hi Keith, On 02/14/2015 07:13 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > mk/rte.extvars.mk | 4 > 1 file changed, 4 insertions(+) > > diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk > index 3e5a990..83a5721 100644 > --- a/mk/rte.extvars.mk > +++ b/mk/rte.extvars.mk >

[dpdk-dev] [PATCH] Add support to read target/generic/rte.vars.mk file for external builds

2015-02-16 Thread Olivier MATZ
Hi Keith, On 02/14/2015 07:52 PM, Keith Wiles wrote: > The external build of applications does not import the > target/generic/rte.vars.mk > file, which is needed for locating DPDK headers and libraries. > > Signed-off-by: Keith Wiles > --- > mk/rte.extvars.mk | 7 +++ > 1 file changed, 7

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-16 Thread Olivier MATZ
Hi John, On 02/13/2015 04:39 PM, John McNamara wrote: > From: Richardson, Bruce > > Example showing how callbacks can be used to insert a timestamp > into each packet on RX. On TX the timestamp is used to calculate > the packet latency through the app, in cycles. > > Signed-off-by: Bruce

[dpdk-dev] [PATCH v7 04/19] eal: fix wrong strnlen() return value in 32bit icc

2015-02-16 Thread Olivier MATZ
Hi, On 02/15/2015 04:15 AM, Cunming Liang wrote: > The problem is that strnlen() here may return invalid value with 32bit icc. > (actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)). > It starts to manifest hwen max_len parameter is > 2M and using icc ?m32 ?O2 > (or above). > >

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

2015-02-17 Thread Olivier MATZ
Hi Helin, On 02/17/2015 07:59 AM, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet > types, which is not enough to describe all the possible packet > types hardware can recognize. For example, i40e hardware can > recognize more than 150 packet types. Unified

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Olivier MATZ
Hi Bruce, On 02/17/2015 01:25 PM, Bruce Richardson wrote: > On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: >> 2015-02-16 15:16, Bruce Richardson: >>> In this specific instance, given that the application does little else, >>> there >>> is no real advantage to using the

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Sergio, On 02/16/2015 05:08 PM, Sergio Gonzalez Monroy wrote: > This patch removes all references to RTE_MBUF_REFCNT, setting the refcnt > field in the mbuf struct permanently. > > Signed-off-by: Sergio Gonzalez Monroy I think removing the refcount compile option goes in the right direction.

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Bruce, On 02/18/2015 10:35 AM, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 10:16:56AM +0100, Olivier MATZ wrote: >> Hi Sergio, >> >> On 02/16/2015 05:08 PM, Sergio Gonzalez Monroy wrote: >>> This patch removes all references to RTE_MBUF_REFCNT, setting th

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Sent: Wednesday, February 18, 2015 9:36 AM >>> To: Olivier MATZ >>> Cc: dev at dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references >>> >>> On Wed, Feb 18, 2015 at 10:16:56AM +0100, Olivier MATZ wrote: >>>> Hi Sergio, >

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi, On 02/18/2015 11:22 AM, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 11:14:42AM +0100, Olivier MATZ wrote: >> On 02/18/2015 11:00 AM, Bruce Richardson wrote: >>> On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konstantin wrote: >>>> Hi lads, &g

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
is still there. >> >> Before the patch, an application that wanted to reserve a private >> data could disable refcounts at compile-time. >> After the patch, the solution is just to avoid using refcounts. >> >> Regards, >> Olivier >> > Thanks for clarifying. > So, you ok with this patch as a step in the right direction? Yep, Acked-by: Olivier Matz

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Konstantin, On 02/18/2015 11:47 AM, Ananyev, Konstantin wrote: >>> How was this managed before, since refcnt field seems to be necessary in >>> order >>> to effectively manage indirect mbufs? Is this just the case that this is >>> something >>> that never worked and that needs to be solved,

[dpdk-dev] [PATCH v5 1/6] reorder: new reorder library

2015-02-19 Thread Olivier MATZ
Hi Sergio, On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote: > This library provides reordering capability for out of order mbufs based > on a sequence number in the mbuf structure. > > Signed-off-by: Reshma Pattan > Signed-off-by: Richardson Bruce > Signed-off-by: Sergio Gonzalez Monroy >

[dpdk-dev] [PATCH v5 1/6] reorder: new reorder library

2015-02-19 Thread Olivier MATZ
Hi, On 02/19/2015 10:20 AM, Olivier MATZ wrote: > Hi Sergio, > > On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote: >> This library provides reordering capability for out of order mbufs based >> on a sequence number in the mbuf structure. >> >> Signed-off

[dpdk-dev] [PATCH 0/3] Misc fixes

2015-02-24 Thread Olivier MATZ
er > > doc/api/doxy-api.conf | 1 + > examples/packet_ordering/main.c | 37 + > lib/librte_mbuf/rte_mbuf.h | 4 ++-- > 3 files changed, 28 insertions(+), 14 deletions(-) > Series: Acked-by: Olivier Matz

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

2015-02-24 Thread Olivier MATZ
Hi Helin, On 02/20/2015 03:26 PM, Zhang, Helin wrote: >> On 02/17/2015 07:59 AM, Helin Zhang wrote: >>> As there are only 6 bit flags in ol_flags for indicating packet types, >>> which is not enough to describe all the possible packet types hardware >>> can recognize. For example, i40e hardware

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

2015-02-24 Thread Olivier MATZ
Hi Pawel, On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Declaration for function pointer should be > typedef ret_type (*type_name)(args...) > not > typedef ret_type (type_name)(args...) > > although compiler treat both of them the same, the static analysis tool > like klocwork complain about

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

2015-02-24 Thread Olivier MATZ
Hi Daniel, On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote: > Function match_inst is used to take buffor using sizeof() which is size_t > type. > This modification also involved changing '%u' to '%zu' in printf function. > > Signed-off-by: Daniel Mrzyglod > --- >

[dpdk-dev] [PATCH 4/5] cmdline: make parse_set_list() use size_t instead of int for low/high parameter

2015-02-24 Thread Olivier MATZ
f-by: Pawel Wodkowski Acked-by: Olivier Matz

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Olivier MATZ
On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: > Free kvlist on function exit to avoid memory leak. > > Signed-off-by: Pawel Wodkowski Acked-by: Olivier Matz

[dpdk-dev] [PATCH 3/5] pmd ring: fix possible memory leak during devinit

2015-02-24 Thread Olivier MATZ
On 02/24/2015 12:15 PM, Pawel Wodkowski wrote: > On 2015-02-24 12:05, Olivier MATZ wrote: >> On 02/23/2015 03:09 PM, Pawel Wodkowski wrote: >>> Free kvlist on function exit to avoid memory leak. >>> >>> Signed-off-by: Pawel Wodkowski >> >> Ac

[dpdk-dev] [PATCH 2/5] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions

2015-02-24 Thread Olivier MATZ
dkowski Acked-by: Olivier Matz

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

2015-02-24 Thread Olivier MATZ
Hi Pawel, On 02/24/2015 12:12 PM, Wodkowski, PawelX wrote: > > >> -Original Message----- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Tuesday, February 24, 2015 11:39 AM >> To: Wodkowski, PawelX; dev at dpdk.org >> Subject: Re: [

[dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset

2015-02-25 Thread Olivier MATZ
++ > 2 files changed, 26 insertions(+), 7 deletions(-) > Series: Acked-by: Olivier Matz Thanks!

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-02-27 Thread Olivier MATZ
Hi Vadim, Hi Konstantin, On 02/27/2015 01:18 PM, Vadim Suraev wrote: > Hi, Konstantin, > >> Seems really useful. Indeed, this function looks useful, and I also have a work in progress on this topic, but currently it is not well tested. As we are on the mbuf subject, for 2.1, I would like to

[dpdk-dev] [PATCH v2 0/4] Fix issues reported by static analysis tool

2015-02-27 Thread Olivier MATZ
> lib/librte_kvargs/rte_kvargs.h | 3 ++- > lib/librte_pmd_ring/rte_eth_ring.c | 6 +++--- > lib/librte_timer/rte_timer.h| 4 ++-- > 5 files changed, 13 insertions(+), 8 deletions(-) > Series: Acked-by: Olivier Matz

[dpdk-dev] [PATCH v4 03/18] mbuf: add definitions of unified packet types

2015-02-27 Thread Olivier MATZ
Hi Helin, On 02/27/2015 02:11 PM, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet > types, which is not enough to describe all the possible packet > types hardware can recognize. For example, i40e hardware can > recognize more than 150 packet types. Unified

[dpdk-dev] IPv6 Offload Capabilities

2015-01-05 Thread Olivier MATZ
Hello, On 01/05/2015 08:56 AM, Gal Sagie wrote: > I noticed that in version 1.8, there are no flags to indicate IPv6 check > sum offloading > (only DEV_TX_OFFLOAD_IPV4_CKSUM) There is no L3 checksum field in IPv6 header, that's why there is no DEV_TX_OFFLOAD_IPV6_CKSUM flag. > which means TSO

[dpdk-dev] two tso related questions

2015-01-05 Thread Olivier MATZ
Hi, On 01/04/2015 11:13 AM, Helmut Sim wrote: > In such case, a modified api should not require to set the ip_hdr > total_length field, which is 16 bits. > The HW will assign the correct packet length for each transmitted IP > packet which is l3_len+l4_len+mss (except of the last segment which

[dpdk-dev] [PATCH 0/7] Move EAL common functions

2015-01-09 Thread Olivier MATZ
Hi, Sorry for the late answer. On 01/05/2015 01:24 PM, Bruce Richardson wrote: > Hopefully that means two directories, not three. I think the existing common > folder should stay as it is, with the same name, and possibly add one new > folder > for code that is common between BSD and Linux, but

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-09 Thread Olivier MATZ
Hi, Thank you Jijiang for taking the time to get back on this. On 01/08/2015 11:54 AM, Ananyev, Konstantin wrote: >> And we are able to test all of cases in >> http://dpdk.org/ml/archives/dev/2014-December/009213.html >> >> Test case A: >> >> tx_checksum set sw-tunnel-mode off >> tx_checksum

[dpdk-dev] ret_pktmbuf_pool_init problem with opaque_arg

2015-01-09 Thread Olivier MATZ
Hi Alejandro, On 01/09/2015 03:12 PM, Alejandro Lucero wrote: > Inside this function mbuf_data_room_size is set to a default value if > opaque_arg is null and it should be set to the value pointed by opaque_arg > if not null. Current implementation is using not the value but with the > pointer

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-12 Thread Olivier MATZ
Hi Jijiang, Please find some comments below. On 01/12/2015 04:41 AM, Liu, Jijiang wrote: > There are some examples for the different packet types: > > 1. For L2 Packet types: > MAC, ARP > MAC, PAY2 > ... > They are forwarded without beeing modified no matter if these above commands > are set.

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-13 Thread Olivier MATZ
Hi Jijiang, On 01/13/2015 04:04 AM, Liu, Jijiang wrote: > the following two commands are. > > 1. tx_checksum set sw-tunnel-mode on/off > > 2. tx_checksum set hw-tunnel-mode on/off > > For command 1, If the sw-tunnel-mode is set/clear, which will set/clear a > testpmd flag that is used in the

[dpdk-dev] No probed ethernet devices /DPDP 1.7.1 in Fedora 21

2015-01-16 Thread Olivier MATZ
Hi Sothy, On 01/16/2015 05:07 PM, sothy shan wrote: > On Fri, Jan 16, 2015 at 3:27 PM, Olivier MATZ > wrote: >>> When I do with >>> >>> export RTE_SDK=$(pwd)export RTE_TARGET="x86_64-ivshmem-linuxapp-gcc" >>> make CONFIG_RTE_BUILD_COMBIN

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-16 Thread Olivier MATZ
Hi Konstantin, Hi Jijiang, On 01/15/2015 02:31 PM, Ananyev, Konstantin wrote: > To be honest, there are so many mails around that subject, so I am already > lost :) > Oliver, as I understand you are not happy with the test-pmd commands Frank is > proposing. > Both syntax and semantics. > Is

  1   2   3   4   5   6   7   8   9   10   >