This patch fixes a typo in proc_info guide (tools),
doc/guides/tools/proc_info.rst.
Signed-off-by: Rami Rosen
---
doc/guides/tools/proc_info.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst
index baaf977
This patch fixes a trivial typo in testpmd application guide.
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
This patch fixes a trivial typo in testpmd application user guide.
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/run_app.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/run_app.rst
b/doc/guides/testpmd_app_ug/run_app.rst
index d7c5120
This trivial patch removes wrong comments about
the return value of the rte_bus_dump(), as
this method does not return any value
(it's return type is void)
Signed-off-by: Rami Rosen
---
lib/librte_eal/common/include/rte_bus.h | 3 ---
1 file changed, 3 deletions(-)
diff --git
This patch fixes a trivial typo in rte_jobstats.h.
Signed-off-by: Rami Rosen
---
lib/librte_jobstats/rte_jobstats.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_jobstats/rte_jobstats.h
b/lib/librte_jobstats/rte_jobstats.h
index b3686030e820..7e76fd50c6fa
This trivial patch removes wrong comments about
the return value of the rte_eth_copy_pci_info() method.
The method return value type is void.
Signed-off-by: Rami Rosen
---
lib/librte_ether/rte_ethdev_pci.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev_pci.h
b
",
and this trivial patch fixes it.
Signed-off-by: Rami Rosen
---
doc/guides/nics/i40e.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 043de34..413661c 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/
/net/vhost/rte_eth_vhost.c.
Signed-off-by: Rami Rosen
---
drivers/net/vhost/rte_eth_vhost.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c
b/drivers/net/vhost/rte_eth_vhost.c
index e98cffd..62ccb74 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers
This patch fixes a trivial typo in i40e_flow.c.
Signed-off-by: Rami Rosen
---
drivers/net/i40e/i40e_flow.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index c6e4d87..f163ce5 100644
--- a/drivers/net/i40e
while the explanation immediately following
says:
In this command:
• The -c option enables cores 0, 1, 2 and 3
This patch fixes the
explanation to have "-l" instead of "-c".
Signed-off-by: Rami Rosen
---
doc/guides/sample_app_ug/ipv4_multicast.rst | 2 +-
1 file chang
This patch fixes a trivial typo in rte_ethdev.h; it should be
"RX multicast OFF" and not "RX multicast OF".
Signed-off-by: Rami Rosen
---
lib/librte_ether/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.
Cnsolidate the duplicate #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES
into one #ifdef.
Signed-off-by: Rami Rosen
---
app/test-pmd/rxonly.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c
index dcc8346..dcd1d85 100644
--- a/app/test-pmd/rxonly.c
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug
rce/drivers/net/ethernet/intel/ice
Regards,
Rami Rosen
O_PF(dev->data->dev_private);
> + uint16_t nb_rxq = 0;
> + uint16_t nb_txq, i;
> + int ret;
> +
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY)
> + return -E_RTE_SECONDARY;
> +
[Rami Rosen] Suppose start of a TX queue failes in the loop belo
Hi,
The same comment refers also to V2 of the patch, [PATCH v2 03/20]
net/ice: support device and queue ops
Regards,
Rami Rosen
On Mon, 3 Dec 2018 at 17:24, Rami Rosen wrote:
>
> Hi, Wenzhuo,
>
> > +static int
> > +ice_dev_start(struct rte_eth_dev *dev)
>
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)
Fixes: ac718398f477 ("doc: testpmd application user guide")
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP).
Fixes: ac718398f477 ("doc: testpmd application user guide")
Signed-off-by: Rami Rosen
Acked-by: Bernard Iremonger
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Reviewed-by: Rami Rosen
On Fri, 14 Dec 2018 at 18:43, Jeff Shaw wrote:
>
> Prior to this patch, the two affected .c files include
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw
> ---
> lib/librte_eal/common/eal_common_lcore.c |
cket guide.
Fixes: c8dba1ee6cde ("doc: add af_packet PMD guide")
Signed-off-by: Rami Rosen
---
doc/guides/nics/af_packet.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/af_packet.rst b/doc/guides/nics/af_packet.rst
index 188a6efe1..1260bb
This patch fixes I40E RxTx module to use the proper config setting,
CONFIG_RTE_LIBRTE_I40E_INC_VECTOR.
Fixes: 9ed94e5bb04e ("i40e: add vector Rx")
Signed-off-by: Rami Rosen
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
DCR is Intel internal information, no need to be in public code.
See also a parallel patch by Ferruh, commit
1a0833efde70 ("net/i40e/base: fix comment referencing internal data").
Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")
Cc: sta...@dpdk.org
Signe
There is no parameter called "eth-peer-configfile" in testpmd. It should be
"eth-peers-configfile". See the usage() method in app/test-pmd/parameters.c.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: sta...@dpdk.org
Signed-off-b
use it without the need to
include testpmd.h, which is a bit awkard.
Another question is whether it should be IPV4_VHL_DEF or IPV_VHL_DEF as in
other DPDK apps. Probably other apps should be adjusted to use it.
Regards,
Rami Rosen
This patch fixes a typo in testpmd user guide.
Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
ode")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..1ceb000da 100644
-
ode")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..1ceb000da 100644
-
boolean parameter (mark_malform
or something like that) to this method + removing the const quailifier. The
bulk method will set that flag when calling the rte_hdr_parse(). Thus you
will avoid duplicity of the parsing code.
Regards,
Rami Rosen
>
>
ned-off-by: Rami Rosen
---
examples/vhost/main.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index dc9ea10..f722a13 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -55,9 +55,6 @@
#define INVALID_PO
Hi, Morten,
> And regarding avoiding code duplicity, I'm pursuing Olivier about merging
packet header validation into rte_net_get_ptype() instead of writing a
separate function.
>
This seems also a good alternative.
+1
Regards,
Rami Rosen
>
>
>
gt; David Marchand wrote:
>Those are new functions, they should go through the EXPERIMENTAL api
>marking process.
+1
Regards,
Rami Rosen
בתאריך יום ד׳, 9 בינו׳ 2019, 15:47, מאת David Marchand <
david.march...@redhat.com>:
> On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh wrote:
&g
This patch removes unneeded include of rte_mempool.h in
two modules in examples/l3fwd.
Fixes: 26b5b020 ("examples/l3fwd: modularize")
Signed-off-by: Rami Rosen
---
examples/l3fwd/l3fwd_em.c | 1 -
examples/l3fwd/l3fwd_lpm.c | 1 -
2 files changed, 2 deletions(-)
diff --git
This patch fixes a typo in flow_filtering.rst. There is no
method named generate_ipv4_rule in DPDK, it should be generate_ipv4_flow.
Signed-off-by: Rami Rosen
---
doc/guides/sample_app_ug/flow_filtering.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides
Hi, Anatoly,
This is really minor nitpick, but in case you decide to send V2, I believe
it should say
>> + if ret != 0:
>> +print("'lspci' not found - please install pciutils')
as the name of the package containing lspci is pciutils in centos.
Regards,
Rami Rosen
>
pm2html/search.php?query=pciutils&submit=Search+...
https://packages.ubuntu.com/trusty/pciutils
https://packages.debian.org/search?keywords=pciutils
https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils
Regards,
Rami Rosen
Reviewed-by: Rami Rosen
On Tue, 13 Nov 2018 at 18:06, Anatoly Burakov wrote:
>
> On some distributions (such as CentOS 7) lspci may not be installed
> by default, causing exceptions which are difficult to interpret.
>
> Fix devbind script to check if lspci is installed at script
guide.
>
> Signed-off-by: Anatoly Burakov
This is a right and needed thing to do, thanks!
Reviewed-by: Rami Rosen
HI Kenvish,
Apologies, maybe I miss something, but what is the issue ?
Regards,
Rami Rosen
On Tue, 20 Nov 2018 at 08:24, Kenvish Butani wrote:
>
> # ./l3fwd -c 0x3 -n 2 -- -p 0x3 --config="(0,0,0),(1,0,1)" EAL: Detected 24
> lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-pro
://doc.dpdk.org/guides/sample_app_ug/l2_forward_job_stats.html
And also see:
https://doc.dpdk.org/api/rte__jobstats_8h_source.html
Regards,
Rami Rosen
בתאריך יום ד׳, 21 בנוב׳ 2018, 09:50, מאת Hideyuki Yamashita <
yamashita.hidey...@po.ntt-tx.co.jp>:
> Hello,
>
> I have some basic questions abou
No, AFAIK. It will
be great if someone will write documentation and implement such a
thing, if it is doable.
Regards,
Rami Rosen
u may try, DPDK is an Open Source project.
> Q8.
> BTW, when I read jobstats sample, I felt that
> application programmers should be fully aware of the jobstats
> from the first place of software design (many timers in main function)
> and it is NOT "opt-in" "opt-out" f
The forward declaraion of rte_pci_device in rte_ethdev.h
is not needed anymore.
Fixes: cd8c7c7ce241 ("replace bus specific struct with generic dev")
Signed-off-by: Rami Rosen
---
lib/librte_ethdev/rte_ethdev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_
This patch fixes a trivial typo in pci_common.c.
Signed-off-by: Rami Rosen
---
drivers/bus/pci/pci_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 94b0f41..8253a50 100644
--- a/drivers/bus/pci
This patch fixes a doxygen comment of the rte_eth_dev_allocate()
method. There is no parameter named "type" for this
method; so this patch removes the doxygen comment about it.
Signed-off-by: Rami Rosen
---
lib/librte_ethdev/rte_ethdev_driver.h | 1 -
1 file changed, 1 deletion(-)
This patch removes the forward declaration of rte_pci_remove_device()
method. In the past, this forward decalaration was needed for
rte_pci_detach(), which is now removed from pci_common.c.
Fixes: e690338a7b85 ("bus/pci: remove unused function to detach by address")
Signed-off-by:
This trivial patch removes an uneeded include
from drivers/bus/pci/linux/pci.c.
Signed-off-by: Rami Rosen
---
drivers/bus/pci/linux/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 004600f..04648ac 100644
--- a/drivers/bus
Signed-off-by: Rami Rosen
---
app/test-pmd/testpmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index ee48db2a3..8a31722db 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -435,9 +435,6 @@ static int eth_event_callback
This trivial patch fixes a typo in rte_bpf_ethdev.h,
Signed-off-by: Rami Rosen
---
lib/librte_bpf/rte_bpf_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_bpf/rte_bpf_ethdev.h b/lib/librte_bpf/rte_bpf_ethdev.h
index 31731e7a9..11d09cdc2 100644
--- a/lib
This patch fixes wrong usage of bind command in vhost.rst.
Using "dpdk-devbind.py -b=uio_pci_generic :00:04.0" gives
an error of "unbind failed". It should be "-b uio_pci_generic" so
it will work correctly.
Signed-off-by: Rami Rosen
---
doc/guides/sample_a
This patch removes an unnecessary definition of MAX_PRINT_BUFF
in examples/vhost/main.c, since it is no longer being used.
Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
Signed-off-by: Rami Rosen
---
examples/vhost/main.c | 3 ---
1 file changed, 3
:
uint16_t
rte_eth_dev_count_avail(void)
{
uint16_t p;
uint16_t count;
count = 0;
RTE_ETH_FOREACH_DEV(p)
count++;
return count;
}
Regards,
Rami Rosen
This patch fixes a trivial typo in the programmer's guide.
Fixes: 1733be6d3147 ("doc: new eal multi-pthread feature")
Signed-off-by: Rami Rosen
---
doc/guides/prog_guide/env_abstraction_layer.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/gu
Hi Tone,
>if the devices for used DPDK bound to the ``uio-pci`` kernel module,
please make
The three kernel modules which can be used for DPDK binding are vfio-pci,
uio_pci_generic and igb_uio. Don't you mean here uio_pci_generic ?
Regards,
Rami Rosen
בתאריך יום ג׳, 4 בספט׳ 2018, 11
f8530d1648d623205246e1da
Author: Fan Zhang
Date: Thu Apr 5 17:01:36 2018 +0100
examples/vhost_crypto: add sample application
Regards,
Rami Rosen
The function rte_pci_detach() is private to PCI and is
not used anywhere in current code base. Remove dead code.
Signed-off-by: Rami Rosen
---
drivers/bus/pci/pci_common.c | 36
drivers/bus/pci/private.h| 14 --
2 files changed, 50 deletions
The definition of MAX_PRINT_BUFF in examples/tep_termination/main.c
is not necessary as it is not used. This cleanup patch removes it.
Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
examples/tep_termination/
This minor patch fixes a typo in examples/vhost/main.c.
Fixes: d19533e86f1d ("examples/vhost: copy old vhost example")
Signed-off-by: Rami Rosen
---
examples/vhost/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b/examples/vhost/ma
guide.
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/run_app.rst
b/doc/guides/test
in the testpmd guide.
v2: Change "loopback" to "loop" (following Bernard review)
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
1 file changed, 3 ins
;)
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/nics/ifc.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
index bdf7b4e..317d9ff 100644
--- a/doc/guides/nics/ifc.rst
+++ b/doc/guides/nics/ifc.rst
@@ -19,7 +19,7 @@ C
e dependency in
sub-section 4.3.1 of the contributing guide ("Dependencies").
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/contributing/documentation.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/contributing/documentation.
This minor cleanup patch removes an unecessary forward
declaration of virtio_intr_enable() in net/virtio PMD.
Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
drivers/net/virtio/virtio_ethdev.c | 1 -
1 file changed,
Hi all,
>My vote is definitely for merging.
+1 for this, this seems very reasonable
Regards,
Rami Rosen
On Wed, 23 Jan 2019 at 19:20, Ananyev, Konstantin
wrote:
>
>
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent:
Was it with
-l CORELIST / --lcores COREMAP EAL parameter ?
Did you try also the isolcpus Linux kernel parameter in order to isolate
cores from the general Linux scheduler?
Regards,
Rami Rosen
On Tue, Jan 29, 2019 at 6:32 PM Shirley Avishour
wrote:
> Hi,
> We are trying to run a dpdk based
, if you boot from a different partition.
Regards,
Rami Rosen
guide/sect-red_hat_enterprise_linux-performance_tuning_guide-cpu-configuration_suggestions
So if there is no way to configure JVM to use specified kernel cores (and I
am afraid there is no such way),
I am not sure how this can be solved.
Regards,
Rami Rosen
On Wed, Jan 30, 2019 at 9:05 AM Shirle
them and try:
taskset -pc 7 521
pid 521's current affinity list: 0-15
taskset: failed to set pid 521's affinity: Invalid argument
Regards,
Rami Rosen
per kernel thread for example)
via a sysf entry or a kernel parameter will be accepted, though. You may try
Regards,
Rami Rosen
ere are setups when you cannot generated
PMD VFs.
Most PMD Ethernet Vendors *do* provide VF PMDs in the DPDK official repo;
but what are the benefits of providing DPDK VFs PMD? is it mandatory in
some use cases ?
Is there any advantage for using a DPDK PF/DPDK VF
combination over using Kernel VF?
Regards,
Rami Rosen
what are the benefits of providing DPDK VFs,
is it mandatory in some use cases, and are there any advantage for using a
DPDK PF/DPDK VF combination over using Kernel VF?
Regards,
Rami Rosen
latest/intro/install/dpdk/
"VFIO is prefered to the UIO driver when using recent versions of DPDK. "
Regards,
Rami Rosen
uot;
instead of "Command"; this patch fixes it.
Bugzilla ID: 205
Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
Signed-off-by: Rami Rosen
---
test/test/autotest_data.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/autotest_d
This trivial patch fixes a typo in rte_mbuf.h.
Fixes: f20b50b946da ("mbuf: optimize refcnt update")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
lib/librte_mbuf/rte_mbuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/l
+1
Reviewed-by: Rami Rosen
>
Hi,
I would suggest to consider to add:
Fixes: 450f0791312c ("power: add traffic pattern aware power control")
Reviewed-By: Rami Rosen
This patch fixes a minor typo in testpmd guide.
Cc: sta...@dpdk.org
Fixes: 3c272b280a50 ("app/testpmd: add commands for RSS queue region")
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Acked-by: Rami Rosen
בתאריך יום ב׳, 18 בפבר׳ 2019, 14:30, מאת Ferruh Yigit <
ferruh.yi...@intel.com>:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation
I believe this patch should be cc'ed/sent to sta...@dpdk.org
Reviewed-by: Rami Rosen
On Thu, Feb 14, 2019 at 5:43 PM David Marchand
wrote:
> Remove some leftover from a previous rework.
>
> Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding")
> Si
Reviewed-by: Rami Rosen
On Fri, Feb 15, 2019 at 12:29 PM Nikhil Rao wrote:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>
> Fixes: 4d55194d76a4 ("service: add attribute get function")
&
+1
Reviewed-by: Rami Rosen
On Thu, Feb 14, 2019 at 5:43 PM David Marchand
wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
> RX-packets: 3542977TX-packets: 3542971
Hi,
+Shared memory packet interface (memif) PMD allows for DPDK and any other
client
+using memif (DPDK, VPP, libmemif) toc ommunicate using shared memory.
Memif is
+Linux only.s
Minor nit.
should be "to communicate"
And Also
Linux only.s => Linux only.
Reviewed-by: Rami Rosen
Reviewed-by: Rami Rosen
בתאריך יום ג׳, 19 בפבר׳ 2019, 22:38, מאת David Marchand <
david.march...@redhat.com>:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passin
Reviewed-by: Rami Rosen
בתאריך יום ה׳, 21 בפבר׳ 2019, 21:01, מאת Thomas Monjalon <
tho...@monjalon.net>:
> The log was printing the device name two times,
> first one being supposed to be the driver name.
> As we don't know yet the driver name, the log is simplified.
>
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:33 AM Thomas Monjalon
wrote:
> The placeholder for PCI address should be named DBDF
> which stands for Domain/Bus/Device/Function.
>
> Fixes: 33af337773ac ("ethdev: add common devargs parser")
> Cc: remy.hor...@intel.
Checked on Fedora 28
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon
> ---
> app/
Checked on Fedora 28
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon
> ---
> drivers/n
This patch removes the reference to rte.doc.mk in
DPDK programmers guide.
Fixes: ee801f6cc7b8 ("mk: clean dead doc rules")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/prog_guide/dev_kit_build_system.rst | 2 --
1 file changed, 2 deletions(-)
diff --git a/
("examples/ethtool: add user-space ethtool sample
application")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
examples/ethtool/lib/rte_ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ethtool/lib/rte_ethtool.h
b/examples/ethtool/lib/rte_ethto
Reviewed-by: Rami Rosen
On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh
wrote:
> The structure was not initialized.
>
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
> secondary")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Raslan Dara
Hi, Cernay,
> delete mode 100644 examples/skeleton/basicfwd.c
It seems that this patch deletes examples/skeleton/basicfwd.c,
(instead of patching it ?!), maybe by mistake.
Reviewed-by: Rami Rosen
Rami Rosen
On Tue, Feb 26, 2019 at 3:04 PM Rastislav Cernay wrote:
> From: Rastislav
Reviewed-by: Rami Rosen
Hi, Dekel,
It seems that the link to the patch in your post is broken.
Regards,
Rami Rosen
בתאריך יום ה׳, 28 בפבר׳ 2019, 12:04, מאת Dekel Peled :
> In current kernel implementation, the physical port name for representors
> is a numeric string (i.e. '0', '1',
Reviewed-by: Rami Rosen
on, it should be "uses"
instead of "users".
Fixes: d0a87d9aa8de ("doc: update mlx5 guide on tunnel offloading")
Signed-off-by: Rami Rosen
---
doc/guides/nics/features.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/features.rst b
This patch fixes a wrong link in gsg. The
Documentation/kernel-parameters.txt file from the kernel
source tree was moved quite a time ago to
Documentation/admin-guide/kernel-parameters.txt.
Fixes: 1ab07743b21b ("doc: getting started guide for linux")
Cc: sta...@dpdk.org
Signed-of
Reviewed-by: Rami Rosen
>
>
Reviewed-by: Rami Rosen
>
Reviewed-by: Rami Rosen
>
+ "bpf-unload rx|tx (port) (queue)\n"
+ "Unload previously loaded eBPF program"
+ " for partciular RX/TX queue\n\n"
+
+ "port config (port_id) tx_metadata (value)\n"
+ "Set Tx metadata value per port.testpmd will add this value"
+ " to any Tx packet sent from this port\n\n"
Reviewed-by: Rami Rosen
Hi,
Added new net driver for Netcope nfb cards
Signed-off-by: Rastislav Cernay
Reviewed-by: Rami Rosen
---
v2: remove unnecessary cast
remove unnecessary zeroing
move declaration to not mix with code
restore skeleton example
v3: add release notes
add doc to doc index
add
1 - 100 of 177 matches
Mail list logo
