[dpdk-dev] [PATCH] librte_reorder: New reorder library with unit tests and app

2015-01-07 Thread Reshma Pattan
From: Reshma Pattan <reshma.pat...@intel.com> 1)New library to provide reordering of out of ordered mbufs based on sequence number of mbuf. Library uses reorder buffer structure which in tern uses two circular buffers called ready and order b

[dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library

2015-01-07 Thread Reshma Pattan
From: Reshma Pattan <reshma.pat...@intel.com> 1)New library to provide reordering of out of ordered mbufs based on sequence number of mbuf. Library uses reorder buffer structure which in tern uses two circular buffers called ready and order b

[dpdk-dev] [PATCH 2/3] librte_reorder: New unit test cases added

2015-01-07 Thread Reshma Pattan
From: Reshma Pattan <reshma.pat...@intel.com> Signed-off-by: Reshma Pattan --- app/test/Makefile | 2 + app/test/test_reorder.c | 452 mk/rte.app.mk | 4 + 3 files changed, 458 insertions(+) create mode 1006

[dpdk-dev] [PATCH 3/3] librte_reorder: New sample app for reorder library

2015-01-07 Thread Reshma Pattan
From: Reshma Pattan <reshma.pat...@intel.com> *Sample application consists of RX, Worker and TX threads. *RX thread marks the seqn field of mbufs upon receiving mbufs from driver. Marked mbufs will be enqueued in multi consumer ring. *Worker threads will d

[dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2015-12-23 Thread Reshma Pattan
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET are blocking the secondary process from using the APIs. API access should be given to both secondary and primary. Fix minor checkpath issues in rte_ethdev.h Reported-by: Sean Harte Signed-off-by: Reshma Pattan --- lib/librte_ether

[dpdk-dev] [PATCH 3/3] librte_ether: fix rte_eth_dev_configure

2015-12-23 Thread Reshma Pattan
User should be able to configure ethdev with zero rx/tx queues, but both should not be zero. After above change, rte_eth_dev_tx_queue_config, rte_eth_dev_rx_queue_config should allocate memory for rx/tx queues only when number of rx/tx queues are nonzero. Signed-off-by: Reshma Pattan --- lib

[dpdk-dev] [PATCH 2/3] librte_cryptodev: remove RTE_PROC_PRIMARY_OR_RET

2015-12-23 Thread Reshma Pattan
Macro RTE_PROC_PRIMARY_OR_ERR_RET blocking the secondary process from API usage. API access should be given to both secondary and primary. Signed-off-by: Reshma Pattan --- lib/librte_cryptodev/rte_cryptodev.c | 42 1 file changed, 42 deletions(-) diff --git

[dpdk-dev] [PATCH] doc: typos corrected in distributor application

2014-12-05 Thread Reshma Pattan
corrected couple of typos in distributor application Signed-off-by: Reshma Pattan --- doc/guides/sample_app_ug/dist_app.rst |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/dist_app.rst b/doc/guides/sample_app_ug/dist_app.rst index 76e3924

[dpdk-dev] [PATCH] linux_gsg: quick_start.rst fixed as per setup.sh menu options *corrected as per latest setup.sh menu options

2014-12-16 Thread Reshma Pattan
Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/quick_start.rst | 64 ++--- 1 files changed, 35 insertions(+), 29 deletions(-) diff --git a/doc/guides/linux_gsg/quick_start.rst b/doc/guides/linux_gsg/quick_start.rst index 089dddb..a99b8fa 100644

[dpdk-dev] [PATCH] app/pdump: cleanup rte rings upon failures

2016-07-22 Thread Reshma Pattan
Function create_mp_ring_vdev() for failure cases exits without freeing the created rte rings, because of this pdump tool cannot be rerun successfully. Added rte ring cleanup logic upon failures. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Res

[dpdk-dev] [PATCH v5 0/9] add packet capture framework

2016-06-08 Thread Reshma Pattan
hes. example command changed in app/pdump application guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (9): librte_ether: protect add/remove of rxtx callbacks with spinlocks librte_ether: add new api rte_eth_add_first_rx_callback librte_e

[dpdk-dev] [PATCH v5 3/9] librte_ether: add new fields to rte_eth_dev_info struct

2016-06-08 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v5 4/9] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public

2016-06-08 Thread Reshma Pattan
Converted rte_eth_dev_get_port_by_name to a public API. Converted rte_eth_dev_get_name_by_port to a public API. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 29 + lib/librte_ether

[dpdk-dev] [PATCH v5 2/9] librte_ether: add new api rte_eth_add_first_rx_callback

2016-06-08 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 27 ++ lib/librte_ether

[dpdk-dev] [PATCH v5 9/9] doc: announce ABI change for rte_eth_dev_info structure

2016-06-08 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues will be added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() will be done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6

[dpdk-dev] [PATCH v5 6/9] app/pdump: add pdump tool for packet capturing

2016-06-08 Thread Reshma Pattan
for the creation of the ring and mempool. Signed-off-by: Reshma Pattan --- MAINTAINERS| 1 + app/Makefile | 1 + app/pdump/Makefile | 45 +++ app/pdump/main.c | 814 + 4 files changed, 861 insertions(+) create mode 100644 app

[dpdk-dev] [PATCH v5 5/9] lib/librte_pdump: add new library for packet capturing support

2016-06-08 Thread Reshma Pattan
/packet_ordering.rst +Pdump +M: Reshma Pattan +F: lib/librte_pdump/ + Hierarchical scheduler M: Cristian Dumitrescu F: lib/librte_sched/ diff --git a/config/common_base b/config/common_base index 47c26f6..a2d5d72 100644 --- a/config/common_base +++ b/config/common_base @@ -484,6 +484,11

[dpdk-dev] [PATCH v5 8/9] doc: update doc for packet capture framework

2016-06-08 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan --- MAINTAINERS | 3 + doc/guides/prog_guide/index.rst | 1 + doc

[dpdk-dev] [PATCH v5 1/9] librte_ether: protect add/remove of rxtx callbacks with spinlocks

2016-06-08 Thread Reshma Pattan
Added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v5 7/9] app/test-pmd: add pdump initialization uninitialization

2016-06-08 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9d11830..645bf50 100644

[dpdk-dev] [PATCH v6 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks

2016-06-09 Thread Reshma Pattan
Added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v6 2/8] librte_ether: add new api rte_eth_add_first_rx_callback

2016-06-09 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 27 ++ lib/librte_ether

[dpdk-dev] [PATCH v6 7/8] app/test-pmd: add pdump initialization uninitialization

2016-06-09 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..f6089fa 100644

[dpdk-dev] [PATCH v6 5/8] lib/librte_pdump: add new library for packet capturing support

2016-06-09 Thread Reshma Pattan
/packet_ordering.rst +Pdump +M: Reshma Pattan +F: lib/librte_pdump/ + Hierarchical scheduler M: Cristian Dumitrescu F: lib/librte_sched/ diff --git a/config/common_base b/config/common_base index 47c26f6..a2d5d72 100644 --- a/config/common_base +++ b/config/common_base @@ -484,6 +484,11

[dpdk-dev] [PATCH v6 6/8] app/pdump: add pdump tool for packet capturing

2016-06-09 Thread Reshma Pattan
for the creation of the ring and mempool. Signed-off-by: Reshma Pattan --- MAINTAINERS| 1 + app/Makefile | 1 + app/pdump/Makefile | 45 +++ app/pdump/main.c | 814 + 4 files changed, 861 insertions(+) create mode 100644 app

[dpdk-dev] [PATCH v6 8/8] doc: update doc for packet capture framework

2016-06-09 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 + doc/guides/prog_guide

[dpdk-dev] [PATCH v6 0/8] add packet capture framework

2016-06-09 Thread Reshma Pattan
v3: app/pdump: Moved cleanup code from signal handler to main. divided librte_ether changes into multiple patches. example command changed in app/pdump application guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (8): librte_ether: protect add/remove of rxtx call

[dpdk-dev] [PATCH v6 4/8] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public

2016-06-09 Thread Reshma Pattan
Converted rte_eth_dev_get_port_by_name to a public API. Converted rte_eth_dev_get_name_by_port to a public API. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 29 + lib/librte_ether

[dpdk-dev] [PATCH v6 3/8] librte_ether: add new fields to rte_eth_dev_info struct

2016-06-09 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v7 4/8] librte_ether: make rte_eth_dev_get_port_by_name rte_eth_dev_get_name_by_port public

2016-06-09 Thread Reshma Pattan
Converted rte_eth_dev_get_port_by_name to a public API. Converted rte_eth_dev_get_name_by_port to a public API. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 29 + lib/librte_ether

[dpdk-dev] [PATCH v7 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks

2016-06-09 Thread Reshma Pattan
Added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v7 2/8] librte_ether: add new api rte_eth_add_first_rx_callback

2016-06-09 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 28 +++ lib/librte_ether

[dpdk-dev] [PATCH v7 0/8] add packet capture framework

2016-06-09 Thread Reshma Pattan
eter from pdump tool command line. v3: app/pdump: Moved cleanup code from signal handler to main. divided librte_ether changes into multiple patches. example command changed in app/pdump application guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (8): librte_ether

[dpdk-dev] [PATCH v7 3/8] librte_ether: add new fields to rte_eth_dev_info struct

2016-06-09 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v7 7/8] app/test-pmd: add pdump initialization uninitialization

2016-06-09 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..f6089fa 100644

[dpdk-dev] [PATCH v7 6/8] app/pdump: add pdump tool for packet capturing

2016-06-09 Thread Reshma Pattan
for the creation of the ring and mempool. Signed-off-by: Reshma Pattan --- MAINTAINERS| 1 + app/Makefile | 1 + app/pdump/Makefile | 45 +++ app/pdump/main.c | 844 + 4 files changed, 891 insertions(+) create mode 100644 app

[dpdk-dev] [PATCH v7 8/8] doc: update doc for packet capture framework

2016-06-09 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 + doc/guides/prog_guide

[dpdk-dev] [PATCH v7 5/8] lib/librte_pdump: add new library for packet capturing support

2016-06-09 Thread Reshma Pattan
/packet_ordering.rst +Pdump +M: Reshma Pattan +F: lib/librte_pdump/ + Hierarchical scheduler M: Cristian Dumitrescu F: lib/librte_sched/ diff --git a/config/common_base b/config/common_base index 47c26f6..a2d5d72 100644 --- a/config/common_base +++ b/config/common_base @@ -484,6 +484,11

[dpdk-dev] [PATCH v8 0/8] add packet capture framework

2016-06-10 Thread Reshma Pattan
ltiple patches. example command changed in app/pdump application guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (8): librte_ether: protect add/remove of rxtx callbacks with spinlocks librte_ether: add new api rte_eth_add_first_rx_callback librt

[dpdk-dev] [PATCH v8 1/8] librte_ether: protect add/remove of rxtx callbacks with spinlocks

2016-06-10 Thread Reshma Pattan
Added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v8 2/8] librte_ether: add new api rte_eth_add_first_rx_callback

2016-06-10 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 28 +++ lib/librte_ether

[dpdk-dev] [PATCH v8 7/8] app/test-pmd: add pdump initialization uninitialization

2016-06-10 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..9707cfc 100644

[dpdk-dev] [PATCH v8 8/8] doc: update doc for packet capture framework

2016-06-10 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 + doc/guides/prog_guide

[dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support

2016-06-10 Thread Reshma Pattan
rte_pdump_set_socket_dir to set the server socket path. Signed-off-by: Reshma Pattan --- MAINTAINERS| 4 + config/common_base | 5 + lib/Makefile | 1 + lib/librte_pdump/Makefile | 55 ++ lib/librte_pdump

[dpdk-dev] [PATCH v8 3/8] librte_ether: add new fields to rte_eth_dev_info struct

2016-06-10 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v8 6/8] app/pdump: add pdump tool for packet capturing

2016-06-10 Thread Reshma Pattan
for the creation of the ring and mempool. Signed-off-by: Reshma Pattan --- MAINTAINERS| 1 + app/Makefile | 1 + app/pdump/Makefile | 45 +++ app/pdump/main.c | 844 + 4 files changed, 891 insertions(+) create mode 100644 app

[dpdk-dev] [PATCH v9 0/8] add packet capture framework

2016-06-14 Thread Reshma Pattan
e patches. example command changed in app/pdump application guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (8): ethdev: use locks to protect Rx/Tx callback lists ethdev: add new api to add Rx callback as head of the list ethdev: add new fields to ethdev info

[dpdk-dev] [PATCH v9 2/8] ethdev: add new api to add Rx callback as head of the list

2016-06-14 Thread Reshma Pattan
Added new public api rte_eth_add_first_rx_callback to add given callback as head of the list. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 35 ++ lib/librte_ether/rte_ethdev.h | 28 +++ lib

[dpdk-dev] [PATCH v9 4/8] ethdev: make get port by name and get name by port public

2016-06-14 Thread Reshma Pattan
Converted rte_eth_dev_get_port_by_name to a public API. Converted rte_eth_dev_get_name_by_port to a public API. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 4 ++-- lib/librte_ether/rte_ethdev.h | 29 + lib/librte_ether

[dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support

2016-06-14 Thread Reshma Pattan
public api rte_pdump_set_socket_dir to set the server and client socket paths. Signed-off-by: Reshma Pattan --- MAINTAINERS| 4 + config/common_base | 5 + lib/Makefile | 1 + lib/librte_pdump/Makefile

[dpdk-dev] [PATCH v9 6/8] app/pdump: add pdump tool for packet capturing

2016-06-14 Thread Reshma Pattan
for the creation of the ring and mempool. Signed-off-by: Reshma Pattan --- MAINTAINERS| 1 + app/Makefile | 1 + app/pdump/Makefile | 45 +++ app/pdump/main.c | 844 + 4 files changed, 891 insertions(+) create mode 100644 app

[dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists

2016-06-14 Thread Reshma Pattan
Added spinlocks around add/remove logic of Rx and Tx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v9 3/8] ethdev: add new fields to ethdev info struct

2016-06-14 Thread Reshma Pattan
New fields nb_rx_queues and nb_tx_queues are added to rte_eth_dev_info structure. Changes to API rte_eth_dev_info_get() are done to update these new fields to rte_eth_dev_info object. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 2 ++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v9 7/8] app/testpmd: add pdump initialization uninitialization

2016-06-14 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..9707cfc 100644

[dpdk-dev] [PATCH v9 8/8] doc: update doc for packet capture framework

2016-06-14 Thread Reshma Pattan
Added programmers guide for librte_pdump. Added sample application guide for app/pdump application. Updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan Acked-by: John McNamara --- MAINTAINERS | 3 + doc/guides/prog_guide

[dpdk-dev] [PATCH v10 1/7] ethdev: use locks to protect Rx/Tx callback lists

2016-06-15 Thread Reshma Pattan
Added spinlocks around add/remove logic of Rx and Tx callbacks to avoid corruption of callback lists in multithreaded context. Signed-off-by: Reshma Pattan --- lib/librte_ether/rte_ethdev.c | 82 +-- 1 file changed, 40 insertions(+), 42 deletions(-) diff

[dpdk-dev] [PATCH v10 7/7] app/testpmd: add pdump initialization uninitialization

2016-06-15 Thread Reshma Pattan
Call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 12 1 file changed, 12 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dd6b046..b26f5be

[dpdk-dev] [PATCH v10 5/7] pdump: add new library for packet capturing support

2016-06-15 Thread Reshma Pattan
callback for all the port and queues. Update the release notes. Added programmers guide for librte_pdump. Updated the MAINTAINERS file. Signed-off-by: Reshma Pattan --- MAINTAINERS | 5 + config/common_base | 5 + doc/guides/prog_guide

[dpdk-dev] [PATCH v10 0/7] add packet capture framework

2016-06-15 Thread Reshma Pattan
guide v2: fix compilation issues for 4.8.3 fix unnecessary #includes Reshma Pattan (7): ethdev: use locks to protect Rx/Tx callback lists ethdev: add new api to add Rx callback as head of the list ethdev: add new fields to ethdev info struct ethdev: make get port by name and get name b

[dpdk-dev] [PATCH v10 6/7] app/pdump: add pdump tool for packet capturing

2016-06-15 Thread Reshma Pattan
. Updated the MAINTAINERS. Added sample application guide for app/pdump application. Signed-off-by: Reshma Pattan --- MAINTAINERS| 2 + app/Makefile | 1 + app/pdump/Makefile | 49 ++ app/pdump/main.c

[dpdk-dev] [PATCH 2/3] pdump: fix string overflow

2016-06-21 Thread Reshma Pattan
brary for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index dbc6816..05513d6 100644 --- a/lib/librte_pdump/rte_pdump.c

[dpdk-dev] [PATCH 1/3] pdump: check getenv return value

2016-06-21 Thread Reshma Pattan
d new library for packet capture") Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 46 ++-- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/lib/libr

[dpdk-dev] [PATCH 0/3] fix coverity issues in packet capture framework

2016-06-21 Thread Reshma Pattan
This patchset fixes coverity issues in pdump library and pdump tool. Reshma Pattan (3): pdump: check getenv return value pdump: fix string overflow app/pdump: fix string overflow app/pdump/main.c | 4 ++-- lib/librte_pdump/rte_pdump.c | 53

[dpdk-dev] [PATCH 3/3] app/pdump: fix string overflow

2016-06-21 Thread Reshma Pattan
tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index f8923b9..af92ef3 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -217,12 +217,12 @@ parse_rxtxdev(

[dpdk-dev] [PATCH v2 1/3] pdump: check getenv return value

2016-06-22 Thread Reshma Pattan
value is checked and error message is logged. Coverity issue 127344: return value check Coverity issue 127347: null pointer dereference Fixes: 278f945402c5 ("pdump: add new library for packet capture") Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-o

[dpdk-dev] [PATCH v2 0/3] fix coverity issues in packet capture framework

2016-06-22 Thread Reshma Pattan
This patchset fixes coverity issues in pdump library and pdump tool. v2: fixed code review comment to use snprintf instead of strncpy. Reshma Pattan (3): pdump: check getenv return value pdump: fix string overflow app/pdump: fix string overflow app/pdump/main.c | 4 ++-- lib

[dpdk-dev] [PATCH v2 2/3] pdump: fix string overflow

2016-06-22 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH v2 3/3] app/pdump: fix string overflow

2016-06-22 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v3 3/4] pdump: fix string overflow

2016-06-23 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH v3 0/4] fix issues in packet capture framework

2016-06-23 Thread Reshma Pattan
e change. v2: fixed code review comment to use snprintf instead of strncpy. Reshma Pattan (4): pdump: fix default socket path pdump: check getenv return value pdump: fix string overflow app/pdump: fix string overflow app/pdump/main.c | 4 +-- lib/librte_pd

[dpdk-dev] [PATCH v3 4/4] app/pdump: fix string overflow

2016-06-23 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v3 1/4] pdump: fix default socket path

2016-06-23 Thread Reshma Pattan
s" from SOCKET_PATH_VAR_RUN. Changes are done in pdump_get_socket_path() to accommodate new socket path changes. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 22 +- 1 file changed, 13

[dpdk-dev] [PATCH v4 0/5] fix issues in packet capture framework

2016-06-24 Thread Reshma Pattan
patch for fixing default socket paths "HOME" and "/var/run". reworked coverity fixes on top of the above change. v2: fixed code review comment to use snprintf instead of strncpy. Reshma Pattan (5): pdump: fix default socket path pdump: check getenv return value pdump: fix s

[dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path

2016-06-24 Thread Reshma Pattan
s" from SOCKET_PATH_VAR_RUN. Changes are done in pdump_get_socket_path() to accommodate new socket path changes. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 22 +- 1 file changed, 13

[dpdk-dev] [PATCH v4 2/5] pdump: check getenv return value

2016-06-24 Thread Reshma Pattan
and error message is logged. Coverity issue 127344: return value check Coverity issue 127347: null pointer dereference Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 44 +

[dpdk-dev] [PATCH v4 3/5] pdump: fix string overflow

2016-06-24 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH v4 4/5] app/pdump: fix string overflow

2016-06-24 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v4 5/5] app/pdump: fix type casting of ring size

2016-06-24 Thread Reshma Pattan
ring_size value is wrongly type casted to uint16_t. It should be type casted to uint32_t, as maximum ring size is 28bit long. Wrong type cast wrapping around the ring size values bigger than 65535. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Res

[dpdk-dev] [PATCH v5 0/5] fix issues in packet capture framework

2016-06-24 Thread Reshma Pattan
nge. v2: fixed code review comment to use snprintf instead of strncpy. Reshma Pattan (5): pdump: fix default socket path pdump: check getenv return value pdump: fix string overflow app/pdump: fix string overflow app/pdump: fix type casting of ring size app/pdump/main.c | 6 ++

[dpdk-dev] [PATCH v5 1/5] pdump: fix default socket path

2016-06-24 Thread Reshma Pattan
for root users and under HOME/.dpdk/pdump_sockets for non root users. Changes are done in pdump_get_socket_path() to accommodate new socket path changes. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c |

[dpdk-dev] [PATCH v5 5/5] app/pdump: fix type casting of ring size

2016-06-24 Thread Reshma Pattan
ring_size value is wrongly type casted to uint16_t. It should be type casted to uint32_t, as maximum ring size is 28bit long. Wrong type cast wrapping around the ring size values bigger than 65535. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Res

[dpdk-dev] [PATCH v5 2/5] pdump: check getenv return value

2016-06-24 Thread Reshma Pattan
and error message is logged. Coverity issue 127344: return value check Coverity issue 127347: null pointer dereference Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 43

[dpdk-dev] [PATCH v5 4/5] app/pdump: fix string overflow

2016-06-24 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Reshma Pattan --- app/pdump/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v5 3/5] pdump: fix string overflow

2016-06-24 Thread Reshma Pattan
replaced strncpy with snprintf for safely copying the strings. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH] librte_reorder: fix failing unit test cases

2015-10-20 Thread Reshma Pattan
nd 4 ports are used for reorder sample app testing. Signed-off-by: Reshma Pattan --- app/test/test_reorder.c | 75 + examples/packet_ordering/main.c | 2 +- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/app/test/test_reorder.c

[dpdk-dev] [PATCH] MAINTAINERS: update maintainer for reorder library

2015-10-21 Thread Reshma Pattan
Updated maintainers list for reorder library Signed-off-by: Reshma Pattan --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 080a8e8..bdc0981 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -314,7 +314,7 @@ F: examples

[dpdk-dev] [PATCH v2] app/test: fix reorder library unit test

2015-10-21 Thread Reshma Pattan
behavior. Fixes: 7e1fa1de8a53 ("reorder: allow random number as starting point") Signed-off-by: Reshma Pattan --- Version 2: split patch for unit test only update commit message app/test/test_reorder.c | 75 --- 1 files changed, 38 inserti

[dpdk-dev] [PATCH v2 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2016-01-05 Thread Reshma Pattan
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET are blocking the secondary process from using the APIs. API access should be given to both secondary and primary. Reported-by: Sean Harte Signed-off-by: Reshma Pattan --- v2: * Removed checkpatch fixes of lib/librte_ether

[dpdk-dev] [PATCH v3 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET

2016-01-05 Thread Reshma Pattan
Macros RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET are blocking the secondary process from using the APIs. API access should be given to both secondary and primary. Reported-by: Sean Harte Signed-off-by: Reshma Pattan --- v3: * Removed checkpatch fixes of lib/librte_ether

[dpdk-dev] [PATCH v3 3/3] librte_ether: fix rte_eth_dev_configure

2016-01-05 Thread Reshma Pattan
User should be able to configure ethdev with zero rx/tx queues, but both should not be zero. After above change, rte_eth_dev_tx_queue_config, rte_eth_dev_rx_queue_config should allocate memory for rx/tx queues only when number of rx/tx queues are nonzero. Signed-off-by: Reshma Pattan --- lib

[dpdk-dev] [PATCH v3 2/3] librte_cryptodev: remove RTE_PROC_PRIMARY_OR_RET

2016-01-05 Thread Reshma Pattan
Macro RTE_PROC_PRIMARY_OR_ERR_RET blocking the secondary process from API usage. API access should be given to both secondary and primary. Signed-off-by: Reshma Pattan --- lib/librte_cryptodev/rte_cryptodev.c | 42 -- 1 files changed, 0 insertions(+), 42

[dpdk-dev] [PATCH 0/5] add dpdk packet capture support for tcpdump

2016-01-29 Thread Reshma Pattan
riting to PCAP files will be stopped once the folder size where pcap files exists reaches its max value. Reshma Pattan (5): app/test-pmd: fix nb_rxq and np_txq checks drivers/net/pcap: add public api to create pcap device app/proc_info: add tcpdump support in secondary process lib/librte_eal:

[dpdk-dev] [PATCH 1/5] app/test-pmd: fix nb_rxq and np_txq checks

2016-01-29 Thread Reshma Pattan
Made testpmd changes to validate nb_rxq/nb_txq zero value changes of librte_ether. Signed-off-by: Reshma Pattan --- app/test-pmd/cmdline.c| 11 +-- app/test-pmd/parameters.c | 14 +- app/test-pmd/testpmd.c| 19 +-- 3 files changed, 31 insertions

[dpdk-dev] [PATCH 2/5] drivers/net/pcap: add public api to create pcap device

2016-01-29 Thread Reshma Pattan
Added new public api to create pcap device from pcaps. Added new header file for API declaration. Added new public api to version map Signed-off-by: Reshma Pattan --- drivers/net/pcap/Makefile |4 +- drivers/net/pcap/rte_eth_pcap.c | 156

[dpdk-dev] [PATCH 3/5] app/proc_info: add tcpdump support in secondary process

2016-01-29 Thread Reshma Pattan
Added "--tcupdump2 and "--src-ip-filter" command line options for tcpdump support. Added pcap device creation and writing of packets to pcap device for tcpdump. Added socket functionality to communicate with primary process. Signed-off-by: Reshma Pattan --- app/proc_inf

[dpdk-dev] [PATCH 5/5] doc: update doc for tcpdump feature

2016-01-29 Thread Reshma Pattan
Added tcpdump design changes to proc_info section of sample application user guide. Added tcpdump design changes env abstraction layer section of programmers guide. Signed-off-by: Reshma Pattan --- doc/guides/prog_guide/env_abstraction_layer.rst | 29 +++- doc/guides

[dpdk-dev] [PATCH 4/5] lib/librte_eal: add tcpdump support in primary process

2016-01-29 Thread Reshma Pattan
functionality to remove registered rte_eth_rxtx_callbacks once secondary process is terminated. Signed-off-by: Reshma Pattan --- lib/librte_eal/linuxapp/eal/Makefile |5 +- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 376 +- 2 files changed, 378 insertions

[dpdk-dev] [PATCH] app/testpmd: add timer based fwd Rx queue flushing

2016-07-01 Thread Reshma Pattan
ble packet forwarding and forward the packets. So timer is set to exit the do while loop after 1 second. Fixes: af75078f ("first public release") Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH] pdump: close client socket

2016-07-04 Thread Reshma Pattan
Close the client socket before returning on error. Coverity issue: 127555 Fixes: f3c1829130ac ("pdump: check missing home environment variable") Signed-off-by: Reshma Pattan --- lib/librte_pdump/rte_pdump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/li

[dpdk-dev] [PATCH 0/2] update packet capture framework doc

2016-07-06 Thread Reshma Pattan
This patch set contains 1) Release notes update for adding pdump library version to shared library section. 2) Added missing note about pdump tool dependency on libpcap and CONFIG_RTE_LIBRTE_PMD_PCAP. Reshma Pattan (2): doc: add pcap dependency note to pdump tool guide doc: add pdump shared

  1   2   >