[dpdk-dev] building shared library

2014-11-11 Thread Sergio Gonzalez Monroy
On Tue, Nov 11, 2014 at 01:10:29PM +0100, Newman Poborsky wrote: > Hi, > > I want to build one .so file with my app (it contains API that I want to > call through JNI) and all DPDK libs that I use in my app. > > As I've already mentioned, when I build and start my dpdk app as a > standalone appli

[dpdk-dev] [PATCH] doc: Add known issue for iommu and igb_uio

2014-12-12 Thread Sergio Gonzalez Monroy
Known issue regarding iommu/VT-d and igb_uio on Linux kernel version 3.15 to 3.17 where unbinding the device from the driver removes the 1:1 mapping for the device on the iommu resulting in memory access errors. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/known_issues.rst

[dpdk-dev] [PATCH v2] doc: add known issue for iommu and igb_uio

2014-12-12 Thread Sergio Gonzalez Monroy
Known issue regarding iommu/VT-d and igb_uio on Linux kernel version 3.15 to 3.17 where unbinding the device from the driver removes the 1:1 mapping for the device on the iommu resulting in memory access errors. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/known_issues.rst

[dpdk-dev] [PATCH v3] doc: add known issue for iommu and igb_uio

2014-12-12 Thread Sergio Gonzalez Monroy
Known issue regarding iommu/VT-d and igb_uio on Linux kernel version 3.15 to 3.17 where unbinding the device from the driver removes the 1:1 mapping for the device on the iommu resulting in memory access errors. Signed-off-by: Sergio Gonzalez Monroy --- v3: Remove reference number Add Linux

[dpdk-dev] [PATCH v4] doc: add known issue for iommu and igb_uio

2014-12-15 Thread Sergio Gonzalez Monroy
Known issue regarding iommu/VT-d and igb_uio in Linux kernel version 3.15 to 3.17 where unbinding the device from the driver removes the 1:1 mapping in the iommu resulting in IOMMU/DMAR errors when the device tries to access memory. Signed-off-by: Sergio Gonzalez Monroy --- v4: Improve commit

[dpdk-dev] [PATCH v3 1/4] compat: Add infrastructure to support symbol versioning

2014-12-29 Thread Sergio Gonzalez Monroy
mpat/rte_compat.h | 96 > ++ > mk/rte.lib.mk | 4 ++ > 4 files changed, 139 insertions(+) > create mode 100644 lib/librte_compat/Makefile > create mode 100644 lib/librte_compat/rte_compat.h > Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v3 2/4] Provide initial versioning for all DPDK libraries

2014-12-29 Thread Sergio Gonzalez Monroy
ce" > > --- > Change Notes: > > v2) > * Updated export map to not require full path > --- Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v3 3/4] Add library version extenstion

2014-12-29 Thread Sergio Gonzalez Monroy
e symlinking of libraries conditional on a DSO build > --- Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v3 4/4] docs: Add ABI documentation

2014-12-29 Thread Sergio Gonzalez Monroy
release, and actually removed when > DPDK > +1.10 ships. > + > + ABI versions may be deprecated in whole, or in part as needed by a given > +update. > + > +Deprecation Notices: > + > -- > 1.9.3 > Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-09-23 Thread Sergio Gonzalez Monroy
Hi Neil, On Mon, Sep 15, 2014 at 03:23:48PM -0400, Neil Horman wrote: > Add initial pass header files to support symbol versioning. > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Richardson, Bruce" > --- > lib/Makefile | 1 + > lib/librte_compat/Makefile |

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-09-23 Thread Sergio Gonzalez Monroy
On Tue, Sep 23, 2014 at 10:58:29AM -0400, Neil Horman wrote: > On Tue, Sep 23, 2014 at 11:39:29AM +0100, Sergio Gonzalez Monroy wrote: > > Hi Neil, > > > > On Mon, Sep 15, 2014 at 03:23:48PM -0400, Neil Horman wrote: > > > Add initial pass header file

[dpdk-dev] [PATCH 1/4 v2] compat: Add infrastructure to support symbol versioning

2014-09-26 Thread Sergio Gonzalez Monroy
On Thu, Sep 25, 2014 at 02:52:32PM -0400, Neil Horman wrote: > Add initial pass header files to support symbol versioning. > > --- > Change notes > v2) > * Fixed ifdef in rte_compat.h to test for RTE_BUILD_SHARED_LIB instead of the > non-existant RTE_SYMBOL_VERSIONING > > * Fixed VERSION_SYMBOL m

[dpdk-dev] [PATCH 1/4 v2] compat: Add infrastructure to support symbol versioning

2014-09-26 Thread Sergio Gonzalez Monroy
On Fri, Sep 26, 2014 at 11:16:30AM -0400, Neil Horman wrote: > On Fri, Sep 26, 2014 at 03:16:08PM +0100, Sergio Gonzalez Monroy wrote: > > On Thu, Sep 25, 2014 at 02:52:32PM -0400, Neil Horman wrote: > > > Add initial pass header files to support symbol versioning. > > &

[dpdk-dev] [PATCH 1/4 v3] compat: Add infrastructure to support symbol versioning

2014-09-30 Thread Sergio Gonzalez Monroy
On Mon, Sep 29, 2014 at 11:44:03AM -0400, Neil Horman wrote: > Add initial pass header files to support symbol versioning. > > --- > Change notes > v2) > * Fixed ifdef in rte_compat.h to test for RTE_BUILD_SHARED_LIB instead of the > non-existant RTE_SYMBOL_VERSIONING > > * Fixed VERSION_SYMBOL m

[dpdk-dev] [PATCH v3 5/5] mk: update LDLIBS for app building

2015-04-08 Thread Sergio Gonzalez Monroy
. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.app.mk | 54 ++ 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index e8630b6..2d6b2ca 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -59,7 +59,30

[dpdk-dev] [PATCH v3 0/5] Enhance build process

2015-04-08 Thread Sergio Gonzalez Monroy
between eal, malloc, mempool and ring libraries. Instead, add DT_NEEDED entries for all libraries but eal, then for application linking, always link against these libraries by preceding them with --no-as-needed flag. Sergio Gonzalez Monroy (5): mk: remove combined library and related

[dpdk-dev] [PATCH v3 2/5] mk: always generate combined lib linker script

2015-04-08 Thread Sergio Gonzalez Monroy
After the patch, building DPDK will always generate a linker script (name use is based on CONFIG_RTE_LIBNAME config option) that behaves as a combined library when linking against it. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.combinedlib.mk | 89

[dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options

2015-04-08 Thread Sergio Gonzalez Monroy
removes CONFIG_RTE_BUILD_COMBINE_LIB build config option and removes the makefiles associated with building a combined library. The CONFIG_RTE_LIBNAME config option is kept as it will be use to always generate a linker script that acts as a single combined library. Signed-off-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v3 4/5] mk: use LDLIBS when linking shared libraries

2015-04-08 Thread Sergio Gonzalez Monroy
enable (D). Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index d96101a..603badf 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -62,16 +62,19 @@ build: _postbuild exe2cmd

[dpdk-dev] [PATCH v3 3/5] lib: set LDLIBS for each library

2015-04-08 Thread Sergio Gonzalez Monroy
: Sergio Gonzalez Monroy --- lib/librte_acl/Makefile | 2 ++ lib/librte_cfgfile/Makefile | 2 ++ lib/librte_cmdline/Makefile | 2 ++ lib/librte_distributor/Makefile | 2 ++ lib/librte_eal/bsdapp/eal/Makefile | 2 ++ lib/librte_eal/linuxapp/eal/Makefile | 2 ++ lib

[dpdk-dev] [PATCH 0/3] Add DT_NEEDED entries to shared libs

2015-04-15 Thread Sergio Gonzalez Monroy
. More on this can be read in: http://dpdk.org/ml/archives/dev/2015-January/011927.html Sergio Gonzalez Monroy (3): lib: set LDLIBS for each library mk: use LDLIBS when linking shared libraries mk: update app linking flags against shared libs lib/librte_acl/Makefile | 2

[dpdk-dev] [PATCH 3/3] mk: update app linking flags against shared libs

2015-04-15 Thread Sergio Gonzalez Monroy
Use flag --as-needed when linking against shared libs, exluding eal, malloc, mempool and ring as explained in: 7cee5f6b4a9b ("lib: set LDLIBS for each library") Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.app.mk | 36 1 file changed, 20

[dpdk-dev] [PATCH 1/3] lib: set LDLIBS for each library

2015-04-15 Thread Sergio Gonzalez Monroy
does not directly use mempool (therefore no DT_NEEDED entry). In such case, the application will fail to start as eal does not have a DT_NEEDED entry for mempool either. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_acl/Makefile | 2 ++ lib/librte_cfgfile/Makefile

[dpdk-dev] [PATCH 2/3] mk: use LDLIBS when linking shared libraries

2015-04-15 Thread Sergio Gonzalez Monroy
Set proper DT_NEEDED entries for shared libraries by explicitly linking against its dependent libraries (LDLIBS). Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 0d7482d..5d0988f

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add support for SHA256 HMAC

2017-01-13 Thread Sergio Gonzalez Monroy
: Zbigniew Bodek --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v2] eal: Support running as unprivileged user

2017-01-18 Thread Sergio Gonzalez Monroy
On 03/01/2017 22:56, Ben Walker wrote: For Linux kernel 4.0 and newer, the ability to obtain physical page frame numbers for unprivileged users from /proc/self/pagemap was removed. Instead, when an IOMMU is present, simply choose our own DMA addresses instead. Signed-off-by: Ben Walker @@ -255,

[dpdk-dev] [PATCH] eal: remove single file segments related code

2016-09-30 Thread Sergio Gonzalez Monroy
s said, since this feature had been introduced with ivshmem > 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"), > if Sergio has nothing against this removal, I am all for removing > unused code. I certainly do not have anything against this removal :) Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-05 Thread Sergio Gonzalez Monroy
On 04/01/2017 21:34, Walker, Benjamin wrote: On Wed, 2017-01-04 at 19:39 +0800, Tan, Jianfeng wrote: Hi Benjamin, On 12/30/2016 4:41 AM, Walker, Benjamin wrote: DPDK today begins by allocating all of the required hugepages, then finds all of the physical addresses for those hugepages using /p

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-05 Thread Sergio Gonzalez Monroy
On 05/01/2017 10:09, Sergio Gonzalez Monroy wrote: On 04/01/2017 21:34, Walker, Benjamin wrote: On Wed, 2017-01-04 at 19:39 +0800, Tan, Jianfeng wrote: Hi Benjamin, On 12/30/2016 4:41 AM, Walker, Benjamin wrote: DPDK today begins by allocating all of the required hugepages, then finds all

[dpdk-dev] [PATCH] app/crypto-perf: fix digest data for chained mbufs

2017-06-30 Thread Sergio Gonzalez Monroy
Use corect mbuf segment for chained mbufs. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") CC: sta...@dpdk.org Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_ops.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletion

[dpdk-dev] [PATCH] app/crypto-perf: set crypto op pool cache

2017-06-30 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_test_latency.c| 2 +- app/test-crypto-perf/cperf_test_throughput.c | 2 +- app/test-crypto-perf/cperf_test_verify.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf

[dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk

2017-06-30 Thread Sergio Gonzalez Monroy
Use rte_mempool_put_bulk for both latency and throughput tests instead of rte_crypto_op_free to improve application performance. Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_test_latency.c| 14 -- app/test-crypto-perf/cperf_test_throughput.c | 8

Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46

2017-06-30 Thread Sergio Gonzalez Monroy
On 28/06/2017 12:48, Pablo de Lara wrote: IPSec Multi-buffer library v0.46 has been released, which includes, among othe features, support for 12-byte IV, for AES-CTR, keeping also the previous 16-byte IV, for backward compatibility reasons. Signed-off-by: Pablo de Lara --- doc/guides/cryptod

Re: [dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library

2017-06-30 Thread Sergio Gonzalez Monroy
+-- test/test/test_cryptodev_gcm_test_vectors.h | 357 12 files changed, 922 insertions(+), 223 deletions(-) Series Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux

2017-07-03 Thread Sergio Gonzalez Monroy
On 01/07/2017 15:18, Thomas Monjalon wrote: 21/06/2017 17:49, Sergio Gonzalez Monroy: I think following the discussion of libnuma dependency in another thread [1], you would need to implement a similar approach and keep the old method while providing this alternative if libnuma is present

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-11 Thread Sergio Gonzalez Monroy
On 11/07/2017 02:56, Tan, Jianfeng wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Tuesday, July 11, 2017 9:13 AM To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [RFC] pci: force address of mappings in secondary process Th

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 21:00, Stephen Hemminger wrote: On Tue, 11 Jul 2017 12:35:39 +0100 Sergio Gonzalez Monroy wrote: On 11/07/2017 02:56, Tan, Jianfeng wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Tuesday, July 11, 2017 9:13 AM To

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 12/07/2017 03:45, Tan, Jianfeng wrote: -Original Message- From: Gonzalez Monroy, Sergio Sent: Tuesday, July 11, 2017 7:36 PM To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process On 11/07/2017 02:56, Tan,

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 07:16, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any d

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread Sergio Gonzalez Monroy
On 13/07/2017 09:23, santosh wrote: Hi Sergio, On Wednesday 12 July 2017 01:50 PM, Sergio Gonzalez Monroy wrote: On 11/07/2017 07:16, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for

Re: [dpdk-dev] [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

2017-07-14 Thread Sergio Gonzalez Monroy
On 11/07/2017 20:21, Aaron Conole wrote: Aaron Conole writes: Aaron Conole writes: This series attempts to introduce the ability to start and use Open vSwitch 'out of the box' as a non-root user. It does this by modifying the service files to pass the recently introduced --ovs-user argumen

[dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
rnings for them. Instead, only check for invalid NUMA node information for devices managed by the DPDK. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/eal_common_pci.c | 5 + lib/librte_eal/linuxapp/eal/eal_pci.c | 11 +++ 2 files changed, 8 insertions(+), 8

Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
the change from one file to another. 21/07/2017 12:11, Sergio Gonzalez Monroy: Commit 8a04cb612589 ("pci: set default numa node for broken systems") added logic to default to NUMA node 0 when sysfs numa_node information was wrong or not available. Unfortunately there are many devices

Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
On 21/07/2017 16:37, Thomas Monjalon wrote: 21/07/2017 18:03, Sergio Gonzalez Monroy: On 21/07/2017 15:53, Thomas Monjalon wrote: The title and the text below should explain that you move the warning log from scan to probe, thanks to a temporary negative value. I thought that saying that I

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-28 Thread Sergio Gonzalez Monroy
On 12/07/2017 21:15, Jan Blunck wrote: This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] cryptodev: fix NULL pointer dereference

2017-07-31 Thread Sergio Gonzalez Monroy
mory for crypto driver %u\n", + nb_drivers); + driver->driver = drv; driver->id = nb_drivers; Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is safer to allocate this memory statically in each PMD, so driver registration will never fail

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 01/08/2017 10:35, Thomas Monjalon wrote: 01/08/2017 10:13, Sergio Gonzalez Monroy: On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is

Re: [dpdk-dev] Use rte_malloc in application

2017-08-03 Thread Sergio Gonzalez Monroy
On 03/08/2017 07:12, Rohit Saini (Stellus) wrote: With below code, I am getting this warning. warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] my_node_t *data_ptr = (my_node_t *) rte_malloc(NULL, sizeof(my_node_t), 0); As far as I can see, the syntax looks corre

Re: [dpdk-dev] Is contiguous hugepages memory still required in latest DPDKs?

2017-03-21 Thread Sergio Gonzalez Monroy
The DPDK will still try to allocate contiguous hugepages. Since DPDK v16.07 the mempool library is able to create a mempool with multiple chunks of memory. You would still have the contig memory restriction for any other DPDK library or app. Are you pre-allocating hugepages on boot (kernel cmd

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp

2017-03-23 Thread Sergio Gonzalez Monroy
->tbl[cdev_id_qp].qp); Guideline is to keep error strings in single line to facilitate grep. Other than that: Acked-by: Sergio Gonzalez Monroy + return -1; + } + } sa->cdev_id_qp = cdev_id_qp; return 0;

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp

2017-03-23 Thread Sergio Gonzalez Monroy
On 23/03/2017 10:38, Akhil Goyal wrote: On 3/23/2017 4:00 PM, Sergio Gonzalez Monroy wrote: That was simpler than I thought. For some reason I understood that the device will support thousands of queues and single session per queue which would have needed more app changes. On 23/03/2017 08:06

Re: [dpdk-dev] Is contiguous hugepages memory still required in latest DPDKs?

2017-03-23 Thread Sergio Gonzalez Monroy
On 23/03/2017 16:24, Ruslan Bilovol wrote: On 03/22/2017 02:08 PM, Ruslan Bilovol wrote: On 03/21/2017 04:41 PM, Sergio Gonzalez Monroy wrote: The DPDK will still try to allocate contiguous hugepages. Since DPDK v16.07 the mempool library is able to create a mempool with multiple chunks of

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-27 Thread Sergio Gonzalez Monroy
On 09/03/2017 12:57, Ilya Maximets wrote: On 08.03.2017 16:46, Sergio Gonzalez Monroy wrote: Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quot

[dpdk-dev] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function

2017-03-29 Thread Sergio Gonzalez Monroy
doing enqueue/dequeue. This patch moves the crypto operation to the dequeue function which fixes the above issue without having to check for the number of free entries in the ring. Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations") Signed-off-by: Sergio Gonza

Re: [dpdk-dev] [PATCH] eal/linux: fix multi-process cannot work

2017-03-29 Thread Sergio Gonzalez Monroy
ist, next) { - if (memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr))) + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr, +&dev->addr)) continue; break; } Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v2 0/9] Crypto performance app improvements

2017-03-29 Thread Sergio Gonzalez Monroy
/crypto-perf: display results in test runner app/crypto-perf: add range/list of sizes app/crypto-perf: add extra option checks app/crypto-perf: reorg options structure Sergio Gonzalez Monroy (1): app/crypto-perf: move verify as single test type app/test-crypto-perf/Makefile

Re: [dpdk-dev] [PATCH] crypto/scheduler: add get attached slaves API

2017-03-29 Thread Sergio Gonzalez Monroy
On 21/02/2017 15:14, Fan Zhang wrote: This patch adds an API to get the run-time slaves number and list of a cryptodev scheduler PMD. Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 31 ++ drivers/crypto/scheduler/rte_cryptodev_scheduler.

Re: [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address

2017-03-31 Thread Sergio Gonzalez Monroy
On 31/03/2017 16:56, Andrew Rybchenko wrote: PCI address structure has padding which may have garbage. Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- It is a real bug which I've hit during multi-process debugging. lib/librte_ea

Re: [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address

2017-03-31 Thread Sergio Gonzalez Monroy
On 31/03/2017 17:18, Andrew Rybchenko wrote: On 03/31/2017 07:09 PM, Sergio Gonzalez Monroy wrote: On 31/03/2017 16:56, Andrew Rybchenko wrote: PCI address structure has padding which may have garbage. Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] cryptodev - Session and queue pair relationship

2017-02-14 Thread Sergio Gonzalez Monroy
Hi Akhil, Thanks for your feedback Declan, The suggestion from Fiona looks good. Should I send the patch for this or is it already in discussion in some different thread? Also, if this new API is added, there would be corresponding change in the ipsec-secgw application as well. I am look

Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user

2017-02-17 Thread Sergio Gonzalez Monroy
--- lib/librte_eal/common/eal_private.h | 12 + lib/librte_eal/linuxapp/eal/eal_memory.c | 75 +++- lib/librte_eal/linuxapp/eal/eal_pci.c| 6 ++- 3 files changed, 71 insertions(+), 22 deletions(-) Acked-by: Sergio Gonzalez Monroy PS: Please keep a summary

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-08 Thread Sergio Gonzalez Monroy
Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quota limit on hugetlbfs mount point. I would be inclined towards *adding libnuma as dependency* to DPDK to m

Re: [dpdk-dev] rte_malloc_heap usage scenario

2017-03-14 Thread Sergio Gonzalez Monroy
On 09/03/2017 04:48, Yerden Zhumabekov wrote: Hello, Can anybody explain why rte_malloc_heap.h is advertised as a public interface? It only contains malloc_heap struct which is used internally and violates DPDK naming conventions for public struct. I haven't found any use of it outside of EAL

[dpdk-dev] [PATCH v5 0/2] app/testpmd: improve multiprocess support

2016-10-18 Thread Sergio Gonzalez Monroy
On 30/09/2016 15:00, Marcin Kerlin wrote: > This patch ensure not overwrite device data in the multiprocess application. > > 1)Changes in the library introduces continuity in array rte_eth_dev_data[] > shared between all processes. Secondary process adds new entries in free > space instead of overw

[dpdk-dev] [PATCH v2 0/8] IPsec Enhancements

2016-09-23 Thread Sergio Gonzalez Monroy
Gonzalez Monroy (8): examples/ipsec-secgw: change CBC IV generation examples/ipsec-secgw: reset crypto operation status examples/ipsec-secgw: add AES-GCM support examples/ipsec-secgw: enable AES-CTR mode examples/ipsec-secgw: check sp only when setup examples/ipsec-secgw: cryptodev queue

[dpdk-dev] [PATCH v2 1/7] examples/ipsec-secgw: change CBC IV generation

2016-09-23 Thread Sergio Gonzalez Monroy
generate the IV. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 99 +--- examples/ipsec-secgw/ipsec.h | 34 ++- 2 files changed, 89 insertions(+), 44 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec

[dpdk-dev] [PATCH v2 2/7] examples/ipsec-secgw: reset crypto operation status

2016-09-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 1e87d0d..f49143b 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -124,6

[dpdk-dev] [PATCH v2 3/7] examples/ipsec-secgw: add AES-GCM support

2016-09-23 Thread Sergio Gonzalez Monroy
Add support for AES-GCM (Galois-Counter Mode). RFC4106: The Use of Galois-Counter Mode (GCM) in IPSec ESP. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 59 ++-- examples/ipsec-secgw/ipsec.h | 9 +++ examples/ipsec-secgw

[dpdk-dev] [PATCH v2 4/7] examples/ipsec-secgw: enable AES-CTR mode

2016-09-23 Thread Sergio Gonzalez Monroy
RFC3686: Using AES Counter (CTR) Mode With IPsec ESP.` Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 2 ++ examples/ipsec-secgw/sa.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c index 7ee53da

[dpdk-dev] [PATCH v2 5/7] examples/ipsec-secgw: check sp only when setup

2016-09-23 Thread Sergio Gonzalez Monroy
Application will segfault if there is IPv4 or IPv6 and no SP/ACL rules for IPv4 or IPv6 respectively. Avoid checking the ACL/SP in such cases. Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6") Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c |

[dpdk-dev] [PATCH v2 6/7] examples/ipsec-secgw: cryptodev queue size macro

2016-09-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 9eee96f..5a4c9b7 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b

[dpdk-dev] [PATCH v2 7/7] examples/ipsec-secgw: initialize sa salt

2016-09-23 Thread Sergio Gonzalez Monroy
This patch initializes the salt value used by the following cipher algorithms: - CBC: random salt - GCM/CTR: the key required is 20B, and the last 4B are used as salt. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/sa.c | 17 ++--- 1 file changed, 14 insertions(+), 3

[dpdk-dev] [PATCH v2 8/8] examples/ipsec-secgw: update release notes

2016-09-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/release_16_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index 373053a..12f507b 100644 --- a/doc/guides/rel_notes/release_16_11

[dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add configuration file support

2016-09-23 Thread Sergio Gonzalez Monroy
> examples/ipsec-secgw/sp4.c | 538 > examples/ipsec-secgw/sp6.c | 539 +--- > 11 files changed, 2397 insertions(+), 1319 deletions(-) > create mode 100644 examples/ipsec-secgw/parser.c > create mode 100644 examples/ipsec-secgw/parser.h Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v8 2/2] examples/ipsec-secgw: add sample configuration files

2016-09-23 Thread Sergio Gonzalez Monroy
reate mode 100644 examples/ipsec-secgw/ep1.cfg > Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH] examples/ipsec-secgw: Update checksum while decrementing ttl

2016-09-26 Thread Sergio Gonzalez Monroy
Hi Akhil, This application relies on checksum offload in both outbound and inbound paths (PKT_TX_IP_CKSUM flag). Because we assume that we always forward the packet in both paths, we decrement the ttl in both inbound and outbound. You seem to only increment (recalculate) the checksum of the inn

[dpdk-dev] [PATCH v2 8/8] examples/ipsec-secgw: update release notes

2016-09-29 Thread Sergio Gonzalez Monroy
es/ipsec-secgw: update release notes >> >> Signed-off-by: Sergio Gonzalez Monroy >> --- >> doc/guides/rel_notes/release_16_11.rst | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/doc/guides/rel_notes/release_16_11.rst >> b/doc/gui

[dpdk-dev] [PATCH v2 1/7] examples/ipsec-secgw: change CBC IV generation

2016-09-29 Thread Sergio Gonzalez Monroy
t;> This patch implements the first recommended method by using the forward >> function to generate the IV. >> >> Signed-off-by: Sergio Gonzalez Monroy > [...] > >> +static inline void * >> +get_cop(struct rte_mbuf *m) >> +{ >> +struct ipsec_mbuf_me

[dpdk-dev] [PATCH v3 0/9] IPsec Enhancements

2016-09-29 Thread Sergio Gonzalez Monroy
: add sample configuration files http://dpdk.org/dev/patchwork/patch/16003/ Sergio Gonzalez Monroy (9): examples/ipsec-secgw: change CBC IV generation examples/ipsec-secgw: reset crypto operation status examples/ipsec-secgw: add AES-GCM support examples/ipsec-secgw: enable AES-CTR mode

[dpdk-dev] [PATCH v3 2/9] examples/ipsec-secgw: reset crypto operation status

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 1e87d0d..f49143b 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -124,6

[dpdk-dev] [PATCH v3 1/9] examples/ipsec-secgw: change CBC IV generation

2016-09-29 Thread Sergio Gonzalez Monroy
generate the IV. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 99 +--- examples/ipsec-secgw/ipsec.h | 26 +++- 2 files changed, 81 insertions(+), 44 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw

[dpdk-dev] [PATCH v3 6/9] examples/ipsec-secgw: add cryptodev queue size macro

2016-09-29 Thread Sergio Gonzalez Monroy
Introduce a specific cryptodev queue size macro. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 9eee96f..5a4c9b7

[dpdk-dev] [PATCH v3 7/9] examples/ipsec-secgw: initialize sa salt

2016-09-29 Thread Sergio Gonzalez Monroy
This patch initializes the salt value used by the following cipher algorithms: - CBC: random salt - GCM/CTR: the key required is 20B, and the last 4B are used as salt. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/sa.c | 17 ++--- 1 file changed, 14 insertions(+), 3

[dpdk-dev] [PATCH v3 4/9] examples/ipsec-secgw: enable AES-CTR mode

2016-09-29 Thread Sergio Gonzalez Monroy
RFC3686: Using AES Counter (CTR) Mode With IPsec ESP.` Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 2 ++ examples/ipsec-secgw/sa.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c index 7ee53da

[dpdk-dev] [PATCH v3 3/9] examples/ipsec-secgw: add AES-GCM support

2016-09-29 Thread Sergio Gonzalez Monroy
Add support for AES-GCM (Galois-Counter Mode). RFC4106: The Use of Galois-Counter Mode (GCM) in IPSec ESP. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 59 ++-- examples/ipsec-secgw/ipsec.h | 9 +++ examples/ipsec-secgw

[dpdk-dev] [PATCH v3 5/9] examples/ipsec-secgw: check sp only when setup

2016-09-29 Thread Sergio Gonzalez Monroy
Application will segfault if there is IPv4 or IPv6 and no SP/ACL rules for IPv4 or IPv6 respectively. Avoid checking the ACL/SP in such cases. Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6") Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c |

[dpdk-dev] [PATCH v3 8/9] doc: ipsec-secgw release notes

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/release_16_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index cc507a9..168d589 100644 --- a/doc/guides/rel_notes/release_16_11

[dpdk-dev] [PATCH v3 8/9] examples/ipsec-secgw: update release notes

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/release_16_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index cc507a9..168d589 100644 --- a/doc/guides/rel_notes/release_16_11

[dpdk-dev] [PATCH v3 9/9] examples/ipsec-secgw: update ipsec-secgw guide

2016-09-29 Thread Sergio Gonzalez Monroy
Update sample guide to reflect support for new algorithms. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/sample_app_ug/ipsec_secgw.rst | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug

[dpdk-dev] [PATCH v3 9/9] doc: update ipsec-secgw sample app guide

2016-09-29 Thread Sergio Gonzalez Monroy
Update sample guide to reflect support for new algorithms. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/sample_app_ug/ipsec_secgw.rst | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug

Re: [dpdk-dev] [PATCH v2] Correctly handle malloc_elem resize with padding

2017-06-06 Thread Sergio Gonzalez Monroy
Hi Jamie, On 31/05/2017 01:16, Jamie Lavigne wrote: Currently when a malloc_elem is split after resizing, any padding present in the elem is ignored. This causes the resized elem to be too small when padding is present, and user data can overwrite the beginning of the following malloc_elem. So

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-08 Thread Sergio Gonzalez Monroy
On 08/06/2017 13:14, Bruce Richardson wrote: On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: Hi everyone, I just want to clarify current status of these patches. As I understand, moving to the new build system (for example, meson+ninja as proposed[1] by Bruce) is a very long proc

Re: [dpdk-dev] [PATCH v3] mem: fix malloc_elem resize with padding

2017-06-20 Thread Sergio Gonzalez Monroy
by including the size of the padding when computing where to split the malloc_elem. Fixes: af75078fece3 ("first public release") Signed-off-by: Jamie Lavigne --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-20 Thread Sergio Gonzalez Monroy
On 20/06/2017 15:35, Thomas Monjalon wrote: 20/06/2017 15:58, Ilya Maximets: On 20.06.2017 16:07, Thomas Monjalon wrote: 19/06/2017 13:10, Hemant Agrawal: On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: So, there are 2 option: 1. Return back config option RTE_LIBRTE_EAL_N

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-20 Thread Sergio Gonzalez Monroy
On 20/06/2017 16:41, Jerin Jacob wrote: -Original Message- Date: Tue, 20 Jun 2017 15:58:50 +0100 From: Sergio Gonzalez Monroy To: Thomas Monjalon , Ilya Maximets CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-21 Thread Sergio Gonzalez Monroy
On 21/06/2017 09:14, Hemant Agrawal wrote: On 6/20/2017 9:11 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 20 Jun 2017 15:58:50 +0100 From: Sergio Gonzalez Monroy To: Thomas Monjalon , Ilya Maximets CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson , David Marchand

Re: [dpdk-dev] [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux

2017-06-21 Thread Sergio Gonzalez Monroy
On 18/06/2017 16:52, Gregory Etelson wrote: Use get_mempolicy(2) to find numa socket on Linux instead of parsing /proc/self/numa_maps. When process maps around 1K hugepages numa_maps file can miss huge records in older Linux kernels. get_mempolicy() proved more reliable Requires numactl dev pack

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-22 Thread Sergio Gonzalez Monroy
resent. " + "Set it 0 as default\n"); + dev->device.numa_node = 0; } rte_pci_device_name(addr, dev->name, sizeof(dev->name)); The code changes look fine, so I leave it to Thomas regarding the commit message :) Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Sergio Gonzalez Monroy
On 23/06/2017 14:02, Thomas Monjalon wrote: 22/06/2017 17:15, Sergio Gonzalez Monroy: Just fyi, the summary line should be lowercase apart from acronyms (DPDK guidelines). On 11/05/2017 02:56, Tonghao Zhang wrote: The NUMA node information for PCI devices provided through sysfs is invalid for

  1   2   3   4   5   6   >