More files should be referenced in MAINTAINERS files:
- some (forgotten) docs can be co-maintained in doc and lib areas
- new ABI files
The script can now check for unknown files.
Thomas Monjalon (3):
maintainers: dispatch more doc
maintainers: add ABI versioning
scripts: check wrong
Documentation of build system, EAL and ring lib should be covered by
the maintainers of the respective areas.
Signed-off-by: Thomas Monjalon
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 12c7c16..f2b697e 100644
--- a/MAINTAINERS
+++ b
Reference the new framework and policy for ABI versioning,
in the MAINTAINERS file.
Signed-off-by: Thomas Monjalon
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f2b697e..7c0047b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -54,6 +54,9
Each F or X pattern is checked and printed if there is no match
with a file in the repository.
The wildcard must be temporarily replaced to prevent from shell expansion.
Signed-off-by: Thomas Monjalon
---
scripts/check-maintainers.sh | 20 +++-
1 file changed, 19 insertions
2015-02-04 06:43, Neil Horman:
> On Wed, Feb 04, 2015 at 10:22:50AM +0200, Panu Matilainen wrote:
> > This is all-important now that the libraries are versioned: DT_SONAME
> > presence instructs the runtime dynamic linker to load the shared object
> > by the versioned name in DT_SONAME instead of
2015-02-04 06:42, Neil Horman:
> On Wed, Feb 04, 2015 at 09:07:14AM +0200, Panu Matilainen wrote:
> > cmdline_token_portlist_ops fell through cracks in the initial symbol
> > versioning patch, breaking pktgen build.
> >
> > Signed-off-by: Panu Matilainen
> > + cmdline_token_portlist_ops;
>
Hi Jijiang,
2015-02-05 10:31, Jijiang Liu:
> I will be a volunteer of reviewing the following files:
>lib/librte_eal/linuxapp/xen_dom0/*
>lib/librte_eal/linuxapp/eal/eal_xen_memory.c
>lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
Actually, the section that you are
> More files should be referenced in MAINTAINERS files:
> - some (forgotten) docs can be co-maintained in doc and lib areas
> - new ABI files
> The script can now check for unknown files.
>
> Thomas Monjalon (3):
> maintainers: dispatch more doc
> maintai
> Signed-off-by: Yong Wang
> VMware vmxnet3
> +M: Yong Wang
> F: lib/librte_pmd_vmxnet3/
> F: doc/guides/prog_guide/poll_mode_drv_paravirtual_vmxnets_nic.rst
Acked-by: Thomas Monjalon
Could you help reviewing these patches?
http://dpdk.org/dev/patchwork/proje
> > Signed-off-by: Pablo de Lara
[...]
> > Driver testing tool
> > +M: Pablo de Lara
> > F: app/test-pmd/
> > F: doc/guides/testpmd_app_ug/
>
> Acked-by: Sergio Gonzalez Monroy
Acked-by: Thomas Monjalon
Applied, thanks
ed and pkt
> > framework
> >
> > As original author of these DPDK components, I am volunteering to maintain
> > them going forward:
> > - Traffic Metering
> > - Hierarchical Scheduler
> > - Packet Framework
> > - Configuration File
> >
> > Signed-o
> > Signed-off-by: Konstantin Ananyev
>
> Acked-by: Sergio Gonzalez Monroy
Acked-by: Thomas Monjalon
Applied, thanks
> > Signed-off-by: Bruce Richardson
>
> Acked-by: Pablo de Lara
Acked-by: Thomas Monjalon
Applied, thanks
> > Signed-off-by: Bruce Richardson
>
> Acked-by: Helin Zhang
Acked-by: Thomas Monjalon
Applied, thanks
> Claim i40e and KNI modules.
>
> Signed-off-by: Helin Zhang
Acked-by: Thomas Monjalon
Applied, thanks
2015-02-09 14:50, David Marchand:
> As discussed with Thomas, I would like to take care of the common eal and
> linux
> implementation.
>
> Signed-off-by: David Marchand
[...]
> EAL API and common code
> -M: Thomas Monjalon
> +M: David Marchand
Thank you David to as
>doc/guides/sample_app_ug/vhost.rst
> >
> > Signed-off-by: Changchun Ouyang
>
> Acked-by: Sergio Gonzalez Monroy
Acked-by: Thomas Monjalon
Applied, thanks
2015-02-09 16:18, Dumitrescu, Cristian:
> > About cfgfile, we are still waiting for the cleanup in qos_sched example:
> > http://dpdk.org/ml/archives/dev/2014-October/006774.html
> > Do you have news?
> We are working on some enhancements on librte_cfg for release 2.1, so in
> order to avoid
2015-02-09 22:40, Shankari Vaidyalingam:
> I'm trying to execute the testpmd sample appplication.
> I'm getting the below error and not able to execute the sample application.
>
> controller at controller-VirtualBox:~/software/dpdk-1.7.1$ sudo
> ./build/app/testpmd -c7 -n3 -- -i --nb-cores=2
2015-02-11 05:50, Stephen Hemminger:
> But driver needs to tell application via driver flags
I think it's done:
> + pci_dev->intr_handle.type = RTE_INTR_HANDLE_UIO;
> + pci_drv->drv_flags |= RTE_PCI_DRV_INTR_LSC;
In my understanding, Changchun chose to use ioports as a fallback if uio
is
Hi Matthew,
2015-02-11 23:06, Matthew Hall:
> Hi all,
>
> I ran into a funny situation today with the API documentation.
>
> For stability until I can get my app mostly working, I was using DPDK 1.7.X,
> so I could concentrate on making the app reliable. But the DPDK website only
> has the
2015-02-12 11:03, Panu Matilainen:
> On 02/12/2015 09:06 AM, Matthew Hall wrote:
> > Hi all,
> >
> > I ran into a funny situation today with the API documentation.
> >
> > For stability until I can get my app mostly working, I was using DPDK 1.7.X,
> > so I could concentrate on making the app
Hi Stephen,
2015-02-07 07:15, Stephen Hemminger:
> Source was from FreeBSD.
>
> changes were to make it work and lots of de-uglification.
Maintenance would be eased by showing this work with separate commits.
You should at least have a patch for importing FreeBSD source without
modifications.
2015-02-12 15:58, Panu Matilainen:
> + # see if we're building from git
> + ifneq ($(wildcard $(RTE_SDK)/.git),)
> +DEVEL_BUILD := y
> + endif
Yes it allows to force DEVEL_BUILD to any value on command line.
But please use RTE_ prefix.
2015-02-12 06:33, Stephen Hemminger:
> On Thu, 12 Feb 2015 15:00:13 +0100
> Thomas Monjalon wrote:
>
> > Hi Stephen,
> >
> > 2015-02-07 07:15, Stephen Hemminger:
> > > Source was from FreeBSD.
> > >
> > > changes were to make it work a
2015-02-11 13:30, Sergio Gonzalez Monroy:
> Common rte_eal_iopl_init function is missing from eal version map.
How did you see it?
Thanks
> rte_eal_hpet_init;
> + rte_eal_iopl_init;
> rte_eal_init;
You missed the alphabetical order, you were not so far ;)
2015-02-11 12:31, Gonzalez Monroy, Sergio:
> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> > On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote:
> > > I think that vhost is being linked in the wrong place (plugins section).
> > > The plugins only get linked when building static
> > librte_vhost is not a plugin but a library, move it to proper section to fix
> > sample app build in shared, non-combined library setup.
> >
> > Signed-off-by: Panu Matilainen
>
> Acked-by: Sergio Gonzalez Monroy
Applied, thanks
2015-02-11 21:25, Michael Qiu:
> max_vfs will only be created by igb_uio driver, for other
> drivers like vfio or pci_uio_generic, max_vfs will miss.
>
> But sriov_numvfs is not driver related, just get the vf numbers
> from that field.
>
> Signed-off-by: Michael Qiu
[...]
>
This is a small reorganization of options.
The main goal is to provide a nice --help option.
changes in v3:
- reword arguments in usage
changes in v2:
- sort also the options enum
Thomas Monjalon (2):
eal: sort and align options lists
eal: add help option
lib/librte_eal/bsdapp/eal/eal.c
Options listing in usage help was a mess.
The main usage line is fixed and shorter.
The options in usage output are logically sorted (cpu/mem/dev/proc),
aligned and lightly reworded.
The options in declarations are alphabetically sorted.
Code in swith statement is not moved.
Signed-off-by: Thomas
Help is printed with -h or --help.
Help is also printed for an unknown option.
This was broken since the rework of options.
Fixes: 489a9d6c9f77 ("merge bsd and linux common options parsing")
Signed-off-by: Thomas Monjalon
Acked-by: David Marchand
---
lib/librte_eal/bsdapp
2015-02-13 02:56, Qiu, Michael:
> On 2/13/2015 12:26 AM, Thomas Monjalon wrote:
> > 2015-02-11 21:25, Michael Qiu:
> >> max_vfs will only be created by igb_uio driver, for other
> >> drivers like vfio or pci_uio_generic, max_vfs will miss.
> >>
> >> But
2015-02-13 09:27, Panu Matilainen:
> On 02/12/2015 05:44 PM, Thomas Monjalon wrote:
> > 2015-02-11 12:31, Gonzalez Monroy, Sergio:
> >> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> >>> On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote:
> >&g
2015-02-13 12:33, Panu Matilainen:
> On 02/13/2015 11:28 AM, Thomas Monjalon wrote:
> > 2015-02-13 09:27, Panu Matilainen:
> >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote:
> >>> 2015-02-11 12:31, Gonzalez Monroy, Sergio:
> >>>> From: Panu Matilainen
2015-02-13 12:33, Panu Matilainen:
> On 02/13/2015 11:28 AM, Thomas Monjalon wrote:
> > 2015-02-13 09:27, Panu Matilainen:
> >> On 02/12/2015 05:44 PM, Thomas Monjalon wrote:
> >>> A library is considered as a plugin if there is no public API and it
> >
> > max_vfs will only be created by igb_uio driver, for other
> > drivers like vfio or pci_uio_generic, max_vfs will miss.
> >
> > But sriov_numvfs is not driver related, just get the vf numbers
> > from that field.
> >
> > Signed-off-by: Michael Qiu
>
> I can see a different solution : maybe
2015-02-13 15:39, John McNamara:
> ---
There is no signed-off.
And there is no need of a separate patch for that.
> lib/librte_ether/rte_ether_version.map |4
It appears you made some copy paste of an old example.
Please try to send something up to date.
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
Old
> +#ifdef RTE_EXEC_ENV_BAREMETAL
> +#define MAIN _main
> +#else
> +#define MAIN main
> +#endif
There is no bare metal
2015-02-13 15:39, John McNamara:
> From: Richardson, Bruce
>
> Add in support for inline processing of packets inside the RX or
> TX call. For an RX callback, what happens is that we get a set of
> packets from the NIC and then pass them to a callback function, if
> configured, to allow
2015-02-13 17:06, Thomas Monjalon:
> 2015-02-13 15:39, John McNamara:
> > From: Richardson, Bruce
> >
> > The callbacks member of the rte_eth_dev structure has been renamed
> > to intr_cbs to make it clear that it refers to callbacks from NIC
> > interrupts.
> > the port number type should be consistent with librte_cmdline,
> > else there is potential endian issue.
> >
> > Signed-off-by: Xuelin Shi
>
> Acked-by: Olivier Matz
Applied, thanks
> > Several parameters were being parsed twice in testpmd, so this patch gets
> > rid of the second parsing.
> >
> > Signed-off-by: Pablo de Lara
> >
> Acked-by: Sergio Gonzalez Monroy
Applied, thanks
> > Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> > had an incorrect range of values shown in help command line.
> >
> > Signed-off-by: Pablo de Lara
> >
> Acked-by: Sergio Gonzalez Monroy
Applied, thanks
> > Testpmd has the capability of changing the forwarding cores and ports in
> > runtime.
> > If these are changed when forwarding, two issues may be encountered:
> >
> > - If "show config fwd" is used, changes made in the core list are applied.
> > Therefore, trying to stop forwarding may hang
> > Function to get rx/tx port configuration from the PMDs was added in
> > previous release to simplify the port configuration in all sample apps,
> > but testpmd was not modified.
> >
> > This patch makes testpmd get the default rx/tx port configuration, but
> > still uses the parameters passed
2015-02-16 12:01, Panu Matilainen:
> On 02/13/2015 03:18 PM, Thomas Monjalon wrote:
> > 2015-02-13 12:33, Panu Matilainen:
> >> On 02/13/2015 11:28 AM, Thomas Monjalon wrote:
> >>> 2015-02-13 09:27, Panu Matilainen:
> >>>> On 02/12/2015 05:44
Hi,
2015-02-16 18:18, Chen Jing D:
> These changes add poll mode driver for the host interface of Intel
> Ethernet Switch FM1 Series of silicons, which integrate NIC and
> switch functionalities. The patch set include below features:
>
> 1. Basic RX/TX functions for PF/VF.
> 2. Interrupt
> > In loopback mode, it's expected force link up even when there's no cable
> > connect.
> > But in codes, setup_sfp() rewrites the related register.
> > It causes in the case 'multispeed_fiber', it can't link up without cable
> > connect.
> >
> > Signed-off-by: Cunming Liang
> Acked-by:
2015-02-16 15:16, Bruce Richardson:
> On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote:
> > Hi John,
> >
> > On 02/13/2015 04:39 PM, John McNamara wrote:
> > > From: Richardson, Bruce
> > >
> > > Example showing how callbacks can be used to insert a timestamp
> > > into each packet
> > The goal of this series is to clarify and simplify the mbuf offload API.
> >
> > - simplify the definitions of PKT_TX_IP_CKSUM and PKT_TX_IPV4, each
> > flag has now only one meaning. No impact on the code.
> >
> > - add a feature flag for OUTER_IP_CHECKSUM (from Jijiang's patches)
> >
>
2015-02-16 13:14, Tetsuya Mukawa:
> From: Michael Qiu
>
> Currently, dpdk has no ability to know which type of driver(
> vfio-pci/igb_uio/uio_pci_generic) the device used. It only can
> check whether vfio is enabled or not staticly.
>
> It really useful to have the flag, becasue different type
2015-02-16 13:14, Tetsuya Mukawa:
> To remove assumption, do like followings.
>
> This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver
> structure. The flags indicate the driver can detach devices at runtime.
> Also, remove assumption that port will not be detached.
>
> To
2015-02-16 13:14, Tetsuya Mukawa:
> This patch replaces pci_addr_comparison() and memcmp() of pci addresses by
> eal_compare_pci_addr().
>
> v8:
> - Fix pci_scan_one() to update sysfs values.
> (Thanks to Qiu, Michael and Iremonger, Bernard)
> v5:
> - Fix pci_scan_one to handle pt_driver
2015-02-16 13:14, Tetsuya Mukawa:
> This patch adds rte_eth_dev_free(). The function is used for changing an
> attached status of the device that has specified name.
>
> v6:
> - Use rte_eth_dev structure as the paramter of rte_eth_dev_free().
> v4:
> - Add parameter checking.
>
> Signed-off-by:
2015-02-16 13:14, Tetsuya Mukawa:
> The patch adds function pointer to rte_pci_driver and eth_driver
> structure. These function pointers are used when ports are detached.
> Also, the patch adds rte_eth_dev_uninit(). So far, it's not called
> by anywhere, but it will be called when port hotplug
2015-02-16 13:14, Tetsuya Mukawa:
> The patch adds following functions.
>
> - rte_eth_dev_save()
> The function is used for saving current rte_eth_dev structures.
> - rte_eth_dev_get_changed_port()
> The function receives the rte_eth_dev structures, then compare
> these with current values
2015-02-16 13:14, Tetsuya Mukawa:
> The patch adds functions for unmapping igb_uio resources. The patch is only
> for Linux and igb_uio environment. VFIO and BSD are not supported.
>
> v8:
> - Fix typo.
> (Thanks to Iremonger, Bernard)
> v5:
> - Fix pci_unmap_device() to check pt_driver.
> v4:
2015-02-16 13:14, Tetsuya Mukawa:
> This new parameter is needed to keep device type like physical or virtual.
Actually types are "PCI" and "virtual".
> Port detaching processes are different between physical and virtual.
> This parameter lets detaching function know a device type of the port.
2015-02-16 13:14, Tetsuya Mukawa:
> The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration.
This patch should be introduced earlier in the patchset.
2015-02-16 13:14, Tetsuya Mukawa:
> These functions are used for attaching or detaching a port.
> When rte_eal_dev_attach() is called, the function tries to realize the
> device name as pci address. If this is done successfully,
> rte_eal_dev_attach() will attach physical device port. If not,
2015-02-17 17:51, Tetsuya Mukawa:
> On 2015/02/17 10:48, Thomas Monjalon wrote:
> > 2015-02-16 13:14, Tetsuya Mukawa:
> >> +/* attach the new physical device, then store port_id of the device */
> >> +static int
> >> +rte_eal_dev_attach_pdev(struct
2015-02-17 00:48, Matthew Hall:
> On Feb 12, 2015, at 1:29 AM, Thomas Monjalon
> wrote:
> > Yes you can: make doc
> > For doxygen API only: make doc-api-html
> > For sphinx only: doc-guides-html.
>
> Hi Thomas,
>
> In 1.7 for me at least I found the targe
2015-02-17 12:25, Bruce Richardson:
> On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote:
> > 2015-02-16 15:16, Bruce Richardson:
> > > On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote:
> > > > Hi John,
> > > >
> >
2015-02-17 10:35, Stephen Hemminger:
> There are currently 1039 patches outstanding on DPDK.
> What is the schedule for getting these merged or resolved?
Several patches are ready to be applied in coming days.
Many patches are still waiting for closing discussions.
> I don't think it would be
2015-02-17 22:18, Chen Jing D:
> From: "Chen Jing D(Mark)"
>
> The patch set add poll mode driver for the host interface of Intel
> Ethernet Switch FM1 Series of silicons, which integrate NIC and
> switch functionalities. The patch set include below features:
>
> 1. Basic RX/TX functions
2015-02-17 15:14, Tetsuya Mukawa:
> On 2015/02/17 9:36, Thomas Monjalon wrote:
> > 2015-02-16 13:14, Tetsuya Mukawa:
> > Is uint8_t sill a good size for hotpluggable virtual device ids?
>
> I am not sure it's enough, but uint8_t is widely used in "rte_ethdev.c"
>
2015-02-17 15:14, Tetsuya Mukawa:
> On 2015/02/17 9:44, Thomas Monjalon wrote:
> > 2015-02-16 13:14, Tetsuya Mukawa:
> >> @@ -356,13 +342,24 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf)
> >>}
> >>else {
> >>struct rte_pci
2015-02-17 15:15, Tetsuya Mukawa:
> On 2015/02/17 10:11, Thomas Monjalon wrote:
> > 2015-02-16 13:14, Tetsuya Mukawa:
> >> +#ifdef ENABLE_HOTPLUG
> > Please avoid using #ifdef if not really necessary.
>
> I agree with you.
> In this case, only hotplug function
2015-02-17 19:26, Tetsuya Mukawa:
> On 2015/02/17 18:23, Thomas Monjalon wrote:
> > 2015-02-17 17:51, Tetsuya Mukawa:
> >> On 2015/02/17 10:48, Thomas Monjalon wrote:
> >>> 2015-02-16 13:14, Tetsuya Mukawa:
> >>>> +/* attach the new phys
2015-02-18 15:10, Tetsuya Mukawa:
> On 2015/02/18 10:54, Tetsuya Mukawa wrote:
> > On 2015/02/18 9:31, Thomas Monjalon wrote:
> >> 2015-02-17 15:14, Tetsuya Mukawa:
> >>> On 2015/02/17 9:36, Thomas Monjalon wrote:
> >>>> 2015-02-16 13:14, Tetsu
Hi Bernard,
2015-02-18 10:26, Iremonger, Bernard:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
> > On 2015/02/18 10:02, Thomas Monjalon wrote:
> > > 2015-02-17 15:14, Tetsuya Mukawa:
> > >> On 2015/02/17 9:44, Thomas Monjalon wrote:
>
>
> Changes since v1:
> - fix devargs tests (problem reported by Thomas)
>
> David Marchand (3):
> devargs: indent and cleanup
> devargs: remove limit on parameters length
> app/test: fix devargs tests
Acked-by: Thomas Monjalon
Applied, thanks
Hi Danny,
I wanted to apply this patchset which was reviewed. But when having a quick
overview, I've seen some strange additions.
2015-01-29 17:28, Danny Zhou:
> 1) Unify procedure to retrieve BAR resource mapping information.
> 2) Setup bus master bit in NIC's PCIe configuration space for
Hi Sergio,
2015-02-11 13:07, Sergio Gonzalez Monroy:
> This series introduces the new reorder library along with unit tests,
> sample app and a new entry in the programmers guide describing the library.
>
> The library provides reordering of mbufs based on their sequence number.
>
> As mention
> This series introduces the new reorder library along with unit tests,
> sample app and a new entry in the programmers guide describing the library.
>
> The library provides reordering of mbufs based on their sequence number.
>
> As mention in the patch describing the library, one use case is
> > Signed-off-by: Declan Doherty
>
> Acked-by: Olivier Matz
Applied, thanks
Hi Keith,
2015-02-18 17:01, Wiles, Keith:
> I just pulled the code and found a unused function error ?dump_rxd()?
>
> I had to add the ifdef around the function and remove the ifdef inside the
> function:
>
> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
> static inline void dump_rxd(union fm10k_rx_desc
> > This patch series depends of "PMD ring" patches and should be applied after
> > them
> > to run successfully.
> >
> > v4 changes
> > - Adapting to changes in the initialize_eth_header API
> > - Fix linking problem against librte_pmd_bond.so for shared libraries
> > - Patchset cleanup for
> Remove function name from warning.
>
> Signed-off-by: Pawel Wodkowski
Other patches of series were split in other series.
Applied, thanks
Hi,
2015-02-13 16:12, Declan Doherty:
> On 13/02/15 15:16, Michal Jastrzebski wrote:
> > Michal Jastrzebski (6):
> >net: changed arp_hdr struct declaration
> >bond: add link bonding mode 6 implementation
> >bond: add debug info for mode 6 link bonding
> >bond: add example
> > > Signed-off-by: Konstantin Ananyev
> > > Signed-off-by: Daniel Mrzyglod
> >
> > Acked-by: Konstantin Ananyev
>
> Acked-by: Pablo de Lara
>
> Just add that documentation should be updated for this.
Applied, thanks
> > This patch add requirements about compiler and distribution support.
> >
> > v2:
> > spelling fixes
> >
> > Signed-off-by: Daniel Mrzyglod
>
> Acked-by: Pablo de Lara
>
> Thanks Daniel!
Applied, thanks
2015-02-19 09:18, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2015-02-13 16:12, Declan Doherty:
> > > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > > Michal Jastrzebski (6):
> > > >net: changed arp_h
> @@ -152,6 +159,7 @@ struct rte_pci_device {
> uint16_t max_vfs; /**< sriov enable if not zero */
> int numa_node; /**< NUMA node connection */
> struct rte_devargs *devargs;/**< Device user arguments */
> + enum
2015-02-19 11:49, Tetsuya Mukawa:
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -109,6 +109,13 @@ DPDK_2.0 {
> rte_eth_tx_queue_setup;
> rte_eth_xstats_get;
> rte_eth_xstats_reset;
> + rte_eth_dev_allocated;
> +
2015-02-19 11:49, Tetsuya Mukawa:
> +/* attach the new virtual device, then store port_id of the device */
> +static int
> +rte_eal_dev_attach_vdev(const char *vdevargs, uint8_t *port_id)
> +{
> + char *args;
> + uint8_t new_port_id;
> + struct rte_eth_dev devs[RTE_MAX_ETHPORTS];
> +
>
2015-02-19 08:08, Neil Horman:
> On Tue, Feb 17, 2015 at 10:35:07AM -0500, Stephen Hemminger wrote:
> > There are currently 1039 patches outstanding on DPDK.
> > What is the schedule for getting these merged or resolved?
> > I don't think it would be reasonable to declare 2.0 as done
> > until the
Hi Danny,
2015-02-20 01:08, Zhou Danny:
> @@ -148,6 +151,7 @@ struct rte_pci_device {
> struct rte_pci_id id; /**< PCI ID. */
> struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI
> Memory Resource */
> struct rte_intr_handle intr_handle;
2015-02-04 10:49, Olivier Matz:
> The argument ressize contains the size of the result buffer which
> should be large enough to store the parsed result of a token. In
> this case, it should be larger or equal to sizeof(cmdline_portlist_t)
> (4 bytes), not PORTLIST_TOKEN_SIZE which is the max size
> > Building shared libraries and using virtio PMD results in undefined
> > reference to 'rte_eal_iopl_init'.
> >
> > Add missing function to eal version map.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
>
> Acked-by: Pablo de Lara
Applied, thanks
> > Variables are unsigned int but format scans for signed int.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
>
> Acked-by: Pablo de Lara
Applied, thanks
Hi Cunming,
You would have more chance to have a review by CC'ing John.
I checked your patch and have a comment below.
2015-02-12 17:08, Cunming Liang:
> Klocwork report 'req' might be used uninitialized.
> In some cases it can 'goto error' when '*internals' not been set.
> The result is
2015-02-20 10:06, Bruce Richardson:
> On Thu, Feb 19, 2015 at 05:56:41PM +, John McNamara wrote:
> > From: Richardson, Bruce
> >
> > Add optional support for inline processing of packets inside the RX
> > or TX call. For an RX callback, what happens is that we get a set of
> > packets from
> e1000 is little endian, but cpu maybe not.
> add necessary conversions.
>
> rte_cpu_to_le_32(...) for PCI write
> rte_le_to_cpu_32(...) for PCI read.
>
> Signed-off-by: Xuelin Shi
Acked-by: Thomas Monjalon
Applied, thanks
> ixgbe is little endian, but cpu maybe not.
> add necessary conversions.
> rte_cpu_to_le_32(...) for PCI write
> rte_le_to_cpu_32(...) for PCI read.
>
> Signed-off-by: Xuelin Shi
Acked-by: Thomas Monjalon
Applied, thanks
Anyone to review this patch?
2015-02-11 14:49, xuelin.shi at freescale.com:
> From: Xuelin Shi
>
> make sure:
> CPU read from ixgbe with IXGBE_LE32_TO_CPUS
> CPU write to ixgbe with IXGBE_CPU_TO_LE32
>
> otherwise, there is endian issue for ixgbe on BIG_ENDIAN CPU.
>
>
> When the vector pmd was receiving a mix of packets of various sizes,
> some of which were split across multiple mbufs, there was an issue
> with reassembly of the jumbo frames. This was due to a skipped increment
> when using "continue" in a while loop. Changing the loop to a "for"
> loop fixes
2015-01-30 00:31, Thomas Monjalon:
> CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is a prerequisite
> of CONFIG_RTE_IXGBE_INC_VECTOR.
>
> Reported-by: Alexander Belyakov
> Signed-off-by: Thomas Monjalon
Applied
2015-02-17 15:52, Pablo de Lara:
> rx_fc_en and tx_fc_en in cmd_link_flow_ctrl_set_parsed
> could be used without being initialized.
>
> Signed-off-by: Pablo de Lara
Applied, thanks
1 - 100 of 5912 matches
Mail list logo