[PATCH] doc: add build_root to STRIP_FROM_PATH

2021-11-22 Thread Timothy Redaelli
commit adds builddir to STRIP_FROM_PATH in order to avoid generating html files that includes it. Fixes: a6090630f4e5 ("doc: automate examples file list for API") Cc: ferruh.yi...@intel.com Signed-off-by: Timothy Redaelli --- doc/api/doxy-api.conf.in | 1 + doc/api/meson.build | 1

Re: [PATCH] doc: add build_root to STRIP_FROM_PATH

2021-11-22 Thread Timothy Redaelli
Fixing the mail address of Thomas Monjalon in To. I used ./devtools/get-maintainer.sh, but it returned the old mail address. On Mon, Nov 22, 2021 at 9:17 PM Timothy Redaelli wrote: > > examples.dox is built inside builddir and so doxygen generates some > dir_HASH.html that includes the

[PATCH v2] doc: add examples.dox path to STRIP_FROM_PATH

2021-11-23 Thread Timothy Redaelli
. This commit adds builddir/doc/api (the path where examples.dox is generated) to STRIP_FROM_PATH, so the generated documentation doesn't change if builddir changes. Fixes: a6090630f4e5 ("doc: automate examples file list for API") Cc: ferruh.yi...@intel.com Cc: sta...@dpdk.org Signed-

[dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora

2017-07-28 Thread Timothy Redaelli
Fedora and RHEL dpdk-devel package installs rte_version.h inside $RTE_INCLUDE (/usr/include/dpdk) instead of $RTE_SDK Signed-off-by: Timothy Redaelli --- tools/dpdk-version.sh | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/dpdk-version.sh b/tools

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Timothy Redaelli
On Mon, 01 Oct 2018 10:46:02 +0100 Luca Boccassi wrote: > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > > Allow users and packagers to

Re: [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY

2018-10-05 Thread Timothy Redaelli
d-off-by: Luca Boccassi > --- Acked-by: Timothy Redaelli

Re: [dpdk-dev] [PATCH v4 2/2] build: add drivers_install_subdir meson option

2018-10-05 Thread Timothy Redaelli
On Tue, 2 Oct 2018 17:20:46 +0100 Luca Boccassi wrote: > Allow users and packagers to override the default dpdk/drivers > subdirectory where the PMDs get installed under $lib. > > Signed-off-by: Luca Boccassi > --- Acked-by: Timothy Redaelli

[dpdk-dev] [PATCH] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-16 Thread Timothy Redaelli
with rte_crypto and rte_hash only when cryptodev is enabled. Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev") Fixes: d090c7f86a76 ("vhost/crypto: update makefile") Signed-off-by: Timothy Redaelli --- lib/librte_vhost/Makefile | 4 ++-- 1 file changed, 2 insertions

[dpdk-dev] [PATCH v2] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-16 Thread Timothy Redaelli
with rte_crypto and rte_hash only when cryptodev is enabled. Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev") Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli Reviewed-by: Maxime Coquelin ---

[dpdk-dev] [PATCH] net/qede: fix crash when configure fails

2018-11-09 Thread Timothy Redaelli
tiple port reconfig") Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- drivers/net/qede/qede_rxtx.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 8a4772f46..296189107 100644 ---

Re: [dpdk-dev] [PATCH v2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Timothy Redaelli
thout this commit, if you link OVS as shared library (--enable-shared), you'll also have this annoying message every time you open a new (bash) shell, as user, due to OVS bash-completion: [tredaell@aldebaran ~]$ bash rte_virtio_pmd_init(): IOPL call failed - cannot use virtio PMD rte_virt

Re: [dpdk-dev] Fedora 28 fails DPDK 18.11 on Azure/Hyper-V

2018-11-26 Thread Timothy Redaelli
On Mon, 26 Nov 2018 13:30:46 -0800 Stephen Hemminger wrote: > Started testing DPDK support of Hyper-V in Fedora and discovered that it > doesn't work. > Looks like the multiq qdisc is not in the default Fedora kernel configuration. > Hopefully CentOS/RHEL don't have the same problem. > > Not su

[dpdk-dev] [PATCH] mk: don't install meson.build in usertools

2018-11-27 Thread Timothy Redaelli
In commit 7dd34c71de2a ("usertools: install with meson") meson.build was added in usertools directory and so it's copied to $(datadir)/usertools with "make install". This patch avoids to copy meson.build when installing usertools with "make install". Signe

[dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library

2018-07-31 Thread Timothy Redaelli
Stripping binaries at build time is usually a bad thing since it makes impossible to generate (split) debug symbols and this can lead to a more difficult debugging. CC: Adrien Mazarguil Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") Signed-off-by: Timoth

[dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library

2018-07-31 Thread Timothy Redaelli
Stripping binaries at build time is usually a bad thing since it makes impossible to generate (split) debug symbols and this can lead to a more difficult debugging. CC: Adrien Mazarguil Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in") Signed-off-by: Timoth

Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir

2018-09-12 Thread Timothy Redaelli
ild: symlink drivers to library directory") > Cc: sta...@dpdk.org > > Signed-off-by: Luca Boccassi Tested on Fedora 28 by building dpdk using meson from a spec file Tested-by: Timothy Redaelli

Re: [dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

2018-09-18 Thread Timothy Redaelli
Richardson Tried to build using meson 0.42.1 and it builds correctly Tested-by: Timothy Redaelli

Re: [dpdk-dev] [PATCH v2] doc: support building HTML guides with meson

2018-09-20 Thread Timothy Redaelli
On Wed, 19 Sep 2018 14:48:27 +0100 Luca Boccassi wrote: > From: Bruce Richardson > > Signed-off-by: Bruce Richardson > Signed-off-by: Luca Boccassi > --- > v2: send on behalf of Bruce on request. > - tell sphinx to create .doctrees working files in the > parent of the target directo

Re: [dpdk-dev] [PATCH v3] doc: support building HTML guides with meson

2018-09-20 Thread Timothy Redaelli
On Thu, 20 Sep 2018 14:22:08 +0100 Luca Boccassi wrote: > From: Bruce Richardson > > Signed-off-by: Bruce Richardson > Signed-off-by: Luca Boccassi Tested on Fedora 28 (sphinx 1.7.5) and RHEL 7.5 (sphinx 1.1.3) Tested-by: Timothy Redaelli

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for meson version

2019-01-16 Thread Timothy Redaelli
s_process`` will get a new parameter >for returning key match count. It will ease handling of no-match case. > Acked-by: Timothy Redaelli

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Timothy Redaelli
On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: > > Hi all, > > > > Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: > > > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > > lib/librte_vhost/fd

[dpdk-dev] [PATCH] app/testpmd: Fix relative rpath for drivers

2017-09-20 Thread Timothy Redaelli
This commit fixes the setting of relative rpath on dpdk-testpmd for drivers ($libdir/dpdk/drivers) to the correct absolute rpath ($prefix$libdir/dpdk/drivers) Fixes: d123bba2dfbe ("build: add initial infrastructure for meson & ninja builds") Signed-off-by: Timothy Redaelli ---

[dpdk-dev] [PATCH] app/testpmd: Remove xenvirt again

2017-11-17 Thread Timothy Redaelli
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Signed-off-by: Timothy Redaelli --- app/test-pmd/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index d21308fcd..4993c9184 100644 --- a/ap

[dpdk-dev] [PATCH] app/testpmd: link with virtio PMD when using shared libraries

2017-11-17 Thread Timothy Redaelli
testpmd is often used inside a VM to test the OVS PVP scenario. This commit makes testpmd to link to virtio PMD when DPDK is built as shared libraries too. Signed-off-by: Timothy Redaelli --- app/test-pmd/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/Makefile b

Re: [dpdk-dev] [PATCH] app/testpmd: link with virtio PMD when using shared libraries

2017-11-30 Thread Timothy Redaelli
On Wed, 29 Nov 2017 23:23:40 +0100 Thomas Monjalon wrote: > 20/11/2017 11:27, Eelco Chaudron: > > On 17/11/17 17:19, Timothy Redaelli wrote: > > > testpmd is often used inside a VM to test the OVS PVP scenario. > > > This commit makes testpmd to link to virtio PMD

Re: [dpdk-dev] [PATCH v2] net/mlx: fix rdma-core glue path with EAL plugins

2018-03-02 Thread Timothy Redaelli
helpers, not actual DPDK plug-ins. > > Fixes: f6242d0655cd ("net/mlx: make rdma-core glue path configurable") > Cc: sta...@dpdk.org > > Reported-by: Timothy Redaelli > Signed-off-by: Adrien Mazarguil Tested-by: Timothy Redaelli Tested with and without libibverbs

[dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build

2020-07-01 Thread Timothy Redaelli
ned-off-by: Timothy Redaelli --- app/test/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/meson.build b/app/test/meson.build index 5233ead46..476b332cb 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -424,7 +424,8 @@ dpdk_test = executable(

Re: [dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build

2020-07-02 Thread Timothy Redaelli
On Thu, 2 Jul 2020 10:16:48 +0100 Bruce Richardson wrote: > On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote: > > This commit fixes the setting of relative rpath on dpdk-test for > > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath > > ($p

[dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") Cc: ano...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Timoth

[dpdk-dev] [PATCH 0/3] fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
on is useful on targets for which it provides better performance, or if you wish to verify that the program will work on other systems that always treat uninitialized variable definitions this way. from gcc man page Timothy Redaelli (3): crypto/octeontx2: fix building with GCC 10 app/test

[dpdk-dev] [PATCH 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 08e0c7581468 ("test/fib: add performance autotests") Cc: vladimir.medved...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timoth

[dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
on is useful on targets for which it provides better performance, or if you wish to verify that the program will work on other systems that always treat uninitialized variable definitions this way. from gcc man page Timothy Redaelli (3): examples/vhost_blk: fix building with GCC 10 exa

[dpdk-dev] [PATCH 1/3] examples/vhost_blk: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: jin...@intel.com Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
Fixes: 3d1b33e44ae2 ("examples/eventdev: move common data into pipeline common") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- examples/eventdev_pipeline/main.c| 2 ++ examples/eventdev_pipeline/pipeline_common.h | 4 ++-- 2 files

[dpdk-dev] [PATCH 3/3] examples/qos_sched: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
ned-off-by: Timothy Redaelli --- examples/qos_sched/cfg_file.c | 3 +++ examples/qos_sched/main.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c index 5714c3f36..f078e4f7d 100644 --- a/examples/qos_sched/

[dpdk-dev] [PATCH] test: fix build without timer

2019-07-04 Thread Timothy Redaelli
The action for timer_secondary_spawn_wait should be enabled only when CONFIG_RTE_LIBRTE_TIMER is enabled. Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") Cc: erik.g.carri...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- app/test/test.c

[dpdk-dev] [PATCH] usertools: Fix clearing any old data

2019-05-31 Thread Timothy Redaelli
Currently clear_data (dpdk-devbind.py) doesn't work as expected since "global devices" is missing and so "devices" is considered a local variable. This commit changes "clear_data" function in order to really clear devices by adding "global devices".

[dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL

2020-11-24 Thread Timothy Redaelli
at by checking for .so.ABI_VERSION that should be available on any linux distribution. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Timothy Redaelli (2): eal: fix shared lib mode detection eal: fix loading of shared libs from driver plugin directories lib/librt

[dpdk-dev] [PATCH 1/2] eal: fix shared lib mode detection

2020-11-24 Thread Timothy Redaelli
7871dde01 ("eal: restrict default plugin path to shared lib mode") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- lib/librte_eal/common/eal_common_options.c | 3 ++- lib/librte_eal/common/meson.build | 2 ++ 2 files changed, 4 insertions(+),

[dpdk-dev] [PATCH 2/2] eal: fix loading of shared libs from driver plugin directories

2020-11-24 Thread Timothy Redaelli
s from driver plugin directories") Cc: bruce.richard...@intel.com Signed-off-by: Timothy Redaelli --- lib/librte_eal/common/eal_common_options.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_o