[PATCH] fib: fix adding default route overwriting entire table

2023-10-02 Thread Vladimir Medvedkin
;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/fib/dir24_8.c b/lib/fib/dir24_8.c index 3efdcb533c..5f73b8a7f0 100644 --- a/lib/fib/dir24_8.c +++ b/lib/fib/dir24_8.c @@ -388,6 +388,12 @@ modify_

[PATCH] fib6: fix adding default route as first route

2023-10-02 Thread Vladimir Medvedkin
rg Signed-off-by: Vladimir Medvedkin --- lib/fib/trie.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 3e780afdaf..09470e7287 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -451,6 +451,14 @@ get_nxt_net(uint8_t *i

[dpdk-dev] [PATCH v5 0/5] Predictable RSS feature

2021-04-19 Thread Vladimir Medvedkin
fields to rte_thash_subtuple_helper struct - fixed typos Vladimir Medvedkin (5): hash: add predictable RSS API hash: add predictable RSS implementation test/hash: add additional thash tests doc: add thash documentation maintainers: claim maintainership of the hash library M

[dpdk-dev] [PATCH v5 1/5] hash: add predictable RSS API

2021-04-19 Thread Vladimir Medvedkin
This patch adds predictable RSS API. It is based on the idea of searching partial Toeplitz hash collisions. Signed-off-by: Vladimir Medvedkin Acked-by: Yipeng Wang --- lib/librte_hash/meson.build | 3 +- lib/librte_hash/rte_thash.c | 109 lib/librte_hash/rte_thash.h

[dpdk-dev] [PATCH v5 2/5] hash: add predictable RSS implementation

2021-04-19 Thread Vladimir Medvedkin
This patch implements predictable RSS functionality. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Yipeng Wang --- lib/librte_hash/rte_thash.c | 619 ++-- 1 file changed, 596 insertions(+), 23 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v5 4/5] doc: add thash documentation

2021-04-19 Thread Vladimir Medvedkin
Adds documentation for the Toeplitz hash library Signed-off-by: Vladimir Medvedkin Reviewed-by: Konstantin Ananyev Reviewed-by: John McNamara --- doc/guides/prog_guide/img/predictable_snat_1.svg | 1444 + doc/guides/prog_guide/img/predictable_snat_2.svg | 1444

[dpdk-dev] [PATCH v5 3/5] test/hash: add additional thash tests

2021-04-19 Thread Vladimir Medvedkin
This patch adds tests for predictable RSS feature. Signed-off-by: Vladimir Medvedkin Acked-by: Yipeng Wang --- app/test/test_thash.c | 469 +- 1 file changed, 463 insertions(+), 6 deletions(-) diff --git a/app/test/test_thash.c b/app/test

[dpdk-dev] [PATCH v5 5/5] maintainers: claim maintainership of the hash library

2021-04-19 Thread Vladimir Medvedkin
Claim maintainership of the hash library. Signed-off-by: Vladimir Medvedkin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2550d95..35a87e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1430,8 +1430,10 @@ Hashes M: Yipeng Wang M: Sameh

[dpdk-dev] [PATCH] hash: fix tuple adjustment

2021-05-04 Thread Vladimir Medvedkin
: 28ebff11c2dc ("hash: add predictable RSS") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.c | 121 1 file changed, 100 insertions(+), 21 deletions(-) diff --git a/lib/librte_hash/rte_thash.c b/lib/l

[dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-04 Thread Vladimir Medvedkin
: 28ebff11c2dc ("hash: add predictable RSS") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 121 ++- 1 file changed, 100 insertions(+), 21 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/r

[dpdk-dev] [PATCH v3] hash: fix tuple adjustment

2021-05-06 Thread Vladimir Medvedkin
: 28ebff11c2dc ("hash: add predictable RSS") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin Acked-by: Yipeng Wang Tested-by: Stanislaw Kardach Reviewed-by: Stanislaw Kardach --- Notes: v3: - fix comment v2: - fix path from lib/librte_hash/ to lib/hash/

[PATCH] net/ice: fix possible memory leak

2024-07-11 Thread Vladimir Medvedkin
ng in RSS") Cc: ting...@intel.com Cc:sta...@dpdk.org Reported-by: Michael Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/d

[PATCH v2 1/3] net/ice: fix possible memory leak

2024-07-15 Thread Vladimir Medvedkin
l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..913f54fca4 100644 --- a/drivers/net/ice/ice_ha

[PATCH v2 2/3] net/ice: refactor raw pattern parsing function

2024-07-15 Thread Vladimir Medvedkin
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 913f54fca4..00503d0d28

[PATCH v2 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-15 Thread Vladimir Medvedkin
ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 00503d0d28..13a68b8f02 100644 --- a/drivers/net/ice/ice_hash.c +++

Re: IPv6 APIs rework

2024-07-18 Thread Vladimir Medvedkin
Hi Robin, Thanks, that is a good idea. чт, 18 июл. 2024 г. в 21:27, Morten Brørup : > > From: Robin Jarry [mailto:rja...@redhat.com] > > > > Hi folks, > > > > while working on IPv6 support for grout [1], I noticed that all DPDK > > IPv6 APIs used fixed sized arrays in the route lookup functio

[PATCH v3 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Vladimir Medvedkin
l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..cdce1d0ea2 100644 --- a/drivers/net/ice/ice_ha

[PATCH v3 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index cdce1d0ea2..d63e673b25

[PATCH v3 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index d63e673b25..b040a198bb 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v4 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Vladimir Medvedkin
l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..6b3095e2c5 100644 --- a/drivers/net/ice/ice_ha

[PATCH v4 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 6b3095e2c5..506ea261e8

[PATCH v4 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 506ea261e8..1188962752 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v5 1/3] net/ice: fix possible memory leak

2024-07-22 Thread Vladimir Medvedkin
l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..6b3095e2c5 100644 --- a/drivers/net/ice/ice_ha

[PATCH v5 2/3] net/ice: refactor raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin tmp --- drivers/net/ice/ice_hash.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 6b3095e2c5

[PATCH v5 3/3] net/ice: fix return value for raw pattern parsing function

2024-07-22 Thread Vladimir Medvedkin
ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index aa76718313..b720e0f755 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH] doc: announce fib configuration structure changes

2024-07-26 Thread Vladimir Medvedkin
Announce addition of the flags field into rte_fib_conf structure. Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6948641ff6

[PATCH] examples/ipsec-secgw: revert fix SA salt endianness

2024-07-29 Thread Vladimir Medvedkin
shihong.w...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 2 +- examples/ipsec-secgw/sa.c| 13 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ips

[PATCH] test/ipsec: fix performance test failure

2022-06-17 Thread Vladimir Medvedkin
mance cases") Cc: savinay.dharma...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_ipsec_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c index 346a851648..580cad00f6 10064

[PATCH v2] test/ipsec: fix performance test failure

2022-06-21 Thread Vladimir Medvedkin
mance cases") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- Notes: v2: - fix gcc4 warnings app/test/test_ipsec_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c index 346a851648..11de9a6

[dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-04-06 Thread Vladimir Medvedkin
just_tuple() - added extra fields to rte_thash_subtuple_helper struct - fixed typos Vladimir Medvedkin (3): hash: add predictable RSS API hash: add predictable RSS implementation test/hash: add additional thash tests app/test/test_thash.c | 468 +++- lib/l

[dpdk-dev] [PATCH v2 1/3] hash: add predictable RSS API

2021-04-06 Thread Vladimir Medvedkin
This patch adds predictable RSS API. It is based on the idea of searching partial Toeplitz hash collisions. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/meson.build | 3 +- lib/librte_hash/rte_thash.c | 96 ++ lib/librte_hash/rte_thash.h | 138

[dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-06 Thread Vladimir Medvedkin
This patch implements predictable RSS functionality. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.c | 577 ++-- lib/librte_hash/rte_thash.h | 42 lib/librte_hash/version.map | 1 + 3 files changed, 602 insertions(+), 18

[dpdk-dev] [PATCH v2 3/3] test/hash: add additional thash tests

2021-04-06 Thread Vladimir Medvedkin
This patch adds tests for predictable RSS feature Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 468 +- 1 file changed, 462 insertions(+), 6 deletions(-) diff --git a/app/test/test_thash.c b/app/test/test_thash.c index a6aadd1

[dpdk-dev] [PATCH v3 0/3] Predictable RSS feature

2021-04-11 Thread Vladimir Medvedkin
ixed typos - rte_thash_adjust_tuple() API was putted into the first commit v2: - added extra API rte_thash_adjust_tuple() - added extra tests for rte_thash_adjust_tuple() - added extra fields to rte_thash_subtuple_helper struct - fixed typos Vladimir Medvedkin (3): hash: add predictable RSS API hash: add predi

[dpdk-dev] [PATCH v3 1/3] hash: add predictable RSS API

2021-04-11 Thread Vladimir Medvedkin
This patch adds predictable RSS API. It is based on the idea of searching partial Toeplitz hash collisions. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/meson.build | 3 +- lib/librte_hash/rte_thash.c | 109 + lib/librte_hash/rte_thash.h | 193

[dpdk-dev] [PATCH v3 2/3] hash: add predictable RSS implementation

2021-04-11 Thread Vladimir Medvedkin
This patch implements predictable RSS functionality. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.c | 610 ++-- 1 file changed, 587 insertions(+), 23 deletions(-) diff --git a/lib/librte_hash/rte_thash.c b/lib/librte_hash/rte_thash.c

[dpdk-dev] [PATCH v3 3/3] test/hash: add additional thash tests

2021-04-11 Thread Vladimir Medvedkin
This patch adds tests for predictable RSS feature. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 469 +- 1 file changed, 463 insertions(+), 6 deletions(-) diff --git a/app/test/test_thash.c b/app/test/test_thash.c index a6aadd1

[dpdk-dev] [PATCH v4 1/3] hash: add predictable RSS API

2021-04-13 Thread Vladimir Medvedkin
This patch adds predictable RSS API. It is based on the idea of searching partial Toeplitz hash collisions. Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/meson.build | 3 +- lib/librte_hash/rte_thash.c | 109 lib/librte_hash/rte_thash.h | 198

[dpdk-dev] [PATCH v4 0/3] Predictable RSS feature

2021-04-13 Thread Vladimir Medvedkin
just_tuple() - added extra comments - fixed typos - rte_thash_adjust_tuple() API was putted into the first commit v2: - added extra API rte_thash_adjust_tuple() - added extra tests for rte_thash_adjust_tuple() - added extra fields to rte_thash_subtuple_helper struct - fixed typos Vladimir Medvedkin (

[dpdk-dev] [PATCH v4 2/3] hash: add predictable RSS implementation

2021-04-13 Thread Vladimir Medvedkin
This patch implements predictable RSS functionality. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_hash/rte_thash.c | 608 ++-- 1 file changed, 585 insertions(+), 23 deletions(-) diff --git a/lib/librte_hash/rte_thash.c b

[dpdk-dev] [PATCH v4 3/3] test/hash: add additional thash tests

2021-04-13 Thread Vladimir Medvedkin
This patch adds tests for predictable RSS feature. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 469 +- 1 file changed, 463 insertions(+), 6 deletions(-) diff --git a/app/test/test_thash.c b/app/test/test_thash.c index a6aadd1

[PATCH v3] app/test-fib: fix possible division by zero

2022-01-27 Thread Vladimir Medvedkin
uot;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..067c5284f9 100644 --- a/app/test-fib/main.c +++ b/app/test-fib/main.c @@ -711,6 +711,10 @@ parse_

[dpdk-dev] [PATCH v2] test/hash: fix buffer overflow

2021-10-13 Thread Vladimir Medvedkin
(but not used in the computation). This patch increases the size of the proto field of the flow_key struct up to uint32_t and sets the alignment to 4 bytes. Bugzilla ID: 818 Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin ---

[dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-14 Thread Vladimir Medvedkin
four bytes in length, the memory region just after may be read (but not used in the computation). This patch increases the size of the proto field of the flow_key struct up to uint32_t. Bugzilla ID: 818 Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH v2 0/5] optimized Toeplitz hash implementation

2021-10-15 Thread Vladimir Medvedkin
ments Vladimir Medvedkin (5): hash: add new toeplitz hash implementation hash: enable gfni thash implementation doc/hash: update documentation for the thash library test/thash: add tests for a new Toeplitz hash function test/thash: add performance tests for the Toeplitz hash app/test/meson.

[dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-15 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 28 ++ lib/hash/rte_thash.h | 24 + lib/hash

[dpdk-dev] [PATCH v2 2/5] hash: enable gfni thash implementation

2021-10-15 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 44 lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files changed, 60 insertions(+), 4

[dpdk-dev] [PATCH v2 3/5] doc/hash: update documentation for the thash library

2021-10-15 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37

[dpdk-dev] [PATCH v2 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-15 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 231 ++ 1 file changed, 231 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH v2 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-15 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 125 + 2 files changed, 127 insertions(+) create

[dpdk-dev] [PATCH v3 0/5] optimized Toeplitz hash implementation

2021-10-20 Thread Vladimir Medvedkin
variable - removed RTE_INIT section, due to adding rte_thash_gfni_supported() - reworked rte_thash_complete_matrix() to make it easier tor read v2: - fixed typos - made big_rss_key static const and indented - addressed Konstantin's comments Vladimir Medvedkin (5): hash: add new toeplitz

[dpdk-dev] [PATCH v3 1/5] hash: add new toeplitz hash implementation

2021-10-20 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 29 ++ lib/hash/rte_thash.h | 35

[dpdk-dev] [PATCH v3 2/5] hash: enable gfni thash implementation

2021-10-20 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files changed, 58 insertions(+), 4

[dpdk-dev] [PATCH v3 3/5] doc/hash: update documentation for the thash library

2021-10-20 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37

[dpdk-dev] [PATCH v3 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-20 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 237 ++ 1 file changed, 237 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH v3 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-20 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 120 + 2 files changed, 122 insertions(+) create

[dpdk-dev] [PATCH v2] lpm: fix buffer overflow

2021-10-21 Thread Vladimir Medvedkin
2_t and sets the alignment to 4 bytes. Bugzilla ID: 819 Fixes: 86b3b21952a8 ("lpm6: store rules in hash table") Cc: a...@therouter.net Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/lpm/rte_lpm6.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [PATCH v4 2/5] hash: enable gfni thash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files

[dpdk-dev] [PATCH v4 1/5] hash: add new toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 29 ++ lib/hash

[dpdk-dev] [PATCH v4 0/5] optimized Toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
ments Vladimir Medvedkin (5): hash: add new toeplitz hash implementation hash: enable gfni thash implementation doc/hash: update documentation for the thash library test/thash: add tests for a new Toeplitz hash function test/thash: add performance tests for the Toeplitz hash app/test/meson.

[dpdk-dev] [PATCH v4 3/5] doc/hash: update documentation for the thash library

2021-10-21 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37

[dpdk-dev] [PATCH v4 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-21 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 237 ++ 1 file changed, 237 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH v4 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-21 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 120 + 2 files changed, 122 insertions(+) create

[dpdk-dev] [PATCH v5 2/5] hash: enable gfni thash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files

[dpdk-dev] [PATCH v5 0/5] optimized Toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
indented - addressed Konstantin's comments Vladimir Medvedkin (5): hash: add new toeplitz hash implementation hash: enable gfni thash implementation doc/hash: update documentation for the thash library test/thash: add tests for a new Toeplitz hash function test/thash: add performance

[dpdk-dev] [PATCH v5 1/5] hash: add new toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 29 ++ lib/hash

[dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library

2021-10-21 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37

[dpdk-dev] [PATCH v5 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-21 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 237 ++ 1 file changed, 237 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-21 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 120 + 2 files changed, 122 insertions(+) create

Re: [dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-10-24 Thread Vladimir Medvedkin
Hi Thomas, пт, 22 окт. 2021 г. в 22:56, Thomas Monjalon : > 11/04/2021 20:51, Medvedkin, Vladimir: > > On 08/04/2021 18:56, Stephen Hemminger wrote: > > >> app/test/test_thash.c | 468 +++- > > >> lib/librte_hash/meson.build | 3 +- > > >> lib/librte_hash/r

[dpdk-dev] [PATCH v6 0/4] optimized Toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
moved RTE_INIT section, due to adding rte_thash_gfni_supported() - reworked rte_thash_complete_matrix() to make it easier tor read v2: - fixed typos - made big_rss_key static const and indented - addressed Konstantin's comments Vladimir Medvedkin (4): hash: add new toeplitz hash implementation

[dpdk-dev] [PATCH v6 1/4] hash: add new toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 172 ++ doc/api/doxy-api-index.md | 1

[dpdk-dev] [PATCH v6 2/4] hash: add bulk toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch adds a bulk version for the Toeplitz hash implemented with Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 67 - doc/guides/prog_guide

[dpdk-dev] [PATCH v6 3/4] hash: enable gfni thash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files

[dpdk-dev] [PATCH v6 4/4] test/thash: add performance tests for the Toeplitz hash

2021-10-26 Thread Vladimir Medvedkin
This patch adds performance tests for the following Toeplitz hash function implementations: Scalar: - rte_softrss() - rte_softrss_be() Vector using gfni: - rte_thash_gfni() - rte_thash_gfni_bulk() Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app

[dpdk-dev] [PATCH v2] fib: add rib extension size parameter

2021-10-27 Thread Vladimir Medvedkin
This patch adds a new parameter to the fib configuration to specify the size of the extension for internal RIB structure. Signed-off-by: Vladimir Medvedkin Tested-by: Conor Walsh --- app/test-fib/main.c| 2 ++ app/test/test_fib.c| 5 + app/test

[dpdk-dev] [PATCH v7 1/4] hash: add new toeplitz hash implementation

2021-10-27 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 172 ++ doc/api/doxy-api-index.md | 1

[dpdk-dev] [PATCH v7 2/4] hash: add bulk toeplitz hash implementation

2021-10-27 Thread Vladimir Medvedkin
This patch adds a bulk version for the Toeplitz hash implemented with Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 67 - doc/guides/prog_guide

[dpdk-dev] [PATCH v7 3/4] hash: enable gfni thash implementation

2021-10-27 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files

[dpdk-dev] [PATCH v7 4/4] test/thash: add performance tests for the Toeplitz hash

2021-10-27 Thread Vladimir Medvedkin
This patch adds performance tests for the following Toeplitz hash function implementations: Scalar: - rte_softrss() - rte_softrss_be() Vector using gfni: - rte_thash_gfni() - rte_thash_gfni_bulk() Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app

[dpdk-dev] [PATCH v7 0/4] optimized Toeplitz hash implementation

2021-10-27 Thread Vladimir Medvedkin
orted() instead of the variable - removed RTE_INIT section, due to adding rte_thash_gfni_supported() - reworked rte_thash_complete_matrix() to make it easier tor read v2: - fixed typos - made big_rss_key static const and indented - addressed Konstantin's comments Vladimir Medvedkin (4): has

[dpdk-dev] [PATCH] hash: fix use after free in thash

2021-10-29 Thread Vladimir Medvedkin
This patch fixes use after free in thash library, reported by ASAN. Bugzilla ID: 868 Fixes: 28ebff11c2dc ("hash: add predictable RSS") Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_tha

[dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
ented - addressed Konstantin's comments Vladimir Medvedkin (4): hash: add new toeplitz hash implementation hash: add bulk toeplitz hash implementation hash: enable gfni thash implementation test/thash: add performance tests for the Toeplitz hash app/test/meson.build

[dpdk-dev] [PATCH v8 1/4] hash: add new toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 172 ++ doc/api/doxy-api-index.md | 1

[dpdk-dev] [PATCH v8 2/4] hash: add bulk toeplitz hash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch adds a bulk version for the Toeplitz hash implemented with Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 67 - doc/guides/prog_guide

[dpdk-dev] [PATCH v8 3/4] hash: enable gfni thash implementation

2021-11-02 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files

[dpdk-dev] [PATCH v8 4/4] test/thash: add performance tests for the Toeplitz hash

2021-11-02 Thread Vladimir Medvedkin
This patch adds performance tests for the following Toeplitz hash function implementations: Scalar: - rte_softrss() - rte_softrss_be() Vector using gfni: - rte_thash_gfni() - rte_thash_gfni_bulk() Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app

[dpdk-dev] [PATCH] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-08 Thread Vladimir Medvedkin
This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h

[dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB library

2021-11-08 Thread Vladimir Medvedkin
Currently, programmer's guide for the FIB library is missing. This commit adds it. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/fib_lib.rst | 139 + doc/guides/prog_guide/img/dir_24_8_alg.svg | 136 doc/guides/prog_guide/inde

[dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB library

2021-11-08 Thread Vladimir Medvedkin
Currently, programmer's guide for the RIB library is missing. This commit adds it. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/img/rib_internals.svg | 148 + doc/guides/prog_guide/img/rib_pic.svg | 152 + doc/guides/prog_guide/inde

[dpdk-dev] [PATCH] hash: fix thash gfni implementation

2021-11-09 Thread Vladimir Medvedkin
: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash_x86_gfni.h | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/lib/hash/rte_thash_x86_gfni.h

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Vladimir Medvedkin
Hi Michal, вт, 13 июл. 2021 г. в 18:42, Michal Krawczyk : > Allow user to specify his own hash key and hash ctrl if the > device is supporting that. HW interprets the key in reverse byte order, > so the PMD reorders the key before passing it to the ena_com layer. > > Default key is being set in r

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Vladimir Medvedkin
Great, thanks! BTW, you can check with a given hash_key if the rss hash value calculated by the NIC and by the rte_softrss() are the same. ср, 14 июл. 2021 г. в 11:21, Michał Krawczyk : > śr., 14 lip 2021 o 10:04 Vladimir Medvedkin > napisał(a): > > > > Hi Michal, > > &

[dpdk-dev] [PATCH 1/2] rib: announce experimental tag removal of the rib API

2021-08-05 Thread Vladimir Medvedkin
This patch announces the experimental tag removal of all rib APIs, which have been experimental for 2 years. API will be promoted to stable in DPDK 21.11 Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-05 Thread Vladimir Medvedkin
This patch announces the experimental tag removal of all fib APIs, which have been experimental for 2 years. API will be promoted to stable in DPDK 21.11 Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides

[PATCH v2] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-10 Thread Vladimir Medvedkin
This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h

[PATCH v2] hash: fix thash gfni implementation

2021-11-12 Thread Vladimir Medvedkin
compilation problems on 32bit arch due to lack of support for _mm_extract_epi64() by implementing XOR folding with _mm_extract_epi32() on 32-bit arch. Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin Acked

[PATCH v3] hash: fix thash gfni implementation

2021-11-16 Thread Vladimir Medvedkin
compilation problems on 32bit arch due to lack of support for _mm_extract_epi64() by implementing XOR folding with _mm_extract_epi32() on 32-bit arch. Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin Acked

[PATCH] app/test-fib: fix possible division by zero

2021-12-23 Thread Vladimir Medvedkin
FIB") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..9bc8b8a7ca 100644 --- a/app/test-fib

[PATCH v2] app/test-fib: fix possible division by zero

2021-12-23 Thread Vladimir Medvedkin
uot;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..9bc8b8a7ca 100644 --- a/app/test-fib/main.c +++ b

  1   2   3   4   5   6   >