RE: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[Dariusz Sosnowski]

> -Original Message-
> From: rongwei liu 
> Sent: Monday, May 27, 2024 04:47
> To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> 
> Cc: Michael Baum ; sta...@dpdk.org; Aman Singh
> ; Yuying Zhang ;
> Ferruh Yigit ; Dariusz Sosnowski
> 
> Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence
> 
> The field string should be in the same order as the rte_flow_field_id
> enumration definitions
> 
> Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
> Cc: michae...@nvidia.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Rongwei Liu 

Acked-by: Dariusz Sosnowski 

Best regards,
Dariusz Sosnowski

Re: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[rongwei liu]

Hi
@Dariusz Sosnowski<mailto:dsosnow...@nvidia.com> Can you comment on this patch? 
Thanks.


BR

Rongwei




From: Rongwei Liu 
Sent: Monday, May 27, 2024 10:47
To: dev@dpdk.org ; Matan Azrad ; Slava 
Ovsiienko ; Ori Kam ; Suanming Mou 
; NBU-Contact-Thomas Monjalon (EXTERNAL) 

Cc: Michael Baum ; sta...@dpdk.org ; 
Aman Singh ; Yuying Zhang ; 
Ferruh Yigit ; Dariusz Sosnowski 
Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

External email: Use caution opening links or attachments


The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
Cc: michae...@nvidia.com
Cc: sta...@dpdk.org

Signed-off-by: Rongwei Liu 
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
"hash_result",
"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
-   "random",
"ipv4_proto",
-   "esp_spi", "esp_seq_num", "esp_proto",
"ipv6_flow_label", "ipv6_traffic_class",
+   "esp_spi", "esp_seq_num", "esp_proto",
+   "random",
NULL
 };

--
2.27.0

[PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence

[Rongwei Liu]

The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
Cc: michae...@nvidia.com
Cc: sta...@dpdk.org

Signed-off-by: Rongwei Liu 
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
"hash_result",
"geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
"tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
-   "random",
"ipv4_proto",
-   "esp_spi", "esp_seq_num", "esp_proto",
"ipv6_flow_label", "ipv6_traffic_class",
+   "esp_spi", "esp_seq_num", "esp_proto",
+   "random",
NULL
 };
 
-- 
2.27.0