[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment
Hi Wei, 2lOn 11/15/2016 07:54 AM, Zhao1, Wei wrote: > Hi, john > >> -Original Message- >> From: Mcnamara, John >> Sent: Monday, November 14, 2016 6:30 PM >> To: Zhao1, Wei ; dev at dpdk.org >> Cc: olivier.matz at 6wind.com; Zhao1, Wei >> Subject: RE: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in >> comment >> >> >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao >>> Sent: Monday, November 14, 2016 2:47 AM >>> To: dev at dpdk.org >>> Cc: olivier.matz at 6wind.com; Zhao1, Wei >>> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in >>> comment >>> >>> From: zhao wei >> >> I think you need to add your name to gitconfig file on the sending machine to >> avoid this "From:" >> >>> >>> There is a redundant repetition word "for" in commnet line the file >>> rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. >>> The word "for"appear twice in line 359 and 360.One of them is >>> redundant, so delete it. >>> >>> Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler >>> operations") The proper fixline should be: Fixes: 449c49b93a6b ("mempool: support handler operations") (no need to add "lib/librte_mempool:") This comment also applies to the other patch, I missed it. >>> >>> Signed-off-by: zhao wei >> >> /commnet/comment/ >> >> And same comment as before about the title. Apart from that: >> >> Acked-by: John McNamara >> >> > > Thank you for your suggestion, I will change as your comment in following > patch! > Also same comment about "mempool:" instead of "lib/librte_mempool: mempool:" Thanks, Olivier
[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment
Hi, john > -Original Message- > From: Mcnamara, John > Sent: Monday, November 14, 2016 6:30 PM > To: Zhao1, Wei ; dev at dpdk.org > Cc: olivier.matz at 6wind.com; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in > comment > > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao > > Sent: Monday, November 14, 2016 2:47 AM > > To: dev at dpdk.org > > Cc: olivier.matz at 6wind.com; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in > > comment > > > > From: zhao wei > > I think you need to add your name to gitconfig file on the sending machine to > avoid this "From:" > > > > > There is a redundant repetition word "for" in commnet line the file > > rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. > > The word "for"appear twice in line 359 and 360.One of them is > > redundant, so delete it. > > > > Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler > > operations") > > > > Signed-off-by: zhao wei > > /commnet/comment/ > > And same comment as before about the title. Apart from that: > > Acked-by: John McNamara > > Thank you for your suggestion, I will change as your comment in following patch!
[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment
From: zhao weiThere is a redundant repetition word "for" in commnet line the file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. The word "for"appear twice in line 359 and 360.One of them is redundant, so delete it. Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler operations") Signed-off-by: zhao wei --- lib/librte_mempool/rte_mempool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 440f3b1..911102b 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/lib/librte_mempool/rte_mempool.h @@ -357,7 +357,7 @@ void rte_mempool_check_cookies(const struct rte_mempool *mp, * Prototype for implementation specific data provisioning function. * * The function should provide the implementation specific memory for - * for use by the other mempool ops functions in a given mempool ops struct. + * use by the other mempool ops functions in a given mempool ops struct. * E.g. the default ops provides an instance of the rte_ring for this purpose. * it will most likely point to a different type of data structure, and * will be transparent to the application programmer. -- 2.5.5
[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao > Sent: Monday, November 14, 2016 2:47 AM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; Zhao1, Wei > Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in > comment > > From: zhao wei I think you need to add your name to gitconfig file on the sending machine to avoid this "From:" > > There is a redundant repetition word "for" in commnet line the file > rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. > The word "for"appear twice in line 359 and 360.One of them is redundant, > so delete it. > > Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler > operations") > > Signed-off-by: zhao wei /commnet/comment/ And same comment as before about the title. Apart from that: Acked-by: John McNamara