Re: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, March 25, 2020 9:53 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Dekel Peled ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action with

Re: [dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-26 Thread Matan Azrad
From: Asaf Penso > The item is being set according to the attribute value, whether it is udp/tcp > or > ipv4/6. > Also, there are two condition calls. > > If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at > all, but > the call to the flow_dv_convert_modify_action is

[dpdk-dev] [PATCH] net/mlx5: fix call to modify action without init item

2020-03-25 Thread Asaf Penso
The item is being set according to the attribute value, whether it is udp/tcp or ipv4/6. Also, there are two condition calls. If the attribute is neither udp/tcp or ipv4/6 the item is not initialized at all, but the call to the flow_dv_convert_modify_action is still being done. Also, even if the a