Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak

2018-04-17 Thread Ferruh Yigit 
On 4/17/2018 10:07 AM, Alejandro Lucero wrote:

> 
> On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou  wrote:

Fixes: c7e9729da6b5 ("net/nfp: support CPP")

>> Signed-off-by: Yangchao Zhou 

> Acked-by: Alejandro Lucero 

Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak

2018-04-17 Thread Alejandro Lucero 
Acked-by: Alejandro Lucero 

On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou  wrote:

> Signed-off-by: Yangchao Zhou 
> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index ad6ce72..f2fcc4a 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -816,6 +816,7 @@ struct nfp6000_area_priv {
>
> if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
> printf("error reading resource file for bar size\n");
> +   fclose(fp);
> return -1;
> }
>
> --
> 1.7.1
>
>

[dpdk-dev] [PATCH] net/nfp: fix possible resource leak

2018-04-16 Thread Yangchao Zhou 
Signed-off-by: Yangchao Zhou 
---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c 
b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index ad6ce72..f2fcc4a 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -816,6 +816,7 @@ struct nfp6000_area_priv {
 
if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
printf("error reading resource file for bar size\n");
+   fclose(fp);
return -1;
}
 
-- 
1.7.1