[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
2016-03-29 08:16, Alejandro Lucero: > Hi guys, > > Sorry for the delay but I was on a Easter break. > > That patch is OK for me. In fact, I had one patch ready for upstreaming > with this change needed for supporting hotplug. I was waiting for some > feedback from one internal project needing this hotplug functionality > before submitting. [...] > > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > > > The NFP driver (unlike other PCI devices) was not copying the pci info > > > from the pci_dev to the eth_dev. This would make the driver_name be > > > null (and other unset fields) when application uses dev_info_get. > > > > > > This was found by code review; do not have the hardware. > > > > > > Signed-off-by: Stephen Hemminger Applied, thanks
[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
Hi guys, Sorry for the delay but I was on a Easter break. That patch is OK for me. In fact, I had one patch ready for upstreaming with this change needed for supporting hotplug. I was waiting for some feedback from one internal project needing this hotplug functionality before submitting. Regards On Fri, Mar 25, 2016 at 12:31 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > > The NFP driver (unlike other PCI devices) was not copying the pci info > > from the pci_dev to the eth_dev. This would make the driver_name be > > null (and other unset fields) when application uses dev_info_get. > > > > This was found by code review; do not have the hardware. > > > > Signed-off-by: Stephen Hemminger > > --- > Alejandro, > > any review or ack on this patch for nfp driver? > > Regards, > /Bruce >
[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > The NFP driver (unlike other PCI devices) was not copying the pci info > from the pci_dev to the eth_dev. This would make the driver_name be > null (and other unset fields) when application uses dev_info_get. > > This was found by code review; do not have the hardware. > > Signed-off-by: Stephen Hemminger > --- Alejandro, any review or ack on this patch for nfp driver? Regards, /Bruce
[dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
The NFP driver (unlike other PCI devices) was not copying the pci info from the pci_dev to the eth_dev. This would make the driver_name be null (and other unset fields) when application uses dev_info_get. This was found by code review; do not have the hardware. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 8810704..10ba0ec 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2319,6 +2319,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev) return 0; pci_dev = eth_dev->pci_dev; + rte_eth_copy_pci_info(eth_dev, pci_dev); + hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id; hw->subsystem_device_id = pci_dev->id.subsystem_device_id; -- 2.1.4
