[dpdk-dev] [PATCH] testpmd: remove duplicated parameter parsing

[Thomas Monjalon]

> > Several parameters were being parsed twice in testpmd, so this patch gets
> > rid of the second parsing.
> > 
> > Signed-off-by: Pablo de Lara 
> > 
> Acked-by: Sergio Gonzalez Monroy 

Applied, thanks

[dpdk-dev] [PATCH] testpmd: remove duplicated parameter parsing

[Gonzalez Monroy, Sergio]

> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, February 6, 2015 2:15 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] testpmd: remove duplicated parameter parsing
> 
> Several parameters were being parsed twice in testpmd, so this patch gets
> rid of the second parsing.
> 
> Signed-off-by: Pablo de Lara 
> ---
>  app/test-pmd/parameters.c |   56 
> -
>  1 files changed, 0 insertions(+), 56 deletions(-)
> 
Acked-by: Sergio Gonzalez Monroy 

[dpdk-dev] [PATCH] testpmd: remove duplicated parameter parsing

[Pablo de Lara]

Several parameters were being parsed twice in testpmd,
so this patch gets rid of the second parsing.

Signed-off-by: Pablo de Lara 
---
 app/test-pmd/parameters.c |   56 -
 1 files changed, 0 insertions(+), 56 deletions(-)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index adf3203..c7105ca 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -819,20 +819,6 @@ launch_args_parse(int argc, char** argv)
  " >= 1 && <= %d\n", n,
  (int) MAX_QUEUE_ID);
}
-   if (!strcmp(lgopts[opt_idx].name, "rxd")) {
-   n = atoi(optarg);
-   if (n > 0)
-   nb_rxd = (uint16_t) n;
-   else
-   rte_exit(EXIT_FAILURE, "rxd must be > 
0\n");
-   }
-   if (!strcmp(lgopts[opt_idx].name, "txd")) {
-   n = atoi(optarg);
-   if (n > 0)
-   nb_txd = (uint16_t) n;
-   else
-   rte_exit(EXIT_FAILURE, "txd must be in 
> 0\n");
-   }
if (!strcmp(lgopts[opt_idx].name, "burst")) {
n = atoi(optarg);
if ((n >= 1) && (n <= MAX_PKT_BURST))
@@ -852,27 +838,6 @@ launch_args_parse(int argc, char** argv)
 "mbcache must be >= 0 and <= 
%d\n",
 RTE_MEMPOOL_CACHE_MAX_SIZE);
}
-   if (!strcmp(lgopts[opt_idx].name, "txpt")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   tx_thresh.pthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "txpt must be >= 
0\n");
-   }
-   if (!strcmp(lgopts[opt_idx].name, "txht")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   tx_thresh.hthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "txht must be >= 
0\n");
-   }
-   if (!strcmp(lgopts[opt_idx].name, "txwt")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   tx_thresh.wthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "txwt must be >= 
0\n");
-   }
if (!strcmp(lgopts[opt_idx].name, "txfreet")) {
n = atoi(optarg);
if (n >= 0)
@@ -896,27 +861,6 @@ launch_args_parse(int argc, char** argv)
rte_exit(EXIT_FAILURE,
 "txqflags must be >= 0\n");
}
-   if (!strcmp(lgopts[opt_idx].name, "rxpt")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   rx_thresh.pthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "rxpt must be >= 
0\n");
-   }
-   if (!strcmp(lgopts[opt_idx].name, "rxht")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   rx_thresh.hthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "rxht must be >= 
0\n");
-   }
-   if (!strcmp(lgopts[opt_idx].name, "rxwt")) {
-   n = atoi(optarg);
-   if (n >= 0)
-   rx_thresh.wthresh = (uint8_t)n;
-   else
-   rte_exit(EXIT_FAILURE, "rxwt must be >= 
0\n");
-   }
if (!strcmp(lgopts[opt_idx].name, "rxd")) {
n = atoi(optarg);
if (n > 0) {
-- 
1.7.4.1