Re: [dpdk-dev] [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration
Friday, February 2, 2018 6:46 PM, Adrien Mazarguil: > The decision to deliver mlx4/mlx5 rdma-core glue plug-ins separately instead > of generating them at run time due to security concerns [1] led to a few > issues: > > - They must be present on the file system before running DPDK. > - Their location must be known to the dynamic linker. > - Their names overlap and ABI compatibility is not guaranteed, which may > lead to crashes. > > This series addresses the above by adding version information to plug-ins > and taking CONFIG_RTE_EAL_PMD_PATH into account to locate them on the > file system. Series applied to next-net-mlx, with the following diff in patch 3/4: diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index cc9db9977..cc800493b 100644 --- a/drivers/net/mlx4/Makefile +++ b/drivers/net/mlx4/Makefile @@ -35,7 +35,7 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB = librte_pmd_mlx4.a LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) LIB_GLUE_BASE = librte_pmd_mlx4_glue.so -LIB_GLUE_VERSION = 18.02.1 +LIB_GLUE_VERSION = 18.02.0 # Sources. SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4.c diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index 4086f2039..3bc9736c9 100644 --- a/drivers/net/mlx5/Makefile +++ b/drivers/net/mlx5/Makefile @@ -35,7 +35,7 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB = librte_pmd_mlx5.a LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) LIB_GLUE_BASE = librte_pmd_mlx5_glue.so -LIB_GLUE_VERSION = 18.02.1 +LIB_GLUE_VERSION = 18.02.0 Thanks. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > January%2F089617.html&data=02%7C01%7Cshahafs%40mellanox.com%7C6d > 6d87b37a574c15f41808d56a5c7eae%7Ca652971c7d2e4d9ba6a4d149256f461b > %7C0%7C0%7C636531867854846685&sdata=9Bc7lEnU%2Fq4E5PxgOkEvgwDN > zc46%2BZ1B5boHyxg1Cuo%3D&reserved=0 > > v2 changes: > > - Fixed extra "\n" in glue file name generation (although it didn't break > functionality). > > Adrien Mazarguil (4): > net/mlx: add debug checks to glue structure > net/mlx: fix missing includes for rdma-core glue > net/mlx: version rdma-core glue libraries > net/mlx: make rdma-core glue path configurable > > doc/guides/nics/mlx4.rst | 17 > doc/guides/nics/mlx5.rst | 14 ++ > drivers/net/mlx4/Makefile| 8 -- > drivers/net/mlx4/mlx4.c | 57 > ++- > drivers/net/mlx4/mlx4_glue.c | 4 +++ > drivers/net/mlx4/mlx4_glue.h | 9 +++ > drivers/net/mlx5/Makefile| 8 -- > drivers/net/mlx5/mlx5.c | 57 > ++- > drivers/net/mlx5/mlx5_glue.c | 1 + > drivers/net/mlx5/mlx5_glue.h | 7 + > 10 files changed, 176 insertions(+), 6 deletions(-) > > -- > 2.11.0
Re: [dpdk-dev] [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration
On Fri, Feb 02, 2018 at 05:46:10PM +0100, Adrien Mazarguil wrote: > The decision to deliver mlx4/mlx5 rdma-core glue plug-ins separately instead > of generating them at run time due to security concerns [1] led to a few > issues: > > - They must be present on the file system before running DPDK. > - Their location must be known to the dynamic linker. > - Their names overlap and ABI compatibility is not guaranteed, which may > lead to crashes. > > This series addresses the above by adding version information to plug-ins > and taking CONFIG_RTE_EAL_PMD_PATH into account to locate them on the file > system. > > [1] http://dpdk.org/ml/archives/dev/2018-January/089617.html > > v2 changes: > > - Fixed extra "\n" in glue file name generation (although it didn't break > functionality). > > Adrien Mazarguil (4): > net/mlx: add debug checks to glue structure > net/mlx: fix missing includes for rdma-core glue > net/mlx: version rdma-core glue libraries > net/mlx: make rdma-core glue path configurable > > doc/guides/nics/mlx4.rst | 17 > doc/guides/nics/mlx5.rst | 14 ++ > drivers/net/mlx4/Makefile| 8 -- > drivers/net/mlx4/mlx4.c | 57 ++- > drivers/net/mlx4/mlx4_glue.c | 4 +++ > drivers/net/mlx4/mlx4_glue.h | 9 +++ > drivers/net/mlx5/Makefile| 8 -- > drivers/net/mlx5/mlx5.c | 57 ++- > drivers/net/mlx5/mlx5_glue.c | 1 + > drivers/net/mlx5/mlx5_glue.h | 7 + > 10 files changed, 176 insertions(+), 6 deletions(-) > > -- > 2.11.0 For the series, Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND
[dpdk-dev] [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration
The decision to deliver mlx4/mlx5 rdma-core glue plug-ins separately instead of generating them at run time due to security concerns [1] led to a few issues: - They must be present on the file system before running DPDK. - Their location must be known to the dynamic linker. - Their names overlap and ABI compatibility is not guaranteed, which may lead to crashes. This series addresses the above by adding version information to plug-ins and taking CONFIG_RTE_EAL_PMD_PATH into account to locate them on the file system. [1] http://dpdk.org/ml/archives/dev/2018-January/089617.html v2 changes: - Fixed extra "\n" in glue file name generation (although it didn't break functionality). Adrien Mazarguil (4): net/mlx: add debug checks to glue structure net/mlx: fix missing includes for rdma-core glue net/mlx: version rdma-core glue libraries net/mlx: make rdma-core glue path configurable doc/guides/nics/mlx4.rst | 17 doc/guides/nics/mlx5.rst | 14 ++ drivers/net/mlx4/Makefile| 8 -- drivers/net/mlx4/mlx4.c | 57 ++- drivers/net/mlx4/mlx4_glue.c | 4 +++ drivers/net/mlx4/mlx4_glue.h | 9 +++ drivers/net/mlx5/Makefile| 8 -- drivers/net/mlx5/mlx5.c | 57 ++- drivers/net/mlx5/mlx5_glue.c | 1 + drivers/net/mlx5/mlx5_glue.h | 7 + 10 files changed, 176 insertions(+), 6 deletions(-) -- 2.11.0
