Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, August 30, 2017 1:43 PM > To: Ananyev, Konstantin ; Shahaf Shuler > ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloa

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Thomas Monjalon
30/08/2017 14:42, Ferruh Yigit: > On 8/30/2017 11:16 AM, Ananyev, Konstantin wrote: > > Hi Ferruh, > > From: Yigit, Ferruh > >> On 8/30/2017 7:30 AM, Shahaf Shuler wrote: > >>> Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: > >> Considering the re-configuration is risky, and without other idea

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ferruh Yigit
dk.org >> Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the >> new offloads API >> >> On 8/30/2017 7:30 AM, Shahaf Shuler wrote: >>> Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: >>>>>> Considering the re-configuration is ri

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ananyev, Konstantin
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, August 30, 2017 8:51 AM > To: Shahaf Shuler ; Thomas Monjalon > ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the >

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-30 Thread Ferruh Yigit
On 8/30/2017 7:30 AM, Shahaf Shuler wrote: > Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: Considering the re-configuration is risky, and without other ideas I will >> need to fall back to the error flow case. Are we OK with that? >>> >>> I think we can take the risk of keeping this cal

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Shahaf Shuler
Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: > >> Considering the re-configuration is risky, and without other ideas I will > need to fall back to the error flow case. > >> Are we OK with that? > > > > I think we can take the risk of keeping this call to > > rte_eth_dev_configure() in the middle

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Ferruh Yigit
On 8/25/2017 2:26 PM, Thomas Monjalon wrote: > 24/08/2017 09:12, Shahaf Shuler: >> Thursday, August 24, 2017 1:06 AM, Thomas Monjalon: >>> 23/08/2017 15:13, Shahaf Shuler: Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > From: Shahaf Shuler >> In order to enable PMDs to suppo

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Ananyev, Konstantin
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, August 29, 2017 7:27 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloads API > > Monday,

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-28 Thread Shahaf Shuler
Monday, August 28, 2017 5:12 PM, Ananyev, Konstantin: > > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > > > > > Hmm, and why we would need to reconfigure our device in the middle > > > of rx queue setup? > > > > The reason is the old Rx offloads API is configured on device configure.

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-28 Thread Ananyev, Konstantin
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, August 23, 2017 2:13 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloads API > > Wedn

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-25 Thread Thomas Monjalon
24/08/2017 09:12, Shahaf Shuler: > Thursday, August 24, 2017 1:06 AM, Thomas Monjalon: > > 23/08/2017 15:13, Shahaf Shuler: > > > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > > > From: Shahaf Shuler > > > > > In order to enable PMDs to support only one of the APIs, and > > > > > app

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-24 Thread Shahaf Shuler
Thursday, August 24, 2017 1:06 AM, Thomas Monjalon: > 23/08/2017 15:13, Shahaf Shuler: > > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > > From: Shahaf Shuler > > > > In order to enable PMDs to support only one of the APIs, and > > > > applications to avoid branching according to the

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Thomas Monjalon
23/08/2017 15:13, Shahaf Shuler: > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > From: Shahaf Shuler > > > In order to enable PMDs to support only one of the APIs, and > > > applications to avoid branching according to the underlying device a > > > copy functions to/from the old/new

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Shahaf Shuler
Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > > Sent: Monday, August 7, 2017 1:55 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [RFC PATCH

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Monday, August 7, 2017 1:55 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new > offloads API > > A new offloa

[dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-07 Thread Shahaf Shuler
A new offloads API was introduced by commits: commit 8b07fcae6061 ("ethdev: introduce Tx queue offloads API") commit c6504557763e ("ethdev: introduce Rx queue offloads API") In order to enable PMDs to support only one of the APIs, and applications to avoid branching according to the underlying de