Re: [dpdk-dev] [patch] net/octeontx2: fix ptype get overflow

2019-09-23 Thread Jerin Jacob 
On Fri, Sep 13, 2019 at 7:40 PM Jerin Jacob  wrote:
>
> On Wed, Aug 14, 2019 at 3:11 PM  wrote:
> >
> > From: Pavan Nikhilesh 
> >
> > The function `rte_eth_dev_get_supported_ptypes` expects the underlying
> > ethernet device to return array of supported ptypes. The ethernet device
> > needs to set `RTE_PTYPE_UNKNOWN` as the last element which signifies
> > thats its the end of the ptype array.
> > Else the function `rte_eth_dev_get_supported_ptypes` might overflow.
> >
>
> Cc: sta...@dpdk.org
>
> > Fixes: 6e892eabce11 ("net/octeontx2: support packet type")
> >
> > Signed-off-by: Pavan Nikhilesh 
>
> Acked-by: Jerin Jacob 

Applied to dpdk-next-net-mrvl/master. Thanks


>
>
> > ---
> >  drivers/net/octeontx2/otx2_lookup.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/octeontx2/otx2_lookup.c 
> > b/drivers/net/octeontx2/otx2_lookup.c
> > index 99199d08a..3347e7014 100644
> > --- a/drivers/net/octeontx2/otx2_lookup.c
> > +++ b/drivers/net/octeontx2/otx2_lookup.c
> > @@ -53,6 +53,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
> > RTE_PTYPE_INNER_L4_UDP,  /* LH */
> > RTE_PTYPE_INNER_L4_SCTP, /* LH */
> > RTE_PTYPE_INNER_L4_ICMP, /* LH */
> > +   RTE_PTYPE_UNKNOWN,
> > };
> >
> > if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F)
> > --
> > 2.17.1
> >

Re: [dpdk-dev] [patch] net/octeontx2: fix ptype get overflow

2019-09-13 Thread Jerin Jacob 
On Wed, Aug 14, 2019 at 3:11 PM  wrote:
>
> From: Pavan Nikhilesh 
>
> The function `rte_eth_dev_get_supported_ptypes` expects the underlying
> ethernet device to return array of supported ptypes. The ethernet device
> needs to set `RTE_PTYPE_UNKNOWN` as the last element which signifies
> thats its the end of the ptype array.
> Else the function `rte_eth_dev_get_supported_ptypes` might overflow.
>

Cc: sta...@dpdk.org

> Fixes: 6e892eabce11 ("net/octeontx2: support packet type")
>
> Signed-off-by: Pavan Nikhilesh 

Acked-by: Jerin Jacob 


> ---
>  drivers/net/octeontx2/otx2_lookup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/octeontx2/otx2_lookup.c 
> b/drivers/net/octeontx2/otx2_lookup.c
> index 99199d08a..3347e7014 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -53,6 +53,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
> RTE_PTYPE_INNER_L4_UDP,  /* LH */
> RTE_PTYPE_INNER_L4_SCTP, /* LH */
> RTE_PTYPE_INNER_L4_ICMP, /* LH */
> +   RTE_PTYPE_UNKNOWN,
> };
>
> if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F)
> --
> 2.17.1
>

[dpdk-dev] [patch] net/octeontx2: fix ptype get overflow

2019-08-14 Thread pbhagavatula 
From: Pavan Nikhilesh 

The function `rte_eth_dev_get_supported_ptypes` expects the underlying
ethernet device to return array of supported ptypes. The ethernet device
needs to set `RTE_PTYPE_UNKNOWN` as the last element which signifies
thats its the end of the ptype array.
Else the function `rte_eth_dev_get_supported_ptypes` might overflow.

Fixes: 6e892eabce11 ("net/octeontx2: support packet type")

Signed-off-by: Pavan Nikhilesh 
---
 drivers/net/octeontx2/otx2_lookup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/octeontx2/otx2_lookup.c 
b/drivers/net/octeontx2/otx2_lookup.c
index 99199d08a..3347e7014 100644
--- a/drivers/net/octeontx2/otx2_lookup.c
+++ b/drivers/net/octeontx2/otx2_lookup.c
@@ -53,6 +53,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
RTE_PTYPE_INNER_L4_UDP,  /* LH */
RTE_PTYPE_INNER_L4_SCTP, /* LH */
RTE_PTYPE_INNER_L4_ICMP, /* LH */
+   RTE_PTYPE_UNKNOWN,
};
 
if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F)
-- 
2.17.1