Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-09-12 Thread Peng, Yuan
Bug 3-5 which are not fixed are medium.
Bug1 and bug2(high priority) have been fixed and verified, will the patches be 
submitted?

-Original Message-
From: Peng, Yuan 
Sent: Thursday, September 12, 2019 4:53 PM
To: dev@dpdk.org
Subject: FW: 17.11.7-rc1 (LTS) patches review and test

Update the latest test status here.

-Original Message-
From: Yu, PingX 
Sent: Thursday, September 12, 2019 2:37 PM
To: Yongseok Koh ; Ananyev, Konstantin 
; as...@mellanox.com
Cc: Xu, Qian Q ; Lin, Xueqin ; Chen, 
Zhaoyan ; O'Hare, Cathal ; 
Yigit, Ferruh ; Ma, LihongX ; Li, 
WenjieX A ; Wang, FengqinX ; 
Peng, Yuan 
Subject: RE: 17.11.7-rc1 (LTS) patches review and test

All,
Update the latest test status here.
The critical bug has been fixed and we have re-tested all Intel key features. 

Intel(R) Testing result lists here.
# Basic Intel(R) NIC testing
* PF(i40e): One bug found in 1st round test. 2nd round test pass after fixing 
the bug. (see Bug1)
* PF(ixgbe): the same as PF(i40e).
* VF: Pass and no issue.
* Build or compile: One bug found in 1st round test. 2nd round test pass after 
fixing the bug. (see Bug2)
* Intel NIC single core/NIC performance: Pass and no issue.

#Basic cryptodev and virtio testing
* vhost/virtio basic loopback, PVP and performance test: pass.
* cryptodev: 3 bugs are found(see bug statistic in below). (See Bug3,4 and 5)

Bugs statistic:
Bug1: make  -C test/ failed. It blocked about 60 test cases for both PF(i40e) 
and PF(ixgbe). Resolved by adding "#include " into test_rwlock.c. 
Please decide whether submit a patch to DPDK or not.
Bug2: compile error on fc30. Patch is provided and validated pass. Need to 
decide whether merge into DPDK or not.  
Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet.
  commit 39fb9500c42752a537588f7a203433ec4737fa1e
  Author: Arek Kusztal 
  Date:   Wed Dec 12 20:59:02 2018 +0100

Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No progress yet.
  commit 39fb9500c42752a537588f7a203433ec4737fa1e
  Author: Arek Kusztal 
  Date:   Wed Dec 12 20:59:02 2018 +0100

Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet.
  39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit
  commit 39fb9500c42752a537588f7a203433ec4737fa1e
  Author: Arek Kusztal 
  Date:   Wed Dec 12 20:59:02 2018 +0100

Regards,
Yu Ping


-Original Message-
From: Wang, FengqinX 
Sent: Monday, August 26, 2019 3:12 PM
To: Yongseok Koh ; Ananyev, Konstantin 
; as...@mellanox.com
Cc: Xu, Qian Q ; Lin, Xueqin ; Chen, 
Zhaoyan ; O'Hare, Cathal ; 
Yigit, Ferruh ; Yu, PingX ; Ma, 
LihongX ; Li, WenjieX A 
Subject: RE: 17.11.7-rc1 (LTS) patches review and test

Add asafp in the loop due to Yongseok is longer working at Mellanox.

BRs, Vicky

-Original Message-
From: Wang, FengqinX 
Sent: Monday, August 26, 2019 3:07 PM
To: 'Yongseok Koh' ; Ananyev, Konstantin 

Cc: Xu, Qian Q ; Lin, Xueqin ; Chen, 
Zhaoyan ; O'Hare, Cathal ; 
Yigit, Ferruh ; Yu, PingX ; Ma, 
LihongX ; Li, WenjieX A 
Subject: RE: 17.11.7-rc1 (LTS) patches review and test

Hi Yongseok, Konstantin,

There is one critical compile issue found, and below is the bad commit related 
information, this issue has blocked most of unit tests which have used 
dpdk/test/test, would you please help to fix this issue ASAP?

commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070
Author: Joyce Kong 
Date:   Thu Jul 25 14:50:21 2019 +0800

test/rwlock: benchmark on all available cores

[ backported from upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ]

Add performance test on all available cores to benchmark
the scaling up performance of rw_lock.

Fixes: af75078fece3 ("first public release")

Suggested-by: Gavin Hu 
Signed-off-by: Joyce Kong 
Acked-by: Konstantin Ananyev 


And below is the error message output:

test_rwlock.c: In function 'load_loop_fn':
test_rwlock.c:126:38: error: expected ')' before 'PRIu64'
printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~
)
test_rwlock.c:126:19: error: format '%u' expects a matching 'unsigned int' 
argument [-Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ~^
test_rwlock.c:126:36: error: spurious trailing '%' in format [-Werror=format=] 
printf("Core [%u] rwlock_data = %"PRIu64"\n", ^
test_rwlock.c: In function 'test_rwlock_perf':
test_rwlock.c:160:31: error: expected ')' before 'PRIu64'
printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~
)
test_rwlock.c:160:18: error: format '%u' expects a matching 'unsigned int' 
argument [-Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, 
lock_count[i]); ~^
test_rwlock.c:160:29: error: spurious trailing '%' in format [-Werror=format=] 
printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^
test_rwlock.c:164:26: error: expected ')' before 'PRIu64'
printf("Total count = %"PRIu64"\n", total); ^~
)
test_rwlock.c:164:24: error: spurious trailing '%' in format [-Werror=format=] 
printf("Total count = %"PRIu64"\n", total); ^
cc1: all 

Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-08-25 Thread Ali Alnubani
Hi,

The following covers the tests that we ran on top of the 17.11 LTS branch:

* Basic functionality:
- Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
* RTE flow and flow_director tests.
* Some RSS tests.
* VLAN stripping and insertion tests.
* Checksum and TSO tests.
* ptype tests.
* Port interrupt testing.
* Multi-process testing.

Tests are Ok.

Tested on:
RHEL7.4 (5.3.0-rc4) / rdma-core v25.0 / ConnectX-5 / fw 16.25.6406
RHEL7.4 (5.3.0-rc4) / rdma-core v25.0 / ConnectX-4 Lx / fw 14.25.6406
RHEL7.4 (3.10.0-693.el7.x86_64) / MLNX_OFED_LINUX-4.6-1.0.1.1 / ConnectX-5 / fw 
16.25.6406
RHEL7.4 (3.10.0-693.el7.x86_64) / MLNX_OFED_LINUX-4.6-1.0.1.1 / ConnectX-4 Lx / 
fw 14.25.6406

Latest tested version:
20a49c7 version: 17.11.7-rc1

Regards,
Ali

> -Original Message-
> From: Yongseok Koh 
> Sent: Thursday, August 15, 2019 9:05 PM
> To: dpdk stable 
> Cc: dev@dpdk.org; pezh...@redhat.com; si...@redhat.com;
> fengqinx.w...@intel.com; zhaoyan.c...@intel.com; qian.q...@intel.com;
> Ali Alnubani ; Raslan Darawsheh
> 
> Subject: 17.11.7-rc1 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 17.11.7. Please help review
> and test. The planned date for the final release is Aug 23, Before that, 
> please
> shout if anyone has objections with these patches being applied.
> 
> Also for the companies committed to running regression tests, please run
> the tests and report any issue before the release date.
> 
> A release candidate tarball can be found at:
> 
> 
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.
> org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv17.11.7-
> rc1&data=02%7C01%7Calialnu%40mellanox.com%7Cd202474df6e2411ce
> b2c08d721ab407f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63
> 7014891731064651&sdata=FpRBliGWsJmHdec6Plx%2BPyphkEvOiZ2SNsg
> RKOfKkBc%3D&reserved=0
> 
> These patches are located at branch 17.11 of dpdk-stable repo:
> 
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.
> org%2Fbrowse%2Fdpdk-
> stable%2F&data=02%7C01%7Calialnu%40mellanox.com%7Cd202474df6
> e2411ceb2c08d721ab407f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C
> 0%7C637014891731064651&sdata=WUT0YSwmWZvschGmfbZsygL9Lp3gi
> %2FjXIr739QZYxcc%3D&reserved=0
> 
> 
> Thanks,
> Yongseok
> 
> ---
> 
> Aaron Conole (1):
>   net/virtio: fix dangling pointer on failure
> 
> Agalya Babu RadhaKrishnan (1):
>   doc: fix interactive commands in testpmd guide
> 
> Akhil Goyal (1):
>   crypto/dpaa2_sec: fix session clearing
> 
> Alejandro Lucero (1):
>   net/nfp: fix RSS query
> 
> Anatoly Burakov (2):
>   eal: improve musl compatibility of string functions
>   malloc: fix documentation of realloc function
> 
> Andrew Rybchenko (2):
>   net/sfc: remove control path logging from Rx queue count
>   app/testpmd: set fixed flag for exact link speed
> 
> Andrius Sirvys (3):
>   net/virtio: fix duplicate naming of include guard
>   bitrate: fix unchecked return value
>   drivers/net: fix shifting 32-bit signed variable 31 times
> 
> Anoob Joseph (1):
>   cryptodev: fix driver name comparison
> 
> Beilei Xing (1):
>   net/i40e: fix link speed for X722
> 
> Bernard Iremonger (1):
>   examples/ipsec-secgw: fix debug logs
> 
> Bill Hong (1):
>   net: fix Tx VLAN flag for offload emulation
> 
> Bruce Richardson (9):
>   eal: support strlcat function
>   net/bonding: fix buffer length when printing strings
>   examples/l2fwd-cat: fix build on FreeBSD
>   app/crypto-perf: check range of socket id
>   examples/vhost_scsi: fix null-check for parameter
>   net/i40e: fix dereference before null check in mbuf release
>   net/ixgbe: fix warning with GCC 9
>   bus/fslmc: fix warning with GCC 9
>   eal: tighten permissions on shared memory files
> 
> Chaitanya Babu Talluri (2):
>   drivers/net: fix possible overflow using strlcat
>   cfgfile: replace strcat with strlcat
> 
> David Christensen (2):
>   maintainers: update for IBM POWER
>   examples/vm_power_manager: fix PMD specific code
> 
> David Marchand (7):
>   eal: fix check when retrieving current CPU affinity
>   eal: remove dead code in core list parsing
>   app/testpmd: remove unused field from port struct
>   doc: fix examples in bonding guide
>   net/bonding: fix port id types
>   net/bonding: fix queue index types
>   app/testpmd: remove useless casts on statistics
> 
> Davide Caratti (1):
>   net/bnxt: support IOVA VA mode
> 
> Dekel Peled (8):
>   net/mlx5: fix hex dump of error completion
>   net/mlx5: fix sync when handling Tx completions
>   eal/ppc: fix global memory barrier
>   eal: fi

Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-08-18 Thread Pei Zhang
Hi Yongseok,

The testing looks good in my testing with 17.11.7-rc1. All get PASS.

Testing scenarios:
(1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size): PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 2Q - cross numa node  throughput testing: PASS
(7)Guest with vhost-user 2 queues throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)PVP 1Q live migration testing: PASS
(10)PVP 2Q cross numa node live migration testing: PASS
(11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS


Versions:
kernel 4.18.0
qemu: git://git.qemu.org/qemu.gitmaster commit 
afd760539308a5524accf964107cdb1d54a059e3
dpdk: git://dpdk.org/dpdk remotes/origin/17.11 commit 
20a49c717e829b9b45b3313c4ed18d94aa287387  (17.11.7-rc1)
 

Thank you.

Best regards,

Pei


- Original Message -
From: "Yongseok Koh" 
To: "dpdk stable" 
Cc: dev@dpdk.org, pezh...@redhat.com, si...@redhat.com, "fengqinx wang" 
, "zhaoyan chen" , "qian q xu" 
, alia...@mellanox.com, rasl...@mellanox.com
Sent: Friday, August 16, 2019 2:05:08 AM
Subject: 17.11.7-rc1 (LTS) patches review and test

Hi all,

Here is a list of patches targeted for LTS release 17.11.7. Please help review
and test. The planned date for the final release is Aug 23, Before that, please
shout if anyone has objections with these patches being applied.

Also for the companies committed to running regression tests, please run the
tests and report any issue before the release date.

A release candidate tarball can be found at:

https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1

These patches are located at branch 17.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/


Thanks,
Yongseok

---

Aaron Conole (1):
  net/virtio: fix dangling pointer on failure

Agalya Babu RadhaKrishnan (1):
  doc: fix interactive commands in testpmd guide

Akhil Goyal (1):
  crypto/dpaa2_sec: fix session clearing

Alejandro Lucero (1):
  net/nfp: fix RSS query

Anatoly Burakov (2):
  eal: improve musl compatibility of string functions
  malloc: fix documentation of realloc function

Andrew Rybchenko (2):
  net/sfc: remove control path logging from Rx queue count
  app/testpmd: set fixed flag for exact link speed

Andrius Sirvys (3):
  net/virtio: fix duplicate naming of include guard
  bitrate: fix unchecked return value
  drivers/net: fix shifting 32-bit signed variable 31 times

Anoob Joseph (1):
  cryptodev: fix driver name comparison

Beilei Xing (1):
  net/i40e: fix link speed for X722

Bernard Iremonger (1):
  examples/ipsec-secgw: fix debug logs

Bill Hong (1):
  net: fix Tx VLAN flag for offload emulation

Bruce Richardson (9):
  eal: support strlcat function
  net/bonding: fix buffer length when printing strings
  examples/l2fwd-cat: fix build on FreeBSD
  app/crypto-perf: check range of socket id
  examples/vhost_scsi: fix null-check for parameter
  net/i40e: fix dereference before null check in mbuf release
  net/ixgbe: fix warning with GCC 9
  bus/fslmc: fix warning with GCC 9
  eal: tighten permissions on shared memory files

Chaitanya Babu Talluri (2):
  drivers/net: fix possible overflow using strlcat
  cfgfile: replace strcat with strlcat

David Christensen (2):
  maintainers: update for IBM POWER
  examples/vm_power_manager: fix PMD specific code

David Marchand (7):
  eal: fix check when retrieving current CPU affinity
  eal: remove dead code in core list parsing
  app/testpmd: remove unused field from port struct
  doc: fix examples in bonding guide
  net/bonding: fix port id types
  net/bonding: fix queue index types
  app/testpmd: remove useless casts on statistics

Davide Caratti (1):
  net/bnxt: support IOVA VA mode

Dekel Peled (8):
  net/mlx5: fix hex dump of error completion
  net/mlx5: fix sync when handling Tx completions
  eal/ppc: fix global memory barrier
  eal: fix typo in comment of vector function
  doc: fix links to doxygen and sphinx sites
  app/testpmd: fix typo in comment
  net/mlx5: fix comments mixing Rx and Tx
  net/mlx5: fix release of Rx queue object

Fan Zhang (1):
  examples/ipsec-secgw: fix AES-CTR block size

Ferruh Yigit (5):
  kni: fix build with Linux 5.1
  build: fix crash by disabling AVX512 with binutils 2.31
  net/ring: fix return value check
  net/kni: fix return value check
  app/testpmd: revert fixed flag for exact link speed

Gage Eads (1):
  ring: fix namesize macro docu

[dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-08-15 Thread Yongseok Koh
Hi all,

Here is a list of patches targeted for LTS release 17.11.7. Please help review
and test. The planned date for the final release is Aug 23, Before that, please
shout if anyone has objections with these patches being applied.

Also for the companies committed to running regression tests, please run the
tests and report any issue before the release date.

A release candidate tarball can be found at:

https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1

These patches are located at branch 17.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/


Thanks,
Yongseok

---

Aaron Conole (1):
  net/virtio: fix dangling pointer on failure

Agalya Babu RadhaKrishnan (1):
  doc: fix interactive commands in testpmd guide

Akhil Goyal (1):
  crypto/dpaa2_sec: fix session clearing

Alejandro Lucero (1):
  net/nfp: fix RSS query

Anatoly Burakov (2):
  eal: improve musl compatibility of string functions
  malloc: fix documentation of realloc function

Andrew Rybchenko (2):
  net/sfc: remove control path logging from Rx queue count
  app/testpmd: set fixed flag for exact link speed

Andrius Sirvys (3):
  net/virtio: fix duplicate naming of include guard
  bitrate: fix unchecked return value
  drivers/net: fix shifting 32-bit signed variable 31 times

Anoob Joseph (1):
  cryptodev: fix driver name comparison

Beilei Xing (1):
  net/i40e: fix link speed for X722

Bernard Iremonger (1):
  examples/ipsec-secgw: fix debug logs

Bill Hong (1):
  net: fix Tx VLAN flag for offload emulation

Bruce Richardson (9):
  eal: support strlcat function
  net/bonding: fix buffer length when printing strings
  examples/l2fwd-cat: fix build on FreeBSD
  app/crypto-perf: check range of socket id
  examples/vhost_scsi: fix null-check for parameter
  net/i40e: fix dereference before null check in mbuf release
  net/ixgbe: fix warning with GCC 9
  bus/fslmc: fix warning with GCC 9
  eal: tighten permissions on shared memory files

Chaitanya Babu Talluri (2):
  drivers/net: fix possible overflow using strlcat
  cfgfile: replace strcat with strlcat

David Christensen (2):
  maintainers: update for IBM POWER
  examples/vm_power_manager: fix PMD specific code

David Marchand (7):
  eal: fix check when retrieving current CPU affinity
  eal: remove dead code in core list parsing
  app/testpmd: remove unused field from port struct
  doc: fix examples in bonding guide
  net/bonding: fix port id types
  net/bonding: fix queue index types
  app/testpmd: remove useless casts on statistics

Davide Caratti (1):
  net/bnxt: support IOVA VA mode

Dekel Peled (8):
  net/mlx5: fix hex dump of error completion
  net/mlx5: fix sync when handling Tx completions
  eal/ppc: fix global memory barrier
  eal: fix typo in comment of vector function
  doc: fix links to doxygen and sphinx sites
  app/testpmd: fix typo in comment
  net/mlx5: fix comments mixing Rx and Tx
  net/mlx5: fix release of Rx queue object

Fan Zhang (1):
  examples/ipsec-secgw: fix AES-CTR block size

Ferruh Yigit (5):
  kni: fix build with Linux 5.1
  build: fix crash by disabling AVX512 with binutils 2.31
  net/ring: fix return value check
  net/kni: fix return value check
  app/testpmd: revert fixed flag for exact link speed

Gage Eads (1):
  ring: fix namesize macro documentation block

Gavin Hu (3):
  test/spinlock: remove delay for correct benchmarking
  test/spinlock: amortize the cost of getting time
  spinlock: reimplement with atomic one-way barrier

Hari Kumar Vemula (1):
  net/bonding: fix reset active slave

Harry van Haaren (1):
  event/sw: fix enqueue checks in self-test

Herakliusz Lipiec (1):
  doc: fix broken link in LPM guide

Hyong Youb Kim (4):
  net/bonding: avoid warning for invalid port
  net/enic: fix flow director SCTP matching
  net/enic: fix SCTP match for flow API
  net/enic: check for unsupported flow item types

Igor Romanov (1):
  app/testpmd: fix stdout flush after printing stats

Ilya Maximets (2):
  vhost: fix device leak on connection add failure
  vhost: fix silent queue enabling with legacy guests

Ivan Malov (1):
  net/sfc: log port ID as 16-bit unsigned integer on panic

Jerin Jacob (1):
  mk: fix AVX512 disabled warning on non x86

Jianfeng Tan (1):
  drivers/net: do not use private ethdev data

Joyce Kong (1):
  test/rwlock: benchmark on all available cores

Kevin Traynor (3):
  net/qede: support IOVA VA mode
  eal/linux: fix log levels for pagemap reading failure
  power: fix frequency list buffer validation

Liang Zhang (1):
  net/bonding: fix LACP negotiation

Luo Gaoliang (1):
  kni: fix build on RHEL8

Marcin Smoczynski (1):
  examples/ipsec-secgw: fix build error log

Natanael Copa (3):
  bus/fslmc: remove unused include of error.