Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, September 17, 2018 8:56 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > Jozwiak, TomaszX > > Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix typo > > Hi, > > 10/08/2018 17:20, Trahe, Fiona: > > > -/**< Intel(R) QAT Symmetric Crypto PMD device name */ > > > +/**< Intel(R) QAT Symmetric Crypto PMD driver name */ > > > #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat > > The comment is above, so the syntax should be /**, not /**< > Do you want me to fix it when pulling in master? > That would be great thanks.
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
Hi, 10/08/2018 17:20, Trahe, Fiona: > > -/**< Intel(R) QAT Symmetric Crypto PMD device name */ > > +/**< Intel(R) QAT Symmetric Crypto PMD driver name */ > > #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat The comment is above, so the syntax should be /**, not /**< Do you want me to fix it when pulling in master?
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
On 8/10/2018 8:50 PM, Trahe, Fiona wrote: Corrected subject - only 1 patch here. -Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:19 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: [PATCH 1/2] crypto/qat: fix typo Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_pmd.h b/drivers/crypto/qat/qat_sym_pmd.h index d343285..75c3362 100644 --- a/drivers/crypto/qat/qat_sym_pmd.h +++ b/drivers/crypto/qat/qat_sym_pmd.h @@ -12,7 +12,7 @@ #include "qat_sym_capabilities.h" #include "qat_device.h" -/**< Intel(R) QAT Symmetric Crypto PMD device name */ +/**< Intel(R) QAT Symmetric Crypto PMD driver name */ #define CRYPTODEV_NAME_QAT_SYM_PMDcrypto_qat extern uint8_t cryptodev_qat_driver_id; -- 2.7.4 Applied to dpdk-next-crypto. Added fixes line. As insisted, this patch is also not CCed to stable. Please ensure to add fixes line for such patches. Thanks, Akhil
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
-Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 5:20 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: RE: [PATCH] crypto/qat: fix typo Corrected subject - only 1 patch here. > -Original Message- > From: Trahe, Fiona > Sent: Friday, August 10, 2018 4:19 PM > To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Jozwiak, TomaszX > > Cc: Trahe, Fiona > Subject: [PATCH 1/2] crypto/qat: fix typo > > Signed-off-by: Fiona Trahe Acked-by: tomaszx.jozw...@intel.com
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
Corrected subject - only 1 patch here. > -Original Message- > From: Trahe, Fiona > Sent: Friday, August 10, 2018 4:19 PM > To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > ; > Jozwiak, TomaszX > Cc: Trahe, Fiona > Subject: [PATCH 1/2] crypto/qat: fix typo > > Signed-off-by: Fiona Trahe > --- > drivers/crypto/qat/qat_sym_pmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/qat/qat_sym_pmd.h > b/drivers/crypto/qat/qat_sym_pmd.h > index d343285..75c3362 100644 > --- a/drivers/crypto/qat/qat_sym_pmd.h > +++ b/drivers/crypto/qat/qat_sym_pmd.h > @@ -12,7 +12,7 @@ > #include "qat_sym_capabilities.h" > #include "qat_device.h" > > -/**< Intel(R) QAT Symmetric Crypto PMD device name */ > +/**< Intel(R) QAT Symmetric Crypto PMD driver name */ > #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat > > extern uint8_t cryptodev_qat_driver_id; > -- > 2.7.4
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
> -Original Message-
> From: Jain, Deepak K
> Sent: Thursday, June 29, 2017 8:46 PM
> To: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Griffin, John
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH] crypto/qat: fix typo
>
>
>
> > -Original Message-
> > From: De Lara Guarch, Pablo
> > Sent: Thursday, June 29, 2017 12:16 PM
> > To: Trahe, Fiona ; Griffin, John
> > ; Jain, Deepak K
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > ; sta...@dpdk.org
> > Subject: [PATCH] crypto/qat: fix typo
> >
> > Fixed a comment in QAT, referring to the IV size for AES-GCM, that
> > should be in bytes, and not bits.
> >
> > Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption")
> > CC: sta...@dpdk.org
> >
> > Signed-off-by: Pablo de Lara
> > ---
> > --
> > 2.9.4
> Acked-by: Deepak Kumar Jain
Applied to dpdk-next-crypto.
Pablo
Re: [dpdk-dev] [PATCH] crypto/qat: fix typo
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Thursday, June 29, 2017 12:16 PM
> To: Trahe, Fiona ; Griffin, John
> ; Jain, Deepak K
> Cc: dev@dpdk.org; De Lara Guarch, Pablo ;
> sta...@dpdk.org
> Subject: [PATCH] crypto/qat: fix typo
>
> Fixed a comment in QAT, referring to the IV size for AES-GCM, that should be
> in bytes, and not bits.
>
> Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption")
> CC: sta...@dpdk.org
>
> Signed-off-by: Pablo de Lara
> ---
> --
> 2.9.4
Acked-by: Deepak Kumar Jain
