Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-17 Thread Thomas Monjalon
14/01/2019 17:24, Stephen Hemminger: > On Mon, 14 Jan 2019 13:29:38 + > Ferruh Yigit wrote: > > > On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > > > Strcat does not check the destination length and there might be > > > chances of string overflow so insted of strcat, strncat is used. >

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Thomas Monjalon
14/01/2019 15:21, Bruce Richardson: > On Mon, Jan 14, 2019 at 06:04:35AM +, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. [...] > > While I believe this is correct, this (an

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2019 13:29:38 + Ferruh Yigit wrote: > On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. > > > > Fixes: 540a211084 ("bnx2x: driver core") >

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Bruce Richardson
On Mon, Jan 14, 2019 at 06:04:35AM +, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so insted of strcat, strncat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Ferruh Yigit
On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so insted of strcat, strncat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > Fix