Re: [dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring base

[Maxime Coquelin]

On 02/21/2018 09:29 AM, Maxime Coquelin wrote:



On 02/09/2018 06:28 PM, Tomasz Kulasek wrote:

According to the "Vhost-user Protocol" document,
VHOST_USER_GET_VRING_BASE should get the available vring base offset.

Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc:huawei@intel.com
Cc:sta...@dpdk.org

Signed-off-by: Pawel Wodkowski
Signed-off-by: Tomasz Kulasek
---
  lib/librte_vhost/vhost_user.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Maxime Coquelin 

And applied to dpdk-next-virtio/master.


I changed the commit title to:
vhost: return the right ring index to the master on stop


Please let me know if this is ok for you.

Thanks,
Maxime


Thanks!
Maxime

Re: [dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring base

[Maxime Coquelin]

On 02/09/2018 06:28 PM, Tomasz Kulasek wrote:

According to the "Vhost-user Protocol" document,
VHOST_USER_GET_VRING_BASE should get the available vring base offset.

Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc:huawei@intel.com
Cc:sta...@dpdk.org

Signed-off-by: Pawel Wodkowski
Signed-off-by: Tomasz Kulasek
---
  lib/librte_vhost/vhost_user.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Maxime Coquelin 

And applied to dpdk-next-virtio/master.

Thanks!
Maxime

Re: [dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring base

[Tan, Jianfeng]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Saturday, February 10, 2018 1:28 AM
> To: y...@fridaylinux.org
> Cc: dev@dpdk.org; Xie, Huawei; sta...@dpdk.org; Wodkowski, PawelX
> Subject: [dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring
> base
> 
> According to the "Vhost-user Protocol" document,
> VHOST_USER_GET_VRING_BASE should get the available vring base offset.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: huawei@intel.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Pawel Wodkowski 
> Signed-off-by: Tomasz Kulasek 

Reviewed-by: Jianfeng Tan 

Nice catch!

> ---
>  lib/librte_vhost/vhost_user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 65ee33919..04eee3a3a 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -881,8 +881,8 @@ vhost_user_get_vring_base(struct virtio_net *dev,
> 
>   dev->flags &= ~VIRTIO_DEV_READY;
> 
> - /* Here we are safe to get the last used index */
> - msg->payload.state.num = vq->last_used_idx;
> + /* Here we are safe to get the last avail index */
> + msg->payload.state.num = vq->last_avail_idx;
> 
>   RTE_LOG(INFO, VHOST_CONFIG,
>   "vring base idx:%d file:%d\n", msg->payload.state.index,
> --
> 2.14.1