Re: [dpdk-dev] [PATCH 0/2] increase port_id range

2017-08-09 Thread Yang, Zhiyong
Hiļ¼ŒPablo: 

> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Wednesday, August 9, 2017 5:01 PM
> To: Yang, Zhiyong ; dev@dpdk.org
> Cc: tho...@monjalon.net
> Subject: RE: [dpdk-dev] [PATCH 0/2] increase port_id range
> 
> Hi Zhiyong,
> 
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang
> > Sent: Wednesday, August 9, 2017 9:42 AM
> > To: dev@dpdk.org
> > Cc: tho...@monjalon.net
> > Subject: [dpdk-dev] [PATCH 0/2] increase port_id range
> >
> > port_id is currently defined as uint8_t, which is limited to the range
> > 0 to 255. A larger range is required for vdev scalability.
> >
> > It is necessary for a redefinition of port_id to extend it from 1
> > bytes to
> > 2 bytes. All ethdev APIs and usages related to port_id will be changed
> > at the same time.
> >
> > Below is an API/ABI change notice for DPDK 17.11.
> > http://www.dpdk.org/dev/patchwork/patch/27475/
> >
> > Discussion about port_id is the following thread.
> > http://www.dpdk.org/dev/patchwork/patch/23208/
> >
> > Zhiyong Yang (2):
> >   ethdev: increase port_id range
> >   examples: increase port_id range
> >
> >  app/pdump/main.c|   2 +-
> >  app/test-pmd/cmdline.c  |   4 +-
> >  app/test-pmd/testpmd.c  |   4 +-
> >  app/test-pmd/testpmd.h  |   2 +-
> >  drivers/net/bonding/rte_eth_bond.h  |  40 ++--
> >  drivers/net/bonding/rte_eth_bond_8023ad.c   |   6 +-
> >  drivers/net/bonding/rte_eth_bond_api.c  |  54 +++---
> >  drivers/net/bonding/rte_eth_bond_pmd.c  |  10 +-
> >  drivers/net/bonding/rte_eth_bond_private.h  |  36 ++--
> >  drivers/net/failsafe/failsafe_ether.c   |   4 +-
> >  drivers/net/failsafe/failsafe_private.h |   4 +-
> >  drivers/net/ring/rte_eth_ring.c |   2 +-
> >  examples/bond/main.c|   6 +-
> >  examples/ip_fragmentation/main.c|   4 +-
> >  examples/l3fwd-power/main.c |   7 +-
> >  examples/l3fwd/l3fwd.h  |  10 +-
> >  examples/l3fwd/l3fwd_em.c   |   2 +-
> >  examples/l3fwd/l3fwd_lpm.c  |   2 +-
> >  examples/link_status_interrupt/main.c   |   5 +-
> >  examples/performance-thread/l3fwd-thread/main.c |   7 +-
> >  examples/rxtx_callbacks/main.c  |   8 +-
> >  lib/librte_ether/rte_ethdev.c   | 231 
> > +++
> >  lib/librte_ether/rte_ethdev.h   | 236 
> > 
> >  lib/librte_ether/rte_tm.c   |  62 +++
> >  lib/librte_ether/rte_tm.h   |  60 +++---
> >  lib/librte_ether/rte_tm_driver.h|   2 +-
> >  lib/librte_latencystats/rte_latencystats.c  |   8 +-
> >  lib/librte_pdump/rte_pdump.c|  16 +-
> >  lib/librte_pdump/rte_pdump.h|   4 +-
> >  lib/librte_port/rte_port_ethdev.c   |   6 +-
> >  lib/librte_port/rte_port_ethdev.h   |   6 +-
> >  31 files changed, 431 insertions(+), 419 deletions(-)
> >
> > --
> > 2.13.3
> 
> You should remove the deprecation notice that was sent for the ABI breakage in
> this patchset, and add a note in release notes, documenting the API/ABI 
> changes
> that you have done.
> 

Thank you, Pablo. I forget to add a note.  Deprecation notice will be removed 
if need v2 patch.
It is my first patchset which needs to send deprecation notice firstly. :)

Zhiyong

> Thanks,
> Pablo





Re: [dpdk-dev] [PATCH 0/2] increase port_id range

2017-08-09 Thread De Lara Guarch, Pablo
Hi Zhiyong,

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang
> Sent: Wednesday, August 9, 2017 9:42 AM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net
> Subject: [dpdk-dev] [PATCH 0/2] increase port_id range
> 
> port_id is currently defined as uint8_t, which is limited to the range 0 to
> 255. A larger range is required for vdev scalability.
> 
> It is necessary for a redefinition of port_id to extend it from 1 bytes to
> 2 bytes. All ethdev APIs and usages related to port_id will be changed at the
> same time.
> 
> Below is an API/ABI change notice for DPDK 17.11.
> http://www.dpdk.org/dev/patchwork/patch/27475/
> 
> Discussion about port_id is the following thread.
> http://www.dpdk.org/dev/patchwork/patch/23208/
> 
> Zhiyong Yang (2):
>   ethdev: increase port_id range
>   examples: increase port_id range
> 
>  app/pdump/main.c|   2 +-
>  app/test-pmd/cmdline.c  |   4 +-
>  app/test-pmd/testpmd.c  |   4 +-
>  app/test-pmd/testpmd.h  |   2 +-
>  drivers/net/bonding/rte_eth_bond.h  |  40 ++--
>  drivers/net/bonding/rte_eth_bond_8023ad.c   |   6 +-
>  drivers/net/bonding/rte_eth_bond_api.c  |  54 +++---
>  drivers/net/bonding/rte_eth_bond_pmd.c  |  10 +-
>  drivers/net/bonding/rte_eth_bond_private.h  |  36 ++--
>  drivers/net/failsafe/failsafe_ether.c   |   4 +-
>  drivers/net/failsafe/failsafe_private.h |   4 +-
>  drivers/net/ring/rte_eth_ring.c |   2 +-
>  examples/bond/main.c|   6 +-
>  examples/ip_fragmentation/main.c|   4 +-
>  examples/l3fwd-power/main.c |   7 +-
>  examples/l3fwd/l3fwd.h  |  10 +-
>  examples/l3fwd/l3fwd_em.c   |   2 +-
>  examples/l3fwd/l3fwd_lpm.c  |   2 +-
>  examples/link_status_interrupt/main.c   |   5 +-
>  examples/performance-thread/l3fwd-thread/main.c |   7 +-
>  examples/rxtx_callbacks/main.c  |   8 +-
>  lib/librte_ether/rte_ethdev.c   | 231 +++
>  lib/librte_ether/rte_ethdev.h   | 236 
> 
>  lib/librte_ether/rte_tm.c   |  62 +++
>  lib/librte_ether/rte_tm.h   |  60 +++---
>  lib/librte_ether/rte_tm_driver.h|   2 +-
>  lib/librte_latencystats/rte_latencystats.c  |   8 +-
>  lib/librte_pdump/rte_pdump.c|  16 +-
>  lib/librte_pdump/rte_pdump.h|   4 +-
>  lib/librte_port/rte_port_ethdev.c   |   6 +-
>  lib/librte_port/rte_port_ethdev.h   |   6 +-
>  31 files changed, 431 insertions(+), 419 deletions(-)
> 
> --
> 2.13.3

You should remove the deprecation notice that was sent
for the ABI breakage in this patchset, and add a note in release notes,
documenting the API/ABI changes that you have done.

Thanks,
Pablo