Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-19 Thread Thomas Monjalon
19/02/2018 15:13, Matan Azrad: > Hi Wiles > > From: Wiles, Keith, Monday, February 19, 2018 3:56 PM > > > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: > > >> Is this the type of API that needs to be marked experimental, > > > > > > I think it is relevant to any exposed API(not only for intern

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-19 Thread Wiles, Keith
> On Feb 19, 2018, at 8:13 AM, Matan Azrad wrote: > > Hi Wiles > > From: Wiles, Keith, Monday, February 19, 2018 3:56 PM >>> On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: Is this the type of API that needs to be marked experimental, >>> >>> I think it is relevant to any exposed API(n

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-19 Thread Matan Azrad
Hi Wiles From: Wiles, Keith, Monday, February 19, 2018 3:56 PM > > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: > >> Is this the type of API that needs to be marked experimental, > > > > I think it is relevant to any exposed API(not only for internal libraries). > > > >> we should be able to

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-19 Thread Wiles, Keith
> On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: > > >> >> Is this the type of API that needs to be marked experimental, > > I think it is relevant to any exposed API(not only for internal libraries). > >> we should be able to prove these functions, correct? > > Don't we need to prove an

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-19 Thread Pavan Nikhilesh
Hi Matan, On Sun, Feb 18, 2018 at 06:11:20AM +, Matan Azrad wrote: > Hi Pavan > > Please see some comments below. > > From: Pavan Nikhilesh, Saturday, February 17, 2018 12:50 PM > > Add 32b and 64b API's to align the given integer to the previous power of 2. > > > > Signed-off-by: Pavan Nikhi

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-18 Thread Matan Azrad
> From: Wiles, Keith, Sunday, February 18, 2018 5:39 PM > > On Feb 18, 2018, at 12:11 AM, Matan Azrad > wrote: > > > > Hi Pavan > > > > Please see some comments below. > > > > From: Pavan Nikhilesh, Saturday, February 17, 2018 12:50 PM > >> Add 32b and 64b API's to align the given integer to the

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-18 Thread Wiles, Keith
> On Feb 18, 2018, at 12:11 AM, Matan Azrad wrote: > > Hi Pavan > > Please see some comments below. > > From: Pavan Nikhilesh, Saturday, February 17, 2018 12:50 PM >> Add 32b and 64b API's to align the given integer to the previous power of 2. >> >> Signed-off-by: Pavan Nikhilesh >> --- >>

Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2

2018-02-17 Thread Matan Azrad
Hi Pavan Please see some comments below. From: Pavan Nikhilesh, Saturday, February 17, 2018 12:50 PM > Add 32b and 64b API's to align the given integer to the previous power of 2. > > Signed-off-by: Pavan Nikhilesh > --- > lib/librte_eal/common/include/rte_common.h | 36 >