On Saturday 07 April 2018 08:46 PM, Nipun Gupta wrote:
Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com>
---
  drivers/bus/fslmc/fslmc_bus.c  | 2 ++
  drivers/bus/fslmc/fslmc_vfio.c | 1 +
  drivers/bus/fslmc/rte_fslmc.h  | 2 ++
  3 files changed, 5 insertions(+)


[...]
Can you please explain, in the commit message, the relation between 'DPDMAI' and 'QDMA' devices? Your patch has both these tokens.

diff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h
index 69d0fec..a454ef5 100644
--- a/drivers/bus/fslmc/rte_fslmc.h
+++ b/drivers/bus/fslmc/rte_fslmc.h
@@ -61,6 +61,7 @@ enum rte_dpaa2_dev_type {
        DPAA2_IO,       /**< DPIO type device */
        DPAA2_CI,       /**< DPCI type device */
        DPAA2_MPORTAL,  /**< DPMCP type device */
+       DPAA2_QDMA,     /**< DPDMAI type device */
        /* Unknown device placeholder */
        DPAA2_UNKNOWN,
        DPAA2_DEVTYPE_MAX,
@@ -91,6 +92,7 @@ struct rte_dpaa2_device {
        union {
                struct rte_eth_dev *eth_dev;        /**< ethernet device */
                struct rte_cryptodev *cryptodev;    /**< Crypto Device */
+               struct rte_rawdev *rawdev;          /**< DPAA2 raw Device */
                                                /'''''''^^^^^^
                    just a 'Raw device' please./

        };
        enum rte_dpaa2_dev_type dev_type;   /**< Device Type */
        uint16_t object_id;                 /**< DPAA2 Object ID */


Just the trivial issues noted above and after rebasing on master, please use:

Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>

Reply via email to