Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
On Thu, Jan 17, 2019 at 1:47 PM Thomas Monjalon wrote: > 17/01/2019 22:34, Ajit Khaparde: > > On Thu, Jan 17, 2019 at 9:26 AM David Marchand < > david.march...@redhat.com> > > wrote: > > > > > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > > > wrote: > > > > > >> 17/01/2019 13:20, David Marchand: > > >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon < > tho...@monjalon.net> > > >> wrote: > > >> > > > >> > > 18/12/2018 16:19, Arnon Warshavsky: > > >> > > > Bugzilla ID: 165 > > >> > > > > >> > > > >> > Thomas, > > >> > > > >> > I just noticed that the bz is still opened. > > >> > Who is supposed to close bug reports ? > > >> > > >> I think we never formally described this workflow. > > >> > > >> I suggest to expect the bug reporter to close the bug. > > >> > > > > > > Well, the reporter is most likely able to reproduce an issue and > confirm > > > it is fixed. > > > So +1 for me. > > > > > Unless I miss an update, I generally try to assign the BZ back to the > > reporter to get an agreement, > > or confirmation as needed and get the BZ closed. > > So +1 for me as well. > > Interesting. Ajit, I think we never documented this process. > Would you like to describe it briefly here: > http://core.dpdk.org/contribute/#bugzilla > > Sure. I am working on it. But I think we need to also mention that bugs will also be aged out if there is no activity on it for say "1" year? Unless there is a valid reason to keep it open?
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
17/01/2019 22:34, Ajit Khaparde: > On Thu, Jan 17, 2019 at 9:26 AM David Marchand > wrote: > > > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > > wrote: > > > >> 17/01/2019 13:20, David Marchand: > >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon > >> wrote: > >> > > >> > > 18/12/2018 16:19, Arnon Warshavsky: > >> > > > Bugzilla ID: 165 > >> > > > >> > > >> > Thomas, > >> > > >> > I just noticed that the bz is still opened. > >> > Who is supposed to close bug reports ? > >> > >> I think we never formally described this workflow. > >> > >> I suggest to expect the bug reporter to close the bug. > >> > > > > Well, the reporter is most likely able to reproduce an issue and confirm > > it is fixed. > > So +1 for me. > > > Unless I miss an update, I generally try to assign the BZ back to the > reporter to get an agreement, > or confirmation as needed and get the BZ closed. > So +1 for me as well. Interesting. Ajit, I think we never documented this process. Would you like to describe it briefly here: http://core.dpdk.org/contribute/#bugzilla
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
On Thu, Jan 17, 2019 at 9:26 AM David Marchand wrote: > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > wrote: > >> 17/01/2019 13:20, David Marchand: >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon >> wrote: >> > >> > > 18/12/2018 16:19, Arnon Warshavsky: >> > > > Bugzilla ID: 165 >> > > >> > >> > Thomas, >> > >> > I just noticed that the bz is still opened. >> > Who is supposed to close bug reports ? >> >> I think we never formally described this workflow. >> >> I suggest to expect the bug reporter to close the bug. >> > > Well, the reporter is most likely able to reproduce an issue and confirm > it is fixed. > So +1 for me. > Unless I miss an update, I generally try to assign the BZ back to the reporter to get an agreement, or confirmation as needed and get the BZ closed. So +1 for me as well. Thanks Ajit > > > -- > David Marchand >
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon wrote: > 17/01/2019 13:20, David Marchand: > > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon > wrote: > > > > > 18/12/2018 16:19, Arnon Warshavsky: > > > > Bugzilla ID: 165 > > > > > > > Thomas, > > > > I just noticed that the bz is still opened. > > Who is supposed to close bug reports ? > > I think we never formally described this workflow. > > I suggest to expect the bug reporter to close the bug. > Well, the reporter is most likely able to reproduce an issue and confirm it is fixed. So +1 for me. -- David Marchand
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
17/01/2019 13:20, David Marchand: > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon wrote: > > > 18/12/2018 16:19, Arnon Warshavsky: > > > Bugzilla ID: 165 > > > > Thomas, > > I just noticed that the bz is still opened. > Who is supposed to close bug reports ? I think we never formally described this workflow. I suggest to expect the bug reporter to close the bug. Comments? Should we update the website with this info?
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon wrote: > 18/12/2018 16:19, Arnon Warshavsky: > > Bugzilla ID: 165 > Thomas, I just noticed that the bz is still opened. Who is supposed to close bug reports ? -- David Marchand
Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk
18/12/2018 16:19, Arnon Warshavsky:
> Bugzilla ID: 165
> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
> Signed-off-by: Arnon Warshavsky
>
> Explicitly collect the error code of the
> multiple awk script calls
Applied, thanks
Note: the explanation must be moved at the beginning of the message.
