Re: [dpdk-dev] [PATCH v2] eal: support strlcat function

[Pattan, Reshma]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> 3f091ab92..3bd8ed5d8 100644
> --- a/test/test/test_string_fns.c
> +++ b/test/test/test_string_fns.c
> @@ -129,11 +129,56 @@ test_rte_strsplit(void)
>   return 0;
>  }
> 
> +int
> +test_rte_strlcat(void)
> +{


test_string_fns.c:133:1: error: no previous prototype for 'test_rte_strlcat' 
[-Werror=missing-prototypes]
 test_rte_strlcat(void)
 ^~~~
cc1: all warnings being treated as errors

function return type should be static int.

Thanks,
Reshma

Re: [dpdk-dev] [PATCH v2] eal: support strlcat function

[Ferruh Yigit]

On 1/17/2019 4:30 PM, Bruce Richardson wrote:
> Add the strlcat function to DPDK to exist alongside the strlcpy one.
> While strncat is generally safe for use for concatenation, the API for the
> strlcat function is perhaps a little nicer to use, and supports truncation
> detection.
> 
> See commit: 5364de644a4b ("eal: support strlcpy function") for more
> details on the function selection logic, since we only should be using the
> DPDK-provided version when no system-provided version is present.
> 
> Signed-off-by: Bruce Richardson 

Reviewed-by: Ferruh Yigit