Hi Phil, Looks good. > On Jul 2, 2020, at 12:26 AM, Phil Yang <phil.y...@arm.com> wrote: > > There is no thread will access these impl_opaque data after timer > canceled. When new timer armed, it got refilled. So the cleanup > process is unnecessary. > > Signed-off-by: Phil Yang <phil.y...@arm.com> > --- > lib/librte_eventdev/rte_event_timer_adapter.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c > b/lib/librte_eventdev/rte_event_timer_adapter.c > index 7cc334c..8909a8c 100644 > --- a/lib/librte_eventdev/rte_event_timer_adapter.c > +++ b/lib/librte_eventdev/rte_event_timer_adapter.c > @@ -1167,8 +1167,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter > *adapter, > rte_mempool_put(sw->tim_pool, (void **)timp); > > evtims[i]->state = RTE_EVENT_TIMER_CANCELED; > - evtims[i]->impl_opaque[0] = 0; > - evtims[i]->impl_opaque[1] = 0; > > rte_smp_wmb(); > } > — > 2.7.4 >
Reviewed-by: Dharmik Thakkar <dharmik.thak...@arm.com>
