Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-14 Thread Thomas Monjalon
14/02/2018 01:14, Thomas Monjalon:
> > > >> Signed-off-by: Kirill Rybalchenko 
> > > >>
> > > >> Acked-by: Marko Kovacevic 
> > > >> ---
> > > >> +* ethdev: announce ABI change
> > > >> +  The size of variables flow_types_mask in rte_eth_fdir_info 
> > > >> structure,
> > > >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf 
> > > >> structure
> > > >> +  will be increased from 32 to 64 bits to fulfill hardware 
> > > >> requirements.
> > > >> +  This change will break existing ABI as size of the structures will 
> > > >> increase.
> > > >> +
> > > > Acked-by: Neil Horman 
> > > 
> > > Acked-by: Ferruh Yigit 
> > 
> > Acked-by: Olivier Matz 
> 
> Acked-by: Thomas Monjalon 
> 
> I would prefer you drop the legacy code to keep only rte_flow.

Applied


Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-13 Thread Thomas Monjalon
> > >> Signed-off-by: Kirill Rybalchenko 
> > >>
> > >> Acked-by: Marko Kovacevic 
> > >> ---
> > >> +* ethdev: announce ABI change
> > >> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> > >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf 
> > >> structure
> > >> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> > >> +  This change will break existing ABI as size of the structures will 
> > >> increase.
> > >> +
> > > Acked-by: Neil Horman 
> > 
> > Acked-by: Ferruh Yigit 
> 
> Acked-by: Olivier Matz 

Acked-by: Thomas Monjalon 

I would prefer you drop the legacy code to keep only rte_flow.



Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-13 Thread Olivier Matz
On Tue, Feb 13, 2018 at 12:09:19PM +, Ferruh Yigit wrote:
> On 1/12/2018 2:38 PM, Neil Horman wrote:
> > On Fri, Jan 12, 2018 at 10:29:46AM +, Kirill Rybalchenko wrote:
> >> Signed-off-by: Kirill Rybalchenko 
> >>
> >> Acked-by: Marko Kovacevic 
> >> ---
> >>  doc/guides/rel_notes/deprecation.rst | 6 ++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/deprecation.rst 
> >> b/doc/guides/rel_notes/deprecation.rst
> >> index 13e8543..aaf306a 100644
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> @@ -45,6 +45,12 @@ Deprecation Notices
> >>Target release for removal of the legacy API will be defined once most
> >>PMDs have switched to rte_flow.
> >>  
> >> +* ethdev: announce ABI change
> >> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf 
> >> structure
> >> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> >> +  This change will break existing ABI as size of the structures will 
> >> increase.
> >> +
> >>  * i40e: The default flexible payload configuration which extracts the 
> >> first 16
> >>bytes of the payload for RSS will be deprecated starting from 18.02. If
> >>required the previous behavior can be configured using existing flow
> >> -- 
> >> 2.5.5
> >>
> >>
> > Acked-by: Neil Horman 
> 
> Acked-by: Ferruh Yigit 

Acked-by: Olivier Matz 


Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-02-13 Thread Ferruh Yigit
On 1/12/2018 2:38 PM, Neil Horman wrote:
> On Fri, Jan 12, 2018 at 10:29:46AM +, Kirill Rybalchenko wrote:
>> Signed-off-by: Kirill Rybalchenko 
>>
>> Acked-by: Marko Kovacevic 
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 6 ++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst 
>> b/doc/guides/rel_notes/deprecation.rst
>> index 13e8543..aaf306a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -45,6 +45,12 @@ Deprecation Notices
>>Target release for removal of the legacy API will be defined once most
>>PMDs have switched to rte_flow.
>>  
>> +* ethdev: announce ABI change
>> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
>> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf 
>> structure
>> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
>> +  This change will break existing ABI as size of the structures will 
>> increase.
>> +
>>  * i40e: The default flexible payload configuration which extracts the first 
>> 16
>>bytes of the payload for RSS will be deprecated starting from 18.02. If
>>required the previous behavior can be configured using existing flow
>> -- 
>> 2.5.5
>>
>>
> Acked-by: Neil Horman 

Acked-by: Ferruh Yigit 


Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-01-12 Thread Neil Horman
On Fri, Jan 12, 2018 at 10:29:46AM +, Kirill Rybalchenko wrote:
> Signed-off-by: Kirill Rybalchenko 
> 
> Acked-by: Marko Kovacevic 
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 13e8543..aaf306a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -45,6 +45,12 @@ Deprecation Notices
>Target release for removal of the legacy API will be defined once most
>PMDs have switched to rte_flow.
>  
> +* ethdev: announce ABI change
> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf 
> structure
> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> +  This change will break existing ABI as size of the structures will 
> increase.
> +
>  * i40e: The default flexible payload configuration which extracts the first 
> 16
>bytes of the payload for RSS will be deprecated starting from 18.02. If
>required the previous behavior can be configured using existing flow
> -- 
> 2.5.5
> 
> 
Acked-by: Neil Horman