Re: [dpdk-dev] [PATCH v4 01/19] net/hinic/base: add mbox command channel for SRIOV

2019-10-28 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Gavin, Thanks for your comments, I will fix the code style issue in Patch v5, and the bit operation for hinic_test_bit and others has beed replaced with common rte_io_XX_bit APIs by Joyce Kong's pathces, I will check other remained bit operations and replace it with the common one. Best

Re: [dpdk-dev] [PATCH v4 01/19] net/hinic/base: add mbox command channel for SRIOV

2019-10-11 Thread Gavin Hu (Arm Technology China)
Hi Xiaoyun, Please pay attention to the coding style issue, and some other inline comments. For the bit operation functions, we are consolidating the bit operations functions into a common eal API family, when it is ready, the cpu_to_be32 and vice versa APIs scattered here and there can be replac